- 25 Sep, 2020 40 commits
-
-
Adam Langley authored
It's now possible to mock out the network service and run the authenticator code against the desktop code in a test environment. BUG=1002262 Change-Id: Ie2bf611d529baddfb1d04be1b0c60d6c4026d419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419337 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#810740}
-
Alice Wang authored
This CL adjusts the bottom sheet subtitle line height to make it look consistent with the incognito interstitial message style, which is required by UX. Bug: 1132215 Change-Id: I786e4ce1d86cabc26bbb026a5a666d5caefc6593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429404Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810739}
-
Emily Stark authored
This is a reland of 992e5b90 Original change's description: > Send SCT reports to Safe Browsing > > This implements sending new SCT audit reports to the Safe Browsing > servers for opted-in users. The SCTAuditingCache now sends reports using > a SimpleURLLoader when new reports are sampled for sending to Safe > Browsing. This reporting is configured by the SCTReportingService via a > new NetworkService::ConfigureSCTAuditing() API. This redesign eliminates > the round-trips between the network service and the browser process > entirely by having the SCTReportingService configure which network > context (and URLLoaderFactory) the SCTAuditingCache should use to send > reports (in this case, we use the system network context). > > This also: > - Removes the OnSCTReportReady Mojo API. > - Moves the feature flag for opt-in SCT auditing from services/network/ > into chrome/ now. > - Adds the network traffic annotation for opt-in SCT auditing. > - Extends the existing SCTReportingService browser tests to track > whether reports sent their results to the reporting server. > - Adds unittests covering reports being sent. > - Adds an optimization where empty reports are stored for reports that > we do not sample (and thus will never be sent to the server), rather > than storing the full report object. > > Bug: 1082860 > Change-Id: I29fd0ee1cb9c2d5c850601e0b54203363d4f8282 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331755 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809867} Bug: 1082860 Change-Id: I3e895c1dcd202d3aab0c1ef8ccaf97bfb04ea7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429240Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#810738}
-
Anastasia Helfinstein authored
Also ensures that non-browser tabs are treated as web elements, not browser tabs. Unblocks crbug.com/1131689 AX-Relnotes: n/a. Bug: None. Change-Id: Ic841403a07941804e1605169ab0e6db481de4d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429844Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#810737}
-
Andrew Xu authored
This CL adds an option to the context menu (with copy/paste options) to show the clipboard history menu. The CL does the following work: (1) It creates an interface called ClipboardHistoryController, enabling the Chrome side to access the clipboard history menu. (2) It renames ClipboardHistoryController to ClipboardHistoryControllerImpl which implements the interface. (3) Adds the option to the context menu. The execution of the menu option's command should open the clipboard history menu through the interface. Bug: 1118158 Change-Id: Idb383571765233514b91d4f2e5629220ddeee1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425192 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810736}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/31c5354707f0..d3ba0ee3a4e7 2020-09-25 alexrudenko@chromium.org Show contrast ratio and preview for each element in CSS Overview 2020-09-25 jacktfranklin@chromium.org Migrate SearchConfig.js to TypeScript 2020-09-25 janscheffler@chromium.org [WebAuthn] Format keyfile If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1120316,chromium:1131055 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I41f7e3e5f7eac8d9ed1fa3dba6afc9a4d78171e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431838Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810735}
-
James Cook authored
kMediaRouterEnableCloudServices was missing a namespace in one file. Tbr: khorimoto@chromium.org Bug: none Change-Id: Ia2abe411046f991893c2e8349d0424d3d7754123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431778Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#810734}
-
Sergey Poromov authored
This is a reland of 1546f3b4 Original change's description: > Add policy logic to clipboard dlp controller > > 1. Changed EnterpriseClipboardDlpController logic > to be based on the policy logic in DlpRulesManager. > 2. Added DlpRulesManager::IsAnyRestrcitedComponents > to decide if any component is restricted. > > Bug: 1102332 > Change-Id: Ib1abc64c71540cb431f94d4dfae44212ef8d3597 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416451 > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810586} Bug: 1102332 Change-Id: I2416dea8c4fa08d40d89feea9f28f590cd47c819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431927Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810733}
-
chinsenj authored
Currently the logic that handles the focus ring and scrolling the window cycle list are coupled together. However, there are cases where the focus ring should move and the list should not scroll and cases where the focus ring shouldn't move and the list should scroll. To handle the aforementioned cases, this CL separates the handling for scrolling and the focus ring. Test: Manual Bug: 1067327 Change-Id: I9fed7362c33dd2c5589b8bb5f52e81269273cad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425483 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#810732}
-
Austin Sullivan authored
In preparation of shared unit tests between the various FileStreamWriter implementations. Merge this before https://crrev.com/c/2422682 Change-Id: I56e4a3f5973a13a2bb39108114be5462296ff8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425429Reviewed-by:
-
Lei Zhang authored
Add Uri::ShouldPrintPort() to make a slightly complicate conditional more clear. With a separate method, it is easier to add local variables. Take advantage of that and use an iterator to avoid doing two searches on the same key. Change-Id: Iea98d7d532448e3ec43e6cf6a6d190079f655b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427222 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#810730}
-
Mugdha Lakhani authored
The recursive prefetch token is generated from the browser process, passed to the renderer process and then back to the browser process. This crashes the renderer in response to a request with an incorrectly set recursive prefetch token. Bug: 1123715 Change-Id: Ia6e627de66566a506b44d31b93e65d4acf07e27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421597Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#810729}
-
Fletcher Woodruff authored
The implementation of StartScan now matches StartScanMultiPage in Lorgnette. Convert LorgnetteManagerClient to use StartScan so that StartScanMultiPage can be deleted. Bug: b:161239919 Change-Id: Id3cd3bd7221aec461ade27cf3450f7f8fbf3fc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427018Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org> Cr-Commit-Position: refs/heads/master@{#810728}
-
Trevor Perrier authored
This CL calls SplitCompat.installActivity on the context returned by |ChromeBaseAppCompatActivity.createConfigurationContext|. This is needed because internally |applyOverrideConfiguration| creates a new context each time getResources() is called. This new context does not have access to the SplitCompat language packs. By calling SplitCompat.installActivity on this new activity hopefully the localization resources will be found. Bug: 1128698 Change-Id: I121ae24a84e456b9cacdfabefc310a0e7ee1c6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430825Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#810727}
-
Chris Fredrickson authored
This reverts commit 09a7c116. Reason for revert: This is a "leaf" API, so we actually want to instrument window.speechSynthesis manually, rather than each SpeechSynthesisVoice object individually. Original change's description: > Instrument access to SpeechSynthesisVoice data. > > This cl causes the bindings generator to automatically collect UKM when > these attributes are accessed. This will be used to analyze how much > entropy leaked by this API can be used for cross-site tracking. > > Bug: 973801 > Change-Id: Id621eb8c0c4cd388c09f30cf7ea4937fc566eadb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424511 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Chris Fredrickson <cfredric@google.com> > Cr-Commit-Position: refs/heads/master@{#809754} TBR=kinuko@chromium.org,cfredric@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973801 Change-Id: Ifb15b6e32d050c36396a2a5e2a83c61ca6c80a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429964Reviewed-by:
-
dpapad authored
Bug: 1114004 Change-Id: I146e6ead62f93c56461804f0e15a40823a685ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427298 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#810725}
-
Roger McFarlane authored
Bug: 1131065 Change-Id: Id922ac5125ba73fd5e1053ea0387cbdcf44e4e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424444 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
-
Yao Xiao authored
Why: There's going to be a new component to be synced for the FLoC project. So we want that and the existing blocklist to be contained in different subdirectories under the same top directory. Bug: 1062736 Change-Id: I730d01a086828feab19acf42361cea8efe9be3ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416729 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810723}
-
Henrique Nakashima authored
Dependencies on modularized, componentized, and base build targets are allowed. Incorporate this in the audit script to automate more of the process of sifting through dependencies. Also removing --no-build-target options to simplify script, as its main purpose is to audit which build targets a class depends on. Change-Id: If4f1b68e8102ad836ebafcd5be38ba8c53278019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424677 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#810722}
-
Erik Chen authored
The directory is the equivalent of Win32 on Windows and Cocoa on macOS. It should not include //content or //chrome. Change-Id: I057a77b2c4a0f4c72aee4218ce743d12c6211bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432126 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Justin Cohen authored
NOTRY=True Bug: 1129875, 1132099 Change-Id: I901f4aea4a0df4e33c23c848289acb0aa2561369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430290 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#810720}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d62c73fbf4d4..fe40be6924e2 2020-09-25 treehugger-gerrit@google.com Merge "Add a query that will compute the CPU time per chrome thread slice." 2020-09-25 fmayer@google.com Merge "Document weird looking if condition." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibb14fadadd741544c7a1d625ec04ebc5fbde247e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431836Reviewed-by:
-
François Doray authored
This reverts commit 7cf7dadf. Reason for revert: Suspect for crbug.com/1132399 Original change's description: > Modularize DeviceConditions to chrome/browser/device > > This is a step to unblock some classes that depend on it (list below) > and allow modularized code to reuse it. > > 11 inbound dependency(ies) into .c.b.DeviceConditions: > [chrome_java] > <- .c.b.background_sync.BackgroundSyncBackgroundTask > <- .c.b.background_sync.PeriodicBackgroundSyncChromeWakeUpTask > <- .c.b.download.DownloadInfoBarController > <- .c.b.explore_sites.ExploreSitesBackgroundTask > <- .c.b.offlinepages.BackgroundSchedulerBridge > <- .c.b.offlinepages.BackgroundSchedulerProcessor > <- .c.b.offlinepages.OfflineBackgroundTask > <- .c.b.offlinepages.prefetch.OfflineNotificationBackgroundTask > <- .c.b.offlinepages.prefetch.PrefetchBackgroundTask > <- .c.b.services.gcm.ChromeGcmListenerService > <- .c.b.sharing.click_to_call.ClickToCallMessageHandler > > This also breaks about 0.4% of the existing package cycles. > > Change-Id: I8ff8b665af2269161811ff76a4087b7e38d38172 > Bug: 1132380 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429587 > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810702} TBR=mthiesse@chromium.org,hnakashima@chromium.org Change-Id: I0065bb87a70e372d0ecce10b7332dce771f9fd38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132380, 1132399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431796Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#810718}
-
Garrett Beaty authored
Now that refs can be excluded from a CQ refset, we do not need the large complicated functions for constructing regexes to exclude the active branches from refs/branch-heads/.*. Change-Id: I3c627a26193706afb9bfe0e662a29be006ce6480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426588Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#810717}
-
Lei Zhang authored
In PDFExtensionTest, there already exists a test case that uses ContextMenuWaiter to interact with the context menu. Extend the test to also check the menu items seen by the ContextMenuWaiter. This is a regression test to make sure context menu items do not go missing by accident. Bug: 1126791 Change-Id: I26b60040ae83e88a835a41443adf439c410e54a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430827Reviewed-by:
-
Lei Zhang authored
- Make IDC to UMA maps constants. - Use base::Contains() to improve readability. Change-Id: I100d8b5dfc87cca4fb26eef06df082364a0ea8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429538Reviewed-by:
-
James Hollyer authored
Previously we asked for location regardless of permission status and trusted macOS to handle the request properly. The causes problems in unsigned builds and puts to much trust into the platform. This change ensures that permission has been granted before making the request. Bug: 1131777 Change-Id: I5e629661bdd058ee2c8d0ca71dee6be7ce1d51ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429572Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#810714}
-
Robert Liao authored
BUG=1130078 Change-Id: I0703a0109fc8a40a9af64bf2f6e7c4501007dd6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429254 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#810713}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009250800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/yjdlXACke1cTwXW-bd8ntMjFTSjSN2nWza75K8xGzDIC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/163421457,b/166042882,b/166689948,b/168843442,b/169360693 Tbr: help-app@grotations.appspotmail.com Change-Id: If99bc48ee8c374ba1512f95702400db528224705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431834Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810712}
-
Kevin McNee authored
Since BrowserPlugin has been removed, references to BrowserPlugin are now either dead code or misnomers due to also being used in the OOPIF based guest view implementation. To help reduce confusion, we remove noticeably dead code from BrowserPlugin related classes in content, remove BrowserPlugin related delegates or delegate methods no longer used by content, and move delegate methods still called by code outside content to the derived guest view classes. Bug: 533069 Change-Id: I049ba6595fe86a44078051a12d341ee5b99a8c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401031 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#810711}
-
Collin Baker authored
As a stopgap before adding proper documentation, this comment discourages use of FeaturePromoBubbleView and redirects users to FeaturePromoController. Bug: 1132335 Change-Id: Ia036dea11232645227d62124fd6683f1a74b32b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431767Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#810710}
-
Scott Violet authored
Renames variable in LayoutBoxModelObject::ComputeStickyConstrainingRect to indicate it's a scroll-container. Changes CompositingInputsUpdater to look for scroll-container. BUG=1087667 Change-Id: If75314386fd7a2cb0afd1afcae6e0315ab951693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430184 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810709}
-
Elly Fong-Jones authored
The layout owners file is gone, which renders the test owners file broken. This was broken in r810403. This change requires a presubmit skip because the presubmit errors out on the missing owners file. NOPRESUBMIT=true Bug: None Change-Id: Ic0945a2abf3bf54908176b7ea87e6a6f62ef507f Tbr: pkasting@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431773 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#810708}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/c947efabcbc38dcf93e8ad0e6a76206cf0ec8072..3743aafdacff2f7b083615a043a37101f740fa53 The following commits have update notes: ca3f243cf Require non-NULL store in X509_STORE_CTX_init. 6d70353ca Const-correct X509V3_CONF_METHOD. 49e9f67d8 Bump OPENSSL_VERSION_NUMBER to 1.1.1. 6ad3b46b2 Remove ASN1_STRING_length_set. 1c58648f1 Remove sxnet and pkey_usage_period extensions. 9372f38cd Bound RSA and DSA key sizes better. Bug: none Change-Id: Ice42742981210fc8fa2302a5ae09080abd3d9ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431451 Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#810707}
-
Charlie Hu authored
Support for intrinsicSize attribute on media element has been removed in CL (https://chromium-review.googlesource.com/c/chromium/src/+/1782660). Test on image policy with this attribute should also be removed. This CL removes related test case in document-policy-oversized-images-responsive-image.html test. Bug: 997286 Change-Id: Ib8535808c320157b7871a786cf98fbfde4bc6f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424708Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#810706}
-
Sammie Quon authored
Adds tests for crrev.com/c/2404945. Test: added Bug: 1120132 Change-Id: Ifb42fa1f8979ef7762614d6edd90dbfefa4d2f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422459 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#810705}
-
Francois Doray authored
TBR=drubery Bug: 1132307 Change-Id: I1407c77bd93d01bfa41bd5e846ea9973253e5db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431791Reviewed-by:
-
Yue Zhang authored
Since with instant start TabListMediator could be created before native is ready, we can no longer depend on looking at the type of current TabModelFilter in TabListMediator constructor for observer setup. Therefore, this CL moves the observer setup to initWithNative() where we are confident about using the type of TabModelFilter to decide whether we should set up observers for tab group. Bug: 1125451, 1125471 Change-Id: If156674137d64b829728402555e2cf4e06916519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429467Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#810703}
-
Henrique Nakashima authored
This is a step to unblock some classes that depend on it (list below) and allow modularized code to reuse it. 11 inbound dependency(ies) into .c.b.DeviceConditions: [chrome_java] <- .c.b.background_sync.BackgroundSyncBackgroundTask <- .c.b.background_sync.PeriodicBackgroundSyncChromeWakeUpTask <- .c.b.download.DownloadInfoBarController <- .c.b.explore_sites.ExploreSitesBackgroundTask <- .c.b.offlinepages.BackgroundSchedulerBridge <- .c.b.offlinepages.BackgroundSchedulerProcessor <- .c.b.offlinepages.OfflineBackgroundTask <- .c.b.offlinepages.prefetch.OfflineNotificationBackgroundTask <- .c.b.offlinepages.prefetch.PrefetchBackgroundTask <- .c.b.services.gcm.ChromeGcmListenerService <- .c.b.sharing.click_to_call.ClickToCallMessageHandler This also breaks about 0.4% of the existing package cycles. Change-Id: I8ff8b665af2269161811ff76a4087b7e38d38172 Bug: 1132380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429587 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#810702}
-
Mohamed Amir Yosef authored
After recent CLs, no conversion from legacy server proto to the new API server protos is required. This CL is getting rid of the code responsible for that. Bug: 1114655 Change-Id: I98d04fca0a13a13b43a950bbcb4c3f400259115a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431044 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#810701}
-
