GitLab

This ensures that re-creating a window with the same id shows that
window if it already exists. This was broken in:
https://codereview.chromium.org/417433002

BUG=461081

Review URL: https://codereview.chromium.org/958923004

Cr-Commit-Position: refs/heads/master@{#319013}

BUG=
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/975973002

Cr-Commit-Position: refs/heads/master@{#319012}

The "on"/"off" text and the switch were both too close to the edge of
the screen on pre-L devices. The bug arose because the LinearLayout had
conflicting padding attributes: it defined "padding" inline, and used a
style which defined "paddingStart" and "paddingEnd". The latter values
were overriding the inline "padding" value.

Review URL: https://codereview.chromium.org/970603003

Cr-Commit-Position: refs/heads/master@{#319011}

This is to fix regression of https://codereview.chromium.org/913033002.

BUG=455996

Review URL: https://codereview.chromium.org/972293003

Cr-Commit-Position: refs/heads/master@{#319010}

Cleaning the webapp as the Hangout Remote Desktop service has discontinued.

BUG=463322

Review URL: https://codereview.chromium.org/973333002

Cr-Commit-Position: refs/heads/master@{#319009}

Flaky on L.

TBR=klundberg@chromium.org,jaekyun@chromium.org
BUG=463740

Review URL: https://codereview.chromium.org/973393002

Cr-Commit-Position: refs/heads/master@{#319008}

Fix the TODO add by jhawkins.
Struct data members do not have the trailing underscores that data members in
class have.

BUG=

Review URL: https://codereview.chromium.org/968813002

Cr-Commit-Position: refs/heads/master@{#319007}

BUG=none

Review URL: https://codereview.chromium.org/975973003

Cr-Commit-Position: refs/heads/master@{#319006}

- Add a install_immediately flag to ExternalProviderImpl;
- Set install_immediately flag to true for kiosk app provider
  so that updated app install is not delayed;
- Set auto acknowledge since kiosk should not show external
  install alert;

BUG=461419

Review URL: https://codereview.chromium.org/974713002

Cr-Commit-Position: refs/heads/master@{#319005}

BUG=447778

Review URL: https://codereview.chromium.org/973983003

Cr-Commit-Position: refs/heads/master@{#319004}

This reverts commit 59e9a996.

it broke linux build
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/10478

BUG=none

Review URL: https://codereview.chromium.org/979663002

Cr-Commit-Position: refs/heads/master@{#319003}

This change contains of two parts. This is Part 1 (Chromium),
Part 2 (Clank) is https://chrome-internal-review.googlesource.com/#/c/204475/

This change reverts https://codereview.chromium.org/972973002/
and restores original https://codereview.chromium.org/896673003/
with an addition of a fix: it removes DCHECK
that verifies that an entry is always found and removed in a map.

An entry will not be in the map unless corresponding player
has been audible at least once.

BUG=414810,463445

Review URL: https://codereview.chromium.org/975943003

Cr-Commit-Position: refs/heads/master@{#319002}

PeerHandle() is not necessarily unique, so have a HostSharedBitmapManagerClient per renderer channel that's responsible for deleting bitmaps from renderers that die.

Review URL: https://codereview.chromium.org/955523005

Cr-Commit-Position: refs/heads/master@{#319001}

Power monitoring was added to the scheduler based on the incorrect
assumption that it would allow the system to use a lower timer
resolution on windows. This is not true because the timer resolution is
always high when on AC power while DelayBasedTimeSource is used for
vsync timing. On battery power the high resolution timer is disabled by
the power monitor irrespective of the presence of high resolution timer
tasks.

BUG=448939

Review URL: https://codereview.chromium.org/974083002

Cr-Commit-Position: refs/heads/master@{#319000}

BUG=

Review URL: https://codereview.chromium.org/975963002

Cr-Commit-Position: refs/heads/master@{#318999}

BUG=450428

Review URL: https://codereview.chromium.org/893313004

Cr-Commit-Position: refs/heads/master@{#318998}

This CL:
- Makes PointerDeviceObserver use ui::InputDeviceEventObserver on X11 (it is
  already used on Ozone)
- Makes X11HotplugEventObserver notify ui::DeviceDataManager when a mouse /
  touchpad is plugged in / unplugged
- Removes DeviceHierarchyObserver

BUG=440503
TEST=Manual

Review URL: https://codereview.chromium.org/946173002

Cr-Commit-Position: refs/heads/master@{#318997}

CL 906403006 introduced a linking error by referencing a symbol that is
not included in iOS builds of the cast sender library. This patch stubs
out the relevant code.

BUG=463713

Review URL: https://codereview.chromium.org/974133002

Cr-Commit-Position: refs/heads/master@{#318996}

In single process mode with impl-side-painting, browser and renderer
would both try to set number of raster worker threads, which causes
DCHECK. This CL makes sure there won't be duplicate call to set number
of worker threads in single process mode.

R=enne
BUG=314185

Review URL: https://codereview.chromium.org/971943002

Cr-Commit-Position: refs/heads/master@{#318995}

ChannelDelegate::GetWeakPtr() was called from the UI thread but
it was racy as the weak ptr is also used in the IO thread.
This CL turns ChannelDelegate a ThreadSafeRefCounted so that
we can pass ChannelDelegate itself to the task runner, instead
of using its weak ptr on the UI thread.

This change also turns some TaskRunner declarations to
SequencedTaskRunner to access its DeleteSoon() API from
ChannelDelegate.

TBR=creis@chromium.org
R=viettrungluu@chrormium.org, agl@chromium.org
BUG=460243

Review URL: https://codereview.chromium.org/955813002

Cr-Commit-Position: refs/heads/master@{#318994}

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/872033002

Cr-Commit-Position: refs/heads/master@{#318993}

We're updating our build to ensure that all html files are auto
generated and jscompiled. This html file is being removed now (rather
than updated to be jscompiled) because we intend to remove the
It2MeHelpeeChannel code in the near future.

BUG=

Review URL: https://codereview.chromium.org/979483002

Cr-Commit-Position: refs/heads/master@{#318992}

BUG=461551
TEST=None.
R=eakuefner

Review URL: https://codereview.chromium.org/973893002

Cr-Commit-Position: refs/heads/master@{#318991}

GpuMemoryBuffer implementations should not depend on
GLImage. This moves the capabilities and size checks
needed for compressed formats to the ImageFactory
interface.

BUG=462541

Review URL: https://codereview.chromium.org/968283002

Cr-Commit-Position: refs/heads/master@{#318990}

BUG=

Review URL: https://codereview.chromium.org/973293003

Cr-Commit-Position: refs/heads/master@{#318989}

Got replaced by a different function.

BUG=457427

Review URL: https://codereview.chromium.org/972253002

Cr-Commit-Position: refs/heads/master@{#318988}

This ensures that both infobars and bubbles are tested by creating both
DownloadTest.TestMultipleDownloadsInfobar and DownloadTest.
TestMultipleDownloadsBubble. The correct UI (infobar or bubble) is
forced with a switch.

BUG=438758

Review URL: https://codereview.chromium.org/976823002

Cr-Commit-Position: refs/heads/master@{#318987}

BUG=439285

Review URL: https://codereview.chromium.org/975193002

Cr-Commit-Position: refs/heads/master@{#318986}

This adds null checks for the result of StartPageService::Get in a few
places where it was missing.

Review URL: https://codereview.chromium.org/970863003

Cr-Commit-Position: refs/heads/master@{#318985}

BUG=463337

Review URL: https://codereview.chromium.org/969283002

Cr-Commit-Position: refs/heads/master@{#318984}

'gn check' for ui/gl:* in an android build currently fails with the
error message:

ERROR at //base/android/jni_generator/jni_generator_helper.h:11:11: Include not allowed.
          ^-------------------------
It is not in any dependency of //ui/gl:surface_jni_headers__jni_Surface
The include file is in the target(s):
  //base:base
which should somehow be reachable from //ui/gl:surface_jni_headers__jni_Surface

This target does not produce files that compile, so checking includes is
less useful.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/961033003

Cr-Commit-Position: refs/heads/master@{#318983}

TBR=tommi@chromium.org
BUG=

Review URL: https://codereview.chromium.org/978683002

Cr-Commit-Position: refs/heads/master@{#318982}

AttachmentService and SyncData no longer need to provide a drop method
beecause model type code can drop attachments using its AttachmentStore.

BUG=

Review URL: https://codereview.chromium.org/973513002

Cr-Commit-Position: refs/heads/master@{#318981}

https://chromium.googlesource.com/angle/angle/+log/586465264..019304886

BUG=
TEST=gpu bots
R=jmadill@chromium.org

Review URL: https://codereview.chromium.org/970363002

Cr-Commit-Position: refs/heads/master@{#318980}

This picks up a bug fix for the analyzer to handle multiple
toolsets the same way that ninja does.

It also picks up a couple of stray changes that were landed
after the migration to Git.

TBR=scottmg@chromium.org, sky@chromium.org
BUG=461811

Review URL: https://codereview.chromium.org/973273002

Cr-Commit-Position: refs/heads/master@{#318979}

BUG=455499

Review URL: https://codereview.chromium.org/972223002

Cr-Commit-Position: refs/heads/master@{#318978}

This fixes clang builds with the simple chrome workflow:
cros chrome-sdk --board=link --clang

Unfortunately there are not currently any builders with this
configuration.

BUG=462767

Review URL: https://codereview.chromium.org/967693002

Cr-Commit-Position: refs/heads/master@{#318977}

This CL fixes the help command of benchmark_runner, which broke after the local
environment switch.

R=dtu,nednguyen

Review URL: https://codereview.chromium.org/979573002

Cr-Commit-Position: refs/heads/master@{#318976}

BUG=none

Review URL: https://codereview.chromium.org/973263002

Cr-Commit-Position: refs/heads/master@{#318975}

On Webapp, touch gestures are offset by the size of the toolbar, even when
the toolbar is hidden. This occurs because we assume that the previous
content offset can never be 0, ending up not calling
onVisibleContentOffsetChanged() callback.

We can fix it by initializing previous content offset as NaN.

BUG=459275

Review URL: https://codereview.chromium.org/970813003

Cr-Commit-Position: refs/heads/master@{#318974}