GitLab

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

TBR=battre@chromium.org
R=battre@chromium.org

Bug: 925652
Change-Id: Ibe9c02c27b69efa50cba51922b498bed6a411d5e
Reviewed-on: https://chromium-review.googlesource.com/c/1438378Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628527}

This fixes the roll from the fix inside prefetto code for crbug/839074.
This allows us to remove the code referenced there since perfetto now
correctly uses the task runner as required.

Bug: crbug/839074
Change-Id: I44c3f9413e6b49a933db140ff1a00d5dc9c1e009
Reviewed-on: https://chromium-review.googlesource.com/c/1449675Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628526}

Bug: 871870
Change-Id: Ia5d7ac9082566bf201ac059987651beb03ce6108
Reviewed-on: https://chromium-review.googlesource.com/c/1450421
Auto-Submit: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628525}

Update the functions we register as FIDL error handlers to use :
- ZX_LOG(FATAL, status) where we never expect to lose connectivity,
  e.g. for connections to system services such as the Netstack. We
  typically follow these with an indication of what disconnected, e.g:
    ZX_LOG(FATAL, status) << " Netstack disconnected.";
- ZX_LOG_IF(FATAL, status != ZX_ERR_PEER_CLOSED, status) where we are
  providing service to a single peer that may disconnect from us at any
  time, where other status values are unexpected.
- ZX_LOG(ERROR, status) where we never expect to lose connectivity, but
  are serving multiple peers, so must not simply crash the process.
- ZX_LOG_IF(ERROR, status != ZX_ERR_PEER_CLOSED, status) where we are
  providing service to multiple peers that we expect may disconnect, to
  verify that they do so gracefully.

We also update FIDL error handlers in some test suites:
- EXPECT_EQ(status, ZX_ERR_PEER_CLOSED) where the test actively expects
  that the FIDL channel will be disconnected gracefully.
- ZX_LOG(ERROR, status) where the test does not expect FIDL errors.

Bug: 927400
Change-Id: I10fef90778e58f2aedadb806f857da00aace96aa
Reviewed-on: https://chromium-review.googlesource.com/c/1448796
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628524}

Bug: 668718
Change-Id: I27f8fee576dafdcc9b30e25be4c148d310d75605
Reviewed-on: https://chromium-review.googlesource.com/c/1444705Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628523}

Remove a couple of directory-level OWNERS files in favour of top-level
//ui/OWNERS rules for all *fuchsia* and *scenic* files &* directories.

Change-Id: Ie2b20f5c272cff9e75859b62a03fc4a13c889a19
Reviewed-on: https://chromium-review.googlesource.com/c/1450702
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628522}

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/extensions/api/enterprise_platform_keys.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=drcrash@chromium.org

Bug: 925652
Change-Id: I30ea9d065fa7f7e8c3ad4ffb44ab06105cda2ccd
Reviewed-on: https://chromium-review.googlesource.com/c/1438380Reviewed-by: Yves Arrouye <drcrash@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628521}

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/extensions/api/enterprise_platform_keys_private.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=drcrash@chromium.org

Bug: 925652
Change-Id: I526eef912697ba8dad512de35f88cf841950c068
Reviewed-on: https://chromium-review.googlesource.com/c/1438370Reviewed-by: Yves Arrouye <drcrash@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628520}

BUG=None
R=thakis
CC=rsesek

Change-Id: Ia94b81592164307aa55a910953909b0b25a82b37
Reviewed-on: https://chromium-review.googlesource.com/c/1444136
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628519}

There is no use of SigninFoo class in local_card_migration_browsertest.cc. So they are
unnecessary now. This CL removes the includes.

Bug: 927244
Change-Id: If20a6806a63123165a865e83c3cf86188b71f2bd
Reviewed-on: https://chromium-review.googlesource.com/c/1448010Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#628518}

Remove the out-of-date comment regarding Watchers outliving the
associated MessagePumpLibevent, and add a Debug mode check for
StopWatchingFileDescriptor failing during Watcher teardown, since that
usually indicates a coding error somewhere.

Also fixes incorrect descriptor/watcher teardown ordering in the
AddressTrackerLinux and ServiceProcessState for POSIX.

Bug: 741188
Change-Id: I3732c61bfb81df89f0011ad8bfff93d7a08c6fc5
Reviewed-on: https://chromium-review.googlesource.com/c/575108
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628517}

As of [1] XkbKeyboardLayoutEngine has been hardcoded to
always set num lock mask. That's a ChromeOS-specific
requirement, so this patch guard those code under
OS_CHROMEOS build flag.

This has been causing an issue in ozone/wayland builds,
for example, when using keyboards Neo layout (e.g: de-neo).
This patch fixes it.

[1] https://crrev.com/834373002

R=rjkroege@chromium.org

Bug: 921947
Change-Id: I0eadae3169ff9a8442714cd7f41c75b1c623447b
Reviewed-on: https://chromium-review.googlesource.com/c/1450338Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#628516}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8cd8f2f71e22..da2bdf0382f7


git log 8cd8f2f71e22..da2bdf0382f7 --date=short --no-merges --format='%ad %ae %s'
2019-02-01 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@da2bdf0382f7

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ie412d4b53fbb12d46bd2ba8a01374caad51488a2
Reviewed-on: https://chromium-review.googlesource.com/c/1450731Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#628515}

This is preparation CL to use forward declaration only header in mojo's
generated code.
If we include forward declaration only header in mojo's generated code, we need
to include mojo header files in some places where definition is necessary.

master CL is in
https://chromium-review.googlesource.com/c/chromium/src/+/1438975

This CL was uploaded by git cl split.

R=hidehiko@chromium.org

CC: rockot@google.com
Bug: 922875
Change-Id: I19d473f728ed83b62c9111f62a4fbb94b7077d77
Reviewed-on: https://chromium-review.googlesource.com/c/1446973Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628514}

https://boringssl.googlesource.com/boringssl/+log/6c1b376e1d502eff365028fe054115f1b46d19b5..1a51a5b4a6bdf7ee11b443f21f08dc2ba2de9815

Bug: none
Change-Id: I41e423f917c36d7bc4d5a8eac1f1f17ba56592a4
Reviewed-on: https://chromium-review.googlesource.com/c/1446837Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628513}

We never pass a null ChromeAppCacheService to AppCacheDispatcherHost so
don't bother trying to support that.

Bug: None
Change-Id: Ic8afd00a9ae405c31ca3bcdee8e87ba0beb4a9bd
Reviewed-on: https://chromium-review.googlesource.com/c/1450532
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628512}

The flag was calculated inside registerLoadRequestForURL: based on
heuristics. These calculations were often wrong, but they were later
fixed up by registerLoadRequestForURL: callers.

This CL passes  'is renderer initiated' flag inside
registerLoadRequestForURL: call so NavigationContext is always created
with correct value. Callers almost always know the value of the flag
with the exception of certain NativeContent navigation where value of
the flag is not important.

This CL does not have tests, because existing tests cover all known
cases.

Bug: None
Change-Id: I0d85b8d91b066a2a8b2788a9618e58fd96fc82e9
Reviewed-on: https://chromium-review.googlesource.com/c/1446797
Commit-Queue: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628511}

This is necessary to have an enterprise check for Navi onboarding.

Bug: 924274
Change-Id: I3168b6fd7ecf6707f7987e5453595913926c19cf
Reviewed-on: https://chromium-review.googlesource.com/c/1428599
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Auto-Submit: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628510}

Adds in retries to the VR fling scrolling test to help combat flakiness
on older/slower devices. The previous version of the test was stable on
newer devices such as the Pixel 2, but was flaking on the Pixel XLs used
by the bots due to scroll jank.

Bug: 923093
Change-Id: I218b09c4ae827149541eda0c735a8121b16dd970
Reviewed-on: https://chromium-review.googlesource.com/c/1448530Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628509}

Cryptotoken used to tolerate challenges and key handles encoded in
either regular base64 or base64url, despite the spec only allowing
base64url. With the WebAuthenticationProxyCryptotoken feature enabled,
this is no longer the case: WebAuthn takes challenges and key handles as
raw byte inputs, and re-encodes them to base64url prior to signing.

Until now, if cryptotoken failed to base64url-decode a challenge for
keyHandle before sending it to WebAuthn, it would send an empty byte
sequence instead. Hence, if a non-compliant passed a challenge encoded
in regular base64, it would subsequently receive a response, but the
challenge field in the response would be empty and signature would be
over the empty challenge.

This change makes the failure to decode more explicit. If a challenge
(or keyHandle) fails to decode, cryptotoken will not forward the
request. Rather it will return a BAD_REQUEST error with a descriptive
error message.

Bug: 925738
Change-Id: I7e1d0bfca55765ccdfaf7b9762c8b79352fb2856
Reviewed-on: https://chromium-review.googlesource.com/c/1450400
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628508}

The test was disabled because it was flaky on TSAN bots. Unfortunately
the logs from these flakes are not available anymore because the test
was disabled a while ago. And the failure could not be reproduced
locally.

Reland the test to verify if the failure on the bots still exists.

R=enne@chromium.org

Bug: 851231
Change-Id: I5ae4d37f10a3173f1d3b452ab50f229f01dd748f
Reviewed-on: https://chromium-review.googlesource.com/c/1450692
Auto-Submit: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628507}

InProcessCommandBuffer wasn't checking if exist_on_context_loss GPU
workaround was set on context loss. Implement a similar check to the
existing one in GpuChannelManager.

To reduce code duplication push more of the logic around exiting on
context loss up into GpuServiceImpl. Both InProcessCommandBuffer and
GpuChannelManager can use the same logic this way through
GpuChannelManagerDelegate (which should be renamed).

A related change for OOP-D display compositor context creation is to not
try to create a context if we are already exiting the process. This
matches the logic in GpuChannel. We have to check on the viz compositor
thread before starting context creation and also on the GPU thread when
starting GPU thread initialization.

Bug: 924148
Change-Id: I6eeb016c063063ef26ccdcaa7ad9d2ae3badcdc7
Reviewed-on: https://chromium-review.googlesource.com/c/1448518
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628506}

https://pdfium.googlesource.com/pdfium.git/+log/e13cf694d42b..33cc9c60892a


git log e13cf694d42b..33cc9c60892a --date=short --no-merges --format='%ad %ae %s'
2019-02-01 tsepez@chromium.org Add --jitless to recommended v8 flags.


Created with:
  gclient setdep -r src/third_party/pdfium@33cc9c60892a

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I5a61dba1c3c5f37b3d46c8c6a43e5b48a87e438b
Reviewed-on: https://chromium-review.googlesource.com/c/1450633Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#628505}

AssistantOverlays are views which are added to AssistantContainerView's
client view. Because they are added at this level of the view hierarchy,
they paint to a higher level in the layer tree than direct children of
AssistantContainerView.

AssistantOverlays are intended to behave as pseudo-children of views in
the Assistant view hierarchy that need to paint to a high level, say to
draw over top of Assistant cards.

This CL adds a flag guarded AssistantNotificationOverlay which behaves
as a pseudo-child of AssistantMainView and will be used to support
in-Assistant notifications in Assistant.

Future overlays will include a shadow that is painted above suggestion
chips when the Assistant main stage can be scrolled (b:112669597).

Bug: b:118654460
Change-Id: I8e9a2c9748b4ecb0fad51c2f27722890d20d4ff3
Reviewed-on: https://chromium-review.googlesource.com/c/1440906
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628504}

related configurations together.

Change-Id: I90cde9e3dd32859da6f95fe35959b7d37e5b1413
Reviewed-on: https://chromium-review.googlesource.com/c/1449000
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628503}

Accidently disabled as part of crrev.com/627191 and it caused a ton
of regressions (see bugs dupped into crbug.com/927619). So we should
probably ship this configuration by default, but as an emergency
bandaid I'm reenabling the feature in tests (and this CL will also
conveniently let us know of any regressions when reenabling should
disabling have improved other metrics..!).

R=skyostil@chromium.org
TBR=isherman@chromium.org

Bug: 927619, 891670, 885371
Change-Id: I9b737a786da5e589ad816827e8d52d439e785204
Reviewed-on: https://chromium-review.googlesource.com/c/1449575Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628502}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/263746b68633..4fa143d003ed


Created with:
  gclient setdep -r src-internal@4fa143d003ed

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib41a4c7232d0f0e53efc829bdc5978e2e4ebd351
Reviewed-on: https://chromium-review.googlesource.com/c/1450467Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#628501}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1fe1ad2c..d5b02673

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Idf4651e11b72322e7cc812b7bef2eda00df4f7de
Reviewed-on: https://chromium-review.googlesource.com/c/1450535Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#628500}

ContextProviderImpl incorrectly assumed that LaunchProcess() would
take ownership of the zx::job specified in the LaunchOptions. Fix the
provider not let the zx::job handle be closed after launch.

To support testing of this fix, add a ScopedDefaultJobForTest helper to
//base, to allow the handle returned by base::GetDefaultJob() (which
ContextProviderImpl creates a per-Context job under) to be overridden
for a given scope.

Bug: 927403
Change-Id: I83cc6119657d82fc8d4c7a62081a1c04938a70b5
Reviewed-on: https://chromium-review.googlesource.com/c/1450614
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628499}

This CL removes SigninManager from bookmark_bubble_view_browsertest.cc
and uses IdentityManager instead of it.

Bug: 927249
Change-Id: Ifea98f39461d900747ce24fec56315489f0608cb
Reviewed-on: https://chromium-review.googlesource.com/c/1449440Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#628498}

This CL removes unused header, device_id_helper.h, from
ios_chrome_signin_client.mm.

Bug: 927332
Change-Id: I34c9fd2254e1b4170f1030d54517d452cb414f6d
Reviewed-on: https://chromium-review.googlesource.com/c/1448008Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#628497}

This CL removes unused header, device_id_helper.h, from
ios_web_view_signin_client.mm.

Bug: 927333
Change-Id: I55fa8ad3a62c89d99cfcf91d9b37427f7dace6c9
Reviewed-on: https://chromium-review.googlesource.com/c/1448090Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#628496}

It seems like we don't have a session for a particular client
when calling ChromeDevToolsManagerDelegate::HandleCommand.
This should not be the case, so adding some DCHECKs to verify
two possible root causes of such behavior (duplicate clients
and wrong ClientDetached notification).

Meanwhile, guard against the crash with an if statement.

Bug: 927595
Change-Id: Iebbb0360ea96d6b1d4eacbfbc34a72fc5a1b8d7d
Reviewed-on: https://chromium-review.googlesource.com/c/1450422
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628495}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4f738c1fe581..a1fbdff17736


git log 4f738c1fe581..a1fbdff17736 --date=short --no-merges --format='%ad %ae %s'
2019-02-01 yuweih@chromium.org Fix filename sorting logic in git_cache.py


Created with:
  gclient setdep -r src/third_party/depot_tools@a1fbdff17736

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:927154
TBR=agable@chromium.org

Change-Id: Ie55afac652072ee9a153c60154d4c1dd680a0bd9
Reviewed-on: https://chromium-review.googlesource.com/c/1450632Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#628494}

https://skia.googlesource.com/skia.git/+log/3ed198faf93a..26ccfcc96f98


git log 3ed198faf93a..26ccfcc96f98 --date=short --no-merges --format='%ad %ae %s'
2019-02-01 brianosman@google.com Remove SkICC::WriteToICC
2019-02-01 bsalomon@google.com Make GrMesh hold regular ref on GrBuffers.
2019-02-01 reed@google.com remove unneeded friends/includes in SkPaint.h
2019-02-01 kjlubick@google.com CMake: distinguish between file and dir copies by presence of '.' in src path


Created with:
  gclient setdep -r src/third_party/skia@26ccfcc96f98

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@chromium.org

Change-Id: Icfd1c576ffe0177f6a396f75668e2ebd6ecf284d
Reviewed-on: https://chromium-review.googlesource.com/c/1450466Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#628493}

Looking at logs right now is slow going without this information.

It seems to work:

https://chromium-swarm.appspot.com/task?id=42c3fb172bd39010&refresh=10&show_raw=1

Bug: chromium:917211
Change-Id: If30ea9075a4275eb7c5aee89521a896d0c82004f
Reviewed-on: https://chromium-review.googlesource.com/c/1450020Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628492}

"Disable DAA" CL https://chromium-review.googlesource.com/c/chromium/src/+/1412462
broke many NG tests because they were not rebaselined.

This rebaselines NG tests so they work again.

Bug: 913223
Change-Id: I96de360ee7572f1446d9a07c3ca5e7c047a2bb5c
Reviewed-on: https://chromium-review.googlesource.com/c/1450202Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628491}

The test was disabled because of a flaky crash which has been fixed by
https://chromium-review.googlesource.com/c/chromium/src/+/1263043.

TBR=piman@chromium.org

Bug: 880948
Change-Id: I32dc675ba564fdb580840482c375237b59e3a15f
Reviewed-on: https://chromium-review.googlesource.com/c/1450615Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628490}

Change-Id: Iccdbbe823d3d4ed2554c2527d90da8b7692a2e4e
Reviewed-on: https://chromium-review.googlesource.com/c/1450282
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628489}

Change-Id: Ie227a7fa799c50db4f874ea2a82d1c0b1bcad5a0
Reviewed-on: https://chromium-review.googlesource.com/c/1448511Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628488}