- 14 May, 2020 40 commits
-
-
Harkiran Bolaria authored
Delta: fix flakey testing failures on linux-chromeos-dbg trybot From previous submit: Bfcache is disabled for documents and frames when picture-in-picture functionality is used because the functionality does not close and the video continues to be displayed even while the page is in the cache. Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1073224 Change-Id: Icea97b3f3f408ad9b677a39ad4d3bfe924c69309 TBR=haraken@chromium.org Change-Id: Icea97b3f3f408ad9b677a39ad4d3bfe924c69309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188654 Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768896}
-
Yue Zhang authored
This CL fixes an issue in conditional tab strip. When switching between normal/incognito tab model by creating new tabs through toolbar menu, there can be two types of misbehavior: 1) The strip doesn't correctly reflect the tab model switch. 2) New tab creation while switching tab model will lead to wrong number of tabs in tab strip. To resolve above problems, this CL 1) Resets the strip if needed when there is a tab model switch. 2) Adds one extra check in TabListMediator so that when reset and add happens at the same time, we don't do redundant addition. Bug: 1081841 Change-Id: Ied7f9e2ee7513b77567b8e7331053d1398342070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197417Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#768895}
-
Matthias Körber authored
Relaxed requirements for BR to ZIP and for TR to ZIP_OR_STATE. With this change, logging the import success is not conditioned on having a LINE1 entry anymore. Since not needing a LINE1 entry is a very rare case, it is not part of combined requirements histogram, yet. Change-Id: I2103a5b4f7d54216e5ea210faee03f91460d60fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199105 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#768894}
-
Ramin Halavati authored
DatabaseTracker uses the term 'incognito' with the meaning of 'in-memory'. This is used for all profile types that are OffTheRecord (including incognito, guest, and non-primary OTRs). To fix the possible misinterpretation, 'incognito' is replaced with 'OffTheRecord'. This CL does not make any behavioral change and is just for better code readability. Bug: 968028 Change-Id: Ifce346865d9d054883ab45679fd3a87144e88bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201377 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#768893}
-
Mugdha Lakhani authored
A layout weight of 1 is a good way to make the TextView take up the rest of the remaining width of the parent view, but it is causing issues with centering of the view. This CL removes that. It also centers the contents of the UrlBarView to match the current use case. Here's a video of what the UI looks like after this change: https://drive.google.com/file/d/1fRzackboMhZW5mMAkiLyKs9zKbll35Ei/view?usp=sharing Bug: 1052375, b/156453601 Change-Id: Iecf4b03aacc2ebb60253c6e437031de1320f644a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199277Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#768892}
-
Shakti Sahu authored
Bug: 1081559 Change-Id: Id0e0bbb4d2d0ea1dc2b44bd9cfb4dc1ebd245af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200076 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#768891}
-
David Tseng authored
This change also adds missing param traits for ui::AXEventIntent which was already part of ui::AXEvent. The Blink renderer -> browser IPC has been fully transitioned to mojo, but the browser -> extension renderer hasn't, so we need to keep maintaining legacy IPC including param traits in ui/accessibility/ax_param_traits*. It was missed previously because no clients of this member existed from the extension renderer. R=akihiroota@chromium.org, nektar@chromium.org AX-Relnotes: n/a Test: manually verify intents appear as part of typing into a text field. Change-Id: Iba4bdafbfd56399c7467721faf845baf393cdda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185511 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#768890}
-
Christian Dullweber authored
Disable deletion of cookies through the cookies tree model for supervised users on ChromeOS. Bug: 2201756 Change-Id: I9a5057f94ab61ba85a91f572f1592d36733fcd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202236Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#768889}
-
Kuo Jen Wei authored
Bug: b:155938542 Test: Manually Change-Id: I20a71f1292d85ba2595e20a0ec33e0668df0a203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190466 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#768888}
-
Kurt Horimoto authored
The SafeBrowsing URL checker strips refs and uses canonicalized URLs, so responses with the same canonicalized URL as a previous request should use the same decision. Bug: 1079493 Change-Id: Id696ce278dc0235bb677b4762a7a33c9fce490b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202496 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#768887}
-
Ayu Ishii authored
This change adds a UMA histogram for the MatchType option to measure if it is useful for users or if it is an unnecessary option. [1] Github issue: https://github.com/WICG/cookie-store/issues/128 Tested locally: chrome://histograms/Blink.CookieStore. Change-Id: Ic38f1e6469855bec88cbda11bcfd01ba79ce9be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195442 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#768886}
-
Ted Meyer authored
This makes the original chrome://url function as normal while simultaneously enabling the sending of events to devtools. Bug: 1018414 Change-Id: I5555d97df5456e65bed56240f3713586203d8a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197818Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#768885}
-
Philipp Hancke authored
BUG=chromium:921041,chromium:840659 Change-Id: I78b85c0dedd15ecf46300f114620c896c4851c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196396 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#768884}
-
Lutz Vahl authored
This is a roll-back to 8.4.371. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. R=machenbach@chromium.org,vahl@chromium.org Change-Id: Ieeda8c6c93c5746014cf213f2ca7ab4028f8783a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201376Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#768883}
-
Rakib M. Hasan authored
import_notifier.py requires WPTExpectationsUpdater.write_test_expectations to return a dictionary mapping test names to lists of test expectation strings. This CL makes sure that it returns that dictionary. The fix for WPT imports can be seen in the diff between patchset 1 and patchset 2. Test: crrev.com/c/2200009 does a full run of wpt_import.py. Expectations are created for the imported tests and are written to the file. Bug: 1050760, 1050754 Change-Id: I138ab91408e52b450e47bf0b38b10158b5677c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199998Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#768882}
-
Victor Fei authored
Refactored AXPlatformNodeWinUnittests test names to drop *Test in order to comply with standards. There is no functionality changes. For example: BEFORE: TEST_F(AXPlatformNodeWinTest, TestIAccessibleLocation) AFTER: TEST_F(AXPlatformNodeWinTest, IAccessibleLocation) Change-Id: Ic90e1d8dbfd1fb8fc4e4e400ba0aba27929e70e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199022Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#768881}
-
Wei-Yin Chen (陳威尹) authored
The differences in web rendering can be ignored. Bug: 1025241 Change-Id: I7f34e51ebdd22b0be97d35ccb9257bc8387ffa8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198640Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768880}
-
John Smith authored
When kColorId_TableBackgroundAlternate got added, it didn't have a mapping in Windows high contrast or gtk. This change adds those mappings, using the same colors as kColorId_TableBackground, as intended on non-Mac platforms. Bug: 1082538 Change-Id: Iceaa51d4af602b45213da54d20233e5eafbcd4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200090 Commit-Queue: Joan Barnett <johnsm@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#768879}
-
Wenyu Fu authored
This work involves: 1. Moving ImpressionTracker from //chrome/metrics to //component/browser_ui as it could be beneficial for widgets that wants integrate tracking impression within. 2. Add another API for ImpressionTracker to adjust the impression threshold with a ratio, rather than the default 2/3 if pixel level threshold is not set; 3. Track impression for the primary button for HomepagePromo with ratio as 75%. Bug: 1068831 Change-Id: Ia7366cfa4b7d53dcea03d2b9143c59203f604302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199360 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#768878}
-
Wei Li authored
Since the majority of use cases is to let Widget to own its content view, and we are moving towards removing those cases otherwise, this CL adds a new API to make the ownership transfer clearer. In the followup CL, we should move most of current use cases to adopt this new API. BUG=1044687 Change-Id: Ie21fd78cda1c74252171d543f1840405b8d48a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198363Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#768877}
-
Erik Jensen authored
Due to a GDM bug, affected users can't log in locally via GDM while Chrome Remote Desktop is running. This CL attempts to warn users of the situation by (1) indicating the system is unsupported to disable the web-based setup flow, and (2) by printing a warning at startup, which will also appear if the user works around (1) by using the headless setup flow. Bug: 1082584 Change-Id: I933c181852d8736cca2b9387c934cf74215ecb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200457Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#768876}
-
Ian Wells authored
Bug: 1044139 Change-Id: I1b25b52b35b7dbb3eb7a954cb45542459d9dab77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198461 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#768875}
-
Sami Kyostila authored
Inline the calls to HasPendingHighResolutionTasks() to avoid that (fairly hot) function from getting folded into unrelated code and causing misleading crash dump stack traces. No functional changes. Bug: 1027726 Change-Id: Iebd86c56dee5d5250326b48d63ce007a37364628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201819 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768874}
-
Hesen Zhang authored
- If in the server side, the translation is not ready, even if the top-level tile has a sub-level tile id, but the sub-level tile could be not existing in the response. - Remove the DCHECK, we just ignore this sub-tile in client side. Change-Id: Ie1f8fab56dc100abc66ff13d55a197fe7704caf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202127Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768873}
-
Charlie Harrison authored
Bug: None Change-Id: I11bd0c7f8503afe5430bac3b399f93134d8dc0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144407 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#768872}
-
Dana Fried authored
Please undo this change when the test has been fixed. Bug: 1082820 Change-Id: I42f33fe05905d917bf83c09c9c2c4c7b205f922a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202341 Commit-Queue: Dana Fried <dfried@google.com> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#768871}
-
Rohit Rao authored
BUG=1082705 Change-Id: I8d26b2b81b4d5e50f7f7d5504ae978997d68a3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202144Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#768870}
-
Toby Huang authored
It turns out that Unicorn users can't view HaTS surveys anywhere due to legal and privacy restrictions. Since that defeats most of the purpose of enabling HaTS for supervised users on ChromeOS, this CL reverts the code related to HaTS for supervised users on ChromeOS. Bug: 1078513 Change-Id: I6c490bcea8f16705f4aa29779a1a3334dc9a926b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188925Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#768869}
-
Dana Fried authored
Tests are consistently (but not always) failing on Win7 builder. Bug: 1082804 Change-Id: I92628ee5f12e4ae574291a3f225803fab5b699bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202318 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#768868}
-
Alice Wang authored
This CL replaces the static class SigninTestUtil with AccountManagerTestRule to mock the AccountManagerFacade in background_sync tests. The latter is simpler and less flaky. Bug: 1078342 Change-Id: I4754df741cf27b92b0c99fa19f7377d762050396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185009Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#768867}
-
Yi Gu authored
Bug: 1066016, 1066017 Change-Id: I2dc5929fc97b54d503d4290fd204d7413bf0cd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201400Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#768866}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fc43dd4cbbcb..db592f10d318 git log fc43dd4cbbcb..db592f10d318 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 dberris@chromium.org auto-triage: Reopen issues with new regressions 2020-05-14 dberris@chromium.org refactoring: Preserve p-values in comparison result Created with: gclient setdep -r src/third_party/catapult@db592f10d318 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1051710,chromium:1081607 Tbr: nuskos@google.com Change-Id: Ie5628c40af267e72f73a5927739c62c6df0876d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201747Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768865}
-
Koji Ishii authored
Following <crrev.com/c/2198867>, there are more |MarkDirtyLine*| tests in |NGInlineNodeTest|. This patch ports them to |NGFragmentItem|-based line caching. Bug: 982194 Change-Id: Icf1841d83d2a63893b33a240382c299c427ce5d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198704 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#768864}
-
Peng Huang authored
For the GPU hang and crashes, I found all those boxes have two GPUs. One is discrete NVIDIA GPU and one is integrated INTEL GPU. Chrome uses the discrete NVIDIA GPU for GL, but chooses INTEL GPU for vulkan. Since all hangs and crashes have the same configuration. So I think the hang and crash could be related. Try to fix the hang by using the same GPU for both GL and Vulkan. Bug: 1082095,1072413 Change-Id: I20a191b03c23e10d1617098c305e0ccf9c9142c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200153Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#768863}
-
Wei Li authored
In these unit tests, the reason to not letting the views hierarchy to own the view was due to the controller and delegate's shorter lifetime. We changed to let the test class own the controller and delegate so that their lifetime are guaranteed. Thus we can remove the use of set_owned_by_client(). BUG=1044687 Change-Id: Id95274422abcbae29107ac2cfdc69adec4ba2d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196929 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#768862}
-
Katie D authored
Users have requested a way to darken all of the screen except what is being read by Select to Speak, in order to improve focus. This draws a semi-transparent black color over the rest of the screen except for where the focus ring and its contents are drawn. Plumbs the focus ring background alpha to Select to Speak, although it is not used yet. Setting the alpha in prefs will be a separate change. Ax-Relnotes: N/A Bug: 1079424 Change-Id: I5c0355fd33b8f595c0e761a46871405a0437ec22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188532 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#768861}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c9ed32549988..ce925b4cbe60 git log c9ed32549988..ce925b4cbe60 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 cnorthrop@google.com Perf: Add Temple Run trace Created with: gclient setdep -r src/third_party/angle@ce925b4cbe60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@chromium.org Change-Id: I8afcc9ff3baeb91ab95cd48d5c2172f2ec99525e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201746Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768860}
-
Roman Sorokin authored
Current flow relies on the page loaded event. SAML page might contain embedded pages which are hosted on separate domains (e.g. Google captcha). That might lead to wrong SAML notice "This sign-in service is hosted by ...". This CL extracts domain from the top level url on each loadcommit Fixed: 1055791 Change-Id: I882a62dc29200c6eb6a569defb89f25c7db2de91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201761Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768859}
-
David Benjamin authored
Bug: 1066623 Change-Id: I3925e1d9e394983f6d6ecb8dc97b31222a333ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182567Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#768858}
-
Nicolás Peña Moreno authored
Currently, we use a static unified clock to be able to compute the 'time at which the global monotonic clock is zero'. This means that this values survives even if a page is reloaded after going to sleep for a while. This is a problem because the time relies on a delta between the unix time and the monotonic time, which may change after going to sleep. Hence this means that values after reload cannot be compared with the value returned by performance.timeOrigin. This CL fixes this by removing the class and computing this value separately upon instantiating each Performance object. In particular this ensures that performance.timeOrigin and performance.timing.navigationStart don't become extremely different after going to sleep and then reloading a page. Bug: 955532 Change-Id: Iaed7e127cd1224a4d3f053225635f2947e074bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182670Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#768857}
-