GitLab

There was a regression recently that was fixed (https://codereview.chromium.org/2838673003/) but broke the network grouping experiment. This patch fixes that regression.

We were deeming the item as not needing to be removed or added without checking if there is a new parent.

R=dgozman,pfeldman
BUG=718116

Review-Url: https://codereview.chromium.org/2856863006
Cr-Commit-Position: refs/heads/master@{#469250}

BUG=716649

Review-Url: https://codereview.chromium.org/2859623002
Cr-Commit-Position: refs/heads/master@{#469249}

This disables safe ARC icon decoding which requires IPC.

TEST=Test passes.
BUG=709297

Review-Url: https://codereview.chromium.org/2856353002
Cr-Commit-Position: refs/heads/master@{#469248}

Help diagnose bugs from non-usable keys more quickly.

BUG=internal b/37379047

Review-Url: https://codereview.chromium.org/2861653003
Cr-Commit-Position: refs/heads/master@{#469247}

So that the UI strings are consistent across Chrome.

BUG=706871

Review-Url: https://codereview.chromium.org/2791433002
Cr-Commit-Position: refs/heads/master@{#469246}

[refactor] - Use WebContents::FindFrameByFrameTreeNodeId() instead of manually searching all frames.

This CL removes a manual for-loop and replaces it with the public API
specified for this purpose.

BUG=NONE

Review-Url: https://codereview.chromium.org/2858143002
Cr-Commit-Position: refs/heads/master@{#469245}

Restore HPKP for facebook.com and preload [www.]messenger.com for HSTS+HPKP.

BUG=
TBR=agl@chromium.org

Review-Url: https://codereview.chromium.org/2861943002 .
Cr-Commit-Position: refs/heads/master@{#469244}

https://pdfium.googlesource.com/pdfium.git/+log/0acfff302c03..28b44b03c133

$ git log 0acfff302..28b44b03c --date=short --no-merges --format='%ad %ae %s'
2017-05-03 thestig Clean up CRYPT_ArcFourCrypt().

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I406c719651fad5e5287df740c23839070ceec6ef
Reviewed-on: https://chromium-review.googlesource.com/495428
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469243}

1. Change popup overlay according to new specs.
2. Change the reset alert icon
3. Other miscellaneous changes (Put powerwash texts in one line etc.)

BUG=715851
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2847603002
Cr-Commit-Position: refs/heads/master@{#469242}

R=rockot@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2851173004
Cr-Commit-Position: refs/heads/master@{#469241}

https://skia.googlesource.com/skia.git/+log/6d4b65e9dad9..461fa6ad8ed8

$ git log 6d4b65e9d..461fa6ad8 --date=short --no-merges --format='%ad %ae %s'
2017-05-03 msarett Add SkImage::makeColorSpace() with correct transfer fn behavior
2017-05-03 mtklein Revert "treat SkPMColor as sRGB in SkPM4f::FromPMColor()"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I83dbf7f19378ba6cb83707b0521cd326b67dd8e3
Reviewed-on: https://chromium-review.googlesource.com/495707Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469240}

Instead of picking up a simple copy of histograms.xml, the metrics_metadata target will now by
merging histograms.xml and enums.xml into single file.

Scripts for enums now update enums.xml, pretty_print.py will enforce that the split is continued,
and validation is updated to run on the merged result.

To be landed after the server side parsing code is fully migrated to using the archived
metrics_metadata.zip files.

BUG:699328

TBR = tnagel,bbudge

Change-Id: Ia701423b7f2117991275477a92f77048a542b6db
Reviewed-on: https://chromium-review.googlesource.com/481901
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469239}

Reason for revert:
This patch is causing some PaymentManager tests to fail.
(https://crrev.com/2858773002)

Original issue's description:
> PaymentHandler: Implement PaymentInstruments.keys().
>
> The method to return keys of the stored payment instruments in insertion order.
>
> Related Spec Link:
>   https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface
>
> BUG=661608
> TEST=payment_manager_unittest.cc, payment-instruments.html
>
> Review-Url: https://codereview.chromium.org/2850203002
> Cr-Commit-Position: refs/heads/master@{#468747}
> Committed: https://chromium.googlesource.com/chromium/src/+/09c61ecc5adf140aa7a59aef0ecacc510e0be1d8

BUG=661608

Review-Url: https://codereview.chromium.org/2859803002
Cr-Commit-Position: refs/heads/master@{#469238}

Review-Url: https://codereview.chromium.org/2786773002
Cr-Commit-Position: refs/heads/master@{#469237}

TBR=jbudorick@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2861583009
Cr-Commit-Position: refs/heads/master@{#469236}

R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2847833002
Cr-Commit-Position: refs/heads/master@{#469235}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/779720b9..af02d0f9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2856323002
Cr-Commit-Position: refs/heads/master@{#469234}

Motivation:
In order to support tracing metrics for prepareToMeasureValuesAsync method,
we need to be able to trigger tracing between prepareToMeasureValuesAsync &
actual test run. This CL rename prepareToMeasureValuesAsync method to
startMeasureValuesAsyn & refactor it  so that the
actual test code is specified as a callback, which allows the framework
to interject the startTrace() call before running test in the future.

BUG=701059

Review-Url: https://codereview.chromium.org/2858783003
Cr-Commit-Position: refs/heads/master@{#469233}

Several //ipc headers will depend on a generated buildflag header and
we have to guarantee the existence of this header before the build of
these source sets.

BUG=711302

Review-Url: https://codereview.chromium.org/2852273002
Cr-Commit-Position: refs/heads/master@{#469232}

Two problems here:
. timeout is in seconds, not minutes.
. hard_timeout needs to be inside the swarming block, otherwise it's
  not used at all.

BUG=none
TEST=none
R=rockot@chromium.org
TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2856183002
Cr-Commit-Position: refs/heads/master@{#469231}

Currently when a checkbox is the extra view, the checkbox tends to cause
the other buttons in a dialog to get bigger. This is because Checkbox
extends LabelButton, so the check using AsCustomButton() will classify
it the same way.

To fix, explicitly filter out Checkboxes from the equal-sizing logic in
DialogClientView.

BUG=671820

Review-Url: https://codereview.chromium.org/2855623004
Cr-Commit-Position: refs/heads/master@{#469230}

The implementation is now part of a class private to network_connection_handler.cc.

This is in preparation for using a test double for NetworkConnectionHandler.

BUG=672263

Review-Url: https://codereview.chromium.org/2861883002
Cr-Commit-Position: refs/heads/master@{#469229}

BUG=
TBR=palmer@chromium.org

Review-Url: https://codereview.chromium.org/2859983002 .
Cr-Commit-Position: refs/heads/master@{#469228}

BUG=none
TBR=junov@chromium.org

Review-Url: https://codereview.chromium.org/2856223005
Cr-Commit-Position: refs/heads/master@{#469227}

BUG=705331

Review-Url: https://codereview.chromium.org/2850533003
Cr-Commit-Position: refs/heads/master@{#469226}

See https://html.spec.whatwg.org/multipage/infrastructure.html#safe-passing-of-structured-data

And the web platform test here:
https://github.com/w3c/web-platform-tests/blob/master/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-notifications-api.any.js

BUG=chromium:718192

Review-Url: https://codereview.chromium.org/2860873002
Cr-Commit-Position: refs/heads/master@{#469225}

They're intermittently running out of memory. Seems difficult to
guarantee that resources will be reclaimed promptly enough for large
allocations to succeed all the time.

BUG=717023
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857583006
Cr-Commit-Position: refs/heads/master@{#469224}

BUG=717417

Review-Url: https://codereview.chromium.org/2863523003
Cr-Commit-Position: refs/heads/master@{#469223}

BUG=713829
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2855323002
Cr-Commit-Position: refs/heads/master@{#469222}

method and instead explicitly track the state in QuicChromiumClientStream.

BUG=716563

Review-Url: https://codereview.chromium.org/2861583004
Cr-Commit-Position: refs/heads/master@{#469221}

Produce a WebRTC log message when:
* starting to use gpu jpeg decoder
* received first decoded frame from gpu jpeg decoder
* gpu jpeg decoder fails
* first frame received at VideoCaptureController

BUG=717772

Review-Url: https://codereview.chromium.org/2860573008
Cr-Commit-Position: refs/heads/master@{#469220}

Adding support for "removed on cache reset" pages to the query interface.
Also Adding a new interface on OfflinePageModel to delete pages matching
a specific query.

BUG=716142

Review-Url: https://codereview.chromium.org/2858803002
Cr-Commit-Position: refs/heads/master@{#469219}

There are no flags to be updated

deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in disabled state.

It achieved results that were in general comparable to "measuring
aggregation" approach, but it had worse rtx rate, and worse QoE, and did
not actually seem to be better in other regards.

Merge internal change: 154601526

https://codereview.chromium.org/2859913003/

fix packet conservation to remove packets from recovery window when they are lost.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2.

This causes a dramatic reduction in losses compared to the previous patch.

The transfer time is approximately the same.

Merge internal change: 154590929

https://codereview.chromium.org/2857243002/

Fix typo in comments.

Merge internal change: 154539040

https://codereview.chromium.org/2854823004/

QUIC - refactor stream creation. Guarded by --quic_reloadable_flag_quic_refactor_stream_creation.

This CL is in preparation for HTTP stream pairs changes.  A prototype
of the entire HTTP stream pairs work is in progress.  This CL is one
subset of that (2nd in the series).

[ HTTP stream pairs builds upon this, by having new QuicSpdySession
overrides that implicitly create headers streams, and abstracting
stream accounting as needed. ]

Add a new factory like method QuicSession::CreateStream(), that
unconditionally creates a new stream.  It's virtual so subclasses of
QuicSession can create streams that are appropriately specialized from
QuicStream.  There are new versions of Create*DynamicStream() called
MaybeCreate*DynamicStream(), and ShouldCreate*DynamicStream() called
ShouldCreate*DynamicStream2().

Separating this out means that fewer overrides of Create*DynamicStream()
and ShouldCreate*DynamicStream() will necessary, because many of those
were actually only needed to specialize the steam types.  Those will go
away when FLAGS_quic_reloadable_flag_quic_refactor_stream_creation is
deprecated.

Merge internal changes: 154351257, 154373998.

https://codereview.chromium.org/2861673004/

QUIC - stream id refactor for tests.

// AKA - http stream pairs bikeshed #1.

This CL is in preparation for HTTP stream pairs changes.  A prototype
of the entire HTTP stream pairs work is in progress.  This CL is one
subset of that.

Rework QUIC tests so that they do not hard code the assumption that
all headers are on stream 3.  Also, prepare to calculate stream ids
according to whether stream pairs are enabled, i.e. whether they
increment by 2 or 4.

Merge internal change: 150949425

https://codereview.chromium.org/2854833005/

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2862563003
Cr-Commit-Position: refs/heads/master@{#469218}

If the get buffer is destroyed say in SetAggressivelyFreeResources, the
next OrderingBarrier call after recreating the get buffer will see the
old value for last_barrier_put_offset_. CommandBufferProxyImpl uses this
to set the put_offset_changed parameter for OrderingBarrier. If the new
put_offset_ matches last_barrier_put_offset_ exactly the OrderingBarrier
becomes a nop. That can cause contexts to run out of order causing
all sorts of rendering glitches.

R=jbauman
BUG=715997

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie1e511e22a3e2f3b0e71ea872bbd690925725be9
Reviewed-on: https://chromium-review.googlesource.com/495369Reviewed-by: John Bauman <jbauman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469217}

The chrome://extensions page uses different urls for a few things,
primarily to highlight a given extension or to display the extension's
options. In the MD version, we have separate pages for these, which
makes these more like navigations.

Add basic page and history manipulation to the chrome://extensions page.
Navigating to a subpage updates the location and pushes a new state to
the history stack, so that clicking back will return you to the previous
page. Dialogs are contained within a page, and do not push a new
history state.

Examples:
- Navigating from the main view to the details view updates the
  location, and 'back' would return to the main view.
- Opening the options dialog from the details view does not push new state
  (since otherwise 'back' would just close the dialog).

Add tests for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2811993004
Cr-Commit-Position: refs/heads/master@{#469216}

In this CL:
* Always show IP config section for remembered or connected networks.
* Fix editing IP config when switching from automatic to static.

BUG=717262
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2856023002
Cr-Commit-Position: refs/heads/master@{#469215}

BUG=672263

Review-Url: https://codereview.chromium.org/2861583002
Cr-Commit-Position: refs/heads/master@{#469214}

The NaCl build (used by //remoting) doesn't actually process
certificates, so we can switch them easily. (They configure
SSLClientSocket to allow only a single certificate and run some other
authenticator over the channel.)

Sadly, this doesn't buy the binary size wins yet. It looks like this is
because they pull in WebRTC. But it means that once this and the Android
switch sticks, we can tidy up USE_OPENSSL_CERTS.

BUG=671420

Review-Url: https://codereview.chromium.org/2861813002
Cr-Commit-Position: refs/heads/master@{#469213}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/86a6787..075011d

$ git log 86a6787..075011d --date=short --no-merges --format=%ad %ae %s
2017-05-03 ehmaldonado@webrtc.org Revert of Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ (patchset #2 id:60001 of https://codereview.webrtc.org/2851563003/ )
2017-05-03 glaznev@webrtc.org Initial implementation of Android audio playback error handling.
2017-05-03 mbonadei@webrtc.org fixing braces around initialization of subobject
2017-05-03 deadbeef@webrtc.org Fixing DCHECK in turnport.cc that was broken by refactoring.
2017-05-03 henrika@webrtc.org Resolves race between Channel::ProcessAndEncodeAudio() and Channel::StopSend()
2017-05-03 magjed@webrtc.org Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/
2017-05-03 peah@webrtc.org Reland of Added ARM Neon SIMD optimizations for AEC3 (patchset #1 id:1 of https://codereview.webrtc.org/2856113003/ )
2017-05-03 mbonadei@webrtc.org Revert of Extract iOS SDK helpers to separate target. (patchset #1 id:1 of https://codereview.webrtc.org/2852323003/ )
2017-05-03 peah@webrtc.org Revert of Added ARM Neon SIMD optimizations for AEC3 (patchset #2 id:970001 of https://codereview.webrtc.org/2834073005/ )
2017-05-03 peah@webrtc.org Added ARM Neon optimizations for AEC3
2017-05-03 mbonadei@webrtc.org Reland of Extract iOS SDK helpers to separate target. (patchset #1 id:1 of https://codereview.webrtc.org/2853273002/ )
2017-05-03 peah@webrtc.org Corrected the behavior in AEC3 during buffer overruns and underruns
2017-05-03 kjellander@webrtc.org Remove config.h from //webrtc:webrtc target.
2017-05-03 mbonadei@webrtc.org Adding virtualsocketserver to rtc_base sources
2017-05-03 brandtr@webrtc.org Reland of Don't reinit encoder when rotation changes. (patchset #1 id:1 of https://codereview.webrtc.org/2861633003/ )
2017-05-03 brandtr@webrtc.org Revert of Don't reinit encoder when rotation changes. (patchset #3 id:40001 of https://codereview.webrtc.org/2853463004/ )
2017-05-03 sakal@webrtc.org Address tkchin's comments on RTCCameraVideoCapturer.
2017-05-03 brandtr@webrtc.org Don't reinit encoder when rotation changes.
2017-05-03 brandtr@webrtc.org Don't re-randomize picture_id/tl0_pic_idx when re-initializing internal encoders.
2017-05-03 bpostelnicu@mozilla.com Make sure the resulted operation is calculated on float basis.
2017-05-03 sakal@webrtc.org Fix lint issues on Android.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2855303002
Cr-Commit-Position: refs/heads/master@{#469212}

https://skia.googlesource.com/skia.git/+log/ab244f045a07..6d4b65e9dad9

$ git log ab244f045..6d4b65e9d --date=short --no-merges --format='%ad %ae %s'
2017-05-03 bsalomon Revert "Revert "Add a new non-AA rect op that does not inherit from GrLegacyMeshDrawOp.""
2017-05-03 mtklein treat SkPMColor as sRGB in SkPM4f::FromPMColor()
2017-05-03 bsalomon Revert "Add a new non-AA rect op that does not inherit from GrLegacyMeshDrawOp."
2017-05-03 bsalomon Add a new non-AA rect op that does not inherit from GrLegacyMeshDrawOp.
2017-05-03 mtklein fix G3 opt android_arm build?
2017-05-03 mtklein disable test_diagonal on 565
2017-05-03 fmalita Validate SkSpecialSurface raster info
2017-04-05 halcanary headers: fix
2017-05-03 fmalita Add a GM to exercise some complex gradient constructs

Created with:
  roll-dep src/third_party/skia
BUG=716311


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I0ef3efa6313f3f0815315cf662a0c94729c34b58
Reviewed-on: https://chromium-review.googlesource.com/494969Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469211}