- 23 Jul, 2019 40 commits
-
-
Jeremy Chinsen authored
Currently draw_utils::GetSurroundingRect() takes a pp::Rect object and uses only the y-component and height, which means it uses only half of the structs attributes. This refactor makes it so GetSurroundingRect() just takes |page_y| and |page_height| as individual int values, reducing the amount of unnecessary data sent. Change-Id: Ie201b4e2d5d6f3c246173782af43cb44890014ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715789Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#680132}
-
Nicolás Peña Moreno authored
This CL adds 'largest-contentful-paint' to PerformanceObserver's supportedEntryTypes, and adds a test. It also fixes a typo in the LayoutShift supportedEntryTypes test title. Bug: 965505 Change-Id: I6954f8abbdf27640413d790e05ff72aa945a248b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713295 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680131}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/84bcd0c3ae08..15baa953a54e git log 84bcd0c3ae08..15baa953a54e --date=short --no-merges --format='%ad %ae %s' 2019-07-23 mtklein@google.com only need to hoist one register per tbl imm 2019-07-23 robertphillips@google.com Address TODO in testing code (i.e., cleanup create_backend_texture) Created with: gclient setdep -r src/third_party/skia@15baa953a54e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I56ba9da4bf4b2219dcff5233e354497a62fa233f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680130}
-
Shakti Sahu authored
This CL creates a ThinWebView class that can display a WebContents on an android surface. It also provides method to the user to attach a ContentView that can be used to provide user interactability. Bug: 980323 Change-Id: If99b98b695a512daa693c343c07ba4717af6ca52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684331 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#680129}
-
James Forshaw authored
This CL removed the old wrapper for RegDeleteKeyEx which was used for compatibility with Windows XP. As the code base is only supported on Windows 7 and above this function can be statically linked. Bug: 986625 Change-Id: I46814d7758948c371de42f66a6e9e96e4a6bfb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714289Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#680128}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/109b30b3..4d5a1973 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If655c7b2a98c33b80b969e6d2b3e4eec10b0d952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715406Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680127}
-
Ted Meyer authored
Also moved the trace event to GetResolutionsForDecoders so that when it is refactored, performance can be measurably improved. Change-Id: Ia0d8808aac8962fde5a45753933672b49900d429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705034 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#680126}
-
Alex Cooper authored
The xrWebGLLayer tests didn't have their expectations wrapped in t.step so their failures were reported as timeouts, rather than the actual error. xrWebGLLayer_viewports expected the device init viewport to match the output viewport, which is not a specced behavior, and contradicts the webxr-test-api spec which calls this out as unsupported, so that part has also been reverted. Bug: 986672 Change-Id: I23713956f6b0bd3d432f0e6e6fdc9d015d509099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715237 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#680125}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0a30c29ba846..3d61312959f3 git log 0a30c29ba846..3d61312959f3 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 tsepez@chromium.org Remove xfa/fwl dependence on xfa/fxfa/parser 2019-07-23 tsepez@chromium.org Remove fpdfdsk/pwl dependence on core/fpdfapi/page 2019-07-23 tsepez@chromium.org Remove circular includes from fpdfapi/font to fpdfapi/page. 2019-07-22 tsepez@chromium.org Remove knowledge of CPDF_ImageObject from fpdfapi/font layer. 2019-07-22 tsepez@chromium.org Use CPDF_Type3Char::FormIface rather than CPDF_Form in cpdf_type3font.cpp Created with: gclient setdep -r src/third_party/pdfium@3d61312959f3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ia43bc2f2fb1c770179b920eecf70482c60b84c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715788Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680124}
-
Kyle Milka authored
Remove some unused CLASSES and move the remaining one to the file it's actually used in. Set the text label via replacements instead of in javascript. Bug: None Change-Id: I72896252332507854930ad2aa6a682f2ff81495d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715108Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#680123}
-
Yann Dago authored
Bug: 982371 Change-Id: I3442efe051902541697c7f2499e63ab06e0d1361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713365Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#680122}
-
Robert Ogden authored
Bug: 985099 Change-Id: Id125845b72a84101451e1d100432e6e470457c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715723 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#680121}
-
Owen Min authored
The report size estimate depends on an assumption that full Profile report is much larger than the basic one. This is not true for the test which causes one of the test flaky. Adding more things into Profile to make the test more close to the real world. Bug: 956237 Change-Id: Idd66ed699362628d0ebd7b2322efd6e960c00d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713254Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680120}
-
Yi Gu authored
target_location has a value only if the target exists. When it doesn't we early exit the DispatchMouseEvent(). In addition, we should skip setting the mouse_down_post_transformed_coordinate_. Bug: 985692 Change-Id: I4cd4dad3b1caefaf2bd7e81660e257a4bdb5fdfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715227 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680119}
-
Kristyn Hamasaki authored
Ctrl+Shift+R locks bubbles from closing and allows bubbles and their elements to be inspected. Change-Id: Iba876a5dcc78324be4750823f6f53a307559bdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703459 Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#680118}
-
Nicolás Peña Moreno authored
This CL replaces responseEnd with loadTime in ElementTiming. Before, responseEnd would be used and would be problematic for memory cached images and for inline images (data scheme). We change it to loadTime, the time at which LayoutObject::ImageNotifyFinished is called. This is the same time as when LargestContentfulPaint computes loadTime. As they are both under runtime flags and the hooks are not unified, for simplicity we compute the timestamp again. This will not be too expensive for ElementTiming, as the timestamp is gated on the existence of the elementtiming attribute. To store the loadTime, we change images_notified_ to be a HashMap which now stores the timestamp corresponding to loadTime and whether the image has painted (after being loaded). Bug: 982046, 879270 Change-Id: I69da42c9250cc36c567df5da285ef1a9a357b554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710840 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680117}
-
Asanka Herath authored
This change uses the plumbing introduced in prior CLs to perform detailed logging of GSSAPI library invocations. R=eroman@chromium.org Bug: 884313 Change-Id: Id010fda54f32691a092edd97385470502d18d15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698942 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#680116}
-
Meilin Wang authored
Delete kAssistantKeyRemapping feature flag and chrome flag since this feature has been launched. Bug: none. Test: local compile and manually test. Change-Id: Ieb8781dbb60c4ec7049c666ce05f0ce100695ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715095Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#680115}
-
Jonah Ryan-Davis authored
Recent ANGLE patches have gotten two tests to pass on all platforms: conformance/glsl/misc/shaders-with-invariance.html conformance2/rendering/blitframebuffer-size-overflow.html Bug: 830046 Bug: 980675 Change-Id: I94dbd1d5567a0524aa0e0ecc23268e390cd99816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710200Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#680114}
-
Josh Nohle authored
Adds fake implementations of CryptAuthGroupPrivateKeySharer and CryptAuthGroupPrivateKeySharerImpl::Factory for use in unit tests. Bug: 951969 Change-Id: I27a281f7f9985021c6820400e0788f7df7ed16e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713292 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680113}
-
Takuto Ikuta authored
Main purpose of this roll is to confirm that GN built on Xenial by os upgrade in https://gn.googlesource.com/gn.git/+/431bbf510dec8e10f607f7fff3f80a1ae84a737f works on Trusty builder. https://gn.googlesource.com/gn.git/+log/972ed755..152c5144 152c5144 Update and add metadata documentation 579b5b39 Move 'rust_example' to the toplevel 'examples' folder 61be3f2e Fix desc to handle single-value outputs correctly bf27729d [rust] Update RustTargetGenerator to not duplicate work 4c0c60eb Move examples to toplevel, document better. c4a88ac9 Allow crate type to be set on all Rust targets 23d22bca [docs] : fix typo 'then' => 'they' and re-generate 'reference.md' 3b5fa962 [docs] : add Markdown format for '--time' 9edc6c08 [docs] : clean up cross_compiles.md d3304fbb [docs] : fix typo sone => some fe0c6bbb Write depfile for non-C-like tools f898ccf7 Fix linking deps propagation 445ac323 [docs] GN can tell empty lists from non empty lists 3ddcc49a Fix build with GCC on FreeBSD Bug: 981741 Change-Id: I062d6b21d3955cd0a2773321b4f68056972f8950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714681Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#680112}
-
Cammie Smith Barnes authored
We add DCHECKs to CreateNetworkFactory(...) for PlzDedicatedWorker to ensure that the render frame host exists, in order to help de-flake the following webkit_layout_test: virtual/omt-worker-fetch/external/wpt/fetch/api/request/destination/ fetch-destination-worker.https.html We also change the erroring out and early return in DidStartScriptLoad(...) before the call to CreateNetworkFactory(...) to the condition when |ancestor_render_frame_host| is null, rather than merely when |worker_process_host| is null. Bug: 910713 Change-Id: I471e6393392423fce736a0ef16442222629ca613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699379 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#680111}
-
Xiyuan Xia authored
LoginDisplayHostWebUI does not need to wait for wallpaper initial animation since it has no visual change (It goes from white boot splash screen to white oobe wallpaper with brightness+gray filter). Make LoginDisplayHostWebUI always create a hidden webui and show it when webui signals ready or has network errors. Bug: 985515 Change-Id: I210ac98890e908ac4381371cba686b6283297824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710000Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#680110}
-
Takuto Ikuta authored
This is for faster compile step time by dropping debug symbols. Higher symbol level seems to cause slow link time. e.g. https://chromium-build-stats.appspot.com/ninja_log/2019/07/23/win-chromium-compile-dbg-ng-37-nyxn/ninja_log.win-chromium-compile-dbg-ng-37-nyxn.chrome-bot.20190723-064013.9724.gz/trace_sort_by_end.html from https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/347566 Bug: 794423 Change-Id: I393d5aae685fba158e7c4be7d7f25ab79b46dd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714371Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#680109}
-
Tina Wang authored
Fix nits to make code clearer. Bug: 980277 Change-Id: I08c6f04fba7e78482f01fbd5ed5f6a0b1eb09a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706556Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#680108}
-
Nick Diego Yamane authored
XEventDispatcher implementation *can* optionally be associated to a PlatformEventDispatcher, however in most cases it is not the case and 3 methods must be overridden with a empty/stub implementation. This CL changes XEventDispatcher, adding default empty implementation for PlatformEvent-related functions, making it easier and more intuitive implementing it. Bug: 789065 Change-Id: Icdb501133817038a536b108f8a0d8556ff3389f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710242 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#680107}
-
behdad authored
The name used for SubmitCompositorFrameToPresentCompositorFrame was not compatible with the code and has been changed to SubmitCompositorFrameToPresentationCompositorFrame Original CL added this histogram: https://chromium-review.googlesource.com/c/chromium/src/+/1672201 Bug: chromium:963778 Change-Id: Iaaace499606d7f896b0b9b5e38e13948655985a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715545Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680106}
-
Kyle Milka authored
These are in doodle.js and unused in local_ntp.js Bug: None Change-Id: I967f1f27a1ab7bc136c561d320282613d5b72f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715717Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#680105}
-
Gayane Petrosyan authored
Sample screenshots: https://screenshot.googleplex.com/H1mkRMhHjAT.png https://screenshot.googleplex.com/eQpbkh9vQaO.png https://screenshot.googleplex.com/3sfoZP8NaSa.png Change-Id: I78cea0e8a387dcd3bc7aa1fe0396672e79fe7463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714219Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#680104}
-
Josh Nohle authored
Adds fake implementations of CryptAuthMetadataSyncer and CryptAuthMetadataSyncerImpl::Factory for use in unit tests. Bug: 951969 Change-Id: I4824dd609edce07767e921f8a4667d03aa9448d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712605 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680103}
-
Vasiliy Telezhnikov authored
Bug: 984954 Change-Id: Ie521ed07709ea266ea7b1c16552c14650e826467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715607Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#680102}
-
kylechar authored
This CL adds support to use SkiaRenderer with InProcessContextFactory. The existing constructor will use SkiaRenderer based on the feature list, so it will depend on the command line and default feature state. Also add a new constructor that lets tests pick between GLRenderer and SkiaRenderer so parameterized tests can be implemented. Bug: 956144 Change-Id: I5424237ccd8eecf9d7b20d59bd4627b27ed37749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715106Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#680101}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/249e60896429..282f4dfee653 git log 249e60896429..282f4dfee653 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 dproy@chromium.org Update tsproxy to latest version Created with: gclient setdep -r src/third_party/catapult@282f4dfee653 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:985343 Change-Id: Id51507467b4568de0eb98b33ffc1c8cbaa00bb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715145Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680100}
-
Brandon Wylie authored
The suggested removal process as documented in the bug is to: (1) Remove any instrumentation code. (2) Mark the histograms as obsolete in histograms.xml Bug: 975891,975790 Change-Id: If21eb5799c788bf49de3e3f91ba1279ad14f19a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700329Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680099}
-
Min Qin authored
These UMA are no longer used. BUG=969993 Change-Id: Ib2d54586958289240aace62ba12d3b6a6b70ae57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704735 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#680098}
-
Mario Sanchez Prada authored
Convert the implementation and clients in the browser and renderer processes for the blink.mojom.NonPersistentNotificationListener and blink.mojom.NotificationService mojo interfaces, and adapt unit tests. Bug: 955171, 978694 Change-Id: I03aa11addfcc84fa3c16680f31f58cdca69a29db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712573 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#680097}
-
Nicolás Peña Moreno authored
This CL replaces responseEnd with loadTime. Before, responseEnd would be used and would be problematic for memory cached images. We change it to loadTime, the time at which LayoutObject::ImageNotifyFinished is called. This time has the advantage of being independent of the memory cache and being after the image has been appended to the DOM, as shown by a test. To implement loadTime, we use a new HashMap. This HashMap populates the timestamps that will be used in ImageRecords. We cannot use the existing data structures because this happens before we know whether the image will be added to the set of visible or invisible images, etc. Bug: 982046, 965505 Change-Id: I50d4f304a35b60409c58c54a5bd912e7d15825e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710682 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680096}
-
Ian Kilpatrick authored
For NG types this isn't needed anymore. The NG types now use: CalculateSizeBasedLayoutCacheStatusWithGeometry Which determines the size of a fragment ahead of time, and applies the same optimization. The only thing that we now miss, is things which are sized shrink-to-fit which use legacy layout. We couldn't apply this optimization to shrink-to-fit tables, as they may have %-based inline-sized children which affect their (final) inline size. Bug: 984642 Change-Id: I0d0b584f31947bb674f4e7e5d88d7af6cf5d9d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662535 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#680095}
-
Asanka Herath authored
This mildly reduces the number of platform specific code in files that are supposed to be cross platform. R=eroman@chromium.org Bug: 927182 Change-Id: I854f452ac95a9dbeca326821d7efd9c2ea4c61b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693565 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#680094}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ecadc16190a..59b2d77a1e39 Created with: gclient setdep -r src-internal@59b2d77a1e39 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: I7d0b3f34716d0f37fc0d7cff44e24f5f95847c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715089Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680093}
-