- 21 Oct, 2020 40 commits
-
-
Rachel Wong authored
This is a reland of be611a0e. The |selected_action| member variable was sometimes uninitialized before being accessed, causing msan failures. This reland initializes the variable. Original change's description: > Enable Suggested Content by default. > > The Suggested Content toggle has been approved in > https://bugs.chromium.org/p/chromium/issues/detail?id=990279#c148. This > CL enables the feature by default, and updates tests that need to take > this into account. > > Bug: 990279 > Change-Id: Icc2c8bdf72cff8734aa5941f3fbc2774b38e4c98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462752 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Rachel Wong <wrong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818758} Bug: 990279 Change-Id: I17ac908b10fef847ed02c0a08980417c1d1998c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488261Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819365}
-
Evan Shrubsole authored
Two variations for applicable platforms (chromeos and mac). On mac, this feature will only be used in combination with the 0-copy feature AVFoundationCaptureV2. Bug: 1134165 Change-Id: Ic630d292041499d0364bf6d7935d278678595f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487103Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/master@{#819364}
-
Ossama Mahmoud authored
Make the user actions `kDoItLater` and `kShowSensorLocation` obsolete in enums.xml. Bug: 1130482 Change-Id: Ibc4d907862dce5a420970e4e02168799e439b17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489981 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#819363}
-
Michele Mancina authored
Bug: b/170722915 Change-Id: Ide6bebda310e2c361f117988af701f28cc9bc02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485510 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Auto-Submit: Michele Mancina <micantox@google.com> Cr-Commit-Position: refs/heads/master@{#819362}
-
Elly Fong-Jones authored
This test is flaky, I think by design. Bug: 1140651 Change-Id: I4f60d97b8fcc553407b33a260e91f1004615e88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488398 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#819361}
-
Erik Staab authored
Capacity was added for these in https://crrev.com/i/3351717. Bug: 1124829 Change-Id: I8665012f6bad3c2ce8734f51f3e4f6dbf13bbad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488713Reviewed-by:
Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#819360}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/553726a4c5c8..99f9277c5bcb 2020-10-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from df17a76102df to 84f5eeb6dd9b (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I42f0d134542483d778e79d04b52557b4aa5a846c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819359}
-
Sigurdur Asgeirsson authored
Bug: 1089528 Change-Id: I525693ed054e3c8d33bba6d6ee68ae3c8b82833d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485514 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#819358}
-
Rohit Agarwal authored
This CL simplifies the profile usage in ToolbarPhone and also adds instrumentation tests. Bug: 1060940 Change-Id: Id2562d2d935914ccb57ade262d667d7c37234c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488566 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#819357}
-
Ben Goldberger authored
This is to resolve a possible conflict with dogfood on dev channels Bug: 1092713 Change-Id: Ice0fe8a473c04599500a438af7c971a540457256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485575Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ben Goldberger <benwgold@google.com> Commit-Queue: Ben Goldberger <benwgold@google.com> Auto-Submit: Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#819356}
-
Ramin Halavati authored
To audit incognito clean ups at startup, |Android.ShouldDestroyIncognitoProfileOnStartup| metric is added to collect the call results to |IncognitoUtils.shouldDestroyIncognitoProfileOnStartup|. Bug: 1095548 Change-Id: Ica7aa5228b783a91beb491d6f9aaf07b6cb96bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479466 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#819355}
-
Illia Klimov authored
GURL was saved as a pointer. That caused a null pointer exception. TBR=engedy@chromium.org Bug: 1140610 Change-Id: Iacfcbb54737e330a161ffe2aabe3c2dfa4790493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490000Reviewed-by:
Illia Klimov <elklm@google.com> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#819354}
-
Natalie Chouinard authored
These histograms will be evaluated as part of the upcoming HaTS-next migration. Bug: 1140012 Change-Id: I4d4e45968c80ec114f2968ed00d8966045a88b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488092Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#819353}
-
Finnur Thorarinsson authored
This CL switches to using SetTestingFactory, thereby removing the need for injecting the wrapper at startup via a command line flag. Bug: 1135551 Change-Id: I29c4c1be56fb9d613b49876cbe6ece4e390c5b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485251 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#819352}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b432d0b75765..ffad5d3b2d0a 2020-10-21 kjlubick@google.com [canvaskit] Fix gm test runner on non-tryjobs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: Ide1c9986183368886616cb915c682b17ae81a678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489762Reviewed-by:
-
Huanzhong Huang authored
- Make the "You and Google" and "Auto-fill" sections visible, when settings is based on an ephemeral guest profile. - The notion of Ephemeral Guest profiles (go/ephemeral-guest-profiles) is to be replacing the current guest profiles. Bug: 1140419 Change-Id: If10584bb4a8105275c2eac8c581c7abccf545225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483753Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#819350}
-
Alice Wang authored
TBR=sandromaggi@google.com Bug: 1140957 Change-Id: Ibc27ca9632d9bba356fc4c628a49bd51034b3a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489623Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819349}
-
Sylvain Defresne authored
The parameters of a script invocation needs to be relative to the directory where the script is invoked which is available as the `root_build_dir` variable. Using `root_out_dir` is incorrect as it has a different value for secondary toolchains (i.e. current_toolchain != default_toolchain). Bug: none Change-Id: I573af8eb46c001fbedc641f5e47022f0424284c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489622 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819348}
-
Andrew Shulaev authored
Bug: 1138893 Change-Id: I9bb9f1c0115d7081795dfd69dee24cd93640392c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485069 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#819347}
-
Colin Blundell authored
Note explicitly contexts in which KeyedService shutdown will *not* run. Bug: 1140296 Change-Id: I389d1be66a22fa3203e49f10d3c4e43721ccd24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485267 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#819346}
-
Maksim Moskvitin authored
The only remained function of SyncBackendRegistrar was keeping track of enabled datatypes. These enabled datatypes were used to determine invalidation topics to subscribe. This CL changes the source of enabled datatypes to ModelTypeRegistry (determined by datatypes that have ModelTypeWorker, i.e. connected datatypes) and removes SyncBackendRegistrar. Bug: 1138132 Change-Id: I0f7c2a17050da5249be7a5aec00b15a28642a835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476155 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#819345}
-
shivanigithub authored
Since the RedirectMode needs to be used for other decisions than just deciding the behavior on redirect e.g. https://chromium-review.googlesource.com/c/chromium/src/+/2487704/1 it makes sense to rename it to RequestType. This CL only renames the type and enum values and their usages but has no functional change Bug: 1135149 Change-Id: Ib0856c83a9cfdcb925cdcfbacd9003895bbacace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463332Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#819344}
-
Fabian Sommer authored
Change "remvoe" to "remove". Bug: 1131450 Change-Id: Icbd37d815b19d658b2dfbf004e3116632f786cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489900Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#819343}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/f3f785ab59..4b915e7092 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/f3f785ab59..4b915e7092 Bug: None Change-Id: Ie433d9b81b087dd8d98242382a2fae9a66cedc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489427Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#819342}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cd48ca0493ce..2d615e49c1cb 2020-10-21 landrey@webrtc.org Update uploads api documentation comment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114056 Tbr: skyostil@google.com Change-Id: I36b157669352dbafa484f71018accd151a090df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489748Reviewed-by:
-
Stephen McGruer authored
This test can flake if the iframe is loaded OOP and the child script runs before the parent script. Bug: 1137228 Change-Id: I13b8d2d85cae6d0eb5ab00029a388ea321c86150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481347 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#819340}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/be6747613d78..d139f2661939 2020-10-21 fmayer@google.com Merge "Add classloader to heap graph proto." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4b83eef5320466ddb2d69f755d436cbe13df6c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489174Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3a2aa62cc74fa3dd774897e8dcc2500f24e9bd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490220Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819338}
-
sauski authored
Creates entry in fieldtrial_testing_config.json which enables the access context auditing feature. Bug: 1101675 Change-Id: I8a1435a9554a8fea2d2022bced88b32d18796441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487322 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#819337}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ef36cec5b92e..7854287f1b6c 2020-10-21 sigurds@chromium.org Update browser_protocol.pdl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I13b8f9ad7ece7cf6d159d75d0b4b00e74fff23d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489173Reviewed-by:
-
Guido Urdaneta authored
This ensures that the actual WebContents is used to track desktop capture in MediaCaptureIndicator. Prior to this CL a null WebContents was used. Bug: 1140487 Change-Id: I3078dc3d071ca1dc34716de491996a275026f793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488160Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#819335}
-
sauski authored
A large refactoring of logic on the security page occurred after the CrSettingsSecurityPageV3 tests were disabled on MacOS. This CL re-enables the test on disabled platform in the expectation that previous changes have fixed MacOS platform specific flakes. Bug: 1081908 Change-Id: I79f8fcd1f408913b0d99d0fe2a8efe697ea86ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463608Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#819334}
-
Mohamed Amir Yosef authored
This is preparation for adding the functionality of moving multiple passwords from settings view. Mocks are in the linked bug. Bug: 1139263 Change-Id: I883e39bbab9bd20cdbfb67b43883886dea71badb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479462Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#819333}
-
sauski authored
Increase minimum height for radio buttons on redesigned content settings pages to the standard two-line height if they have a sub label. Bug: 1113642 Change-Id: I7ed293a967f21c332a86aa292bb741e4ab149f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487289 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/77e70cfcbb1a..f176182440e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC apotapchuk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1140394 Tbr: apotapchuk@google.com Change-Id: I5bab7f2a201187a7ba37f014652ea4921f96be70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489661Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819331}
-
Henrique Ferreiro authored
This is a reland of dcee7502 after fixing https://crbug.com/1139157. The hidden cursor needs to be obtained from the CursorFactory, even if platform cursors are disabled and the Chromium assets are used instead (i.e. Chrome OS). This reland also fixes the original CL in that it accidentally reverted https://crrev.com/c/2443610. Original change's description: > Fix loading of animated cursors on Ozone/Wayland > > Animated cursor assets were not being loaded because GetCursorDataFor > was used for all cursors, instead of using GetAnimatedCursorDataFor when > the cursor was animated. > > With this CL, both set of cursors are merged so they can be retrieved > with a single call. > > To ease these changes, ImageCursor, which was a very thin layer over > CursorLoader, was merged into the latter. This change has the benefit of > unifying the cursor loading code path of Ash with the one of the other > Aura platforms and changing Ash on Linux to use the Chromium assets > instead of the platform cursors, as when running on Chrome OS devices. > > The only behavior change with respect to ImageCursors is that the cached > cursors will be removed on display changes, instead of reloaded. > > Bug: 1135515 > Change-Id: Iedf84290bf3792c3ce06cfad0be1b5c0e2d96946 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440760 > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815678} Bug: 1135515, 1139157 Change-Id: I2bfff067936b1ec8e828c5efdfb0a9c24caf7afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478977 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
sebsg authored
This reverts commit e95f1520. Reason for revert: Suspect for tree closure on mac-archive-rel https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/16413? Original change's description: > Update V8 to version 8.8.149. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/d82ff002..d9ccb94f > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Ic433b4fc8287a7d664817f18b5d81bada20bb87a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489002 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#819313} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I314ad1a663be5e9ff15441bdfb9a5e0bbf0551a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489724Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#819329}
-
Anatoliy Potapchuk authored
This reverts commit fe94c89a. Reason for revert:tree is red Original change's description: > Roll Chrome Mac PGO Profile > > Roll Chrome Mac PGO profile from chrome-mac-master-1603238376-a0754723f0cd6eaa7fc2494ab4a5f08c0cee1720.profdata to chrome-mac-master-1603259905-71f19f253a8b5311fb57e85e7e87c615112024a2.profdata > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/pgo-mac-chromium > Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:mac-chrome > Tbr: pgo-profile-sheriffs@google.com > Change-Id: I7247c4994debae0d519f3b60b5e3bc9b811a3f07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489660 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#819318} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,pgo-profile-sheriffs@google.com Change-Id: Ic0fbf8d36691df86e01e4855d4e4c70add801bb1 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chrome.try:mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490102Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819328}
-
Marc Treib authored
ModelAssociationDone() was always called synchronously from StartAssociationAsync(). Inlining it there uncovers some more dead code: * The status passed back to DataTypeManagerImpl was in fact always OK, so no need to pass a status at all. * requested_types_ was unused. Bug: 1102837 Change-Id: I4d66c926189280e029630c68f58ab05ec7971844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479425 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Aya ElAttar authored
EndpointType::kClipboardHistory was added in crrev.com/c/2362289, so that ClipboardHistory will have access to any clipboard data, but the logic of EnterpriseClipboardDlpController:: IsReadAllowed didn't include kClipboardHistory when it got implemented. Bug: 1139835 Change-Id: I5f7fcd9e05a2a2f424b7ff1932edec557d23180f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487288Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#819326}
-
