- 17 Mar, 2020 40 commits
-
-
Chris Harrelson authored
This is a follow-on to [1]. In addition to the added unittest, this fixes a failure in a test [2] when trying to land [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2092698 [2] http/tests/lazyload/image-subpixel-position.html [3] https://chromium-review.googlesource.com/c/chromium/src/+/2103708 Bug: 992765 Change-Id: I32b28ff0ab4cd4f9f527c6601413a16d2a1d703c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106418Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751067}
-
Livvie Lin authored
UX proposal: https://docs.google.com/document/d/19iu3ISlOw9L_PCpOh8LB4TSKC8uBPzSBiEnkZm4IiQI/edit#heading=h.qyrxas7ncbc9 Design doc: go/context-menu-unelide-dd Bug: 1061576 Change-Id: I3627f0090112378f6df8bbaf274b40c35024a7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103291 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#751066}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/440fc9959f06..2aa80df14528 git log 440fc9959f06..2aa80df14528 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 digit@google.com [vulkan]: Support multiple external semaphore implementations. Created with: gclient setdep -r src/third_party/swiftshader@2aa80df14528 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I20a9dc345b0d0f5a5bad04ac21e53d3aa1c66ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107328Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751065}
-
danakj authored
For LocalFrames that are in a Page owned by a WebView, each LocalFrame has a WebLocalFrameImpl which has a WebFrameWidget. This is always present except very early during initialization which most code can ignore. For LocalFrames in non-ordinary Pages, which live without a WebView (such as WebPagePopupImpl, devtools agent, unit tests) the LocalFrame has an EmptyLocalFrameClient instead of WebLocalFrameImpl and thus there are no WebFrameWidgets. Currently parts of core/ can not get to the WebFrameWidget because WebLocalFrameImpl is banned due to the layering mess being unresolved. It is also difficult to find the path there as going from LocalFrame requires: WebLocalFrameImpl::FromFrame(local_frame)->LocalRootFrameWidget() Since the conversion to WebLocalFrameImpl isn't a member of LocalFrame it's very hard to find and remember this path! We introduce here a well-lit road from LocalFrame to its WebFrameWidget and use it throughout ChromeClientImpl. While updating ChromeClientImpl we note that it was early-outting on WebViewImpl::does_composite() due to a null WebWidgetClient which it is no longer using, as it defers to the WebFrameWidget. Since ChromeClient means we have a WebView, we also know that WebFrameWidget does exist, and it is a better place to early out. So these are moved. This change will allow my display-mode CL for 1060336 to find the WebFrameWidget from code in core/css/ without changing blink layering more dramatically. And it is a long time coming to make this path clearer. R=dtapuska@chromium.org Bug: 1060336, 844547, 1058633 Change-Id: Iabb71ebf0c5ebaf7daea924425c9d3a3a2c23d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101847Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#751064}
-
Adam Langley authored
r745162 adds a v1 event in FidoCableDiscovery::OnStartDiscoverySession, but it's recorded unconditionally. With caBLE v2, there might not be v1 data in play. Change-Id: Ie0aa18f10137f028c4ef06f2ee8d00fc5a19490b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107424 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#751063}
-
Koji Ishii authored
This patch modifies the snap-to-pixel behavior implemented in r736251 <crrev.com/c/2024133>. The CL changed to snap the top of the padding box of the parent box to match legacy and |NGPaintFragment| behavior. It did so even for culled inline boxes too, but this part was not compatible. This patch changes the logic to ignore culled inline boxes for the snap-to-pixel behavior, matching legacy and |NGPaintFragment|. Bug: 982194 Change-Id: I667f35d4b55909505502633b2d7e70b058191c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106044 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#751062}
-
Lily Chen authored
Bug: 1061664 Change-Id: I577aedb7e78d5ad2b8359254f8af1fc384410f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107439 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#751061}
-
Daniel Murphy authored
R=pwnall@chromium.org TBR: pwnall@chromium.org Change-Id: I3e66ad4dbfdc66e4f54192ee81c275bb54848a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107576Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#751060}
-
Anders Hartvoll Ruud authored
Blink currently disables the native appearance of a widget if the author specifies a border or background that's _different_ from the border/background as specified by the UA. This comparison between author and UA border/background is problematic, because it means we can toggle native appearance of widgets in the wild just by tweaking the UA style. Moreover, it leads to behavior that's hard to predict, as Blink may behave in different ways depending on the platform. Therefore, it was suggested to instead disable the native appearance if the author specifies _any_ border/background property, i.e. no comparison with the UA style. This matches Firefox' current behavior, but deviates from Safari (which is doing what Blink currently does). We currently have two code-paths for style resolution: CSSCascade (runtime feature enabled for 'stable'), and the old path. This CL affects the CSSCascade path only, since it's likely not worth it to implement this new behavior in old path (the plan is anyway to remove it). For the CSSCascade path, the comparison between author border/background and UA border/background was implemented by adding -internal-ua-* "companion" properties which held the values provided by the UA. (E.g. -internal-ua-background-color would hold the "as styled by UA"-value, and background-color would be the normal "as styled by author"). After the entire cascade was computed, the -internal-ua-* properties would be compared with the corresponding normal properties, and we would set the HasAuthorBackground/Border flags based on this. This CL now reverts all that, and instead simply checks if the cascaded values for background/border properties have kAuthor origin. I2S: https://mail.google.com/mail/u/2/#inbox/QgrcJHrtrSkDJhRHmWSHHJQSVjGTFHNHsSq Bug: 1061846 Change-Id: I2e543460fb28bcac81410c6a14891be90d6b1a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970312Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#751059}
-
Samuel Huang authored
Previously print_python_deps.py only works for Python 2 target modules (specified with the --root switch). This CL makes the script detect the Python version of the target module (via shebang), and relaunch using the matching vpython version. Bug: 1054018 Change-Id: Iadf0df313fe098ee03c23b212dad928697be79f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106967 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#751058}
-
Ioana Pandele authored
This change adds a custom toggle to the accessory sheet to be displayed by the passwords accessory sheet when password saving is disabled for the current website. A custom toggle is needed because the view needs to display a title as well as a subtitle that indicates whether the toggle is on or off and the toggle needs to be vertically centered in the view. The SwitchView is set to be unclickable so that the parent view handles the click and the tap animates properly. The background is set to null so that there is no ripple effect on the thumb of toggle. This is consistent to the appearance of ChromeSwitchPreference. Bug: 1044930 Change-Id: I6ba5fdf8b70c117729fc0163f0ca62408a6e59d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095119Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#751057}
-
Nate Chapin authored
Bug: 1029822 Change-Id: Ib16193b5bab4aa6d5b807d067843f67670bf87e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087984 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751056}
-
Mansi Awasthi authored
This CL adds GetAccessibilityTextFieldInfo() for fetching text field information from PDFiumEngine using AccessibilityTextFieldInfo struct. GetAccessibilityTextFieldInfo() is called from within GetAccessibilityInfo() to populate PrivateAccessibilityTextFieldInfo. The CL also includes corresponding unit test. Bug: 1030242 Change-Id: Iafab8645f42c3720482f7e180d94587380f58de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084671 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751055}
-
Brian White authored
Bug: 1056622 Change-Id: I44509d2df9d16eb3b804cdb0f2c60a4e8a206921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107601 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#751054}
-
Jesse Schettler authored
Update the description of the arc-print-spooler-experiment flag to reflect that it is no longer restricted to the Canary and Dev channels. Bug: b:151731767 Change-Id: Ia550b913422e6b84225c754948552e647558f5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107419Reviewed-by:
-
Kai Ninomiya authored
Reduces the typical ("median") number of flakes per webgpu_blink_web_tests run from about 5-10 to 0. Bug: 1058176, 953991 Change-Id: Ibf0c169be5a0bb2a123b04893369808542a2390d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099523Reviewed-by:Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#751052}
-
Colin Blundell authored
This CL takes a prepapatory step to WebLayer sharing Chrome's ExternalNavigationHandler for launching external intents by creating and populating the ExternalNavigationParams struct that gets passed to the former class. I adapted the building of ExternalNavigationParams in //chrome's InterceptNavigationDelegateImpl.java:buildExternalNavigationParams() to //weblayer, leaving notes in the code where we might need to refine the calculation of some arguments over time. This CL also changes //weblayer's ExternalNavigationHandler to take in the params just so that the constructed object is used. There is no behavioral change. Bug: 1031465 Change-Id: If7135fcbfc9d369f2683208fde12725925156736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100974Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#751051}
-
Tibor Goldschwendt authored
The fakebox is an NTP search input field that forwards focus and pastes to the omnibox. It's merely an affordance on the NTP to redirect the user to the omnibox, which implements the actual search and suggestions UX. This CL adds a fakebox to the WebUI NTP similar to the existing fakebox on the local NTP. See crbug/1061073 for how the WebUI NTP fakebox looks like. Bug: 1061073 Change-Id: Ic84bbe45867baeb2040b4981ca2d5be4ee1709d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101299 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#751050}
-
Avery Musbach authored
The present CL adds a user action for entering multi-display split view, and a histogram for time spent in multi-display split view. Test: ash_unittests All/SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.MultiDisplaySplitViewMetrics/0 Bug: 1059477 Change-Id: I6e6bdfc1a13038c854f811b9165eb514a888e645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101382 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#751049}
-
Dan Harrington authored
Now surfaces can be added to FeedStream. These surfaces receive updates when the model changes. Also removed FeedStreamBackground, as we're not going to need it. This was originally primarily going to handle storage, but storage will provide an async API. Bug: 2090767 Change-Id: I043f3e7dc10a4fd3a1c983bd0fb47f2f0b04e696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102590Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#751048}
-
Friedrich Horschig authored
With this CL, sync users will see a link to the account checkup unless they use a custom passphrase. Screenshots in the linked bug. Bug: 1062253 Change-Id: Ib31676dab5457192edcc131f23775462a115c9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106090Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 110188fb. With Chromium commits locally applied on WPT: acbe6d96 "Add timeouts for EventWatchers on CSS animation tests" 6a942cea "[WPT/upgrade-insecure-requests] Merge multiple subtests into one file warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1048 and retry the command." 1bb259bc "[WPT/referrer-policy] Merge multiple subtests into one file warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 8469 and retry the command." 168319dc "[WPT/mixed-content] Merge multiple subtests into one file warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1397 and retry the command." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I963c1a5524908415565ef3887535bdcd2b863d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106319Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751046}
-
Jarryd Goodman authored
Update the copy on the warning about being signed out of sites. Bug: 1062281 Change-Id: I2af8362ab3f002451e6f3e14349ed1ec575af18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106460Reviewed-by:
-
Milica Selakovic authored
Tests were left out in https://chromium-review.googlesource.com/c/chromium/src/+/2080233 so they are added in this CL. Bug: 1053522 Change-Id: I9b166cfc4084a4627c7c65973ae4dd3dc6445da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106189 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#751044}
-
Caleb Rouleau authored
R=rmhasan@google.com NOTRY=true Bug: 1062104 Change-Id: Ibc2dd5b4d952d5ab13b8027e820047ebfff37cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106558Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#751043}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/95e01a220bc7..469205e1adaf git log 95e01a220bc7..469205e1adaf --date=short --first-parent --format='%ad %ae %s' 2020-03-17 titovartem@webrtc.org Roll in third_party/turbine 2020-03-17 danilchap@webrtc.org Disable libaom decoder by default Created with: gclient setdep -r src/third_party/webrtc@469205e1adaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I632af5f56bf26f2845b47ebe38b2909cd670d17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107414Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/005f42a834ed..e8ce957aec8c git log 005f42a834ed..e8ce957aec8c --date=short --first-parent --format='%ad %ae %s' 2020-03-17 lalitm@google.com Merge "tp: strip trace processor on Android builds" Created with: gclient setdep -r src/third_party/perfetto@e8ce957aec8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic2c6821bf46b665c260f07cba989f3b9aa579434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107326Reviewed-by:
-
Anupam Snigdha authored
Added squiggle underline style in IMETextSpan for IMEs that apply those formats during an active composition such as MS Japanese IME. Currently, the squiggle format is only applicable for composition markers. Bug: 1033764 Change-Id: I6b159def5d1a9f5983b023a08a8d2dbacf02efe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093292Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751040}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: I696fd9dc63e716cda3ec16aec9dd171f649ec4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101530Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751039}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from core/animation/. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: I9cb6b51e35926ef0ab7a9a7cfcdfd8cd6895839c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101227Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751038}
-
Robert Liao authored
NativeTheme uses the ColorProvider codepath in light mode and if the ColorProviderRedirection feature is enabled for selected colors. A bonus change is that views_examples_exe will now initialize the FeatureList. BUG=1056955 Change-Id: I3867724bcf97f17888bd7bedd3cc01203f54c3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097356Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751037}
-
Ana Salazar authored
Hotseat background blur is disabled during overview to avoid double blurring with the overview background. This blur should be disabled during the transition animations as well. Add test to ensure that the HosteatTransitionAnimation::Observer methods' animation starting is called the same times as animation ending + animation aborted. Bug: 1059454 Change-Id: I3391bc188f33085ca29b586382ad7cc86b460028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092691 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#751036}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1facd5e8d114..141ac68fa0f7 git log 1facd5e8d114..141ac68fa0f7 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 fmalita@chromium.org [skottie] Cleanup: split animators into separate CUs 2020-03-17 michaelludwig@google.com More comparison fixes 2020-03-17 csmartdalton@google.com Change GrProgramInfo::visitProxies to "visitFPProxies" 2020-03-17 csmartdalton@google.com Delete GrOpsRenderPass::drawMeshes 2020-03-17 michaelludwig@google.com Fix unsigned/signed comparison in assert 2020-03-17 michaelludwig@google.com Refactor GrMemoryPool into reusable GrBlockAllocator Created with: gclient setdep -r src/third_party/skia@141ac68fa0f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I04a57f88fb3b8244517d6e42a7643ebef3a4fa2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107325Reviewed-by:
-
Meilin Wang authored
The initial patchset is a cherry-pick of the original reland CL: https://chromium-review.googlesource.com/c/chromium/src/+/1903755 The above CL introduced a bug where a paused podcast auto-resumed playing when you try start another voice interaction, e.g. by saying "ok google" or pressing the mic button. This bug has been fixed in patchset 4 by reverting part of the change in the original CL, where |AssistantManagerServiceImpl| should not observe |AssistantMediaSession| otherwise it will form a loop between them. This CL also created unittests for |AssistantMediaSession|. Misc: Minor code refactor on |AssistantMediaSession| and |AssistantManagerService| for the test usage. Bug: b/150486679 Test: manully. Change-Id: I779a6dc2c42ac528b8c19d9f474532975bb3c629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102643 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#751034}
-
Side Yilmaz authored
FeedContentStorageConformanceTest. Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates FeedContentStorageConformanceTest class. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: Ia8893512bcabf2eb504bab9f7d64fb98d967a1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106579 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751033}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c99efb2f8c62..a30b7bd35b10 git log c99efb2f8c62..a30b7bd35b10 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 sokcevic@google.com Move subcommand_test to py3 Created with: gclient setdep -r src/third_party/depot_tools@a30b7bd35b10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie1bb97587ee06928e68c63ce826d9e974c69353d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107417Reviewed-by:
-
John Budorick authored
Bug: 1062289 Change-Id: Id91bf4d5fafc33e01b1b53d8534e97a21edf4560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107309Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#751031}
-
v.paturi authored
The hand-coded methods to set and get the force dark mode setting are being used alongside the auto-generated methods based on the settings in settings.json5. The hand-coded methods are merged with the auto-generated methods as they are meant to do the same thing. The hand-coded methods invalidate the color scheme while the auto-generated methods invalidate paint. A change in the force dark settings should ideally invalidate both. So a new change type is introduced which invalidates both color scheme and paint. Bug: None Change-Id: Ice0c4b97a30d5d7f7d91b7ea5a30a67b5b19d7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081727Reviewed-by:
Aran Gilman <gilmanmh@google.com> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
-
Vladimir Levin authored
This patch continues the refactor and clean up of the code: - Rename functions to align with what we are now calling concepts - Remove some unneeded layout invalidation, since style adjustments will invalidate style if needed R=chrishtr@chromium.org Change-Id: I4911d90289e6dd9b5b1a61c2e2c1aba2931fa9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103348Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751029}
-
Scott Violet authored
This fixs a number of cases and enables strict mode in tests. Hopefully that helps prevent any other access from being added. The trickier cases are jacoco injects code that accesses the disk, and LayoutInflater may trigger loading classes, which triggers disk access. BUG=1059770 TEST=covered by tests now Change-Id: I50f81836f838b023fe09fd5f760cb7484edd8d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100589 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#751028}
-
