- 20 Mar, 2018 28 commits
-
-
Yuwei Huang authored
ChromotingSession is a complex class that receives calls from both UI and network thread, with some components being invalidated once the connection is disconnected, while other components are invalidated when the session instance is destroyed. This CL refactors the ChromotingSession class by moving session-bound and network thread logic into a core class. It also allows TelemetryLogWriter and ClientTelemetryLogger to be created on a thread different than the thread they are later used and destroyed, to make the refactoring a bit easier. Bug: 817566 Change-Id: I909113cb70fcb15bac2e8a506eb4f32d63f7ad47 Reviewed-on: https://chromium-review.googlesource.com/953597 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#544243}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/544b744621b7..0b89935ad6fe $ git log 544b74462..0b89935ad --date=short --no-merges --format='%ad %ae %s' 2018-03-19 ehmaldonado Revert "gclient: Add commands to edit dependencies and variables in DEPS" 2018-03-19 ehmaldonado gclient: Add commands to edit dependencies and variables in DEPS Created with: roll-dep src/third_party/depot_tools BUG=chromium:760633,chromium:760633 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic468d8ba95e139b32b63562ba07a866ec3b8343c Reviewed-on: https://chromium-review.googlesource.com/969659Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544242}
-
Bo Liu authored
I'm not sure why bots are still happy, but this failed to compile for me locally. I have no idea what the language spec says about referring to inner class of a subclass that's actually defined in itself. Much easier to do the sane thing. Change-Id: I9a197db3afdc7218c326dbb0baf58b57444300cb Reviewed-on: https://chromium-review.googlesource.com/964583Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#544241}
-
Andrey Lushnikov authored
FileWatcher cache is not needed when there are no DevTools windows opened. R=dgozman, pfeldman BUG=810155 Change-Id: Id6c4382f8b5ea6b926636ad2f8c71d7d01266273 Reviewed-on: https://chromium-review.googlesource.com/969823Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#544240}
-
Min Qin authored
No functional changes, just moving the files ResourceDownloader no longer has any dependencies on content/ now Bug: 803135 Change-Id: If1be16e03f4581ec4fb6eec4051c22b37d75797f Reviewed-on: https://chromium-review.googlesource.com/962966Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544239}
-
edchin authored
This CL extracts lengthly code (~50 lines) from TabGridViewController and encapsulates it into TabGridNewTabButton. Bug: 823079 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If038383deeaedc738849d49a3da31c0afd244e5b Reviewed-on: https://chromium-review.googlesource.com/966697 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544238}
-
Karan Bhatia authored
BUG=823484 TBR=nyquist@chromium.org Change-Id: I5f0aac3a43b938ebdc5e6eaae12c21688378e8ef Reviewed-on: https://chromium-review.googlesource.com/969793Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544237}
-
Matt Mueller authored
Silences PRESUBMIT warnings for these headers which intentionally do not have include guards. Change-Id: I699eb2ca9626dfd651d9dac9a18055a9059f5293 Reviewed-on: https://chromium-review.googlesource.com/969718Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#544236}
-
Ovidio Henriquez authored
This change refactors FakePeripheral to use the built-in DeviceUUIDs helper class in BluetoothDevice to handle the UUIDs for a device. BUG=719826 Change-Id: I9c60f00912aca706f16f402031483711f6f3ae89 Reviewed-on: https://chromium-review.googlesource.com/958337 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#544235}
-
https://chromium.googlesource.com/angle/angle.git/+log/e3dc5dd0cb16..daedf4d234eb $ git log e3dc5dd0c..daedf4d23 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 lucferron Vulkan: Add a DynamicDescriptorPool class. 2018-03-15 oetuaho Clean up switch/case pruning code Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I6d81ca14f5e8aa9ef98bf2379f04d4cb74c833de Reviewed-on: https://chromium-review.googlesource.com/969415 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544234}
-
Brian White authored
Bug: 789173 Change-Id: Ieb75ccc47cde63e3c9c7b4e7aed4a106f787a96a Reviewed-on: https://chromium-review.googlesource.com/960961 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Nicolas Zea (slow) <zea@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#544233}
-
Hwanseung Lee authored
pointer-events[1] are added to support in whitelist. there are some camelcase keywords in pointer-events. actually pre-defined keywords are interpreted ASCII case-insensitively[2]. so it was changed to accept camelcase keyword in tests. and test file are also added. [1]https://svgwg.org/svg2-draft/interact.html#PointerEventsProperty [2]https://drafts.csswg.org/css-values-4/#keywords Bug: 820299 Change-Id: Iccc0f88a69bbec68964ef55bcc5c471fea765ccf Reviewed-on: https://chromium-review.googlesource.com/968581Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Cr-Commit-Position: refs/heads/master@{#544232}
-
David Bertoni authored
Metrics indicate this flag is not being used. Bug: 357781 Change-Id: I138151e4726b2c8e3c9a6b59dccb8e37b123063b Reviewed-on: https://chromium-review.googlesource.com/946670 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544231}
-
Evan Stade authored
Bug: 776205 Change-Id: Ibdc3d5c8e7ada356afc68b2a111874bfc6af9684 Reviewed-on: https://chromium-review.googlesource.com/965605Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#544230}
-
PhistucK authored
Also fixed the Powershell command error when a Content-Type HTTP request header exists by using the -ContentType parameter rather than using it as a header. Tests - - Renamed the copy as cURL tests to a more generic name and added tests for the rest of the copy-as operations. - Fixed a get request with an empty body by putting null instead. Otherwise, fetch would complain about get-with-body and it does not seem to have been there intentionally. R=dgozman@chromium.org Bug: 573371 Change-Id: Ib1c90d8cb79658cbf02762cd61f8285dc7ecf2e7 Reviewed-on: https://chromium-review.googlesource.com/966628Reviewed-by:
Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544229}
-
Carlos IL authored
Callbacks in SupervisedUserService were defined as base::Callback, switched NavigationBlockedCallback and CreatePermissionRequestCallback to base::RepeatingCallback, SuccessCallback, AuthErrorCallback and SupervisedUserReportingService::ReportingCallback to base::OnceCallback, and updated callsites and definitions. Change-Id: I1e0e3bc2f3b5a0e74d8c57d14bff5133bb57de46 Reviewed-on: https://chromium-review.googlesource.com/963821Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#544228}
-
https://pdfium.googlesource.com/pdfium.git/+log/ef44194f4f4c..c49f39dff730 $ git log ef44194f4..c49f39dff --date=short --no-merges --format='%ad %ae %s' 2018-03-19 thestig Roll DEPS for Skia to af770026 2018-03-19 thestig Roll DEPS for catapult to 4f03e51f 2018-03-19 thestig Roll instrumented_libs to 323cf321 2018-03-19 thestig Roll v8 to 9cf8abb7 2018-03-19 hnakashima Add more options to combobox_form.pdf resource. Created with: roll-dep src/third_party/pdfium BUG=chromium:823378,chromium:820278 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I05e065de1fdb1abd67dc5554c35ab4f4bccb78fe Reviewed-on: https://chromium-review.googlesource.com/969414Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544227}
-
Dongseong Hwang authored
We now have support for NV12 overlays on all platforms where we have atomic KMS. That means that we can always pick NV12 as the format to decode to as it's the most efficient format for scanout and GPU compositing. Before we had NV12 overlays, decoding to RGB was a better choice since that let us use an overlay, which was an overall win. Delete unit test PictureBufferFormat, since that's an unhelpful change-detector test. Bug: 813250 Change-Id: Ib6cb1cd2275693d9da04cd428081282cc1031be1 Reviewed-on: https://chromium-review.googlesource.com/950007 Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#544226}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8d50e94a5bc9..5978d7dd749e $ git log 8d50e94a5..5978d7dd7 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 dgarrett builder_status_lib: Remove GetBuilderStatusFromCIDB. 2018-03-13 haddowk [chromite] Make moblab-vm important again Created with: roll-dep src/third_party/chromite BUG=chromium:821986,chromium:819695 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie1aad5cf3d65e808393afe189cd50940170a2762 Reviewed-on: https://chromium-review.googlesource.com/969603 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544225}
-
Jinsuk Kim authored
The reported crash indicates that WebContentsAccessibility.fromWebContents() is being called when mWebContents is null. This CL ensures the API won't be called if mWebContents is already nulled out. Also handled ImeAdapter case for similar, potential issue. Bug: 821692 Change-Id: I8c2dd3e443394e1f3d100b46596f830326de2f8f Reviewed-on: https://chromium-review.googlesource.com/965303Reviewed-by:
-
Ahmed Fakhry authored
BUG=b/72832726 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I727d4b23cfc35fba05d14e380f3807672687c581 Reviewed-on: https://chromium-review.googlesource.com/966973Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#544223}
-
Elly Fong-Jones authored
Since these tests depend on the Views omnibox heavily, and the Views omnibox is only used in a Views browser window, this change restricts them to that mode. Also, this change disables the ThemeIntegration test, which only works for *Aura* windows, not just Views. Bug: 817408 Change-Id: I5be68acd7f0788a3cbfe7684a725e53e1a5ee885 Reviewed-on: https://chromium-review.googlesource.com/969628Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#544222}
-
Tom Anderson authored
To enable thin archives on posix, the current plan is to: 1. Land this CL. 2. Remove thin_archive from third_party build files as appropriate. 3. Uncomment the arflags = [ "-T" ] that this CL adds. If you want a standalone static library, you now need to both set complete_static_lib=true and remove the thin_archive config. See the comment in build/config/compiler/BUILD.gn for details. BUG=801925 R=thakis,dpranke TBR=sky Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icd1d3389da13106f46de3468475f0102a88c6211 Reviewed-on: https://chromium-review.googlesource.com/954344Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544221}
-
Tim Zheng authored
TEST=Still compiles. Change-Id: I3781b7f4508112efbd038206a22ffb236065f6d5 Reviewed-on: https://chromium-review.googlesource.com/967267 Commit-Queue: Tim Zheng <timzheng@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#544220}
-
Fan Yang authored
If a QUIC stream is reset by peer and does not finish sending, it is closed instead of marked as zombie streams. Protected by ENABLED FLAGS_quic_reloadable_flag_quic_reset_stream_is_not_zombie. Change-Id: I3d1e3368c97d62cf1f2b3c5a82db0229ad6e710f Reviewed-on: https://chromium-review.googlesource.com/968662Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#544219}
-
David Tseng authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I35ca0e1f2f55ba549a0d2fa8ec62005d1d80d770 Reviewed-on: https://chromium-review.googlesource.com/965463 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#544218}
-
gogerald authored
Only allow one payment handler window is opened at any moment in a browser context. Bug: 753078 Change-Id: Ibba3694eab85be4a4f87d6d638286e0e1d969353 Reviewed-on: https://chromium-review.googlesource.com/963501 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544217}
-
Dominick Ng authored
This Android-specific metric was replaced by the cross-platform Webapp.Install.InstallEvent in M65. It was intended that these metrics exist alongside each other, but WebApk.Install.InstallSource was inadvertently removed from being recorded in https://crrev.com/c/802336, meaning that data is no longer collected as of M65. BUG=790788 Change-Id: I0fc4724cc19fd4103e192f1e5caf6a9347831250 Reviewed-on: https://chromium-review.googlesource.com/967906Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#544216}
-
- 19 Mar, 2018 12 commits
-
-
Theresa authored
BUG=823206 Change-Id: I90280a4048c90a0dbce9bafe590de4c6e13c14a8 Reviewed-on: https://chromium-review.googlesource.com/969287Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#544215}
-
Andrey Kosyakov authored
TBR=jam@chromium.org, pfeldman@chromium.org Bug: 721408,805310,778542 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Icdb98586e6e2ae53802c1e4d2f2fa3b66a6247fa Reviewed-on: https://chromium-review.googlesource.com/969329Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#544214}
-
dpapad authored
Bug: 822640 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I34936fa59d5f930250a12619674f4be1ee5c767c Reviewed-on: https://chromium-review.googlesource.com/966996Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#544213}
-
Findit authored
This reverts commit 3f71f33a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 544128 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzNmNzFmMzNhYTc0OGQwNDQyMTJkM2E2ZDIyNGM4Zjg2NDViYzRiODYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/26652 Sample Failed Step: mus_ash_unittests Original change's description: > cros: Views login backend for removing users. > > Bug: 809637 > Change-Id: I1eebc6708f52539848d2a38025c087051ced9985 > Reviewed-on: https://chromium-review.googlesource.com/935675 > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544128} Change-Id: Ic583e23c993c1dddbf1965088a2b685093c610ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 809637 Reviewed-on: https://chromium-review.googlesource.com/969228 Cr-Commit-Position: refs/heads/master@{#544212}
-
Misha Efimov authored
- Removes Cronet dependency on Breakpad. - Applies to developer environment and public bots. - Reduces Cronet binary size, especially on iOS. - Official buildbots will be updated separately. Bug: 811308 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I24fe9075a731a507ed8861e1f4811d4d463bb80d Reviewed-on: https://chromium-review.googlesource.com/964596 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#544211}
-
Bill Budge authored
- Set shared memory handle to invalid so we don't try to close it twice. Bug: chromium:763174 Change-Id: Ibdb27f6dd36b15e58d7fe144946b2695531b6ccd Reviewed-on: https://chromium-review.googlesource.com/969118Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#544210}
-
Brett Wilson authored
Avoid a crash caused by mutation of the list being iterated over from inside the foreach loop. This does a full copy of the the iterated list since the code inside can't mutate the array via the loop variable anyway. Although theoretically slower, this doesn't seem to have a measurable performance regression in practice (we generally iterate over few large lists). Adds documentation and tests for iteration while mutating the underlying list variable. Bug: 818525 Change-Id: I221fa230685b8998f5874154cad8d5c655b8006c Reviewed-on: https://chromium-review.googlesource.com/959228 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Roland McGrath <mcgrathr@chromium.org> Cr-Commit-Position: refs/heads/master@{#544209}
-
Tibor Goldschwendt authored
Bug: 823272 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I74cd47e699cd999ec4bd44a5e82fef71fd931d27 Reviewed-on: https://chromium-review.googlesource.com/969451Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#544208}
-
Robert Ogden authored
The actual webpage will no longer have CSS and JS resources, so remove them from this test's comments. Bug: 744967 Change-Id: Ic3d8e2a0a5b1c46d1a453ff1e1a9366b46a4e4bf Reviewed-on: https://chromium-review.googlesource.com/969719Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@google.com> Cr-Commit-Position: refs/heads/master@{#544207}
-
Tsuyoshi Horo authored
crrev.com/c/956654 introduced the bad flags warning of "stability and security will suffer" for Android. This change caused parformance regressions because a bad flag "--ignore-certificate-errors-spki-list" is used for perfomance testing. (crbug.com/822258#c13) So this cl introduces the check of "--enable-automation" flag in ShowBadFlagsPrompt(). This check already exists in startup_browser_creator_impl.cc for Desktop not to show the infobar during performance tests. crrev.com/c/catapult/+/965712 will add the flag in the script of catapult. Bug: 822258,803774 Change-Id: Icef23b907460f3a60284675f1dd2f55a73375b72 Reviewed-on: https://chromium-review.googlesource.com/965727Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#544206}
-
Danyao Wang authored
WKBasedNavigationManager::Restore() calls WebState::LoadCurrentURL() to load the restore_session.html into WKWebView. However, after a cold start, LoadCurrentURL() early exits because there is no _containerView, and the pending navigaiton to restore_session.html is only completed when the tab becomes active. While a tab is in this state, the WebState title is empty, causing "Untitled" to be displayed in the tab switcher, and any call to BuildSessionStorage() will incorrectly save an empty session. If the app is backgrounded, the previously restored session will be lost. This CL fixes the issue by temporarily caching the last restored session storage in WebStateImpl, so it can be returned in GetTitle() and BuildSessionStorage() in the intermediate state. The cached version is invalidated as soon as a new navigation item is committed. Bug: 822771 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I573c33f8d3282d4af0ef98c19fedb767c7ab987d Reviewed-on: https://chromium-review.googlesource.com/969638 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#544205}
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: ../../third_party/WebKit/Source/core/page/DragControllerTest.cpp:57:72: error: declaration of ‘blink::DragMockChromeClient& blink::DragControllerTest::ChromeClient() const’ [-fpermissive] DragMockChromeClient& ChromeClient() const { return *chrome_client_; } ^ In file included from ../../third_party/WebKit/Source/core/loader/EmptyClients.h:39:0, from ../../third_party/WebKit/Source/core/layout/LayoutTestHelper.h:17, from ../../third_party/WebKit/Source/core/page/DragControllerTest.cpp:14: ../../third_party/WebKit/Source/core/page/ChromeClient.h:94:19: error: changes meaning of ‘ChromeClient’ from ‘class blink::ChromeClient’ [-fpermissive] class CORE_EXPORT ChromeClient : public PlatformChromeClient { ^~~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having a |ChromeClient()| method can change the meaning of references to |ChromeClient| in the code depending on where it is declared, which contradicts the C++ standard. Fix it by taking advantage of covariant return types: instead of having a GetChromeClient() method that returns a |ChromeClient| and a ChromeClient() method that returns a |DragMockChromeClient|, make GetChromeClient() return a |DragMockChromeClient| and do away with ChromeClient() entirely. Change-Id: I97834bfe22acb0745e5307d13e377f596587e199 Reviewed-on: https://chromium-review.googlesource.com/968496 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544204}
-
