- 07 Oct, 2020 40 commits
-
-
Michael Hansen authored
Because WebRTC is geo-sharded, both peer devices must specify the same locale / "location hint" in order to signal each other via Tachyon. The location hint is in ISO 3166-1 alpha-2 format: https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2 Bug: 1134210 Change-Id: Ic42c7139bd2ac96de8d6ffebe5c15bb70be0c9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447096Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#814880}
-
Josiah K authored
Change-Id: Ie9fc4da6ed9b2b6c2bbcc56ae6de5a088a5760b3 AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454256 Commit-Queue: Josiah Krutz <josiahk@google.com> Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#814879}
-
Brian Malcolm authored
The manager for Dasher domains will be the domain name (foo.com), but for FlexOrgs the manager will be the email address of the FlexOrg administrator (admin@foo.com). BUG=chromium:1081272 Change-Id: I872a2c3bc6208656387f45de122b79e0d8a71e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453443 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#814878}
-
Ionel Popescu authored
This CL fixes the lint error by removing the redundant test entry. Bug: 1135842 Change-Id: Ide6d2d54ac79c7f0a6eeba3ae495dc4e5f3abcb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459046Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814877}
-
zhaoyangli authored
In test runner: Removed logic using xctest path existence to decide whether to run as xctest. In test configs: Added xctest test arg to all iOS tests in chromium. This will be required for all unit tests. Also add this to EG2 tests for consistency of argument meaning for iOS test runner scripts. Comparing test configs in json files, this change: - Added the flag to all tests ToTiOSDevice, ToTiOS, ios-simulator-cronet who didn't have this flag in any tests but were building with .xctest. - Added to all EG2 test targets on rest of iOS builders running tests. We have the option to build xctest arg into test runner wrapper in gn, but it's preferred to set at test configs for fine-grained control. Bug: 1085603, 1006881, 1085603，1001667 Change-Id: I46d7c1995ed9f9f5d96fe0280124767360f0aa21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413298Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#814876}
-
Mike Wittman authored
Move from a 10%/10% experiment to a 50%/50% experiment to provide the maximum signal for analysis of experiment results. The implementation in https://crrev.com/2453795 moves work to the render thread and this enables evaluation of the impact in the wild. Bug: 1004855 Change-Id: Id7c0c75bba2137aaccd78b7dd320fae0c7172004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458388Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#814875}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/70800603f250..81d10f5dd7f5 2020-10-07 sdefresne@chromium.org build: Remove no-op calls to set_sources_assignment_filter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1018739 Tbr: jophba@chromium.org Change-Id: I7b64bc11a356c52968738adc2942c4934e6b2841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458566Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814874}
-
Elly Fong-Jones authored
This class is no longer needed because of the new WidgetDelegate setters. This change: 1) Replaces LockScreenWidgetDelegate with a plain WidgetDelegate 2) Refactors LockScreen::Show() to pass the contents view directly into the Widget factory method, in aid of (1) Bug: 1075649 Change-Id: I5a89cbd822ad22aef62a76f6ea8afb70f6431d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458450 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#814873}
-
Kyle Williams authored
Move all 'cfm' directories and paths to 'chromebox_for_meetings' Rename directories to avoid unnecessary acrynomn and to better follow the general chrome name styling. https://google.github.io/styleguide/cppguide.html#General_Naming_Rules BUG=b:169582550 TEST='xvfb-run ./out/Default/unit_tests \ --single-process-tests --gtest_filter=Cfm* && xvfb-run \ ./out/Default/unit_tests --single-process-tests --gtest_filter=Cfm*' Change-Id: I7c78b7bc91c38506d14ab6445103736d3f226193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451502Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#814872}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bb7c9e117a17..a989f948c4e0 2020-10-07 jonross@chromium.org Remove frame_lengths from frame_time metrics 2020-10-07 fancl@chromium.org auto-traige: Replace empty project with chromium in GetIssueComments 2020-10-07 abennetts@google.com pinpoint: Signal a failure rather than No-Repro when no results. 2020-10-07 dberris@chromium.org [dashboard] Retry requests to Monorail 2020-10-07 bsheedy@chromium.org [Telemetry] Reorder Android debug data collection If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1111450,chromium:1131189,chromium:1132297,chromium:1135662 Tbr: zhanliang@google.com Change-Id: Idc97d8383f8bcc77383911d78544dd0ee00088e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458056Reviewed-by:
-
Robert Sesek authored
Data from the field is showing reduced crashes, so turn it off to see what the crash rate is without this causing an artificial increase. Bug: 1126350 Change-Id: I6d2e5722cca8a8d142f510e0a06d926fdc8f202f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457967 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814870}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/benchmark.git/+log/367119482ff4..ffe1342eb2fa $ git log 367119482..ffe1342eb --date=short --no-merges --format='%ad %ae %s' 2020-09-28 yihshyng223 Add CycleTimer implementation for M68K architecture (#1050) 2020-09-28 dominichamon Include github workflows status in README 2020-09-21 jbakam Add support for JSON dumps of benchmark diff reports. (#1042). Fixes #737. 2020-09-12 vitaly Fixed pkg-config on other than Ubuntu GNU/Linux distributions. (#1043) 2020-09-11 AntoinePrv Bind benchmark builder to Python (#1040) 2020-09-10 dominichamon Add workflow to exercise bindings (#1041) 2020-09-10 AntoinePrv Bind more State methods/attributes to Python (#1037) 2020-09-09 dominichamon Create pylint.yml (#1039) 2020-09-03 yesudeep Revert previous linker additions for FreeBSD as the problem is Bazel using /usr/bin/clang instead of /usr/bin/clang++ to link C++ code. (#1035) 2020-08-28 yesudeep Adds -lm linker flag for FreeBSD/OpenBSD and uses github.com/bazelbuil… (#1032) 2020-08-27 jeremycong Fix Clang builds on Windows (#1021) 2020-08-25 christian_wassermann Add CartesianProduct with associated test (#1029) 2020-08-21 dominichamon Ctest support (#1025) 2020-08-19 adam.f.badura Update build instructions to better use CMake (#1017) 2020-08-18 dominichamon Remove "BENCHMARK_" prefix from env var version of command line flags (#997) 2020-08-18 dominichamon Create build-and-test.yml (#1013) 2020-07-30 dominichamon Add missing breaks for QNX cache counting (#1012) 2020-07-28 alexander.enaldiev JSONReporter: don't report on scaling if we didn't get it (#1005) (#1008) 2020-07-09 cjfj Fix python extension import (#1000) 2020-07-09 cjfj Rename python bindings package to `google_benchmark`. (#999) 2020-06-30 skyewm Expose methods for custom main functions in Python. (#993) 2020-06-29 jottosmail Add requirements.txt for python dependencies (#994) 2020-06-25 jottosmail adds a "--no-color" flag to the compare.py script (#990) 2020-06-17 wrpaape timers: silence strncat truncation warning (#984) 2020-06-15 brian.wolfe timers: just make the buffers big enough 2020-06-15 brian.wolfe timers: use snprintf instead of sprintf 2020-06-15 brian.wolfe timers: silence format overflow warning 2020-06-15 wolfe.br use rfc3339-formatted timestamps in output [output format change] (#965) 2020-06-09 dominichamon Upgrade bazel from 0.10.1 to 3.2.0 (#976) 2020-06-08 cjfj Add some simple docs for installing the Python bindings from source. (#975) 2020-06-08 dma+github Add absl dependency as needed 2020-06-08 dma+github Ignore python bindings build artifacts 2020-06-05 dma+github move releasing doc to docs 2020-05-28 cjfj Expose `SkipWithError` in Python bindings. (#968) 2020-05-26 cclauss Drop unused mingw.py (#966) 2020-05-06 chris.jones Add Python bindings. (#957) 2020-04-23 kai.wolf Add missing <cerrno> header include - fixes Android build (#960) 2020-04-17 luismarques Fix formatting issues introduced by a77d5f7 (#959) 2020-04-14 kmoy Remove warnings for internal use of CSVReporter (#956) 2020-04-10 luis Fix cycleclock::Now for RISC-V and PPC (#955) 2020-04-06 dominichamon Fix type conversion warnings. (#951) 2020-03-30 koct9i Fix Travis-ci builds (#950) 2020-03-16 lebedev.ri Revert "Add d postfix to Debug libraries (#923)" 2020-02-25 dominichamon Update issue templates 2020-02-21 chfast Relax CHECK condition in benchmark_runner.cc (#938) 2020-02-18 NAThompson [docs] Use `benchmark::IterationCount` rather than `int64_t` in lambda to complexity (#940) 2020-02-07 bclayton Fix MSVC warning. (#935) 2020-01-31 alex_reinking Fix cxx03 standard selection, option override in CMake 3.13+. Fixes #933 (#934) 2020-01-30 dominic+github Disable pedantic warnings and errors until googletest/gmock is fixed 2020-01-14 jwillikers Alias CMake Targets. Fixes #921 (#926) 2020-01-05 szitar.gergo Add d postfix to Debug libraries (#923) 2019-12-15 tetsuok Fix typo in mutex.h (#917) Created with: roll-dep src/third_party/google_benchmark/src Bug: Change-Id: I396d793bc45042a40585123502520a08c86288b9 Tested: Built and ran crc32c_benchmarks in client with "checkout_google_benchmark": True. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453791 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814869}
-
Gavin Williams authored
Adding |isDriveMounted| to the init functions allows us to prevent the creation of the Save to Drive destination on Chrome OS when necessary. Bug: 1112416 Change-Id: I509c5354bf07134b6cce5a9298f9624059a3c37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441729Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#814868}
-
Jazz Xu authored
Bug: 1111982 Change-Id: I28eb5de0f0a87be0cbdd8922da65af58447f2167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453438Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814867}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6c1b2bf9beb..60669b2c831f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kmilka@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1004848,chromium:1080854,chromium:1135813 Tbr: kmilka@google.com,eirage@google.com Change-Id: I7b2e9c0d52dfa6336d28e3ecd41811c1dca73751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458052Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814866}
-
Ben Pastene authored
Some builders have a different set of GN args used within a single build. These phased builders didn't have very readable expectations. This should fix that. Bug: 1117577 Change-Id: I965081c221d3508bb6988d8a1b45f0f387384537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458207Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#814865}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602071853-210420531a6e235ee5a49a220c20aeed2a3958f4.profdata to chrome-mac-master-1602093472-1d23f3e20a4e345891a53ac8f50b5338bb0c8ae6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iaf8bbd81a9c01365a5df9a0bfe84b1580a23808b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458666Reviewed-by:
-
Peter Kotwicz authored
The benefit of converting the test to typ is that it makes adding other monochrome tests easier. BUG=1115604 Change-Id: Id36ae6cc9e60efa27d54a1f37f39f7004b9c3619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456189 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Ben Pastene authored
url_unittests was moved over earlier, but it gets deduped almost 80% of the time, so doesn't provide much signal. disk_usage_tast_test isn't marked idempotent, so will never be deduped. It also runs pretty quickly (~2 min), so shouldn't use up an excessive amount of test pool resources. Bug: 1132206 Change-Id: Ibcd6b199cf635280bb5b99e890c9080c3293ed6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458769Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#814862}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602071853-64ee697d793390a90d21674e5f7592c2927f5a99.profdata to chrome-linux-master-1602093472-3c443a4dbd74a5652b0b36774f0b190723e63d12.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I114f3cc62f4562ecac6fabddaa828289111f3b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458569Reviewed-by:
-
Zhongyi Shi authored
https://quiche.googlesource.com/quiche.git/+log/c0588b0ea3a6..60e12c40278b $ git log c0588b0ea..60e12c402 --date=short --no-merges --format='%ad %ae %s' 2020-10-07 bnc Also test http2::HuffmanEncodeFast() in spdy::HpackEncoderTest. 2020-10-06 dschinazi Switch ParsedQuicVersion::ReservedForNegotiation() to TLS Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I2a829b17889c679104f56ff74e9a61f45d969ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458386 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#814860}
-
Devlin Cronin authored
There's a collection of extension API methods that have been deprecated for some time. Restrict these to manifest version 2, so that they are unused in manifest version 3. Bug: 987838 Change-Id: I5ec33a29ceb1eade40e1b97f3692164b581715fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441022Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814859}
-
Scott Violet authored
I couldn't find any wpt tests for this, and it seems worth adding. BUG=1087667 TEST=wpt/css/css-overflow/overflow-clip-cant-scroll.html Change-Id: I4b539a15b3e6bcb0719a04c45a596a52277c3665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457368Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814858}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/79960a9c04c8..f09b0b11305f 2020-10-07 cpinnamaneni@microsoft.com Inline stylesheet location update for elements pane 2020-10-07 vidorteg@microsoft.com Removing check_localizability.js verification If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1133930 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic47f6467b03e6228ab6f41b1d2a10ad4d348cf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458226Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/635de036d766..5f4e70b81046 2020-10-07 capn@google.com Remove float division-by-zero prevention If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8327680758be0c59d8f3526877a43882b24864d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458086Reviewed-by:
-
Karandeep Bhatia authored
WARN_UNUSED_RESULT. The ExtensionApiTest::RunExtensionTest family of functions are used in extension API tests and they return the success or failure of the test. However, if the caller does not check the return value, the test is marked as successful, which can be confusing for developers. This CL annotates these functions with WARN_UNUSED_RESULT to ensure the return value is always consumed. BUG=1135464 Change-Id: Idb6cc6865a0602502a33dd78f55bcf2e28ffd9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454406 Commit-Queue: David Bertoni <dbertoni@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814855}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1e716fb..ae1f2502 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie6082622ddc7636888eaaa9400a42233847ccfaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456050Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814854}
-
Mike Wittman authored
Stability numbers for the trial re-enable on canary in https://crrev.com/814399 look good so restore the renderer process enable rate to the desired production value. Bug: 1135152, 1004855 Change-Id: I56ea0033a49c34d8975484af47f91511927a2df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458507 Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601890590-benchmark-87.0.4280.10-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib143ca88bd2d068bd06dc8d35fb5d1be82abe4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458827Reviewed-by:
-
Chris Sharp authored
Change-Id: Ia3beb34686f34f4e712fc682a88a843967070656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458406Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#814851}
-
Derek Basehore authored
This reverts commit 31fcacb3. Reason for revert: An edge cause for platforms without ARC++ was not handled correctly. Original change's description: > Change the location of chrome_renderers cgroup > > This changes the location of the chrome_renderers freezer cgroup to > match pending changes. > > /sys/fs/cgroup/freezer/early_freezer/chrome_renderers/to_be_frozen/tasks > file > > Bug: b/134792837 > Test: suspend_stress_test and check for PIDs in > Change-Id: Ibf76f4e2f6cbb527dd738194f3baea506447f8d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337546 > Commit-Queue: Derek Basehore <dbasehore@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811894} TBR=achuith@chromium.org,dbasehore@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/134792837 Change-Id: I6a35a64b577695ed6406aacaea2834b3d15afcb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451630Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Derek Basehore <dbasehore@chromium.org> Cr-Commit-Position: refs/heads/master@{#814850}
-
dpapad authored
This is necessary to ensure that the font name will be correctly parsed in CSS, even when it contains a number or punctuation mark. Fixed: 1128566 Change-Id: Ia4159483cac30a350eabaddaf5142fd58a9bd299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456633 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#814849}
-
Ahmed Mehfooz authored
The pin icon on the screenshot view requires a contrasting background to make it easier to see. Bug: 1134377 Change-Id: I61a8c55dc2f6a2370a55c5fbb0e82d89815ff017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454131Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814848}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8f254643. With Chromium commits locally applied on WPT: 710f745e "Handle transferred channels in ConvolverNode" d267d950 "Delete WebRTC-QUIC Blink Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I8c5e1209ae73bdf9c2aa08ccd5ff547b63805352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457549Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814847}
-
Yue Zhang authored
Bug: 1110059 Change-Id: Ib6e1e86dfa1a92a83e9aa7b02549cd18792ead9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399569Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#814846}
-
Peng Huang authored
I think the problem is because the context lost or there is no gl context. So GetOrCreateRenderPassOverlayBacking() cannot create a shared image. Fix the problem by calling MakeCurrent() and check the return value of GetOrCreateRenderPassOverlayBacking() Bug: 1133797 Change-Id: Ibbb92c0c77a63903e2740eee099951b95b930053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457468Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#814845}
-
Jazz Xu authored
This CL makes |media_controls_container_| only show when user is in main system menu. This prevents menu from expanding when in sub-menu. Bug: 1135717 Change-Id: I11d93b61ddc67a3183d18e70b5e64a9b731f61e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453923 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814844}
-
Xing Liu authored
Disable flaky test testPersonalizedSyncPromoInBookmarkPage. deterministic failure for NightModeEnabled parameter, flaky for NightModeDisabled parameter. TBR=twellington@chromium.org Bug: 1133426 Change-Id: I87040e061181eb709699e3544c2f88873907ae25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458168Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814843}
-
John Delaney authored
These flags are still in use, as the Conversion Measurement API is going to an origin trial, and are necessary for developers to test. Updates the expiry to M90, a milestone after the OT is slated to end so that developers can easily test the feature in canary for the duration. Change-Id: Ifcdd4aaf56bd88ea9a29111acf0657d895ebd712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456052Reviewed-by:
Alex Turner <alexmt@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814842}
-
Mohamed Heikal authored
eu-strip's output keeps mode from source file which might not be writable thus it fails to override its output on the next run. AtomicOutput fixes the issue. Also it is good practice anyways. Change-Id: I7b3574dac55cc44e6d0572704f26e42969331ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458786 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#814841}
-
