- 07 Sep, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599440287-c6b20cb063f56842ee44f7264cf204fda7b2b645.profdata to chrome-win32-master-1599450822-c8039978cfc4f91681250dd400e03a84f6c9a29d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie2229f329f5e0b886ffef1798a1512bc46cb68ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395063Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804699}
-
Tanmoy Mollik authored
This cl creates render tests for Personalized promos in RecentTabsPage. Bug: 1100895 Change-Id: I96cf6637fcd09ba6f4fcbdc33db45d27895f8959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362891 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804698}
-
Kent Tamura authored
to LayoutSliderTrack. Renaming files will follow. This CL has no behavior changes. Bug: 1040826 Change-Id: Id921157a65e70e81284ce50cbef843301d8693ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394980 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804697}
-
Sara Kato authored
Follow up to crrev/c/2341231. This change will stop a11y alert events that do not have a name (thus no new meaningful information) from being sent. With this change, empty "Alert" events will not be sent to a11y side. being sent. Test: manual, follow bug steps and ensure one announcement event is Bug: b:162993006 Change-Id: If6fcf75f6e9df24013a0569b57844447eaab912e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374924 Commit-Queue: Sara Kato <sarakato@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804696}
-
Kent Tamura authored
- Add missing dependencies - Make platform/{instrumentation,scheduler} visible to platform/blob/ - Allow circular includes of platform:platform from platform/blob/. platform/blob/ depends on platform/weborigin/*, which is a part of platform:platform, and it depends on platform/blob/. Circular includes between them is safe because they are in a single library. - Move platform/blob:test_support from 'deps' of platform:test_support to 'public_deps'. The 'test_support' library should expose all 'test_support' targets in the sub-directories. This CL has no behavior changes in production. Bug: 800764 Change-Id: I534c3de62813c49f85548dcf80de3aca5bc1c52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395317Reviewed-by:Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#804695}
-
Koji Ishii authored
This patch fixes a case where |EmphasisMarkHeight| may return zero. The same fix as r801476 crrev.com/c/2374918 but in a different function. Bug: 1124854 Change-Id: I987b91e4743a5856889d1e9ab5db6b020c1b373e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395007 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icdd82bfbbd5eb14d964a5245dcdb02bffe7af704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395067Reviewed-by:
-
Arnaud Mandy authored
These files need to be accessible when running wpt outside chromium environment. see: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#mojojs This is the first step towards making these tests pass outside the Chromium CI Bug: 1123993 Change-Id: I87eec58af6f1569d206c6f307365b1ba4690c359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391229 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#804692}
-
Maksim Sisov authored
According to the xdg_popup protocol, popups can be grabbed upon touch down, pointer press or keyboard down events. It's also fine to store a serial of a pointer press event, wait until pointer released event comes and grab a popup using the serial before the last event (basically, the one that came with pointer press). However, the same technique doesn't work with touch events and some compositors such as Mutter just dismiss the popup. Some versions of Weston also do the same. Previously, we just disabled grabs for gnome environment, but it's not that correct. There is a better way to handle that. Instead, store serials from both touch down and up events and make it possible to check what was the last event. If it was touch down, do not grab the popup. If the last event was up, avoid grabbing the popup as long as we can't use the serial from the event before touch up event came. Bug: 1123521 Change-Id: If9869271328372a80f55d81a469960f3965f7b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385280 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#804691}
-
Takashi Sakamoto authored
When PartitionAlloc everywhere is enabled, GetSizeFromPointer will be invoked by malloc_usable_size. The size that malloc_usable_size returns may be larger than the requested size because of alignment and minimum size constraints. The excess bytes can be overwritten by the application without ill effects. However if we use slot_size, partition cookie will be destroyed (when DCHECK_IS_ON()). Change-Id: Ief781e98bc7f637f75633e0c1c0f896a46d1bd76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386901 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#804690}
-
Yuki Shiino authored
Optimizes the following two parts. 1. Faster conversion to the current execution context. 2. Avoid instantiation of ExceptionState if possible. Bug: 839389, 1121730 Change-Id: Ia7c03a06def4e1d4a523ec5e699d6b5e7137a35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391425Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#804689}
-
Matt Falkenhagen authored
It does not look like this trait is needed. Change-Id: I17868f8ee29b405d43a100e87e6fa0cae65b3615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394876Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#804688}
-
Matt Falkenhagen authored
The linked bug was closed and the decision was to use BigBuffer, which the current implementation is doing. Bug: 867848 Change-Id: I7a4915df4836ae63ba0495c2d5a1aa462edd61f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392176Reviewed-by:
-
Fumitoshi Ukai authored
Bug: 1125449, 1121776, 1123704 Change-Id: Ie8c636cc69f3c038f6b4b1162b2b2ba813571122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394844Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com> Cr-Commit-Position: refs/heads/master@{#804686}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/517f39eee46f..dc1b9762731e 2020-09-07 johnkslang@users.noreply.github.com Merge pull request #2386 from amdrexu/bugfix 2020-09-07 johnkslang@users.noreply.github.com Merge pull request #2389 from amdrexu/bugfix2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I0925928376155b0ac2fa4dd463bf6d677486b511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395064Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ef9e56c6..3e2d6551 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9ab44c48eab3684d3e5583f8ec115257aedef56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394840Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804684}
-
Yoshisato Yanagisawa authored
Since Goma client simple chrome builders in goma staging uses the wrong test targets, builders tried to build something cannot be built. Let me adjust the build target by applying the same config with: chromeos-amd64-generic-rel-goma-canary Bug: 1124200 Change-Id: I11c9f0ffec2a93f8470c09fb03054546e30b3201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395080 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
-
jongdeok.kim authored
In this CL, all effect node that is affected by backdrop filter is marked. So that the layer can find the LCD text disallowed reason for the backdrop filter. Bug: 1115564 Change-Id: I6b03abb215603f3a79b7416a11509fd320421e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386442 Commit-Queue: jongdeok.kim <jongdeok.kim@navercorp.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804682}
-
Kent Tamura authored
cross_thread_copier.* depends on |third_party/blink/public/common/ messaging/message_port_channel.h|. This CL has no behavior changes in production. Bug: 800764 Change-Id: I87bec036f7f34f9aa356a9a67834da9c970b3aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394896Reviewed-by:
-
Antonio Gomes authored
... as per section 2.2.2 in [1]. [1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80 Also rename it to GetInstance(). Last, previous, the WebAudioOutputIPCFactory instance was held by RenderThreadImpl, and some test suite (eg content_browsertests and components_browsertests) do not instantiate RenderThreadImpl at all. Hence, the instance needed to be null-checked prior to being used. Now that WebAudioOutputIPCFactory is a lazy initialized singleton, this CL now null-checks WebAudioOutputIPCFactory::io_task_runner(), since it is the object that is null on the aforementioned test suites. This check does not affect production code. TBR=spang@chromium.org BUG=787252 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ie3e662c973e1d1e2287aa4bc9a9378379f88a792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391177 Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8584a9dfb946..a02d5dc9584e 2020-09-07 jleconte@google.com Add Monorail project when triaging with 'NEW BUG'. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: wenbinzhang@google.com Change-Id: Ief6f136db07cd05ba7f03539526e94e673e01abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395062Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a73a84f9b8e3..d0fe7d37d678 2020-09-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e63aa953ddfd to 10121443c16d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: I0b2371d3f6b5d21a416ef5a71a10d51a76db04eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395059Reviewed-by:
-
Jiewei Qian authored
SWA internal name is used for metrics and tast tests. This CL updates the comment to reflect this. Change-Id: I8f6fe694996c6a1ed186a8afb54578b2564981eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386903 Commit-Queue: Jiewei Qian <qjw@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#804677}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c8f4177cf443..9de988b61cfc 2020-09-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I89ae74f40e5799241ce36eca4ba37b4f9f0c90e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395116Reviewed-by:
-
Hirokazu Honda authored
Bug: 1029212 Test: None Change-Id: Ic50815a31cdcdc6cb2b7a8426554871f710b8a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392287Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#804675}
-
Maksim Sisov authored
In case of touch events, we may not find currently focused windows as menu windows might be created on touch up events. Thus, GetCurrentFocusedWindow returns nullptr. To fix that, use a concept of a currently active window. That is, Wayland sets a window to "active" state if it has had a focus. There can be only one focused window at a time. Thus, if there is no a focused window, use currently active window as a parent. That's the best effort one could make to find a parent window for a newly created non-toplevel window. At some point, it might be worth reconsidering the design and make aura always pass parent widgets for new windows if applicable. Bug: 1123521 Change-Id: Ib9479632e049df082ed17e3089680006a32f19fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385279 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/72f6b99c29f2..f184cb61cea6 2020-09-07 syoussefi@chromium.org Add perf test for multisampled render to texture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I8f5a2cdf9b959981e068ed06d8d7001c8b8c603b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395255Reviewed-by:
-
Kent Tamura authored
LayoutSliderContainer should be attached to SliderTrackElement because LayoutSliderContainer adjusts the position of SliderThumbElement, which is a child of SliderTrackElement. Now LayoutSliderContainer inherits from LayoutBlockFlow, not LayoutFlexibleBox. It doesn't need the flex behavior at all. SliderContainerElement still needs to attach LayoutFlexibleBox to center the SliderTrackElement vertically. * LayoutBox::SkipContainingBlockForPercentHeightCalculation() Skip UA shadow elements for percent-height calculation in the quirks mode. This change is necessary for the test fast/forms/range/range-thumb-height-percentage.html. INPUT height:20px; SliderContainerElement display:flex; height:auto; SliderTrackElement height:auto; SliderThumbElement height:50% Before this CL, the height of the SliderThumbElement was 10px. The initial layout of the SliderThumbElement made its height to 0 because the SliderContainerElement didn't determine its height yet. |layout_scope.SetChildNeedsLayout(track)| in |LayoutSliderContainer:: UpdateLayout()| triggered another layout of the SliderThumbElement, and it made its height to 10px because the SliderContainerElement had 20px height this time. After this CL, both of the SliderTrackElement and the SliderThumbElement are not laid out twice. We need to update SkipContainingBlockForPercentHeightCalculation() so that the SliderThumbElement can find the INPUT box for its percent height calculation. This CL should have no behavior changes. Bug: 1040826 Change-Id: I9175f5cd032b82f15b90165036dc770e5dc56ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390937Reviewed-by:Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#804672}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNodeEditor::Prepare()| to return null for letting |LayoutText::SetTextWithOffset()| to use slow path when text content contains generated break opportunity because it is hard to figure out how many characters removed from text content. On <b><i><s>ab\n</s>\n</i>\n</b>, text content is "ab\nZZZ", where "Z" represents U+200B, removing "\n" after "ab" makes text content to "ab". Bug: 1125262 Change-Id: I071822dd8be836ee947766ae1877873f35c3af99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395136 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Philipp Hancke authored
for spec compliance the field can/shall be null instead of an empty string for udp candidates. BUG=chromium:1125168 Change-Id: I201e6a700ba7c4bcba45f0af6ccf809971d1df0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390659Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#804670}
-
Jiewei Qian authored
Eliminate the unnecessary negation in if condition, because we can use operator bool to check the callback is provided. Change-Id: Ib21c24a4ecf37ca98191fbbe0f8bdf8d7dd52efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395001 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This CL passes the hints for DelayCompetingLowPriorityRequests from BlinkOptimizationGuideWebContentsObserver in the browser process to LocalFrame in a renderer process. Subsequent CLs will actually plumb the hints into the resource scheduler. Bug: 1112515 Change-Id: I567b44f13d8fcce157be5bdab7271021997b04d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389380 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599436335-07b3baabca6d9e1cf8136b51219c861829ab3330.profdata to chrome-win32-master-1599440287-c6b20cb063f56842ee44f7264cf204fda7b2b645.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I327f68641bc1bc2fb0ca0fa0fa0987411458034a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395115Reviewed-by:
-
Minoru Chikamune authored
Still not sure the root cause, but WebSettingsTest#testAccessCacheMode is failing on Android L and M. And this failure is caused by HeapMojoReceiver for ImageDownloaderImpl.receiver_. This CL specifies HeapMojoWrapperMode::kForceWithoutContextObserver not to close connection when the associated ExecutionContext is detached. Bug: 1102041, 1049056 Change-Id: I4a88ec57f2b04671a2d7ffad953600713442f648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395195Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This is a reland of e97a414a The original change was reverted because of causing crbug.com/1124751. The fix is two lines, see https://chromium-review.googlesource.com/c/chromium/src/+/2391192/1..4. Original change's description: > media/gpu/vaapi: Introduce ScopedVABuffer and use for encoding and Vpp > > VaapiWrapper owns VABufferIDs of the VA buffers that are used > outside of VaapiWrapper. This CL moves the ownership out of > VaapiWrapper. The VA Buffers are owned by ScopedVABuffer in order > to prevent the buffer leakage. > Ths ScopedVABuffer will be used for other VABufferIDs later. > > Bug: b:166646505, b:162962069 > Test: video_encode_accelerator_tests on atlas > Test: media_unittests --gtest_filter=VaapiVideoEncodeAcceleratorTest > Test: vaapi_unittest --gtest_filter=VaapiUtilsTest > Change-Id: I7b0dda7491d29ebba70bc42051a8657144209dda > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379423 > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804103} Bug: b:166646505 Bug: b:162962069 Change-Id: I3bf5a10ac025460190ff5f627b88b95c649c6130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391192 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#804665}
-
Yuichiro Hanada authored
Bug: b:148193316 Test: tast run arc.PreImeKeyEvent Change-Id: I8ba1437e5a94f3a251d9a7e658df2d995ddd3dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391184Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#804664}
-
Kuo-Hsin Yang authored
This is the first step to rewrite MemoryKillsMonitor. The histograms Arc.OOMKills.{Score,TimeDelta} are not as useful as Arc.OOMKills.Count. Bug: 1124182 Change-Id: I78aa4510939a79cce2917b326d62409c61113001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390935Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#804663}
-
Fumitoshi Ukai authored
Bug: 1121776, 1123704 Change-Id: I15df4eca2d27a3a36f9d980b851b1fec76c3cdb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394839Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@google.com> Cr-Commit-Position: refs/heads/master@{#804662}
-
Kenichi Ishibashi authored
The test will be moved out of content/. Replace BrowserTaskEnvironment with TaskEnvironment. Bug: 1016064 Change-Id: I018eeacf44a3d10462ee12c5c688d804115097f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394898Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804661}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e63aa953ddfd..10121443c16d 2020-09-07 capn@google.com Regres: Roll dEQP to latest tip-of-tree If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib5839eee1e756bbedb9b1350df9162a087c9d46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395055Reviewed-by:
-
