GitLab

Revert of [Android] Set enable_remoting=true by default (patchset #1 id:1 of https://codereview.chromium.org/1619913002/ )

Reason for revert:
This CL broke some of the internal builders which are building "all".

remoting_cardboard_extract_native_lib should be behind an target_arch=="arm" if statement

Original issue's description:
> [Android] Set enable_remoting=true by default
>
> We set enable_remoting=true in the command line on the official builders. Set
> enable_remoting=true as the default on Chromium as well.
>
> BUG=544298
>
> Committed: https://crrev.com/9fdef29316fae0cf8ba6c7258b434432d40eb175
> Cr-Commit-Position: refs/heads/master@{#371604}

TBR=lambroslambrou@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=544298

Review URL: https://codereview.chromium.org/1634353003

Cr-Commit-Position: refs/heads/master@{#371685}

Restructure contents of blimp/client folder. See crbug.com/581506
for more information on the eventual directory structure.
Modify paths and ifdef guards as needed.
Resolve various linter errors encountered along the way.
Add TODOs for missing documentation.

R=dtrainor@chromium.org,haibinlu@chromium.org
BUG=581506

Review URL: https://codereview.chromium.org/1636163002

Cr-Commit-Position: refs/heads/master@{#371684}

Review URL: https://codereview.chromium.org/1634383002

Cr-Commit-Position: refs/heads/master@{#371683}

Adds RotationTransformComponent and SkewTransformComponent.

Changes the name of RotateType to RotationType in
TransformComponentType enum to match class names.

BUG=545318
Spec: https://drafts.css-houdini.org/css-typed-om/#transformcomponent

Review URL: https://codereview.chromium.org/1589733004

Cr-Commit-Position: refs/heads/master@{#371682}

Now that tools/telemetry is moved to catapult/ repo
(https://github.com/catapult-project/catapult/commit/40afc53353daf28b955397c8e27d6f1de7bb10b6), we will soon remove tools/telemetry/.

This patch update the reference to telemetry/ in .gn, .gyp & .isolate files

BUG=478864
TEST=patch set 1 delete telemetry/telemetry.gyp, telemetry/BUILD.gn & telemetry/telemetry.isolate, CQ shows that all bots are green.

Review URL: https://codereview.chromium.org/1638483002

Cr-Commit-Position: refs/heads/master@{#371681}

If a variable is named kFoo it should be a compile-time constant, and
vice versa. Make these match by making variables actually be const, or
by changing the name if they are not compile-time constant.

R=pdr
BUG=580743

Review URL: https://codereview.chromium.org/1636873005

Cr-Commit-Position: refs/heads/master@{#371680}

Revert of [Android] Switch chromium bots on chromium.android to gn. (patchset #1 id:1 of https://codereview.chromium.org/1636003003/ )

Reason for revert:
broken w/

ninja: Entering directory `/b/build/slave/android_build/build/src/out/Debug'
ninja: error: unknown target 'android_builder_tests'

or

In file included from ../../content/gpu/in_process_gpu_thread.cc:10:0:
../../content/gpu/gpu_child_thread.h:24:50: fatal error: content/common/process_control.mojom.h: No such file or directory
 #include "content/common/process_control.mojom.h"

Original issue's description:
> [Android] Switch chromium bots on chromium.android to gn.
>
> This still does not include cronet or webview.
>
> BUG=580129
>
> Committed: https://crrev.com/1f63a1d9804b3c25dd896b52b3b3baf3700293fe
> Cr-Commit-Position: refs/heads/master@{#371641}

TBR=dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580129

Review URL: https://codereview.chromium.org/1632343003

Cr-Commit-Position: refs/heads/master@{#371679}

I cleaned up all the references in our various waterfalls, and this will
remove the test completely.

BUG=578272

Review URL: https://codereview.chromium.org/1640483002

Cr-Commit-Position: refs/heads/master@{#371678}

NOTRY=true

Review URL: https://codereview.chromium.org/1577153002

Cr-Commit-Position: refs/heads/master@{#371677}

This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is
now only one Screen instance. It's still a runtime-installed thing for
test purposes.

TBR=various owners for trivial changes
R=oshima@chromium.org, sky@chromium.org
BUG=558054

Review URL: https://codereview.chromium.org/1608733002

Cr-Commit-Position: refs/heads/master@{#371676}

The stated goal of this was to make dragging the window easier (viz., by
increasing the size of drag area atop the window by 1 px).  However, this
changed the area size from 12 px. high to 13 px., which seems like a rather
trivial "improvement" to make, and we've gotten by without such a change in the
glass frame (which uses 12 px.) for years.  Furthermore, the top resize border
was changed from 4 px. to 3 px., which seems honestly pretty small, especially
when the glass frame will end up using Windows' default 8 px. or whatever.  So
remove this code to make the two frames match up better.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1632123004

Cr-Commit-Position: refs/heads/master@{#371675}

In SQLite 3.10.2, the Unix VFS no longer defines unixCurrentTime(),
instead relying on unixCurrentTimeInt64(), which caused a crash in the
implementation of chromiumCurrentTime().  Add assertions to verify
required infrastructure at instantiation rather than first use.

BUG=580948,579743
R=michaeln@chromium.org

Review URL: https://codereview.chromium.org/1639863003

Cr-Commit-Position: refs/heads/master@{#371674}

This CL removes a .css file that is no longer needed.  This
brings us closer to unifying the MD settings and helps migrate
away from the deprecated css import.

The .settings-box:first-of-type has been replaced by .first
or .vertical-list.  The .vertical-list is used with is="dom-repeat"
and .first is used where the the first element of the list
is explicit (rather than generated at run time).

BUG=537048

Review URL: https://codereview.chromium.org/1628633002

Cr-Commit-Position: refs/heads/master@{#371673}

Add a new source type MENU_SOURCE_LONG_PRESS to identify context menu's being opened via the long press gesture.

For context, please refer to this patch https://codereview.chromium.org/1602903003/, where we display the context menu
on Windows when the long press gesture is released. This patch used the MENU_SOURCE_TOUCH source type in the context menu
params to determine whether a menu is being opened via the long press gesture. Turns out that the MENU_SOURCE_TOUCH is
used in places like devtools to open the context menu, which does not work due to the above patch.

Fix is to add a new menu source type MENU_SOURCE_LONG_PRESS We use this in RenderWidgetHostViewAura to identify context
menus opening via the long press gesture. Added another menu source type MENU_SOURCE_LONG_TAP which indicates menus
opening via the long tap gesture.

This should fix this regression.

BUG=581005
TEST=RenderWidgetHostViewAuraWithViewHarnessTest.ContextMenuTest. Updated this test to test for the MENU_SOURCE_LONG_PRESS gesture
type.

Review URL: https://codereview.chromium.org/1637743002

Cr-Commit-Position: refs/heads/master@{#371672}

This update contains 1126(!) new sites, which is about 225/day since the last update. I've double-checked, and there seems to be nothing awry with the process. We're just getting that many submissions now.

BUG=
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/1633313002

Cr-Commit-Position: refs/heads/master@{#371671}

  In order to roll GN 6a9b6b43..16920f1d (r370714:r371631) and pick up
  the following changes:

  81aa4e8f Add an assert_no_deps variable to GN.
  bf5ff790 Support for excluding variable from forwarding via forward_variables_form.

TBR=dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel

Review URL: https://codereview.chromium.org/1639983002

Cr-Commit-Position: refs/heads/master@{#371670}

- only keep two colors per category, one for "self" and one for "children";
- name them appropriately;
- drop gradients in legend swatches;
- replace explicitly colored borders with semi-transparent grey;
- fix legend for self time in pie chart summary.

BUG=580487

Review URL: https://codereview.chromium.org/1636853002

Cr-Commit-Position: refs/heads/master@{#371669}

This CL is the first step to implement GATT service in Chrome for Windows by using cross platform testing fixture.

BUG=579202

Review URL: https://codereview.chromium.org/1632123003

Cr-Commit-Position: refs/heads/master@{#371668}

No references are actually needed in the blink layer.

BUG=564965

Review URL: https://codereview.chromium.org/1634073003

Cr-Commit-Position: refs/heads/master@{#371667}

BUG=577985

Review URL: https://codereview.chromium.org/1637113002

Cr-Commit-Position: refs/heads/master@{#371666}

We text-align:left; our <li> elements so this shows up on live-sites that attempt
a text indent on their the list element's content.

BUG=568851

Review URL: https://codereview.chromium.org/1635203002

Cr-Commit-Position: refs/heads/master@{#371665}

TBR=cmumford@chromium.org
BUG=459835

Review URL: https://codereview.chromium.org/1636203002

Cr-Commit-Position: refs/heads/master@{#371664}

This is flakily crashing because it doesn't shut down
synchronously between tests, or so it seems.

Doesn't matter though because it's no longer necessary
for Mojo unless doing actual IPC.

R=lhchavez@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1639023003

Cr-Commit-Position: refs/heads/master@{#371663}

This change makes the registration of in-process media service consistent with that of out-of-process service.

BUG=571155

Review URL: https://codereview.chromium.org/1544853003

Cr-Commit-Position: refs/heads/master@{#371662}

We were missing the case where the first object in a multicol container was a
spanner (the call to previousSiblingMultiColumnSet() should have been
previousSiblingMultiColumnBox(), to catch spanner placeholders in addition to
column sets).

But instead of having a special code path depending on whether we're dealing
with the first box or not (to avoid subtracting the multicol container's top
border and padding from an uncalculated logical top of a column set), always
subtract the margin top edge of the first column box instead.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1631633002

Cr-Commit-Position: refs/heads/master@{#371661}

BUG=None
TBR=thakis@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1634333002

Cr-Commit-Position: refs/heads/master@{#371660}

Device scale factor impacts the draw properties (in particular, the
transforms of the TransformNodes in the property tree). So, mark that
draw properties need to be updated when device scale factor changes.

BUG=567832
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1633043004

Cr-Commit-Position: refs/heads/master@{#371659}

After forcing tests to fail after a 10 seconds timeout, turns out the
spy promise tests are the culprit.
I have removed them from our tests as they are originally intended to
test XHR's and we now have a better API for that.

BUG=504204

Review URL: https://codereview.chromium.org/1633273002

Cr-Commit-Position: refs/heads/master@{#371658}

BUG=577403

Review URL: https://codereview.chromium.org/1626663002

Cr-Commit-Position: refs/heads/master@{#371657}

Compositor-workers currently do not support idle tasks (and so does not
have idle-task-runner). So idle-tasks should not be turned on for the
compositor workers' isolate. To fix this, move the code that turns on
idle tasks for the isolate into WorkerThread::initializeIsolate(), so
that compositor worker can choose to not do this for now.

BUG=565789, 430155

Review URL: https://codereview.chromium.org/1612093003

Cr-Commit-Position: refs/heads/master@{#371656}

We capture sk picture from PictureLayer, which happens before we had
a chance to set the image decode controller during commit. The fix here
is not to use PlaybackToCanvas, but rather use other functions to
accomplish the same goal. PlaybackToCanvas should only be called after
commit.

R=enne
BUG=581107
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1633203003

Cr-Commit-Position: refs/heads/master@{#371655}

Calling Layer::set_property_tree_sequence_number() does not set the
flag that a commit is needed, which means it can quickly get out of
date for layers that are not updated for other reasons when the Layer
is (de)serialized.

This CL makes the LayerTreeHost forcefully set the sequence number
to the same value as the current PropertyTrees.sequence_number, since
all valid in the hierarchy is valid at that point.

BUG=577352, 538710
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1584653004

Cr-Commit-Position: refs/heads/master@{#371654}

BUG=536669

Review URL: https://codereview.chromium.org/1632333002

Cr-Commit-Position: refs/heads/master@{#371653}

BUG=574938
TEST=PaintLayerPainterTest.PaintPhaseOutline
TEST=fast/multicol/span/outline.html

Review URL: https://codereview.chromium.org/1584493002

Cr-Commit-Position: refs/heads/master@{#371652}

BUG=523278

Review URL: https://codereview.chromium.org/1609133002

Cr-Commit-Position: refs/heads/master@{#371651}

The tool is run in parallel many times, so they may clobber each
other writing to the rewrite-sym.txt file. So add a rewrite-sym.lock
file that each instance grabs when writing.

Also attempts a windows implementation which is untested.

R=dcheng
BUG=578344

Review URL: https://codereview.chromium.org/1616223002

Cr-Commit-Position: refs/heads/master@{#371650}

original cl:
https://codereview.chromium.org/1633713002/
revert:
https://codereview.chromium.org/1639603002/
reason:
broken paths

BUG=514857

Review URL: https://codereview.chromium.org/1632973002

Cr-Commit-Position: refs/heads/master@{#371649}

The CVDisplayLink is tied to a ScopedTypeRef data member of DisplayLinkMac.
However, there may be other references. Since there's no guarantee that
~DisplayLinkMac() will invoke the last CVDisplayLinkRelease(..) and clear
the callback automatically, clear it explicitly in ~DisplayLinkMac.

BUG=564780

Review URL: https://codereview.chromium.org/1626163002

Cr-Commit-Position: refs/heads/master@{#371648}

A recent commit broke the ability for the Google Cast and Media Router
extensions to start tab capture for mirroring.  The root cause was due
to the new behavior where the presence of deprecated constraints now
causes the getUserMedia() API to error-out (instead of silently ignoring
the constraints).

The short-term fix here is to simply filter out all goog* constraints
since they have no effect on tab capture.

BUG=579729
TBR=hta@chromium.org

Review URL: https://codereview.chromium.org/1631243003

Cr-Commit-Position: refs/heads/master@{#371647}

BUG=581519
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/1634973003

Cr-Commit-Position: refs/heads/master@{#371646}