GitLab

This should make the code structure more clear.

Bug: 1096235
Change-Id: Ie84293a0ffad11eb79301c638299e23aaa2522f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250704Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780410}

If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.

This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.

Bug: 1031540
Change-Id: I63140c7aa4915f7c24085ec7a97b2e7320e87bf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254778
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780409}

Switches the NaCL Python tests to use the version of mock/pymock
provided by vpython instead of manually importing the version from
//third_party/pymock. This is so that the //third_party version can
eventually be removed.

Also drive-by fixes some unidiomatic-typecheck PyLint warnings that
presubmit complained about.

Bug: 1094489
Change-Id: I886a9eaa9130c8babbefc40281c0de7f984026c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254583
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Sam Clegg <sbc@chromium.org>
Reviewed-by: Sam Clegg <sbc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780408}

Move FullscreenManager and FullsreenOptions to
//chrome/browser/fullscreen.

Bug: 995914
Change-Id: I013852910ce3ff34aa532582e61dd9e2fe167802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252025
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780407}

The presubmit input API provides local path names in the OS's native
format. The mojom compatibility checking script effectively assumes
POSIX format. This leads to various wonderful forms of failure whenever
paths are used to represent module identity in scripts.

In this case, mismatches between changed input file paths and mojom
import paths can result in the stability checking tool using the newer
(i.e. post-change) version of an input file when processing the older
(pre-change) contents of other files. This can obviously lead to very
surprising behavior like missing type information.

In the limit we should be using pathlib to manipulate paths consistently
across platforms. For now, this change settles on rewriting the tool's
input paths to be in POSIX form consistently.

Fixed: 1096841
Change-Id: I4beff9a49d573df3815160e2320097886d94d692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254709
Auto-Submit: Ken Rockot <rockot@google.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#780406}

This CL just cleans up includes, and doesn't actually change any
behavior.

Change-Id: I9e5f5b0f16f940be0c013214a7f649beb74890e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250551
Commit-Queue: Scott Little <sclittle@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780405}

This reverts commit 2621701f.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 780382 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI2MjE3MDFmMTc0YTFmMWVmMWMyOGE0N2QzZDY3OWE3YjMzZDA0NzMM

Sample Failed Build: https://ci.chromium.org/b/8877036858738311632

Sample Failed Step: compile

Original change's description:
> Reland "Adds icon loading service with sandbox for Windows."
> 
> This is a reland of c3de1340
> 
> Original change's description:
> > Adds icon loading service with sandbox for Windows.
> >
> > Adds a new |SandboxType::kIconReader| with token and integrity
> > levels that allow PrivateExtractIcon to do its thing. The service is
> > only used for PE files which, as a complex format, should not
> > be parsed in the browser. Other icons are found based only on a
> > file's extension. These are handled in the browser as this is both
> > faster and allows a tighter sandbox to be applied to the PE file
> > parsing. PrivateExtractIcon (a documented but discouraged Windows API)
> > is used instead of SHGetFileInfo as SHGetFileInfo requires COM
> > which considerably weakens sandboxing.
> >
> > Adds basic icon loading test for all platforms.
> >
> > A follow-on CL will add a fallback for PE files for which no embedded
> > icon is available.
> >
> > Testing: adds a unit test for groups, plus
> > manual testing on Windows 7 x86 and Windows 10 x64.
> >
> > Bug: 1032250
> > Change-Id: I6975e5612d8b6f35e3216a67fc98592a45895c1b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987273
> > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > Reviewed-by: Robert Liao <robliao@chromium.org>
> > Reviewed-by: Will Harris <wfh@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#779502}
> 
> TBR=robliao@chromium.org
> 
> Bug: 1032250
> Change-Id: I7b5bd3c66ff7c6935939c1f21ef9c45384183522
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252842
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Commit-Queue: Alex Gough <ajgo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#780382}


Change-Id: I367d0f5483f93f8ccb78f1e5d79a54dabfb6373a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1032250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254899
Cr-Commit-Position: refs/heads/master@{#780404}

This change is necessary when the message will be targeted at the
WidgetBase in a later CL. This just moves plumbing in an idempotent
CL for review.

BUG=1073560

Change-Id: If33da71b313886d2f3a224977a5c8bc25ba0ef2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245882
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780403}

Change-Id: Idd3f607b111b364f59f71a5e350240ced7c1486e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252040Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780402}

Only the content box should be multiplied by the aspect ratio to derive
the size of a side given the other side and the aspect ratio.

So, subtract the border/padding from the side you have, then multiply to
get the content size, then add that side's border/padding.

Bug: 1094311
Change-Id: Ib69a224cdb369c3fa46f5d432af73eb131781673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251202Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780401}

This CL is one more step towards unification of classes used on Linux
with X11.

The lower level of the drag and drop on X11 is handling the XDND
protocol, which is done by ui::XDragDropClient; the latter is currently
used for both non-Ozone and Ozone paths, but historically it had been
part of DesktopDragDropClientAuraX11, so there were no tests for it.

Here DesktopDragDropClientAuraX11 tests that in fact test the XDND level
are moved out and test ui::XDragDropClient directly.  The higher level
ones (like, for example, DesktopDragDropClientAuraX11Test.HighDPI200
that tests that the drag widget is moved properly on different scales)
are subject to move to DesktopDragDropClientOzone tests.

Note: a better place for these tests would be perhaps x11_unittests but
they cannot be moved there easily.  We keep that in mind and will try to
address that later.

Bug: 990756
Change-Id: If1905b2abace0db72a6aa8e4d0f0834bdafded81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250104
Commit-Queue: Alexander Dunaev <adunaev@igalia.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780400}

Roll Chrome Mac PGO profile from chrome-mac-master-1592568001-2ce2e0984e1a1c64d6f424e415ec04a2dca940b3.profdata to chrome-mac-master-1592589290-7b40bba5d54824ecb168b95970b0e07434b386d4.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ifede94f958d8fc94ea331603cc4047735c16ede6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254729Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780399}

The origin is used for storage isolation. Now the CDM service should
call a sync mojo API to get the origin from browser process.

Merge-With: eureka-internal/413835
Bug: internal b/159179276
Test: EME on x86
Change-Id: I0dc1292a207b7e05d204436e0f4d45a95857bb34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252636Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780398}

* When users click the "Run safety check" button, safety check has a 1s
  delay before it runs the actual safety check. This is done to ensure
  that the "running" state of safety check children is shown to users
  for at least 1s.
* If users reload the Settings page in that 1s delay the browser
  crashes with crbug.com/1096965.
* This fix makes safety check ensure that JS is still allowed after the
  delay, before it runs the actual checks.

Bug: 1096965
Change-Id: I8ab45e4e561ba051a87019d41af3ac7a6c00162e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254138Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780397}

Change-Id: Ic1e63c2c35d1e5e2add29cccb2e62606317903cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252936Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780396}

User actions are added to breadcrumbs that get attached to crashlogs to
help with steps to repro.

Bug: 1046223
Change-Id: Icf451a5d9bb72557d18555694227dd4e4d0b23b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250705
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780395}

If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.

This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.

Bug: 1031540
Change-Id: Ifdb52bdd094e9775d5ea91b9014152b950ccd08c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254147
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780394}

This reverts commit 75355920.

Reason for revert: The tests themselves are good. The culprit
breaking the test framework has been reverted in
a5c17494

Original change's description:
> Disabled external/wpt/editing/run flaky tests
> 
> TBR=xiaochengh@chromium.org
> 
> Bug: 1097000
> Change-Id: I94edbeb778bf35ea18a18412262ef57e4dfbabdf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252145
> Reviewed-by: Andy Paicu <andypaicu@chromium.org>
> Commit-Queue: Andy Paicu <andypaicu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#780261}

TBR=xiaochengh@chromium.org,andypaicu@chromium.org

Change-Id: I80b2b64d5379ce8973e5ce26f8a030c2d496355b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1097000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254717Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780393}

Adds feature flag WebUIThemeModeDoodles, which enables showing Doodles
on themed and dark mode NTPs. Furthermore, this CLs implements the dark
mode change protocol for interactive doodles. The protocol looks as
follows:

1. Append theme_messages=0 to the doodle URL. This tells the doodle that
   the mode change messaging protocol with version 0 is enabled.

2. Every time the mode changes postMessage
   {
     cmd: 'changeMode',
     dark: true|false,
   }
   to the doodle.

3. If the doodle postMessages
   {
     cmd: 'sendMode',
   }
   respond with the postMessage from 2. above. This is to work around
   a race condition where the NTP could postMessage the mode before the
   doodle has installed a message listener.

Bug: 688960
Change-Id: Icc1e333f33fd1f01a2c8d1d4a581fdf360ca7090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253220
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780392}

This CL adds animations to grouped tabs and entire groups being dragged.
It reuses most of the already implemented methods of animating tabs
because tab groups are shrunken to the width of one TabElement when
being dragged.

The CL also removes a previous |.remove()| call when placing a
TabGroupElement as the removal and inserting of the TabGroupElement
while animating caused some performance issues.

Bug: 1082344
Change-Id: I04c757b4d2d7f919a3021491e559e020f7e1010d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252036
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780391}

Bug: 1088488
Change-Id: I9650de41fbc60457ffc7318baf03aa127a52dc5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253203Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780390}

Move browser controls related interfaces and helper classes to
//chrome/browser/browser_controls.

BUG=995914

Change-Id: I75ff0fc582e403a98f1a2e894b32e295015f444f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250714
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780389}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a2948f22..1909f444

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib97e9419b435e3954cdd5ea9ca46dfd93084af4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254159Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780388}

This reverts commit b9031921.

Reason for revert: Suspected to cause browser_tests failures on mac:
https://bugs.chromium.org/p/chromium/issues/detail?id=1097000

Original change's description:
> [Blink Heap]: Marking uses jobs API.
>
> Manual reland:
> Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2029609
> Revert: https://chromium-review.googlesource.com/c/chromium/src/+/2109970
> Reset for revert: flaky DCHECK in AssertExpectedConcurrency
> Fix: Avoid calling AssertExpectedConcurrency from ShouldYield.
> https://chromium-review.googlesource.com/c/chromium/src/+/2112235
>
> Original Description:
> Note: This CL enables feature BlinkHeapConcurrentMarking to get
> the desired behavior. However, we should land enabling
> BlinkHeapConcurrentMarking on its own first.
>
> active_markers + GlobalPoolSize() is used to determine
> the desired number of workers.
>
> NotifyConcurrencyIncrease() is called periodically from
> ConcurrentMarkingStep() if GlobalPoolSize() > 0,
> to make sure enough workers are scheduled.
>
> Bug: 1046343
> Change-Id: I4c36044686128b23fc25f45b99334c219a08cffa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214908
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Omer Katz <omerkatz@chromium.org>
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#779969}

TBR=mlippautz@chromium.org,etiennep@chromium.org,omerkatz@chromium.org

Change-Id: I4384cf531428b09d02f97f41368069dd9d056e9f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046343, 1097000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254470Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780387}

This is a reland of 9b955d94

Original change's description:
> [StartSurface] Switch to normal tab model on resume to V2 start surface
> 
> This CL also solves the scroll issue of the incognito description.
> 
> Screen records:
> Resume:
> https://drive.google.com/file/d/1jPFCAEwTDzI4PO-Ef-HdvRV6KeZoW4fD/view?usp=sharing
> 
> Scroll:
> https://drive.google.com/file/d/1C2lFMBKmdTaipWcHBG9mAYCJNuhoiYK_/view?usp=sharing
> 
> Bug: 1093506
> Change-Id: I5d7365daa530b23f897a19665076cbc32238224f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243334
> Commit-Queue: Ganggui Tang <gogerald@chromium.org>
> Auto-Submit: Ganggui Tang <gogerald@chromium.org>
> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#779878}

Bug: 1093506
Change-Id: Ie49546277d347eea6682064a41a859f52b882a7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254578
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780386}

Add metrics to measure the usage of self-mirroring on Slides and Meet.
The metrics record whether audio playback happens on the sender device
(used on Meet) or the receiver device (used on Slides).

Bug: b/158093883, 1095967

Change-Id: I6baa2af56671a3085c16e7d317c5a4349ebd0ff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247326
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780385}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6e722f2eaa58..f594ffdc357a

2020-06-19 sebras@gmail.com [cff] Fix another two memory leaks (#58629).
2020-06-19 sebras@gmail.com [psaux] Fix memory leak (#58626).
2020-06-19 sebras@gmail.com Fix memory leak (#58624).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: Ice90c0e8cf7b97013ae5bead79c1ac38b3fdf5e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254719Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780384}

Thread priority should not be modified after a test.
If that is happening, it needs to be fixed in the code.

This CL remove the code that disable the priority checks.

NOTE TO SHERIFF:
 * please paste failure logs when reverting, the goal is
   to remove flaky tests related to thread priority.
 * assigned flaky test to etienneb@

Bug: 1097092
Change-Id: Id39eac9370d7f554ea16562f422818a44a539adc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254579
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780383}

This is a reland of c3de1340

Original change's description:
> Adds icon loading service with sandbox for Windows.
>
> Adds a new |SandboxType::kIconReader| with token and integrity
> levels that allow PrivateExtractIcon to do its thing. The service is
> only used for PE files which, as a complex format, should not
> be parsed in the browser. Other icons are found based only on a
> file's extension. These are handled in the browser as this is both
> faster and allows a tighter sandbox to be applied to the PE file
> parsing. PrivateExtractIcon (a documented but discouraged Windows API)
> is used instead of SHGetFileInfo as SHGetFileInfo requires COM
> which considerably weakens sandboxing.
>
> Adds basic icon loading test for all platforms.
>
> A follow-on CL will add a fallback for PE files for which no embedded
> icon is available.
>
> Testing: adds a unit test for groups, plus
> manual testing on Windows 7 x86 and Windows 10 x64.
>
> Bug: 1032250
> Change-Id: I6975e5612d8b6f35e3216a67fc98592a45895c1b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987273
> Commit-Queue: Alex Gough <ajgo@chromium.org>
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#779502}

TBR=robliao@chromium.org

Bug: 1032250
Change-Id: I7b5bd3c66ff7c6935939c1f21ef9c45384183522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252842Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780382}

https://skia.googlesource.com/skia.git/+log/75c9c5bd26ae..d4928d03e285

2020-06-19 egdaniel@google.com Implement flush finish proc support for d3d backend.
2020-06-19 michaelludwig@google.com Revert "Snap coordinates for shader nearest-neighbor decal filtering"
2020-06-19 brianosman@google.com Add ceil to skvx/skvm/JIT, and floor/ceil intrinsics to ByteCode
2020-06-19 kjlubick@google.com HTML typo egde => edge
2020-06-19 robertphillips@google.com Fix flippity GM for *ooprddl configs (take 2)
2020-06-19 bsalomon@google.com GrTextureGradientColorizer uses GrTextureEffect
2020-06-19 michaelludwig@google.com Snap coordinates for shader nearest-neighbor decal filtering
2020-06-19 robertphillips@google.com Revert "Fix flippity GM for *ooprddl configs"
2020-06-19 johnstiles@google.com Optimize CPP code generation.
2020-06-19 robertphillips@google.com Fix flippity GM for *ooprddl configs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: djsollen@google.com
Change-Id: I12d558184ba84ca3c589db70006fc04ef5433b02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254212Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780381}

* Remove Document::SetReferrerPolicy and OutgoingReferrer, use the
  LocalDOMWindow variants
* Remove most of the uses of Document::GetReferrerPolicy

Bug: 1029822
Change-Id: Ic986b75733fc217e268dc0e5fbcb4db8ffe67073
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250787
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780380}

Roll Chrome Win64 PGO profile from chrome-win64-master-1592568001-645f451bc013d681af722dc2b85e4992534cb0fa.profdata to chrome-win64-master-1592582404-8222a440e7e5a063efaa22c6430adc77286858ae.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I6b6135c48c5bf2d0cb7835afc22d2d5767714945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254462Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780379}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42bed4306e2e..cb20536fca26

2020-06-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I693c354ab7fd084a788ff22f89511a30effecd01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254718Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780378}

Interim character selection is a standard UI element of Korean and some
Chinese compositions. The interim char selection spans exactly one char
and is visually represented as a solid rectangle behind the text, which
is the visually the same as text selection highlight. In order to render
the blue background highlight during composition that has interim char
selection, we need to introduce a new flag |interim_char_selection| in
ui::ImeTextSpan and new flag |interim_char_selection_| in
blink::ImeTextSpan. If the flag is set to true, then one composition
marker is added with background color equal to active background text
selection highlight color.

Bug: 1095682
Change-Id: If06b0ce38c2993427c04efecf6f3e2e4d9f6ec7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249051
Commit-Queue: Siye Liu <siliu@microsoft.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Reviewed-by: Siye Liu <siliu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#780377}

Tab group underline animation is now tied to tab and tab group header
animation and dragging, rather than the underline repositioning itself
during OnPaint(), which caused visual artifacts.

Appears to also solve crbug.com/1094043

Bug: 1095954, 1094043
Change-Id: I7aab620c16e69366ffed65ee7599b8731833e428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250588Reviewed-by: Connie Wan <connily@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780376}

These tests are already flaky, but are also causing crashes and timeouts.
http/tests/devtools/console/console-object-preview.js
http/tests/devtools/console/console-preserve-scroll.js
http/tests/devtools/console/console-search.js

TBR=szuend@chromium.org

https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/18959/blink_web_tests/layout-test-results/results.html
https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/18958/blink_web_tests/layout-test-results/results.html
https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/18957/blink_web_tests/layout-test-results/results.html

Bug: 1046784
Change-Id: Id3182dcd2f56f5a6536f4dc03f4b69e00ea7a11e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254580Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780375}

Change-Id: I95178dde14672080b562d1cccbb978509adddd2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216569
Commit-Queue: Darin Fisher <darin@chromium.org>
Reviewed-by: Darin Fisher <darin@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780374}

The original check for clearing hints when a new optimization type is
registered the first time is racy because of when register is called by
OptimizationGuide clients.

This change adds additional logic to either clear if the store is
available when the type is registered or defers until the store becomes
available.

This also changes the first run experience logic to only clear hints
that are also persisted to disk, which currently is only host-keyed
hints.

Bug: 1068754
Change-Id: I1bc2df217c178b4ef257380c3efd04740a07468b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252478
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Auto-Submit: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780373}

This CL replaces instances of flag-setting
with calls to QuicEnableVersion and
QuicDisableVersion. Some tests were using
version flags as any flags, and those have
been replaced with test flags. This will make
changing versions easier.

R=renjietang@chromium.org

Change-Id: Id96f2fc92a10de3e410b4995190582e657dc57dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253209
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Renjie Tang <renjietang@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780372}

Report two new disk statistics: I/O and discard time.

Bug: chromium:1067670
Change-Id: I98234cb745501574f758842d3939c147cdfd610b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242199
Commit-Queue: Paul Moy <pmoy@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780371}