GitLab

The native button rendering is strange on Yosemite.

BUG=525884

Review URL: https://codereview.chromium.org/1311533004

git-svn-id: svn://svn.chromium.org/blink/trunk@201371 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes the shrink-to-fit algorithm when descendants of the
element have orthogonal writing-mode.

Strictly speaking, as the [spec] defines, min-content width of the element
must be determined by logicalHeight of children. This would require either
"layout during preferred width calculation" or "multiple layout passes."

In most cases, however, descendants are not mixed. Since orthogonal
descendants need re-layout only when the parent's logicalHeight changes,
this patch updates logicalWidth after children are laid out but does not
re-layout descendants.

Table cells with orthogonal descendants require additional work and the
fix is not included in this CL. 001q-001x are tests for table cells.

css3/flexbox/flex-flow-margins-auto-size.html that currently expects to
fail passes with this patch: http://wkb.ug/70769

[spec]: http://dev.w3.org/csswg/css-writing-modes-3/#orthogonal-flows

BUG=410320, 359604
TEST=css3/flexbox/flex-flow-margins-auto-size.html
TEST=imported/csswg-test/css-writing-modes-3/orthogonal-parent-shrink-to-fit-001.html

Review URL: https://codereview.chromium.org/1121173002

git-svn-id: svn://svn.chromium.org/blink/trunk@201370 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reland: Fixed "notEnoughCharacters" not initialized.

Before this CL, SegmentedString::push() had an exotic behavior, where
two consecutive push would swap its order.

This CL changes the push() implementation so that it would always push
the new char in front of the SegmentedString.
This CL also updates the HTMLEntityParser code which relied on the behavior.

BUG=None
TEST={SegmentedStringTest,HTMLEntityParserTest}.*

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201294

Review URL: https://codereview.chromium.org/1308573006

git-svn-id: svn://svn.chromium.org/blink/trunk@201369 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The current documentation was short and didn't really
explain much about the object. The expanded description
introduces more concepts and talks about the different
layouts in more details.

Review URL: https://codereview.chromium.org/1307653004

git-svn-id: svn://svn.chromium.org/blink/trunk@201368 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SkBitmap is being removed from Chrome. There are no longer any callers
of JPEGImageEncoder::encode(SkBitmap,...) so we can remove it and also
the support code it required.

Note: The libjpeg-turbo specialization was the fastest encoder, but it
required premultiplied data (SkBitmap). Thus some performance was lost
when callers were switched over to use the ImageDataBuffer encoder (in
the SkImage-replaces-SkBitmap endeavor).

No change in behavior, no new tests.

BUG=449197

Review URL: https://codereview.chromium.org/1314763008

git-svn-id: svn://svn.chromium.org/blink/trunk@201367 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1319893002

git-svn-id: svn://svn.chromium.org/blink/trunk@201366 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Keishi is a frequent contributor in Source/web [1], and the originator of
Source/web/resources [2].

[1] https://blink.lc/blink/stats/Source/web?period=q&ofs=10
[2] https://blink.lc/blink/stats/Source/web/resources?period=y&ofs=10

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1319883002

git-svn-id: svn://svn.chromium.org/blink/trunk@201365 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/1322493002

git-svn-id: svn://svn.chromium.org/blink/trunk@201364 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We currently support -webkit-text as a value in clip properties,
background-clip, -webkit-background-clip and -webkit-mask-clip, as
well as in color properties (only when in quirks mode). I suspect
usage is extremely rare in both cases so this patch adds counters
for these.

Review URL: https://codereview.chromium.org/1311713004

git-svn-id: svn://svn.chromium.org/blink/trunk@201363 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves global function |intersectsNode()| in
"VisibleSelection.{cpp,h}" to local function in "FrameSelection.cpp" to
narrow visibility for improving code health and ease of implement composed tree
version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1318183002

git-svn-id: svn://svn.chromium.org/blink/trunk@201362 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, remove an obsoleted comment in TestExpectations.

BUG=

Review URL: https://codereview.chromium.org/1301333005

git-svn-id: svn://svn.chromium.org/blink/trunk@201361 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The class was sorely missing some documentation
about the design decisions and its purpose.

Review URL: https://codereview.chromium.org/1323443002

git-svn-id: svn://svn.chromium.org/blink/trunk@201360 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Was changed to failure actually crashing on MSAN bots.

BUG=525824
TBR=szager1, xlai@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1320993002

git-svn-id: svn://svn.chromium.org/blink/trunk@201358 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The current tip wording is the following: "Use 'file:' to define search scope".
The patch changes wording to: "Enter query, use `file:` to filter by path".

BUG=488112
NOTRY=true
TBR=pfeldman, paulirish

Review URL: https://codereview.chromium.org/1317223002

git-svn-id: svn://svn.chromium.org/blink/trunk@201357 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When chrome running on on root-layer-scrolls, page is scaled the style 
is recalculated and thickness is changed. Change in thickness sets 
informs owning renderer to set for childneedsLayout. This layout shall
happen after style reclac is completed, if this sequence is not executed,
then post layout we see the needsForLayout = true, which asserts and
crashes the chrome.

TESTED=fast/scrollbars/custom-scrollbar-thickness-change-on-zoom-crash.html
now passes with root layer scrolling

BUG=522389(https://code.google.com/p/chromium/issues/detail?id=522389#c1)

Review URL: https://codereview.chromium.org/1310603003

git-svn-id: svn://svn.chromium.org/blink/trunk@201356 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201337

BUG=523056
TBR=aelias@chromium.org

Review URL: https://codereview.chromium.org/1301333006 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201355 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is extracted from https://codereview.chromium.org/1307863003
so that it can be landed after all chromium-side changes are landed.

TBR=pfeldman
BUG=456845

Review URL: https://codereview.chromium.org/1301373004

git-svn-id: svn://svn.chromium.org/blink/trunk@201354 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201342

BUG=525702
TBR=jbroman@chromium.org

Review URL: https://codereview.chromium.org/1319663005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201353 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201339

BUG=509025,524134
TBR=wangxianzhu@google.com

Review URL: https://codereview.chromium.org/1322613002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201352 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 - WebServiceWorkerRegistration* (ownership transferred)
  => WebPassOwnPtr<WebServiceWorkerRegistration>
 - WebVector<WebServiceWorkerRegistration*> (ownership transferred)
  => WebPassOwnPtr<WebVector<WebServiceWorkerRegistration*>>
 - WebServiceWorkerError* (ownership transferred)
  => const WebServiceWorkerError&

1/3: https://codereview.chromium.org/1312343004/
2/3: https://codereview.chromium.org/1318953002/
3/3: https://codereview.chromium.org/1316293002/

BUG=493531, 525340

Review URL: https://codereview.chromium.org/1316293002

git-svn-id: svn://svn.chromium.org/blink/trunk@201351 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=517980

Review URL: https://codereview.chromium.org/1315413005

git-svn-id: svn://svn.chromium.org/blink/trunk@201350 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I don't think forcing paint was necessary.

Trying three frames is an experiment to see if it fixes the flakiness on some debug and windows bots.

TBR=schenney

BUG=518999

Review URL: https://codereview.chromium.org/1306943003

git-svn-id: svn://svn.chromium.org/blink/trunk@201349 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On Japanese locale Android which has Motoya Maruberi
as the system default font (up until 5.1), the font
fallback path mistakenly picked up ".notdef" glyph
for   (U+00A0).

This happened because in the fallback path it still
ended up in looking up non-existent glyph in the same
font file and fell back to the "missingGlyphData".

This is because Blink looks up the glyph in
normalized codepoint (for U+00A0, normalized to U+0020)
but still it tries to look up the original codepoint.

This bug was exposed by the following change, to make
not to normalize   to space before looking up glyph.
https://codereview.chromium.org/705163003

BUG=454108

Review URL: https://codereview.chromium.org/1317833003

git-svn-id: svn://svn.chromium.org/blink/trunk@201348 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1323433002

git-svn-id: svn://svn.chromium.org/blink/trunk@201347 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was made non-refcounted class in https://crrev.com/1190133002,
but looks like this could cause crashes in some corner cases.

To be more specific:
FrameLoaderClientImpl::dispatchDidFinishDocumentLoad() calls
WebFrameClient callback first and then WebView callback next, but
if the loader is deleted in the first callback an attempt to call the
second callback on a member variable would crash.

We could probably avoid this crash without making the loader class
ref-counted again, but for now I would like to fix the crash by simply
reverting some of the changes that're causing the crash.

BUG=524694

Review URL: https://codereview.chromium.org/1322523002

git-svn-id: svn://svn.chromium.org/blink/trunk@201346 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201327

BUG=67587
TBR=xlai@chromium.org

Review URL: https://codereview.chromium.org/1313183005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201345 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201329

BUG=515771
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/1322583003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201344 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525824
TBR=xlai@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1318903006 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201343 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525702

Review URL: https://codereview.chromium.org/1307223003

git-svn-id: svn://svn.chromium.org/blink/trunk@201342 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=503399

Review URL: https://codereview.chromium.org/1317863004

git-svn-id: svn://svn.chromium.org/blink/trunk@201341 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since everyone has shipped this unprefixed for a long time now,
don't bother falling back to the prefixed versions in tests.

R=dgrogan@chromium.org

Review URL: https://codereview.chromium.org/1317593005

git-svn-id: svn://svn.chromium.org/blink/trunk@201340 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These suites runs about 1000 layout tests as smoking tests for
spv2.

BUG=524134

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201328

R=chrishtr@chromium.org, joelo@chromium.org

Review URL: https://codereview.chromium.org/1307293002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201339 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Having ScriptedIdleTaskController and its auxillary object keep a reference
to a document's DocumentLoadTiming part object is unnecessary as the deadlines
do not have to be translated wrt a Document's baseline reference time.

R=sami, rmcilroy
BUG=

Review URL: https://codereview.chromium.org/1316323002

git-svn-id: svn://svn.chromium.org/blink/trunk@201338 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reland of place pinch scrollbars with regular scrollbars. (patchset #1 id:1 of https://codereview.chromium.org/1318603005/ )

Reason for revert:
After discussion with samuong@, the original patch should be OK to reland as is and https://codereview.chromium.org/1317153002 is an appropriate fix for the crasher.

Original issue's description:
> Revert of Replace pinch scrollbars with regular scrollbars. (patchset #10 id:180001 of https://codereview.chromium.org/1308053003/ )
> 
> Reason for revert:
> Introduced ChromeDriver devtools mobile emulation crash https://code.google.com/p/chromedriver/issues/detail?id=1205
> 
> Original issue's description:
> > Replace pinch scrollbars with regular scrollbars.
> > 
> > This patch makes the visual-viewport-managed scrollbars exclusive to
> > Android and improves normal scrollbars to be usable during pinch as follows:
> > 
> > 1. Attach the scrollbar layers to the visual viewport, so they're always
> >    onscreen as you zoom in (as already shipped on Mac).
> > 2. Set the container layer to the inner clip layer, so that the size and
> >    position of the thumb reflects the sum of the two viewports,
> >    instead of just the layout viewport.
> > 
> > Note that result of these changes is visually indistiguishable at
> > minimum page scale.  It only improves the behavior when zoomed in.
> > 
> > BUG=523056
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201285
> 
> TBR=rbyers@chromium.org,skobes@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=523056
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201333

TBR=rbyers@chromium.org,skobes@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=523056

Review URL: https://codereview.chromium.org/1305223004

git-svn-id: svn://svn.chromium.org/blink/trunk@201337 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit e43a87f1b1012746a95937f546f723f7737a46b1.

BUG=525772
TBR=wangxianzhu@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1308953005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201336 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=295792

Review URL: https://codereview.chromium.org/1318853003

git-svn-id: svn://svn.chromium.org/blink/trunk@201335 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201287

BUG=524547
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/1317143003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201334 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Replace pinch scrollbars with regular scrollbars. (patchset #10 id:180001 of https://codereview.chromium.org/1308053003/ )

Reason for revert:
Introduced ChromeDriver devtools mobile emulation crash https://code.google.com/p/chromedriver/issues/detail?id=1205

Original issue's description:
> Replace pinch scrollbars with regular scrollbars.
> 
> This patch makes the visual-viewport-managed scrollbars exclusive to
> Android and improves normal scrollbars to be usable during pinch as follows:
> 
> 1. Attach the scrollbar layers to the visual viewport, so they're always
>    onscreen as you zoom in (as already shipped on Mac).
> 2. Set the container layer to the inner clip layer, so that the size and
>    position of the thumb reflects the sum of the two viewports,
>    instead of just the layout viewport.
> 
> Note that result of these changes is visually indistiguishable at
> minimum page scale.  It only improves the behavior when zoomed in.
> 
> BUG=523056
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201285

TBR=rbyers@chromium.org,skobes@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=523056

Review URL: https://codereview.chromium.org/1318603005

git-svn-id: svn://svn.chromium.org/blink/trunk@201333 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525377

Review URL: https://codereview.chromium.org/1314393003

git-svn-id: svn://svn.chromium.org/blink/trunk@201332 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/1316033003

git-svn-id: svn://svn.chromium.org/blink/trunk@201331 bbb929c8-8fbe-4397-9dbb-9b2b20218538