- 12 Nov, 2020 40 commits
-
-
Owen Min authored
Disable AwSettingsTest#testTextZoomAutosizingWithTwoViews due to flaky. Bug: 1147937 Tbr: boliu@chromium.org Change-Id: Ia3f0cdcbe10717ee2eec415a6da6cb1b74d32996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534402Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826892}
-
Rushan Suleymanov authored
Clients will send the flag which will indicate that the client is not aware of any other clients. This is useful to prevent trying to send invalidations from the server. The single client flag is calculated based on known device infos. Devices which don't have recent enough updates are considered non-active. Bug: 1145942 Change-Id: Ia24cb880e361b65796ea8c516ef38c1bfed58b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533775 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#826891}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/fcafd5b49266..e258cf5e7aa9 2020-11-12 dneto@google.com Roll back googletest to earlier version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Idaadbe9ec81d212caf9c2978891d0050b5615e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826890}
-
Morten Stenshorne authored
The main motivation behind this change is to get the code out of the way when interrupted by spanners. In such cases there may be space left in the fragmentainer when finishing the fragment before the spanner (i.e. the last piece of column content before the spanner), but this should neither be part of the fragment nor consumed block-size. We used to include the remaining space of the column interrupted by a spanner in consumed block-size, so that a node with fixed block-size would have this subtracted when generating fragments after the spanner (causing us to use less space on the node than we should). Bug: 829028 Change-Id: I7990532474b45ef20900455da75b8337d08c62fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532467Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#826889}
-
Trevor Perrier authored
This CL removes two things related to native resources not loading with an override locale. - First, logging on ResourceBundle paths is removed. - Second, a call to SplitCompat.installActivity that was added to try to fix the issue but did not work is removed. Bug: 1143026 Change-Id: I4136be98ca5103d91cc1340fd6252b513ab63e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531661 Auto-Submit: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#826888}
-
Clark DuVall authored
This required moving ChunkedByteBuffer to //components/speech to be shared between //chrome and //content. Bug: 949535 Change-Id: I0c58762bd4c47123f9c36778c3d02b8d2da65564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533854Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Liu <evliu@google.com> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826887}
-
Gordon Seto authored
Add UI with mock data for the eSIM Profile discovery page. Screenshots: https://screenshot.googleplex.com/6APFxT6GKtLqNNd.png https://screenshot.googleplex.com/AMcw2z4myKRKQTs.png Bug: 1093185 Change-Id: I5216bb2f91b58578bbf4f2918ab21f9a78727324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523521 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#826886}
-
Brandon Wylie authored
TBR=wychen@chromium.org Bug: 1148365 Change-Id: Ic52c628790c9d7fc7673b5ba83185af6cafe1a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535014Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#826885}
-
Jan Wilken Dörrie authored
This change adds a feature flag to control reparsing server predictions following dynamic form changes. Bug: 1140480 Change-Id: Ic0520f197d766fedab96c5c30d089bba49ef3e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534857Reviewed-by:
Maria Kazinova <kazinova@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#826884}
-
ckitagawa authored
When under memory pressure, we need to make sure all objects exist and that the callback is the last thing resolved. Otherwise `this` might be gone. Bug: 1148268 Change-Id: I0bc7c5ec29b4189f19b7936b20fc7cd6b8489d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533900 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826883}
-
Brandon Wylie authored
TBR=fhorschig@chromium.org Bug: 1148376 Change-Id: I6f97f5934b0196c8e6aa92db9f17b5598f49ddec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535015Reviewed-by:
-
Matthias Körber authored
The features in the removed experiment have all been enabled by default. Change-Id: Ia80687aa8c68f560b4c4810136769fea195bf602 Bug: 1076175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521731 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#826881}
-
Ben Pastene authored
Appears to be causing shard #2 to timeout consistently. Bug: 1147992 Change-Id: I3e680dc18499c261b013f8b2cb04911e7eee5daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533202Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#826880}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/7b750dc7337d..1980095da7f4 2020-11-12 rharrison@chromium.org [inspector] Convert GetRemapped to be a pass through 2020-11-12 dsinclair@chromium.org [spirv-writer] Revert change to entry point name. 2020-11-11 rharrison@chromium.org [inspector] Add better support for remapped entry point names 2020-11-11 bclayton@google.com writer/spirv: Further reduce test boilerplate 2020-11-11 bclayton@google.com writer/spirv: Reduce test boilerplate 2020-11-11 bclayton@google.com wsgl parser: support multiple error messages 2020-11-11 sarahmashay@google.com remove redundant std::move to fix clang errors 2020-11-11 dsinclair@chromium.org Remove unused function 2020-11-11 dneto@google.com ast: intrinsic spelling matches the spec 2020-11-11 sarahmashay@google.com [validation] Update entry points validation v-0020 2020-11-11 bclayton@google.com wsgl parser: Tweak top-level unexpected token error message 2020-11-11 bclayton@google.com wsgl parser: Fix tests that have multiple errors 2020-11-11 bclayton@google.com wsgl parser: refactor statements() 2020-11-11 bclayton@google.com wsgl parser: add expect_lt_gt_block(), use it 2020-11-11 dneto@google.com spirv-reader: support OpDot, OpOuterProduct 2020-11-11 dsinclair@chromium.org [docs] Expand OpImageType documentation 2020-11-11 dsinclair@chromium.org [msl-writer] Emit texture types 2020-11-10 rharrison@chromium.org [inspector] Extract Sampled Texture data 2020-11-10 dsinclair@chromium.org [hlsl-writer] Emit texture types 2020-11-10 dsinclair@chromium.org [spirv-writer] Hash names 2020-11-09 bclayton@google.com wsgl parser: Have Expect & Maybe operator-> deref 2020-11-09 bclayton@google.com wsgl parser: Add ParserImpl::Maybe<T> 2020-11-09 bclayton@google.com wsgl parser: Add ParserImpl::Expect<T> 2020-11-09 bclayton@google.com wsgl parser: Migrate more code to use expect & match 2020-11-09 bclayton@google.com wsgl parser: expect for storage_class 2020-11-09 bclayton@google.com wsgl parser: expect for variable_ident_decl 2020-11-09 sarahmashay@google.com [validation] relax rule v-0002: return is mandatory for non-void functions 2020-11-09 bclayton@google.com wsgl parser: Remove pointless nullptr checks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC sarahmashay@google.com,dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com,dsinclair@google.com Change-Id: Ibe39ff2a3c3c4ea40f737ce8289bab2ae0f6b71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534621Reviewed-by:
-
Viktor Semeniuk authored
This change replaces usage of AffiliationFetcher to HashAffiliationFetcher depending on the feature state. Bug: 1108279 Change-Id: I2398fc91ce14af80ef28a1e48dad61c60690366a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529109 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#826878}
-
Guido Urdaneta authored
Prior to this CL, explicit max frame rates were not enforced if the configured frame rate for the source was less than or equal to the requested max frame rate. This has led to problems with webcams that produce a higher frame rate than configured. This CL changes the VideoTrackAdapter so that frame rate adjustments are disabled only for tracks that do not explicitly request a maximum frame rate. Bug: 1133796 Change-Id: I2e3769493449b552f9440c2a809b512bf9e3690c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534952 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#826877}
-
Joon Ahn authored
http://screen/Be2cQHGk3cZmE5f Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I6f6ef200659fdcd7e72a56d1d87328c72342ccb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530750 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#826876}
-
Dave Tapuska authored
In https://crrev.com/4bb0db09 I removed an early return for MainFrameImpl being null and added a CHECK. It is clear that CHECK is being hit (we've seen this in EndCompositorFrame as well with issue 1139104) and I speculate that the LocalRootImpl is non-null but MainFrameImpl is null. The only code that still accesses the MainFrameImpl is this piece of HandleGestureEvent as it hasn't been converted yet. Since branch for M88 is coming up silence this condition that was previously an early return. BUG=1148018,1146579 Change-Id: I1d214c8787fcd8e4dcfe5983752b3468373f7321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532990 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826875}
-
chinsenj authored
The {TabletOrClamshell} token is used in various different ash histograms but they all use the same variants. This CL extracts the variants into a common variants tag. Bug: 1140182 Change-Id: Ifd9b5233405b65308c09b24e0e6d7700eef2db3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533362Reviewed-by:Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Jamie Madill authored
This reverts commit e4620991. Reason for revert: Suspected for causing crashes on Windows/Intel. For more info see bug. Bug: 1148269 Original change's description: > Ignore unknown record types in DNS responses > > Previously worked only for address requests. Other request types (e.g. > HTTPS), on seeing any unrecognized (and therefore unparsable) record > type in the response, would fail the whole response as malformed. > > Bug: 1147247 > Change-Id: Icd9e5ab2e39cf09ffe7c3945b011ebf1d4b45778 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529619 > Commit-Queue: Eric Orth <ericorth@chromium.org> > Auto-Submit: Eric Orth <ericorth@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826462} TBR=mmenke@chromium.org,ericorth@chromium.org Change-Id: I03ea912d1a9c8a01be3d84a3f4d417c385f97c2d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533548Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#826873}
-
minch authored
Extend the expiry date of the histograms' for tab/window dragging and back gesture. Bug: 1147108, 1147107, 1147106, 1147105, 1147098 Change-Id: Ic2f9d2eacc9aa39a702fa2dc67c4befcbb25a17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527678 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#826872}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/62c10c170bb3..f9e59ad07855 2020-11-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from a61d07a72763 to 1cda495274bb (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I5967a52af57d49153bf6b77586a89107c098135f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534011Reviewed-by:
-
Matthias Körber authored
Change-Id: I59f544e93fa573d3a5ab9b7b43c3b9b51e1c4550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526062 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
-
Thomas Lukaszewicz authored
This CL adds metrics to track the position of a switched tab from both filtered and unfiltered lists. Bug: 1099917 Change-Id: I4cb7822240bd78b228906b0fd86eaf364b4cdb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529692 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#826869}
-
Andy Paicu authored
Implements a bare-bones version that mostly reuses code from RealTimeUrlLookupServiceBase without doing the work to derive from a base class. This will follow-up in a different CL. For this reason some of the callbacks have unused parameters, to make implementing a base common class less painful. Design doc: go/permission-predictions-client-doc Bug: 1138595 Change-Id: Idc26e836fba565cf42f796ee3a5b20bc8d61f53f No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513656 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#826868}
-
Rune Lillesveen authored
We did a BlendWithWhite() to not have custom selection backgrounds fully obscure replaced content like images. But, we also did that blending for text which means the author could not fully control the ::selection background. Instead, only do this blending for replaced content. This is in line with what Firefox does and what the spec says[1]. The blending is still done on the UA default background color for both text and replaced content in LayoutTheme. [1] https://drafts.csswg.org/css-pseudo-4/#highlight-replaced Bug: 1018450 Change-Id: Ibb2c63d549a21706a511bbb47ff4c686b246314b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532555 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826867}
-
Jan Wilken Dörrie authored
This change adds base::fixed_flat_map and base::fixed_flat_set as specializations of base::flat_map and base::flat_set using a std::array as the underlying container. These containers have immutable keys following their construction, and can be used as constexpr lookup tables in case the keys (and values) are known at compile time and of appropriate types. Bug: 682254 Change-Id: I47725824078beeca5100f502041c4977efde5868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532247Reviewed-by:
-
chinsenj authored
Currently if a user moves a window to another display via overview, its header is invisible upon exiting overview. This CL resets the clipping created when the overview item is created to prevent this bug. Test: manual Fixed: 1140639 Change-Id: I9e5d943bcb4ac7e8fb2054775c2695b2516dc381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533553 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#826865}
-
David Bienvenu authored
Bug: 1007801 Change-Id: I2b93105731784095eee61591478756f6dcafb58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532561 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#826864}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=sdefresne@chromium.org Bug: 1145565 Change-Id: I6079224aa98f835cd8913977b157e02b0a679f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533136Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826863}
-
Xiaodan Zhu authored
This CL add a policy for the fullscreen alert to make admin be able to turn it on/off for certain apps. In M89, we will change this policy to a allowlist policy. Test: Manually tested on the test device. Bug: 1107185 Change-Id: I58c01980218f94946d66b7ee2995d49d30ad329d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530654 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#826862}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605139151-5e724661a0d96b85fc6a4800d483b70ce425d91c.profdata to chrome-win32-master-1605171583-b81bb40f399242d480e6bc76fe7dadde7d574957.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If85c1f0cef656378fe91dacb6d16ef73d0b6b7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534006 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Dave Tapuska authored
MockRenderProcessHost had a unique lifecycle, it could self delete when Cleanup was called and this would lead to a double free in some tests that allocated it via a unique_ptr. In fact the majority of tests allocated it via unique_ptr or stack allocated where self deleting the object makes no sense. To clean this up remove the self deleting and change all ownership to explicit ownership via unique_ptr. BUG=993189 Change-Id: I2cd6ddf3298cbcfe630f17fd008a8895e9562937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528620 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826860}
-
Roger McFarlane authored
Bug: 1110384 Change-Id: I7c0324071625e4bf25e3b797d5a1fb60bdedd1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476134Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#826859}
-
Hans Wennborg authored
These tests are in zlib_unittests, and that's already built and run by the bots (after crrev.com/804566). This removes the redundancy of building and running them twice, and takes some load of the already very large unit_tests target. While here, also move the zip and compression_utils to zlib_unittests and try to clean up chrome/test/BUILD.gn from unnecessary zlib references. Bug: 352073 Change-Id: I3cfe020df9bc2699bbb160ae95b511840589e054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534930 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826858}
-
Tim Volodine authored
StartSurfaceTest#testShow_SingleAsHomepageV2_VoiceSearchButtonShown__Instant_Return StartSurfaceTest#testShow_SingleAsHomepage_VoiceSearchButtonShown__Instant_Return are failing / flaky on L and M bots. BUG=1148352 NOTRY=true TBR=wychen@chromium.org,hanxi@chromium.org Change-Id: I86d4873301d578236f760d323b90c8386c0462bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534932Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#826857}
-
David Dorwin authored
Without a background color, the page is transparent, which can make it hard to read or notice whether it worked when the background behind it is black. Also, add a console log to allow testing of setting the console log level and DevTools. Change-Id: Ib8c4197615b425addc8d44ef9e8e9275a97d4810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533862 Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826856}
-
Angela Yoeurng authored
If a suggestion has a remove suggestion button, this CL adds a voiceover saying 'Press Tab then Enter to remove suggestion.' If a suggestion has a remove suggestion button AND another option, the voiceover will read 'multiple actions are available, press Tab to cycle through them.' The Remove Suggestion button previously was not included in the action count. Bug: 1099798 Change-Id: I84f012d0f9d40a82a8c85214128ce25c6b4323b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533634Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#826855}
-
Ben Joyce authored
Bug: 989569 Change-Id: I71607e5272ca98c896d5dd48307f2198b46ef4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520332Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#826854}
-
Chris Lu authored
Bug: 1107489 Change-Id: I8d7f9a4c8567936993a95589bbc9333360df8570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521108 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#826853}
-
