- 05 Aug, 2020 40 commits
-
-
Yusuf Sengul authored
Bug: 1113075 Change-Id: If6dd51dc9adf71fbceea1421a650a8f0e906c97c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337769 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#794914}
-
Abhijeet Kandalkar authored
This is a reland of 6b1e649d Original change's description: > Merge blink::WritingDirection to mojom::TextDirection > > In this CL, WritingDirection {kNatural, kLeftToRight, kRightToLeft} is > replaced by TextDirection {UNKNOWN_DIRECTION, RIGHT_TO_LEFT, > LEFT_TO_RIGHT} and dependant files are ported to use |TextDirection| > enum. > > Bug: 1088377 > Change-Id: Iac185f2d34eddd78127c3f59b7dc90fe380b5f34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306127 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> > Cr-Commit-Position: refs/heads/master@{#790314} Bug: 1088377 Change-Id: Ic82cde2f3cf38fc996b7bd9369793ee31a6ed288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336100Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#794913}
-
Mugdha Lakhani authored
These classes have references to one another and need to be moved in one go. All references to these in chrome code have also been updated. Bug: 1096088 Change-Id: I3992135f83453c9d283d0a0bd0413001fd549b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332194Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#794912}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f8ccdc63a188..23c5b63d1c68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia084ad2637b9797a68eff3bc28b33d38361e3294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337939Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794911}
-
Yuke Liao authored
This CL re-enables interactive_ui_tests as the compilation failure has been fixed. Bug: 1106980 Change-Id: Ic22547332f04e1e513153d731841f78a36d30fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336511 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#794910}
-
Maggie Cai authored
Currently it is possible to have empty activity name return from intent querying. Update the logic to return the app name if the activity name is empty. BUG=1092784 Change-Id: I4af2406b5627d8d68ac3d6ee7f03c0e7175116ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336008 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#794909}
-
Yuki Shiino authored
According to https://crrev.com/c/2325534, updates the implementation of make_v8_to_blink_value so that it works with string types. Bug: 839389 Change-Id: I99ecec934b7238bfeef4ad549ef2773a3f17d107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337193Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#794908}
-
My Nguyen authored
UndoWindow should gets bounds from autocorrect character bounds if present, else just use caret bounds. Bug: b/160373678 Change-Id: I9fd3a8e3e4e58e889bfde5693df71d1299d7fcb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336342Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#794907}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ea3e861cd37..90bf66075426 2020-08-05 petermarshall@chromium.org l10n: Localize XLink callers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If791799bfaf5c80ce0cfaefa35f69c1c1e91d7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332522Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bfcf8c4832c7..e7b08e4876fb 2020-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 709472c9dd0c to 6c873cfde957 (13 revisions) 2020-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from be02bd1a to b133b38a (477 revisions) 2020-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 74cc8ea2b8df to be7c55a2a8ce (2 revisions) 2020-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 1ea3a22f521e to 076a4e58205d (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1110408,chromium:1110421 Tbr: herb@google.com Test: Test: Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*"Test: Test: gn gen out/Android Change-Id: I7e2863bda8ee7a77dfd3352f2c945a6320284b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336537Reviewed-by:
-
Maggie Cai authored
Currently there is no matching user interaction type for LaunchSource kFromSharesheet, which causes the app cannot launch. Adds the user interaction type to fix this. BUG=1097623 Change-Id: I92f2ca0b34f379cdaffa7d9bf6dea3a7592bbaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336009Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#794904}
-
Jon Mann authored
* Creates EnsureLazyLoaded class to perform lazy loading if it needed. * Creates lazy_load.js to bundle resources that aren't needed in the initial load. * Splits SettingsIdleLoad off from browser settings to use the OS version of EnsureLazyLoaded. Bug: 1045266 Change-Id: Ied500b3b4830e8db2cbd8f5924e65d8bb9eef030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315202 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794903}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b156b016f22b..23c5b63d1c68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id7b6bf8c5d40564dba8702b74226645865d69362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332870Reviewed-by:
-
Xiaocheng Hu authored
Bug: 1113004, 1111008, 1110504, 1078474 Change-Id: I1204ca19fe7533bc30b9b1f867acfae01f423524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337675 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#794901}
-
Dana Fried authored
These issues could conceivably cause some graphical glitches in certain cases in e.g. the extensions container, which we have seen some reports of. Still to do: - Tests which use a widget to simulate being minimized, maximized, etc. mid-animation Change-Id: I54249b8de85dae74d45327ea8f80501981800c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335652 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#794900}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I1d5c9642c0ad303cc71086efa0a577ae2e535817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337202Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#794899}
-
WangShicheng authored
The cached image size of the video poster has been scaled using the style's EffectiveZoom, so it should not be scaled again in LayoutVideo::UpdateIntrinsicSize(). Bug: 1107377 Change-Id: I57ca1ccf59531ac00aac0fbf261d3be59ede8bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317487Reviewed-by:
-
Dominick Ng authored
This CL removes a long-standing TODO, and adds DCHECKs in AppServiceProxyFactory::GetForProfile that mirror the existing logic used to determine whether to return a nullptr or a real AppServiceProxy. Also fix a context menu test that was fetching an AppServiceProxy with an incognito profile, and remove now-redundant DCHECKs/nullptr checks that are placed immediately after a call to AppServiceProxyFactory::GetForProfile that will now DCHECK if a nullptr would be returned. BUG=1112197 Change-Id: I9a7de8849f819cceb061677cef9e37c967d4651a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334249 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#794897}
-
Tsuyoshi Horo authored
This reverts commit b545f589. Reason for revert: Caused crash on MSAN bots. crbug.com/1113054 Bug: 1113054 Original change's description: > Use only SafeSearch filter for EduCoexistence webview. > > This cl fixes the bug where the child user is stuck > in EDU account addition flow when the user's parental > control setting is 'Only allow certain sites'. > > Inorder to prevent this error from happening we will do > only safe search filter for the EduCoexistence webview > and not enforce the 'Only allow certain cites' settings > potentially set by the child's parents. > > "https://accounts.google.com" is manually whitelisted. This > is because there is a race condition where we don't know > whether the WebContent is an inner WebContent belonging > to EduCoexistence flow or not by the time throttling happens. > This happens because navigation to accounts.google.com is > started before the <webview> WebContents is attached to > the outer WebContents hosted by the EduCoexistence flow WebUI. > > We are making this exception only to the webview that is present in > the EDUCoexistence flow. The exception is made because the parent is > present with the child during the flow. Extending this exception > to every inner webcontents will may allow the child to break parental > settings. > > Bug: 1079510 > Change-Id: I4f3e65e58537a845613b0c49b03f801f0a3caa08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316443 > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794661} TBR=michaelpg@chromium.org,treib@chromium.org,agawronska@chromium.org,yilkal@chromium.org Change-Id: Ifc288d0021727b517e7ee75fc631dbd752b93739 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1079510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336429Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794896}
-
Tsuyoshi Horo authored
This reverts commit e41b9b8f. Reason for revert: Caused crash on chromeos-betty-pi-arc-chrome bot. Bug: 1113077 Original change's description: > media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive > > Certain platforms and codecs suffer from horrible artifacts (Intel BYT, > H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of > error in the tracking of the VASurfaces lifetime in the driver: every > time we get a new resource from the pool to decode onto, this is > imported into libva as a VASurface: this works fine almost everywhere > but doesn't play well in these old platforms (see CreateSurface() body). > > This CL adds a map that keeps the ref-counted VASurfaces alive and > indexed by the unique GpuMemoryBufferId until the VA Context is > destroyed. In so doing, we're basically observing the "contract" of > va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all > contexts using these surfaces have been destroyed". > > [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 > > Bug: b:142019786 b:143323596 > Change-Id: I78cc08cd882fda51ff036c88a7050adb577e53ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295947 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > Auto-Submit: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794679} TBR=mcasas@chromium.org,jchinlee@chromium.org,andrescj@chromium.org Change-Id: I9046542cc2d30c9280e9e9fe50c5b0c53314af9e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:142019786 b:143323596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337051Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0a4342793e0e..076a4e58205d 2020-08-04 rharrison@chromium.org Roll 6 dependencies and bypass changed API usage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0066c5514b7a6cf199a8dd893096183bb9cc3258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336535Reviewed-by:
-
Zhuoyu Qian authored
The parameter |factory| of HttpAuthHandlerRegistryFactory:: RegisterSchemeFactory() maybe nullptr, move all usage of |factory| in the check, make sure it will not crash. Change-Id: Ic48b8e798bf26229436ccd2357a5c1a0dec789d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333912Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794893}
-
Rakina Zata Amni authored
Currently if a page has beforeunload/unload handlers, it will block sudden terminations (e.g. tab closing) from happening before it has a chance to run the handlers. This CL makes it so that pagehide & visibilitychange handlers have that power too, to make sure they cover all the cases where unload handlers are fired. Bug: 987409 Change-Id: I685245b863c2976caaea9198665f941ecdedee3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288711 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Wenbin Zhang authored
As part of the progress of removing reference build from perf waterfall, this CL disabled the reference builds on system_health.common on all platforms, i.e., system_health.common_mobile.reference is no longer running on: Android Nexus5 Perf, Android Nexus5X WebView Perf, android-go_webview-perf, android-go-perf, android-pixel2_weblayer-perf, android-pixel2_webview-perf, android-pixel2-perf system_health.common_desktop.reference is no longer running on: linux-perf, mac-10_12_laptop_low_end-perf, mac-10_13_laptop_high_end-perf, win-10_laptop_low_end-perf, win-10-perf More details can be found in: go/ref-builds-prd go/chromeperf-refless Bug: chromium:1108663 Change-Id: I9b0bee9818b74f2a26fb0ed5fbc0286526dfac56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337380Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#794891}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f8ccdc63a188..23c5b63d1c68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie92fc10db9bca3cf0aea107cbee1a6f92821349c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338033Reviewed-by:
-
Kent Tamura authored
According to the legacy layout behavior, WebKit behavior, and Firefox behavior, margins of a LEGEND should not affect block-direction position of the LEGEND. The border-box of the LEGEND should be centered vertically in the top border of the FIELDSET. - We should compare the block-start border width of the FIELDSET and the block size of the LEGEND border-box. - Even if the block size of LEGEND border-box is smaller than the block-start border of the FIELDSET, block-end margin of the LEGEND can affect the position of the FIELDSET content box. This fixes legend-after-margin-with-before-border-horizontal-mode.html and legend-small-after-margin-before-border-horizontal-mode.html, and the major part of legend-block-margins-2.html. Test changes: * NGFieldsetLayoutAlgorithmTest.LegendBreakBeforeAvoid The test assumed a break happened in the block-start margin of a LEGEND. We ignore the block-start margin, and the test broke inside the LEGEND. Add 'break-inside:avoid' to avoid breaking inside the LEGEND. * NGFieldsetLayoutAlgorithmTest.MarginTopPastEndOfFragmentainer Removed. The test made sure that if a break happens inside the block-start margin of a LEGEND, the reaiming block-start margin was ignored. We ignore the block-start margin, so we can't test the behavior. Bug: 875235 Change-Id: I78db12c42d5d1d5a928b7871838a5330f4b6943a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331995 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#794889}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ic58153b84d825e50f7f73ec5432ac104fa03a86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337720Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794888}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d24a19d42924..8076f2289388 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: horo@google.com Change-Id: I44fe9f02f33e84079313e9915d8d0be021156b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337934Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794887}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596571199-429c5d3274b1adcffd4054f095f3cc2a5ada36c8.profdata to chrome-win32-master-1596585596-89744fc48a5c31a4a09c1357a13855640c06c65a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I018fe3e1466f2f8a31090456903b6c7efe594454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336872Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596562698-892fa89488e0e796ec09ee348ea5782de7379276.profdata to chrome-win64-master-1596585596-c75cdf8296e7e3f8b1db14498223f15cea6443e5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9c50bb60e3756070a9123544648fd58b033f393e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337937Reviewed-by:
-
chrome://flagsTsuyoshi Horo authored
This reverts commit 5da77d64. Reason for revert: Caused compile error. https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/5437 [9650/14917] CXX obj/chrome/browser/browser/about_flags.obj FAILED: obj/chrome/browser/browser/about_flags.obj c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../chrome/browser/about_flags.cc(6186,46): error: no member named 'kEnableTabSearchName' in namespace 'flag_descriptions'; did you mean 'kEnableSaveDataName'? {"enable-tab-search", flag_descriptions::kEnableTabSearchName, ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ kEnableSaveDataName ../..\chrome/browser/flag_descriptions.h(358,19): note: 'kEnableSaveDataName' declared here extern const char kEnableSaveDataName[]; ^ Bug: 1113076 Original change's description: > Tab Search: Add chrome://flags entry for Tab Search > > This addition is necessary to allow users to disable the feature once > the experiment is enabled. > > Bug: 1099917 > Change-Id: I4e537a1fe92d1329c75ff8c190f92ce7f1cde8b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336020 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794867} TBR=robliao@chromium.org,tluk@chromium.org Change-Id: I9e4778e201b2e61e1966ebb887930571e670dbdb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337049 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Prakhar Asthana authored
This reverts commit 2940de50. Reason for revert: The reverted build failed: https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/2902 The original CL doesn't seem to be the reason behind https://crbug.com/1112710. Original change's description: > Revert "Bring parity between mac coverage and non-coverage build" > > This reverts commit 25c59fc5. > > Reason for revert: Speculative revert for https://crbug.com/1112710 > > Original change's description: > > Bring parity between mac coverage and non-coverage build > > > > They have diverged since coverage build was first created. > > > > > > Bug: 1024915 > > Change-Id: Iec853bce25916efe7aea644c1a6ddcef4339a849 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335573 > > Commit-Queue: Prakhar Asthana <pasthana@google.com> > > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > > Auto-Submit: Prakhar Asthana <pasthana@google.com> > > Cr-Commit-Position: refs/heads/master@{#794288} > > TBR=liaoyuke@chromium.org,pasthana@google.com > > Change-Id: Ifd50ef6445af397abd08a953e9229d86809d25d7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1024915, 1112710 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333841 > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794487} TBR=liaoyuke@chromium.org,sinhak@chromium.org,pasthana@google.com # Not skipping CQ checks because this is a reland. Bug: 1024915 Bug: 1112710 Change-Id: Ia75ff3b1ef2494274e38eebb3a0ded893a3a2ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336340Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/master@{#794883}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/580a4b1d52b6..5ea3e861cd37 2020-08-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9852fd2d969dcad3887ebc15a49d9cfbb4450e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337936Reviewed-by:
-
chrome-release-bot authored
This is a reland of d67d7452 Original change's description: > Updating trunk VERSION from 4223.0 to 4224.0 > > # This is an automated release commit. > # Do not revert without consulting chrome-pmo@google.com. > NOAUTOREVERT=true > TBR=pbommana@chromium.org > > Change-Id: If634e36bccdaf23712ecf376a6ff315c346875e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332868 > Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#794839} Change-Id: I619563d769b591e301419355874f3249515e5ad7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337768Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#794881}
-
Noah Rose Ledesma authored
The MediaWebContentsObserver will notify the MediaSessionControllersManager of a device switch. In turn the appropriate MeiaSessionController will receive this message. Bug: 1110368 Change-Id: I1ceefdd6a0502384dfffba3ad6dedff21ba8b94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323589 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#794880}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/10f019c5068f..bfcf8c4832c7 2020-08-05 herb@google.com simplify next allocation size If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: If1c42fd819f838bf18117e53271f2d4ebd977a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337451Reviewed-by:
-
Sven Zheng authored
This cl should not change any logic. Lucicfg tool had an update and caused 'lucicfg fmt' changed. This cl enabled lint, fixed some lint issues, and generated changes after running 'lucicfg fmt' inside infra/config. Change-Id: Id6b8cbde334075c2b549337eb12ee819f3ece211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316795 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#794878}
-
Maksim Sisov authored
There are some USE_X11 guards that I needed to fix. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how the finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I5562751867d876b0cbf6a4bde7e71daf2395d541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333842Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#794877}
-
Maksim Sisov authored
Enabling use_x11 && use_ozone results in running X11-only tests that cannot succeed for Wayland config. Thus, disable them (as it was before we started to work on use_x11 && use_ozone config) via checking for the feature flag instead of relaying on GN. I acknowledge that this is wrong to do, but I'm going to fix that as soon as use_x11 && use_ozone config is upstreamed. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how the finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I77b943fe8e54982b97c40a4f34bbbca66ab3f726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336597Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#794876}
-
Maksim Sisov authored
These should be as close to platform level as possible. Thus, avoid having them outside platform. Bug: 789065 Change-Id: Ie61150ae6c9b56c167475c3798464b4f4290b950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332610 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
-
