GitLab

BUG=702154

Change-Id: Ic5b338b9c4a59be0d777b38c6341d9ca293ba9bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131152
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755937}

This component provides ShellMainDelegate, an implementation of
ContentMainDelegate that creates the various Content Shell-based
interfaces for each process. It can be asked to create web test
versions of these interfaces also.

This component will be able to see web_test components, while
content_shell_lib will not need to anymore. (At least in the renderer
so far.) This will allow us to
1) make content/shell/renderer/web_test into a separate component
2) merge test_runner into that same component (or vice versa?) without
   regressing separation by merging test_runner into content_shell_lib.

The dependency graph would be like
content_shell_app -> content_shell_lib
content_shell_app -> web_test_renderer -> content_shell_lib

R=avi@chromium.org

Bug: 866140
Change-Id: I7f530851b60e478260d681b0c43b089d630a6b77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132940Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755936}

This is a reland of c00c874f

Original change's description:
> clang build.py: change LLVM_ENABLE_ZLIB from ON to FORCE_ON
> 
> This uses the FORCE_ON option to enable zlib to ensure that clang
> actually finds and uses zlib. Also moved this setting out of
> base_cmake_args so that it is only used in the main clang build,
> since there is another 32-bit build that can't use this zlib.
> 
> Also changed to remove and re-download the zlib source on
> every build.
> 
> Change-Id: Ifceabc2ba06e4e4a56464f18de80610a0f043641
> Bug: 1061189
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118674
> Commit-Queue: Amy Huang <akhuang@google.com>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753301}

Bug: 1061189
Change-Id: If208eab801b1105814979134d0c75092c8c3f396
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126970Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755935}

Bug: 927509
Change-Id: Icc150445dd72857d9d85fa2939e77bd7b1718c00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132399
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755934}

These were left unused after https://crrev.com/582971.

Change-Id: I3b57367c49367331709eb3b208e1e5fecd3fda74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133121Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755933}

These were left unused after https://crrev.com/605294.

Change-Id: I7a4ea28e498d344252779c3379ff69d73d89695c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133565Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755932}

This new FeatureList class contains the
IMPROVED_COOKIE_CONTROLS[_FOR_THIRD_PARTY_COOKIE_BLOCKING] features,
which are used by Clank's Site Settings UI, which is in the process of
being componentized so it can be used by WebLayer.

Bug: 1058597
Change-Id: I46ceae9dc71e6d96b89278fe7fd28ebfdf8e337d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123336Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755931}

Bug: 1066980
Change-Id: Iad325860483f84b7d1538f1908daf145b45ff8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133924
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755930}

This reverts commit 9dc21ef5.

Reason for revert: This identified the root cause of a flaking test is a bug within the gpu frame submission code path. More work is needed to debug the root cause. In the interim I'm removing this logging until someone can take a closer look

Original change's description:
> Add logging when receiving an invalid frame token
> 
> To investigate issue 1045372 some crash keys were added to log the old
> and new frame tokens however this doesn't work for the flaky browser
> tests I am investigating in issue 1022321. This change adds log messages
> which should show up when the test flakes.
> 
> Bug: 1022321
> Change-Id: If1c88d1cea3dc771c96a4d636b6797a8686b6315
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123030
> Auto-Submit: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Jonathan Ross <jonross@chromium.org>
> Reviewed-by: Jonathan Ross <jonross@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754145}

TBR=jonross@chromium.org,reillyg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1022321
Change-Id: Ibdcf7b30b77f836bb3d0257c77c056c31f554298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134608Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755929}

This CL fixes the issue where text runs after overlapping annotations
are not added to the accessibility tree. In the loop where text runs are
added to the accessibility tree, some text runs are skipped due to
incorrect normalization after overlapping annotations are added to the
tree.

Tests have been added to validate the scenario.

Fixed: 1066802
Change-Id: I6e7b3c72d9c25c45033a057d44261e888e9e7796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131808Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#755928}

MarketingBackendConnector communicates over the Access Points API
to set the user's preference regarding marketing emails. The component
will be used on the last screen of OOBE - Marketing opt-in screen.

Bug: 1056672
Change-Id: I7f3b43b80395ab19c1dfc3313b91453f2e314bd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128492
Commit-Queue: Renato Silva <rrsilva@google.com>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755927}

This prevents TaskEnvironment::FastForwardBy() from instantiating
ScopedBlockingCalls and confusing internal //base tests.

It is also conceptually correct as we wouldn't want to replace
worker threads blocked on TestTaskTracker.

R=fdoray@chromium.org

Bug: 1064645
Change-Id: I304ccbf270177ddb1435aed81e52b26fe9b5a41b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133049Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755926}

OWASP documentation has seemed to move to
https://cheatsheetseries.owasp.org. The source can be found on
https://github.com/OWASP/CheatSheetSeries/blob/master/cheatsheets/, but
all of the old material that our CORB documentation links to is now
hosted on their new site.

R=yhirano@chromium.org

Change-Id: I7c171f709816d69615ff82c10b8bb8fc9c51e08a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134569
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755925}

This matches the behavior of regular extension install dialog in
the same situaton, because the parent permission dialog is never used
for delegated permissions, which the only time optional permissions
are shown in the regular extension install dialog, as can be seen at:
https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_install_prompt.cc?l=602

See bug for a concrete example of where this inconsistency appears.

Bug: 1067037
Change-Id: I5aab8d159d9abc8ba73347be187d0fdcb4034a70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133217Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755924}

This CL disables the notification if shelf navigation buttons
are enabled for accessibility in tablet mode.

Bug: 1066914
Change-Id: I3fa6dbae462df614154c5a5727800eb4a0a4b625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133116Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755923}

Bug: 1025603
Change-Id: Ie2ef10c03b9ffea77436c0932727d1545fcf895f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132540Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755922}

This moves helper code that the browser uses over to the browser/
directory and removes the DEPS rules that were left to support this
violation.

R=avi@chromium.org

Bug: 866140
Change-Id: Ib49c7e5e6f64f34db87a73ef5368384ee73e1c19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133876Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755921}

https://android.googlesource.com/platform/external/perfetto.git/+log/586f781bd78b..96e14888195d

git log 586f781bd78b..96e14888195d --date=short --first-parent --format='%ad %ae %s'
2020-04-02 lalitm@google.com Merge "tp: fix returning utid of freed thread in rss stat event"

Created with:
  gclient setdep -r src/third_party/perfetto@96e14888195d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I4f7e3ad75b1468de8a242f61d6f25994a96a4904
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134357Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755920}

Drive-by: update video tests to return correct promise and improve
style.

Bug: 1052765
Change-Id: Id1c31b577f0431b2073f0ae486926283aca41759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132200
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755919}

This reverts commit 26f39e78.

Reason for revert: it has passed

Original change's description:
> CL to verify that presubmit does not know anythyng about includes
> 
> This CL tests whether we have existing presubmit check to remove
> includes that are not needed
> 
> Change-Id: I821b3cefdc82c8bddf8be20a711af5b121822d82
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879922
> Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Reviewed-by: Oleg Davydov <burunduk@chromium.org>
> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755881}

TBR=apotapchuk@chromium.org,burunduk@chromium.org

Change-Id: I763613a4d48113c515cae121af544ccc1cb95bdd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133931Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755918}

The tests were not initializing the font correctly nor were they
waiting for it to load. This should fix those issues, however the
2d.text.measure.width.space test still fails because of how collapsing
whitespace works. Not sure if this a bug in the test or implementation.

BUG=1066953

Change-Id: I2f0b81da891e6c701b1c9aa7d8d871615ab0ca28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132674Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755917}

TBR=kinuko@chromium.org

Bug: 1058600
Change-Id: I7eb62790b096cacde13fd0392caa71a7bfc35a7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131358Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755916}

This reverts commit 55ee8df4.

Reason for revert: This test is flaking at 10% rate. It is dealing with a race condition inside the GPU frame submission code path. We are disabling it until someone has the time to sort out the root cause.

Original change's description:
> Revert "Disable WebBluetoothTest.WebBluetoothAfterCrash"
> 
> This reverts commit cc673fd0.
> 
> Reason for revert: Unable to reproduce test flakiness.
> 
> Original change's description:
> > Disable WebBluetoothTest.WebBluetoothAfterCrash
> >
> > See details in:
> > https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySQsSBUZsYWtlIj5jaHJvbWl1bUBicm93c2VyX3Rlc3RzQFdlYkJsdWV0b290aFRlc3QuV2ViQmx1ZXRvb3RoQWZ0ZXJDcmFzaAw
> >
> > TBR=reillyg@chromium.org
> >
> > Bug: 1022321
> > Change-Id: I01fcb892eea350bc60a05fc8f5b1aab9088cffc1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904191
> > Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> > Commit-Queue: Hongchan Choi <hongchan@chromium.org>
> > Auto-Submit: Hongchan Choi <hongchan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#713544}
> 
> Bug: 1022321
> Change-Id: I8bc50f7c4328cf4da82e6e4230a4a9b1fe1365cd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121347
> Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> Commit-Queue: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753452}

TBR=reillyg@chromium.org,hongchan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1022321
Change-Id: Ic835ad85cb0b30a3cb2778aa237f926f92ffeb81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134574Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755915}

This re-enables a flaky test which has been disabled the last few years.
It seems OK locally, so let's see if it flakes on the bots.

Bug: 653307
Test: run_webview_instrumentation_test_apk --num_retries=0
Test: --break-on-failure --repeat=1000
Test: -f MediaAccessPermissionRequestTest.*
Change-Id: I5aa806a2087c031ef674278f8c50f2ff4c6eb1f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134575
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755914}

WebRTC recommends not setting the min-bitrate. This setting makes sense
only in the simulcast/SVC case, where higher streams would be disabled
if there's not enough bitrate for them.

Bug: 1067091
Change-Id: Ief47cd36cb00a8f9f576e78f64d111e831bb83a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133409Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755913}

This CL further brings into alignment with design specifications the
style of newly introduced collapsible radio toggles on the Security &
Cookies pages.

A new "data" icon is also introduced representing a vertical bar chart.

Bug: 1061947
Change-Id: I9cf8c3662227ec33da5227118acab750da0110d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129706Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#755912}

This patch removes all unlocking from the activation signal code path.

This is in line with the proposed spec: auto unlocks only on selection,
focus, and visibility. Hidden-matchable issues an event but does not
unlock.

R=chrishtr@chromium.org

Change-Id: Id47e1edcf4a2042e286ce50943f5c5b4a6b5fc4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134571Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755911}

This CL also disables Tab to GTS animation for single start surface,
since it looks bad and does not work for single tab tab switcher.

Screen records:
https://drive.google.com/a/google.com/file/d/1iqIPfeI3GFyfNtz4rHijhlpH4TTbQE_j/view?usp=sharing

TODO: remove 'group tabs' from the menu when showing single tab view.

Binary-Size: Size increase is expected.
Bug: 1065902
Change-Id: I244275e809fefbe4e9106f852fe383201ac1e123
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125455
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755910}

Test: manual; compile weblayer provider with is_chrome_branded=true
Bug: 1025612
Change-Id: Ia56a1fc07cf896129d1bdd1845c8e647e66bfc17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134293Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755909}

Adds a test for the proxy returning an auth challenge. Manually
tested that a proxied auth challenge from the origin also shows no
dialog, but adding a test for that is blocked on crbug/1042829.

Bug: 1023485
Change-Id: I73ac536c7afb80300915734ef239a2cd0c7f7f25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134607Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755908}

Bug: 1067101
Change-Id: I17e0d681a593c9e207a67b6c1b7f3aab32bbcd2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133388Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755907}

Curtesy of cushon@:
There are javac flags that tell it to stop at a particular compilation
phase: -XDshould-stop.ifNoError=FLOW should allow Error Prone to run but
stop the compilation before code is generated.

4 seconds faster for chrome_java errorprone. (55s -> 51s).
5.2s faster for Base Java Signature Change (153.6s -> 148.4s).
Saves 192.9s elapsed time for Base Java Signature Change.
    4552.2s -> 4359.3s

Bug: 906803
Change-Id: I0708cafea2f95ba50df7697d753ea3e930d1330c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134192Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755906}

This reverts commit 4297d4c9.

Reason for revert: widespread failures in DownloadManagerTestCase.testDownloadWhileBrowsing

see e.g. https://ci.chromium.org/p/chromium/builders/ci/ios-simulator/53545

Log includes:

  Exception Reason: containsText is false: Failed waiting for web state containing Google Chrome Terms of Service

Original change's description:
> Reland "Update TOS"
> 
> Updated the iOS UI test.
> 
> This reverts commit 9033a96c.
> 
> Original change's description:
> > Revert "Update TOS"
> >
> > This reverts commit f88c2f7c.
> >
> > Reason for revert: Widespread ios bot failures. auto-rollers are blocked.
> >
> > Original change's description:
> > > Update TOS
> > >
> > > Bring chrome://terms in line with
> > > https://www.google.com/chrome/terms/
> > >
> > > Bug: 1060545
> > > Change-Id: I823aa5bdf51c55488777ebb18406b79f9887e6b9
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120046
> > > Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
> > > Reviewed-by: Ted Choc <tedchoc@chromium.org>
> > > Reviewed-by: Ben Mason <benmason@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#755585}
> >
> > TBR=pinkerton@chromium.org,tedchoc@chromium.org,benmason@chromium.org
> >
> > Change-Id: Ibb4b4c39eff4b9a4276a4e3d64e5ae8552b47452
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1060545, 1067086
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132554
> > Reviewed-by: Trent Apted <tapted@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#755690}
> 
> TBR=tapted@chromium.org,pinkerton@chromium.org,tedchoc@chromium.org,benmason@chromium.org
> 
> Change-Id: I27b47f7f79a00e9f5e3275e7e3de285c1234cc87
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1060545, 1067086
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133873
> Commit-Queue: Ben Mason <benmason@chromium.org>
> Reviewed-by: Ben Mason <benmason@chromium.org>
> Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755838}

TBR=tapted@chromium.org,pinkerton@chromium.org,tedchoc@chromium.org,benmason@chromium.org

Change-Id: I7f762b91f96cf0956579c35285245d9485ba34ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1060545, 1067086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134766Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755905}

Add the ICU timezone data configuration path to the namespace of all
sandboxed processes, so that all Chromium processes run with a
consistent set of timezone data.

Bug: fuchsia:45462, 1067309
Change-Id: Id78f30ce9e07326a8037d6222210dcab60385e15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130214
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755904}

The gestures being tracked are:

Back Gesture
Home to Overview Gesture
In App Shelf to Home Gesture

The metrics being tracked are:

Time between showing nudge and user performing gesture
How the nudge is being dismissed (kOther, kPerformedGesture,
kTap, kSwitchToClamshell, kExitToHomeScreen, kTimeout)

Bug: 1055694
Change-Id: Ia7756d4cd4d0f9fff1184807f1b83acae4bf5f43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086074Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755903}

In the early days, this test was written to accommodate the case where
CSS Grid was under development, and possible to be toggled on/off at
runtime.

Now that CSS is Grid in stable for years, we can simplify the test's
JS code, and rewrite most of the page in pure HTML.

BUG=1063749
R=jfernandez@igalia.com

Change-Id: I558ba15bddd252c2f5fefb236cf630f3d08533f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133918Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#755902}

If an ImageBitmap is created using an image element, it should always
wrap the decoded data. Currently this is done conditionally based on
whether alpha conversion is required.

R=fserb@chromium.org

Bug: 1063679
Change-Id: I670a72eeb9d95cc6c0596aa1642bb7293372a8bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133051
Auto-Submit: Khushal <khushalsagar@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755901}

If a new card was entered with an already expired date, we may prompt
the user to fix it up before uploading.

Bug: 1066690
Change-Id: Iff960a26a512dc66e6f356190e0524b63cba362c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133552
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755900}

https://chromium.googlesource.com/angle/angle.git/+log/75a2ee30c3ec..a053f340a44c

git log 75a2ee30c3ec..a053f340a44c --date=short --first-parent --format='%ad %ae %s'
2020-04-02 thakis@chromium.org Vulkan: Use shader stage specific barrier

Created with:
  gclient setdep -r src/third_party/angle@a053f340a44c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cwallez@google.com
Change-Id: I3d84b649f8181f8b3961c48b6322e5cb8335c878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134355Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755899}

Switching from BrowserWithTestWindowTest to ChromeViewsTestBase lets
us use utilities like set_native_widget_type() and CreateTestWidget().

This also removes some unnecessary code and makes more use of
CreateBookmarkModelAndBookmarkBarView().

Bug: none
Change-Id: I655ea33a5d213d2e5d1a54528b00105bb24e48c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081334Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755898}