- 28 Nov, 2017 40 commits
-
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/e9619f8f81de..b874a352272a $ git log e9619f8f8..b874a3522 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I792b134a8649f2623e08de5b891c627170240384 Reviewed-on: https://chromium-review.googlesource.com/794056Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#519751}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9f553932a4a4..12b69eedeed5 $ git log 9f553932a..12b69eede --date=short --no-merges --format='%ad %ae %s' 2017-11-20 ethannicholas shader cache now ignores shaders with a length of 0 2017-11-14 ethannicholas Fix shader initialization on a cache hit 2017-11-28 jvanverth Add create_bundle support for GN Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: I64a40bba4b6d805993bccce82205711700d29f4c Reviewed-on: https://chromium-review.googlesource.com/794057Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519750}
-
Doug Arnett authored
Bug: 788900 Change-Id: Ia15c1712bc894b2c69920d37192c75b47dc67fbe Reviewed-on: https://chromium-review.googlesource.com/794170Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#519749}
-
Reid Kleckner authored
These bots are no longer split between builders and testers. Part 2 after https://chromium-review.googlesource.com/783518 R=hans@chromium.org No-Try: true Bug: 587879 Change-Id: I98201d6582933e1e86e3762abfe2923bdad7c21e Reviewed-on: https://chromium-review.googlesource.com/792346 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#519748}
-
Peter Beverloo authored
Bug: 789145 Change-Id: Iffd4099a6eb58cc532fb39bddda8581fd5a65a31 Reviewed-on: https://chromium-review.googlesource.com/793810 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#519747}
-
Dave Tapuska authored
With event sender input is possibly injected solely on the main thread and a host may not be bound yet. So protect against null host objects on the main thread. BUG=788886 Change-Id: I6b8d1449ce01e3a1f0872133440839fa445d1567 Reviewed-on: https://chromium-review.googlesource.com/793971Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#519746}
-
Morten Stenshorne authored
Sometimes it times out. Also moved animations/animation-ready-reject-script-forbidden.html expectation to where it belongs. TBR=kojii@chromium.org Change-Id: I36b75d39be98ff57f235fe768259ae37d65b271d Reviewed-on: https://chromium-review.googlesource.com/793192Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#519745}
-
Rune Lillesveen authored
An interesting note is that the spec says scroll-behavior on BODY should not propagate to the viewport. Firefox currently does that. Bug: 788347 Change-Id: Id82deeac64177bce05268bb5fdb2df144f808800 Reviewed-on: https://chromium-review.googlesource.com/793045Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#519744}
-
Hiroshige Hayashizaki authored
To reduce modifications to SecurityContext's SecurityOrigin and make it easier to make SecurityContext's SecurityOrigin const. No behavior changes are expected. Bug: 779730 Change-Id: I03ac5b2a22eb84cce8cd287eed3a4c13cb639f2f Reviewed-on: https://chromium-review.googlesource.com/762360 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#519743}
-
Mike Baxley authored
Instead of sharing this code, it should be replaced by directly using the Embedded Test Server. Bug: 638674 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If887548078abe90314363a39c33980225239a523 Reviewed-on: https://chromium-review.googlesource.com/791810 Commit-Queue: Mike Baxley <baxley@chromium.org> Reviewed-by:
Menglu Huang <huangml@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#519742}
-
Dominic Battre authored
This CL changes the callback of SysLogsSources::Fetch such that the generated SystemLogsResponse is passed as a unique_ptr instead of a raw pointer. This allows further cleanup in the form of processing the SystemLogsResponse asynchronously, because the receiver of the SystemLogsResponse can be sure to be the true owner and does not need to worry about the caller deallocating the object. TBR=rkc@chromium.org Bug: 787554 Change-Id: I85ddfd2f3972039cea0eca43b0fce3bc5d0ba105 Reviewed-on: https://chromium-review.googlesource.com/787470 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#519741}
-
Mythri Alle authored
Bug: chromium:788796 Change-Id: I208022746d63a6379dcf55cb12c1ec8fea8aabcc Reviewed-on: https://chromium-review.googlesource.com/794110Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#519740}
-
yusukes authored
ArcMetricsService used to be simple, but it's not anymore and needs some tests. For example, since b/62703685 has been fully implemented, ArcMetricsService::ReportBootProgress() may receive event timestamps that are smaller than |arc_start_time|. BUG=b:65128488 BUG=b:62703685 TEST=try Change-Id: Idd2aed6bdc2cbdb970d8e9b0e02987377ae1cfd6 Reviewed-on: https://chromium-review.googlesource.com/785110Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#519739}
-
Kenneth Russell authored
These fixes will make it easier to autogenerate this file with full fidelity. BUG=662541 TBR=dpranke@chromium.org NOTRY=true Change-Id: Iab5fc98e13b9ce4c4b61d29fa72d08bc06b3c8b1 Reviewed-on: https://chromium-review.googlesource.com/790131 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#519738}
-
Marc Treib authored
Before, it used local_ntp_browsertest.html instead, for no good reason. Bug: 788166 Change-Id: Iba4fe5c06eab1bc9fafebe6f528955c208c24359 Reviewed-on: https://chromium-review.googlesource.com/787897Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#519737}
-
David Trainor authored
mUseLightColorAssets could be null, which can cause IPH crashes on tablets if called before it is set. This just protects against the value not being ready. BUG=778033 Change-Id: I057178d966d44ee1d755241be919d48e1e324e37 Reviewed-on: https://chromium-review.googlesource.com/779864 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#519736}
-
bsheedy authored
Applies the same fix from https://chromium-review.googlesource.com/c/chromium/src/+/783150 to vr_common_perftests, as it is failing for the same reason the unittests were previously. Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I855ce021db6ef8ab83565b7b2ccccd64ebc4b785 Reviewed-on: https://chromium-review.googlesource.com/792391Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#519735}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/0b684ce3c9f5..df68ca50b310 $ git log 0b684ce3c..df68ca50b --date=short --no-merges --format='%ad %ae %s' 2017-11-27 geofflang Add missing break in StateManagerGL::syncState. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ica92fbdbd27167dc47e4e4a1260be121611bbabd Reviewed-on: https://chromium-review.googlesource.com/794050Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519734}
-
Olivier Robin authored
This reverts commit cc9fb229. Reason for revert: breaks ios_chrome_settings_egtests Original change's description: > [signin] Dice migration: Clear LST tokens when gaia cookies are cleared > > This CL adds ShouldReconcileAccount() function on the > DiceAccountReconcilor delegate, that is used to revoke the tokens when > cookies are empty. > > As a cleanup, the chrome_account_ member is changed to a local variable, > to reduce the amount of state in the AccountReconcilor, making it > hopefully more readable. > > Bug: 788315 > Change-Id: Id4348a6ae2e524de721d39c84cb4e150adb892b2 > Reviewed-on: https://chromium-review.googlesource.com/789032 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519697} TBR=droger@chromium.org,msarda@chromium.org Change-Id: I523e02e242bbb48fb978528c4789f73ce562dd28 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 788315 Reviewed-on: https://chromium-review.googlesource.com/794111Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519733}
-
Patrik Höglund authored
The WebRTC chromium bots need sound cards, and the drivers for those sound cards inject themselves into the COM stack, which triggers a CHECK chromium does to detect precisely this. Therefore, disable this check on these particular builders. We will aim to get rid of the sound cards and simplify the tests in Q1, so hopefully this is just temporary. Depends on crrev.com/c/753591. Bug: 737090 Change-Id: I6cc5603e345b0d8b8866b97abfd3db8d4e94e7eb Reviewed-on: https://chromium-review.googlesource.com/753728Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#519732}
-
Hiroshige Hayashizaki authored
To reduce modifications to SecurityContext's SecurityOrigin and make it easier to make SecurityContext's SecurityOrigin const. No behavior changes are expected. Bug: 779730 Change-Id: I64ea74543c989716b6d80ff249489dddb9ace5d1 Reviewed-on: https://chromium-review.googlesource.com/762142 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#519731}
-
Scott Little authored
This reverts commit cc9fb229. Reason for revert: This seems to have broken ios_chrome_settings_egtests (iPad Air 2 iOS 10.0) failing on chromium.mac/ios-simulator-full-configs The AccountCollectionsTestCase/testMDMError test is failing. See https://uberchromegw.corp.google.com/i/chromium.mac/builders/ios-simulator-full-configs. Original change's description: > [signin] Dice migration: Clear LST tokens when gaia cookies are cleared > > This CL adds ShouldReconcileAccount() function on the > DiceAccountReconcilor delegate, that is used to revoke the tokens when > cookies are empty. > > As a cleanup, the chrome_account_ member is changed to a local variable, > to reduce the amount of state in the AccountReconcilor, making it > hopefully more readable. > > Bug: 788315 > Change-Id: Id4348a6ae2e524de721d39c84cb4e150adb892b2 > Reviewed-on: https://chromium-review.googlesource.com/789032 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519697} TBR=droger@chromium.org,msarda@chromium.org Change-Id: If4f5e30f574365d1cf7d58e4ca1c41889fa1b0bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 788315 Reviewed-on: https://chromium-review.googlesource.com/794250Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#519730}
-
gogerald authored
Do not match capabilities again since it has been done in ServiceWorkerPaymentAppFactory. Note that, the capability related matching tests for getInstruments is not applicable anymore, so they have been modified to test matching modifiers which use the same matching rules. Bug: 777470 Change-Id: Ib01ad930b48b2ab5e78b13aa5b73c1e1fa4cf645 Reviewed-on: https://chromium-review.googlesource.com/788452Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#519729}
-
Antonio Gomes authored
CL is a first step to untangle ENABLE_MUS from OS_CHROMEOS. This does not change any ChromeOS behavior, since in ui/base/ui_features.gni there is 'enable_mus = is_chromeos' .. but makes it easier to run Mus on non-ChromeOS builds. BUG=789043 Change-Id: I0febf99ee8352af9f39c4e3411864e0a1baf3460 Reviewed-on: https://chromium-review.googlesource.com/793952Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#519728}
-
Robert Sesek authored
This is a reland of f12be75c Original change's description: > Add a utility to format a base::debug::StackTrace for CrashKeyString. > > Bug: 598854 > Change-Id: Ie92935f4919e57cae338c33750458c0509a93627 > Reviewed-on: https://chromium-review.googlesource.com/782040 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518381} Bug: 598854, 787669 Change-Id: I81fef0cba08240ee288d4e3db3c3bcf4ff130219 Reviewed-on: https://chromium-review.googlesource.com/793930Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#519727}
-
Marc Treib authored
This removes instant_url, search_terms_replacement_key, and instant_url_post_params from SearchEngineSpecifics. Bug: 476079 Change-Id: Ib0bed32ba21e11cc90e44234a6c321d97a02522b Reviewed-on: https://chromium-review.googlesource.com/785910Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#519726}
-
Eric Seckler authored
This aligns animations with virtual time progression when the CompositorController is used to issue BeginFrames. Also updates VirtualTimeController to use TimeDeltas instead of millisecond ints and initializes BeginFrameArgs frame_time to its minimum value by default to support emulated negative base::TimeTicks values in continuity DCHECKS throughout the compositor code. Bug: 646774 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia28ab131dd1a327907f8570a1f26ce794208d3d4 Reviewed-on: https://chromium-review.googlesource.com/790910 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#519725}
-
Gustav Sennton authored
WebView should not post onReceivedError when shouldOverrideUrlLoading returns true for invalid url schemes - with PlzNavigate we do post onReceivedError when the url checked is a server redirect. This CL fixes that issue by calling shouldOverrideUrlLoading before verifying that the scheme of the new target url in the redirect is valid. Note: if the url is overridden we still update the state of the navigation handle to point to the new url, this is to ensure the WebView (Aw)WebContentsObserver sees the new url. BUG=788775 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I4ad36e3ae3feaa39a00024282752c02bbe88bd6f Reviewed-on: https://chromium-review.googlesource.com/790993 Commit-Queue: Gustav Sennton <gsennton@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#519724}
-
Fady Samuel authored
This CL measures top level UI synchronization duration for both the existing CompositorResizeLock code path and the new surface synchronization code path. Bug: 672962 Change-Id: I069e6ad7207722ccda8d80c791b8604ec8bb6335 Reviewed-on: https://chromium-review.googlesource.com/792213 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#519723}
-
Ryan Harrison authored
This reverts commit add87b2d. Reason for revert: This CL was correcting for an issue with the API function in PDFium. https://pdfium-review.googlesource.com/c/pdfium/+/19350 corrects this issue in PDFium, so this attempted work around is no longer needed. Once the PDFium side change lands and is rolled into Chrome this will need to be landed. Original change's description: > Account for string terminator added to FPDFText_GetText strings > > The documentation for this function in PDFium explictly calls out that > the caller needs to pass in a buffer that is number of characters > desired + 1, to account for the terminator. > > The existing implementation does not correctly do this, grabbing count > characters instead of count - 1 characters. This causes the written > out string to be count + 1 long due to an added terminator. The > corrected implementation cannot be rolled in current, since it causes > the strings being returned to be shorter then expected. > > This CL changes the call sites in Chrome to follow the documentated > behaviour, which works correctly with both the old and new > implementation of the function. For the old implementation it will > overallocate by 1, and for the for the new implementation the > allocation size will be correct. > > BUG=chromium:761770,chromium:761626 > > Change-Id: I874a88d854c2c85c28847ade3d74bcce56d6a876 > Reviewed-on: https://chromium-review.googlesource.com/650650 > Reviewed-by: dsinclair <dsinclair@chromium.org> > Commit-Queue: Ryan Harrison <rharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#499732} TBR=rharrison@chromium.org,dsinclair@chromium.org,paulmeyer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:761770, chromium:761626 Change-Id: Ic608ced5dcf662369e4695118c28794ad3873255 Reviewed-on: https://chromium-review.googlesource.com/788430Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#519722}
-
Chris Mumford authored
This reverts commit 8d71ca83. Reason for revert: Missed existence of filesystem.mojom.FileError Original change's description: > Added a Mojo equivalent to base::File::Error. > > mojo.common.mojom.FileError is the Mojo version of the base::File::Error > enumeration. > > Added enum traits for base::File::Error
↔ mojo::common::mojom::FileError. > > Bug: 787281 > Change-Id: I12075ed19fd412d0f92b0eccef66ba3832261d8b > Reviewed-on: https://chromium-review.googlesource.com/786266 > Commit-Queue: Chris Mumford <cmumford@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Oliver Chang <ochang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519407} TBR=jam@chromium.org,cmumford@chromium.org,ochang@chromium.org Change-Id: I10ec724c00a3022ef177f4ded3268f0e892c1a69 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787281 Reviewed-on: https://chromium-review.googlesource.com/794153Reviewed-by:Chris Mumford <cmumford@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#519721}
-
Christopher Grant authored
To properly render the reticle, it needs to be drawn on the element it is hitting, rather than last in the scene (otherwise, translucent un-hittable elements may appear to have the reticle instead). In the future, we may transition to drawing the reticle last, always, for simplicity. However, if we don't do that, we need a way to have the reticle appear properly on top of composite UI elements - elements made up of sub-elements in a plane. Without this change, something like a button backplane may have the reticle, but portions of the reticle may appear under a different button foreground element even though it's on the same plane. With this change, we traverse the hit element's subtree, and draw the reticle after the last planar, visible child instead. This way, it's guaranteed to render on top of the composed element, unless the element has hittable children floating in front. BUG= R=mthiesse, vollick Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I33a1aef392901b74e3b5814338a4e4c5fb58eac9 Reviewed-on: https://chromium-review.googlesource.com/791151 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#519720}
-
Egor Pasko authored
This is a followup to crrev.com/519345, where the disabling was not done properly for AsyncResourceHandlerBrowserTest. Apologies. TBR=xhwang@chromium.org,csharrison@chromium.org Bug: 788748 Change-Id: Ia5397e830a821e6a7f6408416ec6b86da7589947 Reviewed-on: https://chromium-review.googlesource.com/794131Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#519719}
-
Biao She authored
Bug: 779590 Change-Id: Ie2897ca6de11a4a84c0b54eb3937b355b46a0f33 Reviewed-on: https://chromium-review.googlesource.com/789536 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#519718}
-
Sadrul Habib Chowdhury authored
mus can delegate managing the gfx::AcceleratedWidget it creates to the window manager. The window manager (i.e. ash/aura) in this case needs to support injecting this AcceleratedWidget into its compositor. BUG=786453 Change-Id: If9de911ab70e84e750728b0b46a8d4470c1e7da8 Reviewed-on: https://chromium-review.googlesource.com/792272Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#519717}
-
Katie Thomas authored
This reverts commit 676ba628. Reason for revert: This breaks archive_webkit_tests Original change's description: > Re^3 land Add UKM Document.OutliveTimeAfterShutdown > > This CL is the third trial to add the UKM Document. > OutliveTimeAfterShutdown. This CL uses the existing Document:: > UKMRecorder() and avoids requesting from content renderer to content > browser. Actually, I have confirmed that this CL doesn't emit the > problematic log "Connection InterfaceProviderSpec prevented service: > content_renderer from binding interface: ukm::mojom::UkmRecorderInterface > exposed by: content_browser" on my local machine. > > This CL adds a new UKM Document.OutliveTimeAfterShutdown, that is > recorded when a Document object survives 5, 10, 20 or 50 garbage > collections after detached. If a document outlives such long time, the > document might be leaked. The UKM would be very useful to know where such > leaky documents exist and to fix them. > > Design doc: https://docs.google.com/document/d/1fbs5smdd-pBLLMpq7u8EkyddZILtI7CZPJlo_AA1kak/edit?usp=sharing > > Bug: 757374 > Change-Id: I4615f170626faab7151444b4a898c40761fbb6e1 > Reviewed-on: https://chromium-review.googlesource.com/763187 > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519618} TBR=hajimehoshi@chromium.org,haraken@chromium.org,holte@chromium.org Change-Id: I29014cd0266fe2f8d7c0137c3a1c5a8d419c5505 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 757374 Reviewed-on: https://chromium-review.googlesource.com/794152Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Katie Thomas <katthomas@google.com> Cr-Commit-Position: refs/heads/master@{#519716}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/e82af1a845c1..fee749f0a141 $ git log e82af1a84..fee749f0a --date=short --no-merges --format='%ad %ae %s' 2017-11-28 npm Fix PDF fuzzers memory limit Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1eb49bbcf90ec2e9186cf3103fa43750278c615d Reviewed-on: https://chromium-review.googlesource.com/793890 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519715}
-
tzik authored
This CL updates callers of blink::Timer::StartRepeating around the caret blink preference to use TimeDelta as the time type. Plus, this updates all call path toward it to use TimeDelta instead of double. Change-Id: I520e4707dff69a75ed1a0f6b1a198c26d79ed9da Reviewed-on: https://chromium-review.googlesource.com/784674Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#519714}
-
Greg Thompson authored
AutofillInteractiveTest::PopulateForm has flaky timeouts on CrOS. BUG=516052 TBR=estade@chromium.org Change-Id: I40c3cfaf2a73488fe309e301d7c58317062cd440 Reviewed-on: https://chromium-review.googlesource.com/794130Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#519713}
-
Eero Häkkinen authored
As SSE and AVX optimizations are quite similar, the new file can be modified to be useful also for AVX optimizations with altered preprocessor logic. This is a preparation for AVX optimization of VectorMath functions. Bug: 778262 Change-Id: Ic9540e1a17b090020e789db1ca5126ffe141b044 Reviewed-on: https://chromium-review.googlesource.com/738241 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#519712}
-