- 18 Jul, 2019 40 commits
-
-
Tarun Bansal authored
Treat WiFi connection same as 4G when computing the ECT. Change-Id: I5d1ed46227b1d19b50a30996b2e3e8a551b82b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706871Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#678557}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/34f3be0173a3..f8c5b19aa40a git log 34f3be0173a3..f8c5b19aa40a --date=short --no-merges --format='%ad %ae %s' 2019-07-17 achuith@chromium.org Disable testCommandLineOverriding on cros guest browser. Created with: gclient setdep -r src/third_party/catapult@f8c5b19aa40a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:985125 TBR=sadrul@google.com Change-Id: I099b4918298dac0d5790db859037aa0d81c04353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707256Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678556}
-
Regan Hsu authored
Change-Id: Ida5a4a12042d2b8845294f8630d951b99b45c6bc Bug: 968182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695692 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#678555}
-
Kristi Park authored
Increase height to prevent fakebox placeholder text from being chopped when min font size is increased. Screenshot: http://screen/cxX7edHXjpO.png Bug: 983036 Change-Id: I6e2d5f6d2b1e4d98e0e71fa067426d3facc069ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707406 Commit-Queue: Kristi Park <kristipark@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#678554}
-
siyua authored
The flag is enabled only on Linux, Windows, Mac. Replace flag with a platform build config wherever it is needed. Bug: 905393 Change-Id: I55a23b3583a248680ba6bb87db28b0a0eb9cb4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702383Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#678553}
-
Matt Falkenhagen authored
These pass now that appcache on UI is supported, and other fixes. Bug: 824858, 824856 Change-Id: Iaaedd108065df68b28bc243bab078ee5a6b70c25 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707749 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#678552}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b04e2561be34..fcf3a87cedf4 git log b04e2561be34..fcf3a87cedf4 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 magjed@webrtc.org Android: Expose setting custom visible fraction values for video layout Created with: gclient setdep -r src/third_party/webrtc@fcf3a87cedf4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I207e9991701520973f0defd26256a227c964dc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706400Reviewed-by:
-
vikassoni authored
1. Update 2 pixel video tests to use dimensions within the actual physical device limits. These tests were using the video player and test rectangle width which was overflowing the actual physical device width. Hence we were getting assert when taking a screenshot of the video and cropping it with the test rectangle because the test rectangle width was more than the screenshot width. 2. Update the color expectations for 4 tests accordingly. 3. Add viewport metadata for this page to scale correctly on mobile devices. 4.This CL fixes 2 tests on android - Pixel_Video_MP4_FourColors_Rot_90 and Pixel_Video_MP4_FourColors_Rot_270. Remove the test expectations from pixel_expectations.txt. 5. This CL updates 2 tests running on windows - Pixel_DirectComposition_Video_MP4_FourColors_Rot_90 and Pixel_DirectComposition_Video_MP4_FourColors_Rot_270. Bug: 925744 Change-Id: I3d15256675b538b6be5a4c8f5318c1949c0ab271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699145 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#678550}
-
liberato@chromium.org authored
Previously, CodecImageGroup forwarded image destruction to any interested parties. MaybeRenderEarlyManager used this to know when to try early rendering. However, with image pooling, early rendering isn't always caused by image destruction; the same image can be reused. This CL adds a NowUnusedCB to CodecImage that is called when the CodecImage won't be used for display anymore. Early rendering uses this signal, rather than destruction, to check for rendering. Also, it removes the image from the CodecImageGroup once it's unused, since the image no longer depends on the output surface. Note that the CodecImageGroup still uses CodecImage destruction to keep track of images; it's not necessary to remove them from the group like MaybeRenderEarlyManager does. This guarantees that the CodecImageGroup will track images properly, even if the MaybeRenderEarlyManager is destroyed first. This can happen if, for example, the decoder is destroyed while VideoFrames are outstanding. Also note that the NowUnusedCB is only called during image destruction right now. A future CL will allow it to be triggered at other times. Change-Id: Id26e6eb11e178586fac17ead0a585ed6bbfef854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707190Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#678549}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9d03368411cc..23fdf8916502 git log 9d03368411cc..23fdf8916502 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 rycsmith@google.com FPDFAnnot_IsChecked API for checkboxes and radio buttons. Created with: gclient setdep -r src/third_party/pdfium@23fdf8916502 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/135921512 TBR=pdfium-deps-rolls@chromium.org Change-Id: Iaf10f7a25951b86b33f9f1feb08dddedf69d854a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707769Reviewed-by:
-
Jinseong Jeon authored
That will help a shrinker remove field loads as well. Bug: 137671429 Change-Id: I083f60f3081a1e00c52b000b5ee5430ba3d20487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707128 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#678547}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/97028a5397fd..68185ac0410b git log 97028a5397fd..68185ac0410b --date=short --no-merges --format='%ad %ae %s' 2019-07-17 evanhernandez@chromium.org git: Add Log function. 2019-07-17 lamontjones@chromium.org dependency.py: add board specific package. 2019-07-17 andrewlamb@chromium.org Allow commits from chromeos-ci-prod in cros_mark_as_stable. 2019-07-17 miahsanchez@google.com vm_unittest: testing start with arguments. Created with: gclient setdep -r src/third_party/chromite@68185ac0410b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I9b2f7e353ed1f6cd4e693c191b3d9ae4e9998f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707653Reviewed-by:
-
Tsuyoshi Horo authored
crrev.com/c/1681309 accidentally enabled SignedExchangePrefetchCacheForNavigations feature. Prefetched SXGs are stored to PrefetchedSignedExchangeCache even if both SignedExchangePrefetchCacheForNavigations and SignedExchangeSubresourcePrefetch are disabled. This is unintentional. Prefetched SXGs should no be stored to the cache. This CL fix this. SignedExchangePrefetchCacheForNavigations feature can be enabled only by flags. But SignedExchangeSubresourcePrefetch feature can be enabled by both flags and OriginTrial token which is checked in the renderer process. So we need |is_signed_exchange_prefetch_cache_enabled| flag in ResourceRequest to let the PrefetchURLLoader in the browser process whether the prefetched SXG should be stored to PrefetchedSignedExchangeCache. This CL adds the flag in blink::FetchParameters, blink::ResourceRequest, bink::WebURLRequest, network::ResourceRequest and network::mojom::URLRequest, and sets the flag in PreloadHelper::PrefetchIfNeeded() if SignedExchangePrefetchCacheForNavigations feature or SignedExchangeSubresourcePrefetch feature is enabled. Change-Id: I719dbbd1093e05c30b6b0075ad87f56289f00ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703687Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#678545}
-
Fergus Dall authored
When a surface is both always on top and pinned there is a bad interaction between ScreenPinningController and AlwaysOnTopController. AlwaysOnTopController will attempt to reparent a window that ScreenPinningController is positioning, causing a crash. Prevent this using AlwaysOnTopController::SetDisallowReparent. Bug: 980366 Change-Id: I99f86d43fa6092b4d6c1729de1c983178c76eb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701313 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#678544}
-
Sergey Ulanov authored
Previously WebEngine was trying to use Vulkan for all Context instances that have access to Vulkan loader service. Vulkan support is not tested properly, so it should not be enabled by default. With this change Vulkan is always disabled, but it can be enabled with a build-time flag. Bug: 962617 Change-Id: Iad0bf83e618cc5d4556b5b4ad2b526b4eb8dfa1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706684 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#678543}
-
Sadrul Habib Chowdhury authored
CompositorTimingHistory::submit_ack_watchdog_enabled_ used to be used for reporting Scheduling.*.SwapAckWasFast metrics, but these were removed in crrev.com/575177. So |submit_ack_watchdog_enabled_| field is removed in this CL. BUG=none Change-Id: I9c188e305623b9ec3214f37c603573de5682a6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706954Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#678542}
-
Gyuyoung Kim authored
After removing CString in blink, the performance degradation(1.6%) has been reported on Android Nexus6 WebView Perf bot with system_health.memory_mobile benchmark. To fix the performance regresssion, this CL makes FontFaceCreationParams::Filename() return const std::string& to avoid a copy of std::string, And also, this CL moves |fallback_data.filename| to |fallback_font->filename| by using std::move in FontCache::GetFontForCharacter(). Bug: 974762, 950077 Change-Id: I7e08f56e58b96d326982e7d4d26866d4cafab881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701628 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#678541}
-
Satoshi Niwa authored
BUG=chromium:983047 TEST=Opt-out ARC and check if SelectFileDialog is closed Change-Id: I3301d3c66b621f5cfbf1f0823bf4e9a17d6a57d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705910 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#678540}
-
Vlad Tsyrklevich authored
crashpad_tests should work on Linux and will help keep MSan, among other tests, from regressing. Bug: 932205 Change-Id: I488a0c6e0f3c1d51021b4ed7312ab703c53bae92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684301Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#678539}
-
Kai Ninomiya authored
Bug: 985135 Change-Id: I820dc3964671bbf87e9e0cbb186ea20528c0b8cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707575Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#678538}
-
Mason Freed authored
This DCHECK could be fired in a few corner cases that are actually correct. Removing it, and adding a comment. Bug: 983157 Change-Id: Ibec4f881d4a9a9c538f22f6b24187a164e15648e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707067 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678537}
-
Min Qin authored
If a download is resumed and the server immediately returns an error response that requires the download to restart, |download_file_| is not created. As a result, resuming the download will not clear up the current path, and causing the DCHECK to fail. BUG=982819 Change-Id: Ibe0832e79ca80bd2e76deba454dab2c3d8cb2be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706781 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#678536}
-
Johannes Henkel authored
New revision: d114a62e144cdfdae697fe0af6581ce39a31af37 Change-Id: I80987378dfe7b65951cfba945c5f92fb0a68d32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707170 Commit-Queue: Johannes Henkel <johannes@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#678535}
-
Antonio Gomes authored
... from content/common/media. This is part of phase 4.5 on the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ TBR=clamy@chromium.org (for content/browser mechanical changes) BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I4211d558b0c1f608537518b7a6a7b833e0e32a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706549Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#678534}
-
Yuly Novikov authored
TBR=kbr Bug: 981736 Change-Id: Ie76816fd34b898413db4018515208f9b34837c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707808Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#678533}
-
Austin Tankiang authored
Bug: 735208 Change-Id: I0deb6bc039b23401b6b3c5549d6528e0895f5aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705911Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#678532}
-
dpapad authored
This was residing in util.js and was used by icon.js (3 calls) and ntp4/new_tab.js (1 call). Given that this is icon related, moving to icon.js and updating ntp4/ accordingly. Rationale: Generic "util" files are generally an anti-pattern, and often end up as a bag of unrelated functionality. Given that icon.js already exists and holds icon-related functionality, moving getUrlForCss() over there makes sense. Bug: None Change-Id: I586b2653ba09d6d144f1d99aa9ab331f96095726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706807Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#678531}
-
Jack Steinberg authored
This change sets the groundwork for the toast closebutton, by adding an attribute to set the closebutton content, creating a closeButton property to reflect that attribute, and adding an event listener to close the toast when the closebutton is pressed. This change implements the close button API described in (https://github.com/jackbsteinberg/std-toast/blob/eec7728f7082a897d777181ac07b0448062ffca5/README.md), and is the subject of debate on issue #48 on the explainer here https://github.com/jackbsteinberg/std-toast/issues/48. Future CLs will add the closeButton option for showToast (https://github.com/jackbsteinberg/std-toast/tree/master#showtoastmessage-options) Link: https://chromium-review.googlesource.com/c/chromium/src/+/1706453 Bug: 972945 Change-Id: I5d6c3055791a9f93ef414e575e128c61e2a944ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699269Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678530}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/faec9ebf..be95495a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0c9c352bf8b86181820cc584bd3d32eefaa9f267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706454Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678529}
-
Patrick To authored
To try out this code with the Microsoft OpenXR Runtime in Chromium, perform the following steps. - Install 'Mixed Reality OpenXR Developer Preview' from the Microsoft Store - If prompted also download the compatibility pack Add the following to custom_vars in .gclient, located at the root of the chromium clone: "checkout_openxr": True Add the following to args.gn, located in the out folder: enable_openxr = true gclient sync and build Once you've built and installed Chromium go to about:flags and: - Enable WebVR or WebXR - Enable 'OpenXR Support' Bug: 976430,976436 Change-Id: I8a7c69b3a13349aa9e083d6206121b69a1f724cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688443Reviewed-by:Bill Orr <billorr@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#678528}
-
ssid authored
The java trace event strings cannot be checked for string literals at runtime. So, add a compile time check to verify that all uses are passing in string constants. A few exceptions are marked with suppress warnings. Total overhead of running the plugin is about 100ms with 20ms measurement overhead. BUG=984827 Change-Id: Ia10fe6f9f255c7402936a287bdde8b86684dbd71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705518Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#678527}
-
Kyle Milka authored
The background reset event was being logged twice. Move the logging into searchbox_extension instead of JS. Bug: 984752 Change-Id: Ibb42186dc6cb9054a3785b7818dfd99ff9f33ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707193 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#678526}
-
Xi Han authored
When comparing the metrics Servicification.Startup2 and Android.NativeBackgroundTask.TaskStarted.ReducedMode, we see a large gap for browser's cold startup in ServiceManager only mode. It is unclear whether Servicification.Startup2 loses UMA data when running in ServiceManager only mode or Android.NativeBackgroundTask.TaskStarted.ReducedMode overcounts the number of tasks that started native. In this CL, we add the metric Servicification.Startup3. The UMA data is cached in the SharedPreferences before full browser starts, which is the method that Android.NativeBackgroundTask.TaskStarted.* use. Thus, we can verify whether UMA data is lost in ServiceManager only mode and avoid this loss. Bug: 984559 Change-Id: Id0ca8adc9b1ee9c04e913123962775e4774b6bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702862Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#678525}
-
Wez authored
This reverts commit d6fe2c47. Reason for revert: This causes us to lose backtraces from crashes under the runner scripts. Although the output can be re-enabled via the --system-log-file option, that bypasses symbolization so is also not useful. Original change's description: > [Fuchsia] Remove system logging logic from RunPackage() > > Previously runner scripts implemented system logs collection in two > enabled by default, but could be turned off with --exclude-system-logs. > (2) was disabled by default, but can be turned on with > --system-log-file. (2) is enabled on the bots now. This CL removes (1) > in order to remove noice from runner script output and to simplify code. > When necessary --system-log-file=- flag can be used to get the previous > behavior. > > places: (1) in RunPackage, and (2) in Target implementations. (1) was > Change-Id: I787ff4d8ac54f5c0cd13d0e9d8a71aad05cdd45c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674668 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672180} TBR=kmarshall@chromium.org,sergeyu@chromium.org Bug: 984993 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib84af3efcb5c5859938328977a2aecb4a5428422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707051Reviewed-by:
-
Takuto Ikuta authored
Test from this builder consumes 23~24 machine hour in chrome pool per hour averagely. I took the stats from http://shortn/_EstLqOoMvH Bug: 954450 Change-Id: Ic6ea8f1f7d5b70c42d26853e3f7ce98fb3619633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703225 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#678523}
-
Sam Sebree authored
The purpose of ModuleRecordResolver::GetHostDefined has been to convert from a Module Record to the corresponding Module Script, which previously happened to always be the [[HostDefined]] -- however that is no longer the case. The root cause of the divergence from the spec is that while the spec defines [[HostDefined]] as a field on the ES Module Record, the Chromium implementation chose to define it in Blink using ModuleRecordResolver. Now that the usage of [[HostDefined]] has been expanded for other purposes, this divergence is more obvious. Therefore we propose the following to make it clear that ModuleRecordResolver functionality does not correspond to the spec's concept of [[HostDefined]]: 1) Remove the spec reference comment: "// Corresponds to the spec concept "[[HostDefined]]"." from the GetHostDefined method. 2) Change the name of the ModuleRecordResolver::GetHostDefined to GetModuleScriptFromModuleRecord. This need for this CL was exposed by a related CL: https://chromium-review.googlesource.com/c/chromium/src/+/1694604 Change-Id: Ie020443d7618803e422cb833ac6e173cfabb045f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707468 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#678522}
-
dalyk authored
Use a string constant for the User-Agent header and a wildcard for the Accept-Language header. This reduces the ability of providers to group traffic from a given user across connections but allows providers to trace the queries back to Chrome in debugging efforts. Bug: 878582 Change-Id: I9c51b7400640f7df7c0d51cb6290d6a37f564f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689398 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#678521}
-
Min Chen authored
Bug: 982950 Change-Id: I8e5a45f88daf23b7b64216e461454f97f99d3cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704678 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#678520}
-
sczs authored
- Adds a stop method to InfobarCoordinator that needs to be called by its subclasses. This nils the animatedFullscreenDisabler_ which prevents crashes while testing when trying to access it when BrowserState has been dealloced. - Adds more test cases to InfobarContainerCoordinatorUnitTests Bug: 961343 Change-Id: I9957968de7fe4f00f9e951c49bd39d885989ae62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703460 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#678519}
-
Shakti Sahu authored
Added field trial testing config for the new download backend provided by DownloadOfflineContentProvider. Also fixed the tests to run in this mode as well. Bug: NONE Change-Id: I44405ab964055dd884842411b90a3ba6e01262b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702593Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678518}
-
