- 27 Nov, 2018 40 commits
-
-
Henrique Nakashima authored
This is a reland of a061c829 Reverted due to being a suspect in crbug.com/906242, but after reverting the bug persists and was bisected to another CL. Original change's description: > Flatten UpdateMetricsUsagePrefs - skip Metrics and Reporting service. > > UpdateMetricsUsagePrefs() is a chain of calls: > - ChromeDataUseMeasurement::UpdateDataUseToMetricsService() > -> UpdateMetricsUsagePrefs() > -> MetricsService::UpdateMetricsUsagePrefs() > -> ReportingService::UpdateMetricsUsagePrefs() > -> DataUseTracker::UpdateMetricsUsagePrefs() > > It can be reduced to: > - ChromeDataUseMeasurement::UpdateDataUseToMetricsService() > -> UpdateMetricsUsagePrefs() > -> DataUseTracker::UpdateMetricsUsagePrefs() > > This removes the dependency from ChromeDataUseMeasurement to > MetricsService and ReportingService. > > Bug: 902791 > Change-Id: I38a6d22d1ff823134c79bc342ea32be0f89cda77 > Reviewed-on: https://chromium-review.googlesource.com/c/1334267 > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608567} Bug: 902791 Change-Id: I27abaac1d265e63ae5a921ab2839a77ae8582720 Reviewed-on: https://chromium-review.googlesource.com/c/1348249Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#611250}
-
Christos Froussios authored
Subprocesses set their encryption key by getting it from the browser with GetRawEncryptionKey and setting it locally with SetRawEncryptionKey Since GetRawEncryptionKey may return an empty string (e.g. because the lookup into Keychain failed), SetRawEncryptionKey should not expect that the key is never empty. Bug: 908431 Change-Id: Id9eece1bdf4492778c18178efc97380b800f5034 Reviewed-on: https://chromium-review.googlesource.com/c/1350915 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#611249}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/webui. This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 589840 Change-Id: I047edb54ce7991b4aefd3af99a89affaa53f7a56 Reviewed-on: https://chromium-review.googlesource.com/c/1351956Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611248}
-
Daniel Nicoara authored
When creating a video frame for the video hole, the compositor creates a TextureDrawQuad. This is generic enough that the overlay strategy can't distinguish between a video frame and a EXO texture. Add a hint to the TextureDrawQuad that the video frame requires an overlay and use that to differentiate the video hole quad. TBR=kaznacheev@chromium.org hole. correctly. Bug: 899246 Test: Ran on device and ensured EXO content doesn't trigger the video Test: Ran updated viz_unittests to verify new strategy filters content Change-Id: I4e275550efa287fd2b491d31028a1dead9fbc053 Reviewed-on: https://chromium-review.googlesource.com/c/1316088 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#611247}
-
Scott Violet authored
This reverts commit e45a6ef0. Reason for revert: This triggers DCHECKs on device, so reverting. Here's the stack: [13255:13255:1127/111259.548287:FATAL:tray_bluetooth_helper.cc(50)] Check failed: !timer_.IsRunning(). #0 0x5abde8c02cef base::debug::StackTrace::StackTrace() #1 0x5abde8b586cb logging::LogMessage::~LogMessage() #2 0x5abdeb50f0a5 ash::TrayBluetoothHelper::StartOrStopRefreshingDeviceList() #3 0x5abde9b4ac48 device::BluetoothAdapter::NotifyAdapterPoweredChanged() #4 0x5abde9b55a5f bluez::BluetoothAdapterBlueZ::SetAdapter() #5 0x5abde9b7d3d5 bluez::BluetoothAdapterClientImpl::ObjectAdded() #6 0x5abde9a471be dbus::ObjectManager::AddInterface() #7 0x5abde9a46d2e dbus::ObjectManager::UpdateObject() #8 0x5abde9a457fb dbus::ObjectManager::OnGetManagedObjects() #9 0x5abde505efdc _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos14BiodClientImplEFvPN4dbus6SignalEEJNS_7WeakPtrIS4_EEEEEFvS7_EE3RunEPNS0_13BindStateBaseES7_ #10 0x5abde9a486bf dbus::ObjectProxy::OnCallMethod() #11 0x5abde9a4cb43 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEESD_NS_12OnceCallbackIFvPNS3_8ResponseEEEESG_PNS3_13ErrorResponseEEJ13scoped_refptrIS4_ESB_SB_SI_EEEFvSG_SK_EE7RunOnceEPNS0_13BindStateBaseESG_SK_ #12 0x5abde9a49074 dbus::ObjectProxy::RunResponseOrErrorCallback() #13 0x5abde9a4db5e _ZN4base8internal13FunctorTraitsIMN4dbus11ObjectProxyEFvNS3_19ReplyCallbackHolderENS_9TimeTicksEPNS2_8ResponseEPNS2_13ErrorResponseEEvE6InvokeISB_13scoped_refptrIS3_EJS4_S5_S7_S9_EEEvT_OT0_DpOT1_ #14 0x5abde9a4da80 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvNS4_19ReplyCallbackHolderENS_9TimeTicksEPNS3_8ResponseEPNS3_13ErrorResponseEEJ13scoped_refptrIS4_ES5_S6_S8_SA_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #15 0x5abde8bd218b base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply() #16 0x5abde8bd260b _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEJS4_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #17 0x5abde8c28597 base::debug::TaskAnnotator::RunTask() #18 0x5abde8b6242f base::MessageLoopImpl::RunTask() #19 0x5abde8b62ae2 base::MessageLoopImpl::DoWork() #20 0x5abde8c24189 base::MessagePumpLibevent::Run() #21 0x5abde8b61f05 base::MessageLoopImpl::Run() #22 0x5abde8b8c576 base::RunLoop::Run() #23 0x5abde86a22e5 ChromeBrowserMainParts::MainMessageLoopRun() #24 0x5abde5eebb04 content::BrowserMainLoop::RunMainMessageLoopParts() #25 0x5abde5eee503 content::BrowserMainRunnerImpl::Run() #26 0x5abde5ee828f content::BrowserMain() Original change's description: > bluetooth: Query for devices every second in TrayBluetoothHelper > > Before TrayBluetoothHelper would get notified of any changes to devices. > This caused problems in busy environments because TrayBluetoothHelper > would get notified hundreds or even thousands of times per second of > devices changes. > > This CL changes to a "pull" pattern where TrayBluetootHelper queries > for devices every second. The devices are then cached so that clients > of TrayBluetoothHelper can access them synchronously. > > TrayBluetoothHelper queries for devices as long as the state is > kPoweredOn. If the state changes, the device list is cleared. > > Bug: 882346 > > TEST=The following actions should be performed: > > 1. Turn bluetooth on and off in system tray. > 2. Open device list in system menu. > 3. Connect to a device. > 4. See that the pod feature button in the system tray indicates a > device is connected when connected to a device. > > Change-Id: Id9028546a627f260527aa737f51c032f74a447ec > Reviewed-on: https://chromium-review.googlesource.com/c/1347638 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611069} TBR=ortuno@chromium.org,tetsui@chromium.org Change-Id: I5b5ca3f227ab7616321047b3a8ade17bfa30b29a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882346 Reviewed-on: https://chromium-review.googlesource.com/c/1352340Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#611246}
-
David Bokan authored
If we have a candidate implicit root scroller, we should only promote it if it doesn't have a scrollable ancestor. The reason for this is that we end scroll chaining at the root scroller. This is necessary as the root scroller consumes all scroll in the form of overscroll effects. A (user) scrollable ancestor would be broken in this case, as shown in the example on the attached bug. Note: overflow in an ancestor is still allowed, as long as its overflow style is hidden or visible. Bug: 837007 Change-Id: Ied7a9f02eab76c4ea59fced94d0804ba47ef4e4a Reviewed-on: https://chromium-review.googlesource.com/c/1351590Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611245}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/translate. This CL was uploaded by git cl split. R=toyoshim@chromium.org Bug: 589840 Change-Id: Ia199152845344221db491b895f44ea5a885046f1 Reviewed-on: https://chromium-review.googlesource.com/c/1351080Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/115df409efa1..bd884bbd8385 git log 115df409efa1..bd884bbd8385 --date=short --no-merges --format='%ad %ae %s' 2018-11-27 yueherngl@google.com octopus: add firmware branch builder Created with: gclient setdep -r src/third_party/chromite@bd884bbd8385 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4ce842c0195caca7a5bba293c2d54fd67526303e Reviewed-on: https://chromium-review.googlesource.com/c/1352240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611243}
-
Seth Hampson authored
Bug: 874296 Change-Id: I33e79a0641e38b420a23d0ff42933cd26bc0b368 Reviewed-on: https://chromium-review.googlesource.com/c/1341153 Commit-Queue: Seth Hampson <shampson@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#611242}
-
Charlie Harrison authored
Simple CL which moves more control of the radio group into the actual RadioGroup struct rather than the owning class. Also: - Removes unused |title| member - Constructs radio items using initializer lists. Bug: None Change-Id: I421e42f044a89bd1dd87bb11130d79b18aefe144 Reviewed-on: https://chromium-review.googlesource.com/c/1351504Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#611241}
-
David Bienvenu authored
This CL attempts to handle the unexpected situation we were CHECKING for. The windows native window occlusion finch experiment is causing a lot of check fails with |window_is_moving_| true when we receive a EVENT_SYSTEM_MOVESIZESTART event. I'm unable to reproduce this, but this CL should prevent us from getting stuck in the |window_is_moving_| state while still avoiding calculating occlusion during moves. Also attempt to detect when we've possibly missed an end move event, because we got an unexpected event while we think we're moving, and set |window_is_moving_| to false. I've also moved the setting of |window_is_moving_| to false at the start of UnregisterEventHooks in the unlikely event that UnhookWinEvent is causing the event hook callback to get called reentrantly. Some crash reports show UnregisterEventHooks on the stack, but looking at the same crash dump in VS doesn't show UnregisterEventHooks. Bug: 907365 Change-Id: Iec41dbbe656d0acea0c161b45ec5b7812eb32233 Reviewed-on: https://chromium-review.googlesource.com/c/1348829Reviewed-by:
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/web. This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 589840 Change-Id: Ide0379a61902c122eb75481ea4902a0b777ee76f Reviewed-on: https://chromium-review.googlesource.com/c/1351078Reviewed-by:
-
Tatiana Buldina authored
Bug: chromedriver:2676 Change-Id: I41dcde8b296c5eacf6a49c6c37faf9de2e8f3202 Reviewed-on: https://chromium-review.googlesource.com/c/1351879Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#611238}
-
Francois Doray authored
The imprecise logging caused confusion in the interpretaion of at least one user report. Change-Id: I50a80ef6e322072ae9143f11e6e86b314d1fb263 Reviewed-on: https://chromium-review.googlesource.com/c/1349771Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#611237}
-
Sam Maier authored
Bug: 872904 Change-Id: Ia376f6beb1072d46189954decf7696cb980b4639 Reviewed-on: https://chromium-review.googlesource.com/c/1340364Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#611236}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: Ida42b8e93e569176ddfdaeeb961d3dd50b4e6fd0 Reviewed-on: https://chromium-review.googlesource.com/c/1352435Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#611235}
-
Peter Boström authored
Avoids having additional high-frequency post tasking for no-op tasks in the background. To keep track of when to stop animating without an AnimationEnded callback, we keep track of the last-drawn animation state. This also has the side effect of allowing us to avoid repainting the loading-progress bar if would paint the same pixels we drew last time. This should avoid a lot of repaints for slow-loading sites. This also ends up fixing backwards-jumping indicators. Probably because the logic for clamping the loading-progress timer got easier. Bug: chromium:907044, chromium:905020, chromium:905452 Change-Id: Ic83748bad83115ef2283c881a89ed65e3d3938ab Reviewed-on: https://chromium-review.googlesource.com/c/1346831Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#611234}
-
Mohamed Amir Yosef authored
Bug: 902349 Change-Id: Ibd685911d52ae19c62b06caf47688abad081d243 Reviewed-on: https://chromium-review.googlesource.com/c/1333760 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#611233}
-
Georges Khalil authored
Change-Id: Icfd4b43ed64252e0530ee033fc06f12186bcc2b6 Reviewed-on: https://chromium-review.googlesource.com/c/1347059Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#611232}
-
Sergey Poromov authored
Previously "CorruptPolicyExtensionDetected" was reported every time when policy extension was corrupted even if it's already scheduled to be reinstalled. So it might've lead to multiple "CorruptPolicyExtensionDetected" events per one "CorruptPolicyExtensionResolved" event. Now when new entry is added to |expected_policy_reinstalls_| map, one metric is reported, when removed - another, so it's more 1:1. Change-Id: I2cb4ad2ae043f4ad01d061c8eb63614a24db0a4a Reviewed-on: https://chromium-review.googlesource.com/c/1335604 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611231}
-
Andrey Lushnikov authored
Start using disk cache directory for default headless profile. Bug: 882431 Change-Id: I1790a58fa2da6cb0fd114897d082e289d7a01bc5 Reviewed-on: https://chromium-review.googlesource.com/c/1350881Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#611230}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/reading_list. This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 589840 Change-Id: Ia0b05a38e3daa883a1ebb3d2255df84d9f30eb45 Reviewed-on: https://chromium-review.googlesource.com/c/1351953Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611229}
-
Alexei Filippov authored
The current 1024-bit keys do not work with openssl 1.1.1 BUG=907677 Change-Id: I9abce240d09fc0baf6ea567d71f37c48787b3ceb Reviewed-on: https://chromium-review.googlesource.com/c/1347201Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#611228}
-
Kristi Park authored
Move the ripple animation handler to a new animations file, and move common helper functions into a new utils file. This enables us to add ripple animations to the edit custom link dialog buttons. Bug: 874201 Change-Id: I5e3d72bf3fa282faf0068122f1a660e8ad72bab3 Reviewed-on: https://chromium-review.googlesource.com/c/1347776 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611227}
-
Yuli Huang authored
BUG=908458 Change-Id: I14d61f5fd122c77e0e46d170d7930fc52205937d Reviewed-on: https://chromium-review.googlesource.com/c/1351329Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: yuli <yuli@chromium.org> Cr-Commit-Position: refs/heads/master@{#611226}
-
Andrew Grieve authored
Change-Id: I1e43c4b3b66fe1f90ab110dbf7299dce9813288e Reviewed-on: https://chromium-review.googlesource.com/c/1349870 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#611225}
-
Denis Kuznetsov authored
If language is changed, this change should be performed before rest of OOBE configuration is applied (e.g. input method value can be only relevant for new language, so setting it before language change is resolved would not be possible) Bug: 854101 Change-Id: Ib7e7db058470683d649bfb775c65276141e226fc Reviewed-on: https://chromium-review.googlesource.com/c/1350892 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#611224}
-
Mario Sanchez Prada authored
As discussed in the review for CL1326151, there is no need to do this explicitly on dealloc() since the std::unique_ptr for this object will be destroyed as part of the deallocation. Thus, we're removing the call to .reset() to prevent further confusion. Bug: 903262 Change-Id: Iec51c701501de948d32ce557ca37a7850db7b107 Reviewed-on: https://chromium-review.googlesource.com/c/1337611Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#611223}
-
Becky Zhou authored
+ Change buttons to ButtonCompat + Change button bar to DualControlLayout so that it is more consistent with other button bars + Adjust padding to match the current spec Bug: 856244 Change-Id: I8bd1d211a27fa47769286cf565a627da65657f57 Reviewed-on: https://chromium-review.googlesource.com/c/1351790Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#611222}
-
Mike Dougherty authored
Disabling this feature is no longer a valid working state as it breaks the autofill keyboard accessory. Bug: None Change-Id: Ic5bb57e420567c690aff36245cb47b2c508a15e0 Reviewed-on: https://chromium-review.googlesource.com/c/1305239 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#611221}
-
Mustaq Ahmed authored
- Turns on UAv2 by default, - copies test expectations from the virtual to main test suite, and - changes few test expectations. Intent to Ship discussion: https://groups.google.com/a/chromium.org/d/msg/blink-dev/nkTDR8AUlwM/xsPcojA5BAAJ Bug: 904991 Change-Id: I213b5a723ffe08b859170ae8dfb539eee84ffaf3 Reviewed-on: https://chromium-review.googlesource.com/c/796938Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Min Chen authored
Bug: 890531 Change-Id: Iacf0199ed5b41dce8557d8f9daaf79ad8fa29c27 Reviewed-on: https://chromium-review.googlesource.com/c/1351578Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#611219}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/metrics. This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 589840 Change-Id: I47b0535e525d6ad8c442f0ac2953324d979c1cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1351075Reviewed-by:
-
Adrienne Walker authored
There was a recent issue where this was happening due to cache bugs. This is something that should never happen, so it would be nice to have it be more noisy when it fails. Bug: 906510 Change-Id: Ie4e8aaf415c491d4ba192d1b57c115cec7d81ca9 Reviewed-on: https://chromium-review.googlesource.com/c/1351386Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#611217}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0da9494a4fe9..0bd32409b7b7 git log 0da9494a4fe9..0bd32409b7b7 --date=short --no-merges --format='%ad %ae %s' 2018-11-27 cwallez@chromium.org Run mac-dawn-rel on the CQ Created with: gclient setdep -r src/third_party/dawn@0bd32409b7b7 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:901830 TBR=cwallez@chromium.org Change-Id: I97cee36d91fb5a9fc35f414af92e9066b6ab9e0f Reviewed-on: https://chromium-review.googlesource.com/c/1352238Reviewed-by:
-
Shawn Gallea authored
Prevented ChromeOS-specific funcionality in seat.cc from compiling for other platforms. To be used for EXO on cast shell. Added shell_surface_util, containing utility functions previously included in shell_surface_base, needed for exo on cast. TBR=yusukes@chromium.org Bug: 896710 Test: Run exo_unittests and unit_tests on ChromeOS build. Change-Id: I3d66b09a6e236e731913ecc77cd0fdbe7937e74a Reviewed-on: https://chromium-review.googlesource.com/c/1327562 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#611215}
-
Max Moroz authored
Ran `tools/clang/scripts/upload_revision.py 346388 5`. Bug: 870331 Change-Id: Id09c926a34194487757e641283f63fb63a614436 Reviewed-on: https://chromium-review.googlesource.com/c/1351029 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#611214}
-
Lukasz Suder authored
When default Email is available (defined as email used to start Autofill Assistant) it is used to change the order of Profiles inside Payment Request. The Profiles containing this email will be displayed on top, making them a default choice. Bug: 806868 Change-Id: Iae54abcf009a563a120a6afa09ef02187a82abd8 Reviewed-on: https://chromium-review.googlesource.com/c/1350955 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611213}
-
Wez authored
This reverts commit 912050e1. Reason for revert: Fuchsia SDK believed to be the cause of these failures; speculatively reverting to re-enable the tests to evaluate. Original change's description: > Disable all tests in FrameImplTest. > > Almost all have been reported as flaky. Disable all to avoid having > reports coming in from whichever subtest was not reported yet. Caused a > lot of red jobs on the Fuchsia x64 bot. > > TBR=wez@chromium.org > > Bug: 907804 > Change-Id: I2fb4da79bf1e4251e14900ef4cabb890b7b3380d > Reviewed-on: https://chromium-review.googlesource.com/c/1349315 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610580} TBR=wez@chromium.org,futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 907804, 907859, 907717 Change-Id: I72103faff6457a93136925afdab9d7f003061369 Reviewed-on: https://chromium-review.googlesource.com/c/1351100 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#611212}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/download. This CL was uploaded by git cl split. R=sdefresne@chromium.org Bug: 589840 Change-Id: I60b22d3a7b65e614f6109a5d2a79baabe986724f Reviewed-on: https://chromium-review.googlesource.com/c/1351076Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611211}
-
