GitLab

Adds tests for code in https://codereview.chromium.org/322553005/
Also, update stylesheet to restrict max video size.
BUG=376107
TBR=blundell

Review URL: https://codereview.chromium.org/318723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276842 0039d316-1c4b-4281-b951-d872f2087c98

When the mime_type_handler key is available in an extension, this creates a
BrowserPlugin and gives the ID of it to the background page.

BUG=368514

Review URL: https://codereview.chromium.org/263513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276841 0039d316-1c4b-4281-b951-d872f2087c98

Add the about_page key to the manifest for shared modules. This will
later be used to display the license information for shared module apps.

BUG=364681

Review URL: https://codereview.chromium.org/311193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/303043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276839 0039d316-1c4b-4281-b951-d872f2087c98

Moves gcm_invalidation_bridge and ticl_invalidation_service files from
chrome/browser/sync to components/invalidation.

Refactors TiclInvalidationService so it no longer depends on
chrome/common/chrome_content_client.h.  Its only dependency on this file
was a call to GetUserAgent().  It was removed by changing the class so
that the user agent is specified at construction time.

Moves some related tests and test framework classes into
components/invalidation.

Updates the gyp files to prevent much of the TICL invalidation service
code from being built on Android.  This is the same setup as before the
move, though it does fix a bug where one of the previously componentized
files was accidentally enabled for building on Android.

BUG=336571

Review URL: https://codereview.chromium.org/319223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276838 0039d316-1c4b-4281-b951-d872f2087c98

I forgot to do this in r276708.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/334663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276837 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Telemetry: Build symfs for Android VTune profiler (https://codereview.chromium.org/308123002/)

Reason for revert:
This breaks ChromeOS build at
http://build.chromium.org/p/chromiumos.chromium/builders/X86%20%28chromium%29...

16:09:25 INFO | autoserv|
FAIL	login_Cryptohome	login_Cryptohome	timestamp=1402607364	localtime=Jun 12
14:09:24	Unhandled ImportError: No module named sqlite3
16:09:25 INFO | autoserv| AUTOTEST_STATUS::  Traceback (most recent call last):
16:09:25 INFO | autoserv| AUTOTEST_STATUS::    File
"/usr/local/autotest/common_lib/test.py", line 725, in _call_test_function
16:09:25 INFO | autoserv| AUTOTEST_STATUS::      return func(*args, **dargs)
...
16:09:25 INFO | autoserv| AUTOTEST_STATUS::    File
"/usr/local/telemetry/src/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py",
line 12, in <module>
16:09:25 INFO | autoserv| AUTOTEST_STATUS::      import sqlite3
16:09:25 INFO | autoserv| AUTOTEST_STATUS::  ImportError: No module named
sqlite3

ChromeOS image does not have sqlite3. Please either file a bug (cc vapier@) to
add sqlite3. Or skip the sqlite3 logic for chromeos.

I suggest to revert this for now so that it does not shadow other failures.

Please use 

cbuildbot --remote -G <rietveld_id> x86-generic-tot-chrome-pfq-informational
amd64-generic-tot-chrome-pfq-informational daisy-tot-chrome-pfq-informational

to ensure the CL runs fine on ChromeOS when landing the new version.

Original issue's description:
> Telemetry: Build symfs for Android VTune profiler
> 
> Extend and use android_profiling_helper.py to set up a symfs for VTune.
> Queries the required libraries from the profiler's output and pulls them from
> the device. This allows VTune to resolve all symbols in the profiling output.
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276740

TBR=skyostil@chromium.org,simonhatch@chromium.org,tonyg@chromium.org,xiyuan@chromium.org,dominikg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/337603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276836 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/333443002 has landed, reactivate building
browser_tests.exe for official Windows builds.

BUG=379986

Review URL: https://codereview.chromium.org/328423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276835 0039d316-1c4b-4281-b951-d872f2087c98

This change caused the sole push_messaging layout test to fail :(.

> Hook PushMessagingMessageFilter up to GCMDriver
>
> Add plumbing for registration from push service-agnostic content layer
> to GCMDriver in chrome layer.
>
> To achieve this, GCMProfileService owns an implementation of a new
> PushMessagingService class, which can be used from the content layer.
>
> Based on mvanouwerkerk's prototype in https://codereview.chromium.org/186023002, but significantly refactored.
>
> BUG=350384
> TBR=benm@chromium.org

TBR=johnme@chromium.org
BUG=350384

Review URL: https://codereview.chromium.org/327423006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276834 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276833 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Broke compile step on http://build.chromium.org/p/chromium.linux/builders/Android%20Webview%20AOSP%20Builder/builds/12011

Compile error message:

Export includes file: external/chromium_org/GypAndroid.linux-arm.mk -- out/target/product/generic/obj/STATIC_LIBRARIES/third_party_webrtc_modules_PCM16B_gyp_intermediates/export_includes
make: *** No rule to make target `/mnt/data/b/build/slave/Android_Webview_AOSP_Builder/build/android-src/out/target/product/generic/obj/STATIC_LIBRARIES/libvpx_asm_offsets_vp8_intermediates/libvpx_asm_offsets_vp8.a', needed by `out/target/product/generic/obj/GYP/third_party_libvpx_gen_asm_offsets_vp8_gyp_intermediates/vp8_asm_enc_offsets.o'.  Stop.


Original issue's description:
> Roll libvpx 269083:275816 webrtc 6352:6415
> 
> libvpx:
> See https://codereview.chromium.org/295313002/
> https://codereview.chromium.org/298063002/
> https://codereview.chromium.org/305533008/
> https://codereview.chromium.org/305703002/
> https://codereview.chromium.org/298383003/
> https://codereview.chromium.org/302863004/
> https://codereview.chromium.org/320923003/
> for the actual changes.
> 
> webrtc:
> See https://codereview.chromium.org/313243004/
> for the actual changes.
> 
> BUG=377062
> R=ajm@chromium.org, tomfinegan@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276820

TBR=fgalligan
NOTRY=true

Review URL: https://codereview.chromium.org/330193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276832 0039d316-1c4b-4281-b951-d872f2087c98

Moves some test support classes out of the NonBlockingTypeProcessor's
unit test .cc files and into their own files.

Rearranges some responsibilities between the test harness and the mock
classes.  Much of the functionality related to mocking out server
behavior has been moved into the MockNonBlockingTypeProcessor.  This
makes it possible to share that code with other test harnesses.

This is one of several follow-ups to the commits that introduced the
NonBlockingTypeProcessor and NonBlockingTypeProcessorCore.

BUG=351005

Review URL: https://codereview.chromium.org/318193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276830 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383956
TBR=thestig
NOTRY=true

Review URL: https://codereview.chromium.org/335453005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276828 0039d316-1c4b-4281-b951-d872f2087c98

original code review at:
https://codereview.chromium.org/245763002/

Review URL: https://codereview.chromium.org/269513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276827 0039d316-1c4b-4281-b951-d872f2087c98

This also fixes the yasm build on Windows (where the default toolchain isn't the host toolchain).

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/336683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276826 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Change HistoryService::QueryURL to use CancelableTaskTracker (https://codereview.chromium.org/314293005/)

Reason for revert:
Break Clank ToT build:

https://uberchromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/29577/steps/compile/logs/stdio

Original issue's description:
> Change HistoryService::QueryURL to use CancelableTaskTracker
> 
> The callback no longer receive an HistoryService::Handle as first parameter
> and the caller should use the returned base::CancelableTaskTrasker::TaskId
> to cancel a request early.
> 
> Instead of passing a CancelableRequestConsumer to the query, the caller
> pass a base::CancelableTaskTracker. The lifetime of the callback can be
> associated to the request by using base::Passed().
> 
> Remove unused types and fix usage of the values passed to the result
> callback (check success before using the URLRow or the VisitVector).
> 
> BUG=371818
> TBR=bauerb,sky,asargent,gavinp,shess,pkasting
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276739

TBR=blundell@chromium.org,bauerb@chromium.org,sky@chromium.org,asargent@chromium.org,gavinp@chromium.org,shess@chromium.org,pkasting@chromium.org,sdefresne@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=371818

Review URL: https://codereview.chromium.org/330703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276825 0039d316-1c4b-4281-b951-d872f2087c98

We were aggresively cancelling re-transmission before. This caused an
ill effect with duplicated ACKs that some packets are not transmitted.
This change adds a boolean to control whether or not to cancel rtx.

Review URL: https://codereview.chromium.org/322953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276824 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375955
For trivial renaming:

R=armansito@chromium.org, pneubeck@chromium.org
TBR=derat@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/289383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276822 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276821 0039d316-1c4b-4281-b951-d872f2087c98

libvpx:
See https://codereview.chromium.org/295313002/
https://codereview.chromium.org/298063002/
https://codereview.chromium.org/305533008/
https://codereview.chromium.org/305703002/
https://codereview.chromium.org/298383003/
https://codereview.chromium.org/302863004/
https://codereview.chromium.org/320923003/
for the actual changes.

webrtc:
See https://codereview.chromium.org/313243004/
for the actual changes.

BUG=377062
R=ajm@chromium.org, tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/299313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276820 0039d316-1c4b-4281-b951-d872f2087c98

This adds the --urls flag which accepts a space-separated list of urls
to distill.

This adds a pretty straightforward approach to having multiple of these
requests happening at the same time.

Once all requests are finished, they will be printed (in the order that
they appeared in --urls). If printing binary, each serialized protobuf
will be preceded by its size (as a varint32).

TBR=ben@

Review URL: https://codereview.chromium.org/276553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276819 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/331753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276818 0039d316-1c4b-4281-b951-d872f2087c98

There is no old version of bionic for x64.

BUG=346626

Review URL: https://codereview.chromium.org/335623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276817 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of r275819 https://codereview.chromium.org/317253003 but without compiling it on Android.

TBR=scottmg

Review URL: https://codereview.chromium.org/338493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276816 0039d316-1c4b-4281-b951-d872f2087c98

False start should not disable the session cache, but if we never process the
server Finished message, the session cannot be resumed.

BUG=none

Review URL: https://codereview.chromium.org/301283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276815 0039d316-1c4b-4281-b951-d872f2087c98

The BookmarkEntity class always represents a Bookmark, so there's no
reason to have a ModelType param as part of its constructor.

BUG=NONE

Review URL: https://codereview.chromium.org/319823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276814 0039d316-1c4b-4281-b951-d872f2087c98

Add hide/show functions for the callout widgets on the panel manager, and use
them from WindowSelectorPanels to control them.

BUG=377775
TEST=WindowSelectorTest.WindowOverviewHidesCalloutWidgets

Review URL: https://codereview.chromium.org/327873005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276813 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276810 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176012:176039&mode=html
TBR=yhirano@chromium.org,dpranke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/328403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276809 0039d316-1c4b-4281-b951-d872f2087c98

Many message loops in Chrome are backed by MessagePumpDefault which uses a WaitableEvent object to sleep, this is ultimately implemented as a pthread condition variable on POSIX.

In order to support timer coalescing in MessageLoops we need to sleep using a primitive which supports timer coalescing at the OS level (support for timer coalescing goes down into the kernel on Android/Linux/OSX/Win).  The current change achieves this and should provide a way to gauge the effect of timer coalescing.

An alternate approach to this patch would be to implement MessagePumpDefault using a primitive which supports timer coalescing.

Local performance tests didn't uncover any regressions from this change.

BUG=356804

Review URL: https://codereview.chromium.org/331513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276808 0039d316-1c4b-4281-b951-d872f2087c98

Add shadows to the windows in overview mode. The shadows are destroyed when
going out of overview mode.

BUG=376353
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/335673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276807 0039d316-1c4b-4281-b951-d872f2087c98

(This makes mojo_shell_tests not hang.)

R=sky@chromium.org

Review URL: https://codereview.chromium.org/336483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276806 0039d316-1c4b-4281-b951-d872f2087c98

mathp since he's a chromium veteran and wrote/knows the code

BUG=

Review URL: https://codereview.chromium.org/336493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276805 0039d316-1c4b-4281-b951-d872f2087c98

When synchronizing page scale values between trees, setting the page scale
factor and deltas seperately means that the observer functions called when
the page scale factor was changed get called with a transient, incorrect
total page scale factor. This CL combines the seperate methods for updating
the page scale factor and page scale delta into one and updated tree
synchronizations to use this new one-shot function. The old methods remain
but call into the newly added method.

BUG=366249

Review URL: https://codereview.chromium.org/315003009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276804 0039d316-1c4b-4281-b951-d872f2087c98

Prior to this patch the server would not notify the client of a new
root if the client already knew about the root. Now it always
notifies.

Here's an example of this case: two nodes, A and B with B a child of
A and A the root for the client. If B is added as a root then
previously I would not send B in OnRootsAdded. Now I do.

BUG=365012
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/323413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276803 0039d316-1c4b-4281-b951-d872f2087c98

I'd like to simplify the OpenResource implementation for the Non-SFI case. I
think that this can all stop using the trusted plugin now; this change makes
the ManifestResolveKey method easier to use from within
ppb_nacl_private_impl.cc.

BUG=239656

Review URL: https://codereview.chromium.org/329593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276802 0039d316-1c4b-4281-b951-d872f2087c98

This flag will be used to make the builds determinist, e.g. in place like this one: https://code.google.com/p/chromium/codesearch#chromium/src/base/build_time.h&l=15

BUG=314403

Review URL: https://codereview.chromium.org/324403006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276801 0039d316-1c4b-4281-b951-d872f2087c98

The ConnectionFactory::ConnectionListener gets informed of connection events,
including the actual ip endpoint with which a connection was established. This
will eventually be hooked up to app handlers to allow services to act on
connection changes. For now it just allows the debug page to more accurately
reflect the connection state.

BUG=377882

Review URL: https://codereview.chromium.org/317723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276800 0039d316-1c4b-4281-b951-d872f2087c98

This function made unnecessary use of the render
target and didn't walk its clipping ancestor
chain correctly. This CL refactors the function
and fixes that walk (and adds test to show that
the walk is correct).


R=danakj@chromium.org

Review URL: https://codereview.chromium.org/328753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276799 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383089
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/335673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276797 0039d316-1c4b-4281-b951-d872f2087c98