- 26 Nov, 2019 40 commits
-
-
Natalie Chouinard authored
The "Added Symbols named -ForTest" check is no longer disabled. Change-Id: I3b42550f138de7146627591b5dc4b48d2406e2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937861 Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#719389}
-
Olga Gerchikov authored
Implemented common mechanism for targeting animation events initiated by animations and worklet animations. Changes made: - AnimationHost::SetAnimationEvents consults animation timeline to find a target animation. - Moved animation events routing logic from cc:ElementAnimations to cc:Animation. - Directly route to the target keyframe model using keyframe id and model id instead of using element id and group id to identify the target keyframe model. Bug: 1013727 Change-Id: I28613b0e708258e6433a45e828710caa3e73e280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872486 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719388}
-
Benjamin Beaudry authored
This is a reland of 507f4ee8 It seems like CL:1935027 caused the failures and the revert. Once this change relands with a fix (CL:1935212), I'll reland this one. Original change's description: > Do not return InlineTextBox nodes from UIA GetEnclosingElement > > In AXPlatformNodeTextRangeProviderWin, nodes with role kInlineTextBox > should never be exposed to UIA. This CL introduces a simple fix. > > In GetEnclosingElement(), if the enclosing node is an inline text box, > we simply return its parent. I also updated a unit test for this case. > > Bug: 928948 > Change-Id: I31a31566461c3091bed36ebad626c4f51afc55a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931753 > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#718920} Bug: 928948 Change-Id: I6dbac3eae0a17d29f13c3d6b75532018729782de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937134Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#719387}
-
Piotr Bialecki authored
Change-Id: Ifea3556a96b99f27a13c6ba0b3785d4ddefe28a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937351 Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#719386}
-
Wez authored
Chromium's GN rules generator previous generated GN targets with names based on the last part of FIDL library names. This could lead to target name clashes, so switch to using fully-qualified target names. To allow soft migration of [public_]deps targets are also emitted for most of the old names, for now. Bug: fuchsia:42135 Change-Id: Ic63f423bbe934ff346fda625eff1b060450f573b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937767 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719385}
-
Jeremy Roman authored
Bug: 1013389 Change-Id: I71e8a014660b6144c7f8a13c11bb6e692e331487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937856 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#719384}
-
Devlin Cronin authored
The ExtensionSpeed field trial was used to introduce a delay between extension host starts (to reduce jank). This field trial has been expired for some time. Remove its usage from the code. Bug: 1028334, 477445 Change-Id: I963c0fa9236b86a4fd8c6c6d90296c9b00d8a360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937347 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719383}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for CompositorFrameSinkClient and CompositorFrameSink from SynchronousLayerTreeFrameSink and uses PendingReceiver, Receiver, and PendingRemote instead of them. Bug: 955171 Change-Id: Id0aa5d5dc2409a1de878764514b599a12dcce46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935973Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#719382}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for blink::mojom::AecDumpManager using PendingReceiver instead of InterfaceRequest. Bug: 955171 Change-Id: I62a57912cf87ffc41c16c153c7ecf353378cfbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935275Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#719381}
-
Yue Zhang authored
* Separate feature related logic so that Duet and Adaptive toolbar can be enabled when flags of TabGroup and Duet-TabStrip integration are both on. * Modify the logic in ToolbarManager so that this CL should be no-op when new flag is off and expose integration functionality when new flag and duet are both turned on. * Setup up the basic structure of TabGroupPopUi component and specify the entry point and dependencies. TBR=mdjones@chromium.org Bug: 1022827 Change-Id: I6e99ec73b5603688c40dc884f8dbdc450961bf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935490Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#719380}
-
Dave Tapuska authored
Add 3 use counters to track the following usages 1) Different Agent Clusters 2) Same Agent Clusters 3) Same Origin Adds counters for https://github.com/whatwg/html/issues/4920 Change-Id: Ia9aeb1afb1f355790c5dfb549f1e2459d95d98ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925218 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#719379}
-
Erik Chen authored
If the build configurations supports stripping of absolute paths from debug symbols by default, then it cannot be disabled. If it's causing problems, then the user should file a bug. This was prompted by this discussion thread: https://groups.google.com/a/chromium.org/d/msg/chromium-dev/kE1HeGL4mj0/w_E5OCRLAwAJ where a user disabled the configuration when the real problem was that they were using Xcode 10.1, which had a bug that was fixed in Xcode 10.3. Change-Id: I87598a84bf0c16d777114774656fc9b0b06999ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898778 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#719378}
-
Erik Chen authored
Each of the test suites modified had a per-shard runtime of more than 10 minutes. This CL updates all of them to have expected runtimes of 10 minutes, while still keeping overhead below 10%. Timings come from: https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/430164 Pre-patch runtimes, timings from https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/430164 interactive_ui_tests [31 minutes, 35 second overhead] content_browsertests [24 minutes, 35 second overhead] cc_unittests [21 minutes, 13 second overhead] components_unittests [17 minutes, 41 second overhead] webkit_unit_tests [17 minutes, 22 second overhead] Bug: 1028289 Change-Id: I3254bdb3f26e07a5eec77da4633cd6e0ea1d8311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937574 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#719377}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5b2740c57090..88752889c721 git log 5b2740c57090..88752889c721 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 syoussefi@chromium.org Vulkan: Fix barriers w.r.t sampled->storage image update Created with: gclient setdep -r src/third_party/angle@88752889c721 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I5e35454f74446c6be9157c54fc18775418f99731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937869Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719376}
-
Javier Ernesto Flores Robles authored
Bug: 1028095 Change-Id: I6ca136c360e3ad62a171445f2a8e256b248a4d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937327 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#719375}
-
Maks Orlovich authored
A null site_for_cookies means the containing frame is already cross-site, not that it's top-level. (And it's impossible to see from it whether it's same-site with a resource --- for purposes of cookies everything below is third-party) Also simplify the function to not distinguish 5 cases when it's only used to tell 2 apart. Bug: 1006328 Change-Id: I41d46e990fe9afe78ba502a76b85621dce74d8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932088Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#719374}
-
Mike Wittman authored
Adds the infrastructure to support a dynamic feature module for Android stack unwinding. This module will provide the native code implementation of a stack unwinder supporting unwinding of stack frames corresponding to native system libraries and Java code. This CL contains just the infrastructure to set up the DFM, which is derived from the existing 'test dummy' DFM. The stack unwinder implementation and the use of the module from Chrome code are deferred to later CLs. Bug: 1027654 Change-Id: I4b5dca1294fa1aa8197eab4544a03dd7d5bc48a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934774 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719373}
-
Reilly Grant authored
This change converts the remaining instances of base::Bind, base::Closure and base::Callback to explicitly choose between call-once and call-repeating semantics. Bug: 1007633 Change-Id: Id3636e2f3af003fdf705ba339db8173d27714eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937913 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719372}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/74e43a9f7fd6..5604ce9f20cd git log 74e43a9f7fd6..5604ce9f20cd --date=short --first-parent --format='%ad %ae %s' 2019-11-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@5604ce9f20cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Id5eee1362febc51dcdb2ef20f26e61d0379d45c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937868Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e705827b369b..f2f095be2853 git log e705827b369b..f2f095be2853 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 dberris@chromium.org Update dependency to use vendored d3 Created with: gclient setdep -r src/third_party/catapult@f2f095be2853 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986772 Tbr: skyostil@google.com Change-Id: I68094473344062244ec4e10634ee03a699d91c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937871Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 80-3945.24-1574073272-benchmark-80.0.3964.0-r2 to 80-3945.24-1574678177-benchmark-80.0.3964.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I21f8e40213677716b9088e776f720ec0a4a76901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936120 Commit-Queue: Tiancong Wang <tcwang@google.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 80-3945.24-1574075354-benchmark-80.0.3964.0-r2 to 80-3945.24-1574679770-benchmark-80.0.3964.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I506c9c31cbb8d977b962bda7b53e13d17b07a3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936121 Commit-Queue: Tiancong Wang <tcwang@google.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3945.24-1574073604-benchmark-80.0.3964.0-r2 to 80-3945.24-1574681176-benchmark-80.0.3964.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9a2e585a4bc340c56ecab4078821c147ce882f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936117 Commit-Queue: Tiancong Wang <tcwang@google.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Owen Min authored
Disable virtual/cross-origin-isolation/external/wpt/html/cross-origin-embedder-policy/none.https.html on all platforms. Disable external/wpt/html/cross-origin-embedder-policy/none.https.html on Linux and Mac for failure and timeout. Bug: 1015187 Tbr: yhirano@chromium.org Change-Id: Iec159c070b1b7f54a6d93c4bdd15123b82b222a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937967 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719366}
-
Ryan Hansberry authored
Bug: None Change-Id: I94407ae724d5a0d6bbcaebeb791de55ff50d4a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937510 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#719365}
-
Francois Doray authored
The goal is to ensure that a policy that reduces background work when a tab is loading is applied as soon as possible. In particular, on startup, we don't want background work to start before the first tab has received a response. We want to move TabLoadTracker to the PerformanceManager. However, that shouldn't block experimenting with no background work when a tab is loading. Bug: 839110 Change-Id: Idf59ef95192200e76e3fe387fb76adab88ad85a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906508Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#719364}
-
Archana Simha authored
extensions_checkup verifies that the user has an extension installed that is not policy installed, is not a component extension, and was not installed by default. Bug: 1019296 Change-Id: I1665bac06a33c1015db2637a0426ad9f023ff2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922187 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719363}
-
Robbie McElrath authored
This CL reorganizes //aw/BUILD.gn to group things as follows: * Public targets (targets used by monochrome, shared libraries, apks) * Java rules (JNI, android_libraries, aidl) * Resource rules Test: ninja -C out/aw Bug: 934152 Change-Id: Id5a21048d3353ff77f090c13e04d2c410b69e925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933314 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719362}
-
Robert Sesek authored
Change-Id: I7eec10f83285bc1e22399282c15dcff56aa6df6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937771Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#719361}
-
Gyuyoung Kim authored
This CL converts all uses of IdleManager interface as below, - Convert BindingSet to ReceiverSet - Convert IdleManagerRequest to PendingReceiver<IdleManager> Bug: 955171 Change-Id: I89f1a325b0e3290c1fdb36d5bc92389c8716e546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932139Reviewed-by:Ayu Ishii <ayui@chromium.org> Reviewed-by:
-
Kent Tamura authored
from double, seconds from the Unix epoch, to base::Optional<base::Time>. Bug: 988343 Change-Id: I6f36a98734aea86ed560c841d1b3dd565f4635af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935289Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#719359}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea12f144588e..1a596b35f973 git log ea12f144588e..1a596b35f973 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 chshrest@microsoft.com Reland: Elements: Make 'Add' button in color-picker keyboard accessible Created with: gclient setdep -r src/third_party/devtools-frontend/src@1a596b35f973 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I31a1617d1fe65f033236c2b07da73ea4b83fff38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937550Reviewed-by:
-
Patrick Monette authored
Also remove unneeded null checks since the |delegate_| is never null. Bug: 82827 Change-Id: Ic9ca6af8208330ae6ab85d2de1c0a61921f68ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935236Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#719357}
-
Herb Derby authored
The Mac Metal code uses objective-c++, but was still using the c++14 command-line flag. Change-Id: I150ad2369326e558cad966714a6a966ba7c77dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937657 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Herb Derby <herb@google.com> Reviewed-by:
Mike Reed <reed@google.com> Reviewed-by:
Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#719356}
-
haozhe authored
Both Chrome and Firefox passed Bug: 900581 Change-Id: I7a8e4b3b7f2d040df128cd614e95b8a247d99e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937907Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#719355}
-
Mounir Lamouri authored
A follow-up will remove the associated backend code. Bug: 1028264 Change-Id: I503e8a1b11b86168c074c89fa8160f09f0ebecc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934728Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#719354}
-
Peter Kotwicz authored
This CL enables the tests for phones but keeps them disabled for tablets. The tests started failing as a result of https://chromium-review.googlesource.com/c/chromium/src/+/1858605 which made the tests incompatible with tablets BUG=1028636 Change-Id: I76341e1684cf8587bd4c59e7deebcbb2f39df6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937576Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719353}
-
Alexander Timin authored
Navigation restoring a page from the back-forward cache do not wait for a renderer to reply and commit synchronously, therefore there is no need to simulate a renderer sending a commit ACK. This patch teaches NavigationSimulator to mark bfcached navigation as finished as soon as it commits. R=clamy@chromium.org,arthursonzogni@chromium.org,rakina@chromium.org,fergal@chromium.org BUG=1015328 Change-Id: I8251a2190bb20ecce4027519d4d6eb9a40929e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893170 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#719352}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ifce30e5841b2e188727b8ac6191d6261ecb31d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937352Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#719351}
-
Jared Saul authored
Change-Id: Id13b46e08df385dc3e3107671259d9330ad79153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931758 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#719350}
-
