GitLab

This CL begins the work of adding a Skia usable shared image created via
a Ozone surface factory. ProduceSkia is able to be used in a GL context
but the Vulkan path is not complete yet.

Bug: 1023997
Change-Id: I83432a7a9e265a691adb9d1139bb31a1aafe33b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067448
Commit-Queue: Paulo Warren <pwarren@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751723}

Added CreateCanvasResourceProvider2d and 3d methods to split a large
method, and reordering a part of it to simplify future changes.

Bug: 1035589
Change-Id: Icc6aa07ca15cbedd6194eef6c542ba48fde4a563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106322
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751722}

This change moves long switch statements into separate helper functions
to make it easier to see GetAuraColor's control flow.

BUG=

Change-Id: I203ee8dc54020e4ce60924511363a5cb19269e26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108821
Commit-Queue: Robert Liao <robliao@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751721}

Bug:959776

Change-Id: I631d11703f796b00b3053b3b977ef2b78f2b5277
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108510
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751720}

Bug: 1059389
Change-Id: Ie3f7ec0b298fe89ac3d9d60ed59dcdd5cd88477b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109030Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#751719}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/829a21222fe3..f845b816079e

git log 829a21222fe3..f845b816079e --date=short --first-parent --format='%ad %ae %s'
2020-03-18 ahassani@chromium.org cros_generate_update_payload: Some cleanup
2020-03-18 gredelston@google.com Implement ChromitePytest API
2020-03-18 bpastene@chromium.org cros_test: Push chromite's scripts dir onto PATH during Tast tests.

Created with:
  gclient setdep -r src/third_party/chromite@f845b816079e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: Ic7e7a260d45c578442801dd8230d717b595dba42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110030Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751718}

If the device supports KMS Atomic APIs, Enable CRTC using Atomic Modeset
Commit instead of legacy SetCRTC.

(reverted on crrev.com/c/2080775)

BUG=987274
TEST=displays should start and continue to function normally for devices
supporting atomic APIs.
HardwareDisplayControllerTest.CheckModesettingSetsProps
HardwareDisplayPlaneManagerAtomicTest.CheckPropsAfterModeset

Change-Id: If08b015d1e62f51e9ec3c243c1e5a2965449345e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106476
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Auto-Submit: Mark Yacoub <markyacoub@google.com>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751717}

* Comment changes
* Consistent type for function pointers ("decltype(&name)")
* Update some variable names

Bug: none
Change-Id: Ibf2fdd47fbe3aef92c61554f9b7ab812d29809da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106824
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751716}

This patch eliminates the deprecated function, together with its last
callers. Now we can ensure that we never switch FontSelector for any
Font and FontFallbackList objects.

For the last callers in FontBuilder, since it needs to setup
FontSelector as part of the font-related style computation, we expose
SetFontInternal() from ComputedStyle to it.

Bug: 1049295
Change-Id: Iea40e7150389bf0db1d10d0e0269d579bd2948fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109259Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751715}

In case the user is not opted in to "passwords account storage", the
button in the autofill dropdown menu used to generate passwords will now
have a different UI and prompt a reauth flow to opt in the user to the
feature.

This new button can be shown simultaneously with the pre-existing button
for opting in then displaying password suggestions.

Bug: 1060131
Change-Id: Ibcd85f831f3b81ab28fcb69d4ca0ff02bf4d9c8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107620Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#751714}

This reverts commit 036098e4.

Reason for revert: No changes to this commit.
Fixed by: 02aeb6b2

Original change's description:
> Revert "Reland "Make java_deobfuscate not require being built first""
> 
> This reverts commit d80699f2.
> 
> Reason for revert: Broke swarming again:
> https://ci.chromium.org/p/chromium/builders/ci/android-lollipop-arm-rel/783
> 
> Original change's description:
> > Reland "Make java_deobfuscate not require being built first"
> > 
> > This reverts commit 0b8c0e6a.
> > 
> > Reason for revert: Fixed runtime deps
> > 
> > Original change's description:
> > > Revert "Make java_deobfuscate not require being built first"
> > >
> > > This reverts commit 962e7030.
> > >
> > > Reason for revert: Failing on swarming
> > > https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/747
> > >
> > > Original change's description:
> > > > Make java_deobfuscate not require being built first
> > > >
> > > > Makes the tool easier to use, and easier to document how to use by not
> > > > requiring it to be built first. We have only a single non-prebuilt .java
> > > > file, so it's easy enough to just check in the .class file for it.
> > 
> > Bug: 995290
> > Change-Id: Ib1f396e07d6b0737133f03f1bded1a2d312ebfc8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106972
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: Sam Maier <smaier@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#751322}
> 
> TBR=agrieve@chromium.org,smaier@chromium.org
> 
> Change-Id: I7510d193931940176178ad6f68122f634ed59e93
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 995290
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108612
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751394}

TBR=agrieve@chromium.org,smaier@chromium.org

Bug: 995290
Change-Id: Ia51d50638d859d27e081ff0689b4c5877a02e8c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109817
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751713}

This reverts commit 6a3e1c15.

Reason for revert: We've branched for M83, so we're ready to
make full-hash requests again and re-enable unit tests.

Original change's description:
> [iOS] Disable Safe Browsing full-hash requests
>
> This temporarily disables making full-hash requests on iOS, allowing
> the rest of the Safe Browsing code to be exercised.
>
> Since this change breaks unit tests, this CL also stops running
> Safe Browsing database unit tests on iOS for now.
>
> Bug: 1028755
> Change-Id: Id772d4682bd9a3443b8d6b7042b0b5aecaaff80e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088349
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Commit-Queue: Ali Juma <ajuma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#748049}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1028755
Change-Id: I3d4e64e9c6818e1dcbf66a8a21aa48df98c8e87b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108096Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751712}

The Polymer 2 local chromium.patch file contains a change to
paper-tooltip that was not yet in the Polymer 3 chromium.patch file.
Port this missing patch, as this is used by chrome://settings.

Bug: 1025402
Change-Id: Ia33503edca6dbc5bc17e29d9997a7aac6fe2b8ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109263Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751711}

This reverts commit 6ba92a23.

Reason for revert: causes a crash, see bug
BUG: 1063063


Original change's description:
> Migrate device emulation to mojom
> 
> - introduce DeviceEmulator, make it navigation-associated
> - move WebDeviceEmulationParams to blink/public/common/devtools
> - use base::Optional<WebDeviceEmulationParams> to represent emulation
>     enabled/disabled state through most interfaces.
> 
> Change-Id: Ic743a1af02019610149e1c4a765696c9d8711e5b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092938
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751492}

TBR=dgozman@chromium.org,danakj@chromium.org,caseq@chromium.org,estark@chromium.org,mkwst@chromium.org

Change-Id: I8280c3aabc829245209d8db3d7d1915ddad8d8e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110213Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751710}

This reverts commit 7f5e20cc.

Reason for revert: caused a new crash: crbug.com/1063048

Original change's description:
> [Payment Request] Fixed potential use-after-free of RenderFrameHost.
> 
> InstallablePaymentAppCrawler stores a RenderFrameHost raw pointer and
> uses it in asynchronously when DownloadAndDecodeWebAppIcon() is run as
> a callback for downloading the web app manifest. This creates a possible
> use-after-free situation.
> 
> This CL applies a limited fix: the RenderFrameHost* is converted to its
> GlobalFrameRoutingId to be stored inside InstallablePaymentAppCrawler.
> 
> A better fix is to use WeakPtr<RenderFrameHost> everywhere in payments
> code. However, this requires changing the content public API to expose
> a RenderFrameHost::GetWeakPtr() method. Since this CL is intended to be
> merged to M82, this more risky work is left as a followup for
> crbug.com/1058840.
> 
> The instantiation of InstallablePaymentAppCrawler happens synchronously
> with the instantiation of PaymentRequest, the risk of use-after-free as
> a result of PaymentRequest's storage of RenderFrameHost* is small.
> 
> Bug: 1061110
> Change-Id: I1428c6006201834ee341dd4546bd297116a5f380
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106387
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Commit-Queue: Danyao Wang <danyao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751454}

TBR=rouslan@chromium.org,danyao@chromium.org

Change-Id: Iacb8ff851af05e01503630d671547f8d19dda05c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1061110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109828Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751709}

This reverts commit 23c738ec.

Reason for revert: Broke compilation

Original change's description:
> Update some callbacks to Once/Repeating in //remoting/protocol
> 
> Bug: 1007826
> Change-Id: Ie65fbc4382a397145e085081cca188b37138d5dc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106393
> Commit-Queue: Joe Downing <joedow@chromium.org>
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Auto-Submit: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751684}

TBR=estade@chromium.org,joedow@chromium.org

Change-Id: Ie492bcdd65a8f875412747c8a62c721ce56461ba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1007826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109825Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751708}

TBR=eugenebut@chromium.org

Bug: 1063015
Change-Id: Ic74d8e26f365daad546ce35b210b1d856d8d7225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110021Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751707}

This CL adds a new UKM event to record when an action button is pressed
within the Global Media Controls dialog. This records which button was
pressed.

Bug: 1050077
Change-Id: Ib3c8eb1264d92569fd3a587d7667dc64a49a5e66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092421
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751706}

https://chromium.googlesource.com/angle/angle.git/+log/dadeffa315e7..a38e20e4b435

git log dadeffa315e7..a38e20e4b435 --date=short --first-parent --format='%ad %ae %s'
2020-03-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 440fc9959f06..bc98fbeec99b (3 commits)

Created with:
  gclient setdep -r src/third_party/angle@a38e20e4b435

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: courtneygo@google.com
Change-Id: If280608243aba904e02f0dd6ff7b436960b171cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109888Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751705}

This makes it easier to view and compare test results.

BUG=1026447
TEST=manual
R=backer@chromium.org,magchen@chromium.org

Change-Id: I6fd4cb70add1316059f47b660c68c65f0bce0b2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109454
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751704}

I am familiar with many of the local modifications for robolectric.

Bug: None
Change-Id: Ia7ae390ad9bd172cc238de2bc64cb3c7af5e9619
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109811
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751703}

The function by the same name in overview_test_util.h and .cc is fine.

Bug: None
Change-Id: Ic47a050f9c547fa9353dde74127c08ebc087346e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109253Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751702}

Tests now override a variable used by this function rather than the
function checking whether a test has overridden an environment variable.
This also allowed simplification of the function.

Also made "time zone" consistently two words.

Bug: fuchsia:37487
Change-Id: Ib040dd07dee239faa5f41f9e5c5070309a265a11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102077
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751701}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d3ac36c8..63323405

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I7b16255f458b88f08e2c87fbe4e9c61af0222c7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108847Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751700}

Bug: None
Change-Id: Ic0d85fafae91d15e2c6b8300c20c3d10bbd4b800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109278Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751699}

https://webrtc.googlesource.com/src.git/+log/e55f0c338495..2507f8cdc979

git log e55f0c338495..2507f8cdc979 --date=short --first-parent --format='%ad %ae %s'
2020-03-19 peah@webrtc.org APM: Replace all remaining usage of AudioFrame outside interfaces
2020-03-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d69529f5..4b28405b (751530:751644)
2020-03-19 peah@webrtc.org Correct the storing of the processed output in aecdumps
2020-03-19 magjed@webrtc.org Android: Synchronize EGL14.eglDestroyContext calls
2020-03-19 phoglund@webrtc.org Write pb perf output files on iOS.

Created with:
  gclient setdep -r src/third_party/webrtc@2507f8cdc979

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1029452
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I0e1c4c986c93f563e0ac069619fe1d6ebe4402bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109887Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751698}

TBR=jam@chromium.org

Bug: 1058600
Change-Id: I742b5512c7565ea353f5bbed602b744817eed9fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103310Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751697}

There are 2 tabs that need to be preserved. There might be a 3rd tab,
about:blank that is opened by the test itself. That 3rd tab may or may
not have been opened at the time we validate the first 2.

Bug: 1062701
Change-Id: I4bac4aaa0b97ccc5170f64b92df311541092a555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106572Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751696}

Bug: 1061849
Change-Id: I6a63abe67dd022e6ca70d39647e18d0aa7eaff71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106890Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751695}

https://dawn.googlesource.com/dawn.git/+log/1f9b5960d8b2..81bcbbc20ee5

git log 1f9b5960d8b2..81bcbbc20ee5 --date=short --first-parent --format='%ad %ae %s'
2020-03-19 rharrison@chromium.org Add storage texture format reflection to spvc path

Created with:
  gclient setdep -r src/third_party/dawn@81bcbbc20ee5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I6b6614228f3e317d480f0928e6dbf3ed14cda786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109886Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751694}

This will simplify some code in the future when we remove APIs off the
blink public surface.

Change-Id: I64fa0907158252a0ec73cba81c8bbd06273eb419
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109135Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751693}

A line containing the string <-- End-of-file --> is included
in the output of DumpAccessibilityTree tests, but it's not
supposed to be checked in.

This change removes those lines. A follow-up will fix the diffing
algorithm and make it so that rebasing tests won't keep adding
those lines to expectations files.

Bug: None
Change-Id: I7bd3186793651e7c4c8361882444b6da9c3d35dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109176
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751692}

This adds an about:flags entry for Safe Browsing, to make it easier
to enable and test.

Bug: 1028755
Change-Id: I48bb2c6d20a707a2f44810e71403abd2eb8dda3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105797
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751691}

This CL extends the capabilities of the collapse_radio_button to allow
it to display a policy indicator, as well as sets it's disabled state to
align with expectations for when a control is managed by policy.

To achieve this a policy-indicator-type property is added to the
collapse-radio-button which controls the indicator displayed by the
newly added  cr-policy-indicator element.

A no-collapse property is also added to the collapse-radio-button
element to support situations where no additional content is required.
This allows a radio group containing both collapsing and non-collapsing
radio buttons to use the same element for all entries.

A screenshot example of these indicators in use is available on the bug.

Bug: 1061947
Change-Id: Ie2f3ab02b805210fe165435163fa3734bb62b213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107556Reviewed-by: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#751690}

Bug: 1056841
Change-Id: I08e2c92b4d58ee751543162aaab2ebe6df1fd20b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109024Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751689}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6414c9da662..8a1e6c065240

git log b6414c9da662..8a1e6c065240 --date=short --first-parent --format='%ad %ae %s'
2020-03-19 aerotwist@chromium.org [global] Remaps self.Persistence.IsolatedFileSystemManager
2020-03-19 tvanderlippe@chromium.org Typecheck host/ with TypeScript

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@8a1e6c065240

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811,chromium:1058320
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ic160ec4001c6545646f934b79eeb343352744194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109885Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751688}

PointerCapture should work for Shadow DOM elements based on Pointer Events specification. Add web platform tests to ensure PointerCapture works with shadow DOM elements.

Bug: 810882
Change-Id: I5f183afaab17689551f78903acba3e74f8cd49f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096112
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751687}

This CL migrates the comparisons that check whether an @ is @import or
@charset from DeprecatedEqualIgnoringCase to EqualIgnoringASCIICase.

They weren’t migrated as part of <https://crrev.com/c/2015875> and
<https://crrev.com/c/2108441> because while DeprecatedEqual has an
overload for StringBuilder and char* arguments, EqualASCII has no
similar overload, and the simplest solution (replacing _rule with
_rule.ToString()) is more inefficient than we’re comfortable with.

Rather than adding similar special-case EqualASCII overload, I propose
that we make StringBuilder implicitly convertible to a StringView that
borrows its defined part, by way of a unary constructor.

Google’s C++ style forbids this, but I think it’s appropriate here,
because implicit conversions allow StringBuilder to participate in the
plethora of utility functions that are only defined over StringView,
just like String, AtomicString, LChar*, UChar*, and so on.

These changes are potentially author-facing, but I’ve optimistically
made them without any additional tests based on Rick Byers’ reasoning
on blink-dev [1]. Please let me know if that’s not sufficient here.

[1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/sFOpNuQ91UU/3u1HxbnQCQAJ

Bug: 627682
Change-Id: Ib60c84288f47ca4431db0a2dd8003d226b3f3bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106983Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Cr-Commit-Position: refs/heads/master@{#751686}

If we are already in one finger passthrough mode
triggered by press on the edge, don't allow other
fingers to clobber the initial press. Otherwise
we will never send the release for the first
finger.

Bug: None
Test: display assistant with screen reader enabled, back gesture
Change-Id: I742102eeb3fad05f7a32b6c7cdd34b9036f6ddaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108866
Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751685}

Bug: 1007826
Change-Id: Ie65fbc4382a397145e085081cca188b37138d5dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106393
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751684}