- 28 Sep, 2020 40 commits
-
-
Gayane Petrosyan authored
This reverts commit 1b36f1a7. Reason for revert: causes weblayer_browsertests failure Bug: 1132848 Original change's description: > Add autoplay parameter to navigations. > > Bug: 1131881 > Change-Id: Ia152dc0a76d1f9ad6eff87f74fef2ad17b327b91 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432755 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810932} TBR=sky@chromium.org,jam@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1131881 Change-Id: Id853eaab83af2bc6cf4392a12d3b104bf6652442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435718Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#811239}
-
Alex Rudenko authored
Refactoring done in [1] is changing the internals of the overlay that the test intercepts. This CL disables the test temporarily and modifies it to intercept the new function. I have verified that the test is passing with the new changes in [1]. [1] https://crrev.com/c/2429775 Bug: 1131801 Change-Id: Ibd586a7435270aed3c82c5b1e26946d75fd37043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435644Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#811238}
-
Alice Wang authored
This CL adds an observer to update ProfileDataCache when user's profile photo(include monogram) from IdentityManager is updated. Bug: 1127886 Change-Id: I0c70f72708e50dceb63eb122055315f7818cba06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430984Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811237}
-
Olivier Robin authored
WebStateListMetricsBrowser requires SessionRestorationBrowserAgent, so it must be initialized earlier. Also initialize WebStateListMetricsBrowser member variables that were left uninitialized. Bug: 1132784 Change-Id: I28b9d5afca58870a6273eb1c3b3418a45c9fcd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435344 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#811236}
-
Mohamed Adel authored
The newly added response builder returns an NSDictionary that can then be used to process the notification and to handle interactions with it. Bug: 1131515 Change-Id: I81703650acde994c287945cc8f6a323b1bc18c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426586Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#811235}
-
Sebastien Lalancette authored
These tests cover both Recent tabs from Settings as well as from the Tab grid. They test the Copy link, Open in New Tab and Share functionalities. Also disabling drag-and-drop in Recent Tabs when EarlGrey tests are running. This fix is temporary as the EG team is working on resolving the problem. Clean-up is being tracked in: crbug.com/1129058 Bug: 1131831 Change-Id: I61e069102e7932e9b51860e82f0eeedbcd0459c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431786 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#811234}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ic655bd6062ee95ba1bc2e11d0b77bdac10fc322c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347036Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#811233}
-
Danyao Wang authored
Also updated ownership. Bug: 1128111 Change-Id: Iba6ba54d4a47e02579faa69ff7078ba6ab012333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426977 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811232}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601272286-5f5720137a0694fa0bfa67350ff5844644ba53c0.profdata to chrome-linux-master-1601294375-f18d3a3ac9a6313011d7149de4bf7e7984859ae2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I1022e3730c315dadb814ead5dc00cc1f4e6c0288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435618Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811231}
-
Robbie Gibson authored
Currently, text zoom doesn't work on iPad. This experimental method should work there. Bug: 1061119 Change-Id: Iaad93125be9752b5d70385be39ed6414a566228b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424142 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#811230}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/55c178693cdc..b6103ff5f992 2020-09-28 danilchap@webrtc.org Test scalability structures do not suggest disabled layers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4ac5135fc1e26bc566f092771a2eba9d141cd654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435262Reviewed-by:
-
Dominik Röttsches authored
When attempting to match a font from Android downloadable fonts, there is a scenario in which no font can be created from the returned file descriptor. Check for null SkData before testing for isEmpty() Bug: 1127513 Change-Id: Icaa8e6fadfca6750e9eccb78e6d20c5de20c7f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429272Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#811228}
-
chrome://flagsArthur Hemery authored
Removes the now deprecated cross-origin-opener-policy flag. Note that unfortunately it is not possible to completely remove the feature, due to selective disabling on Android Webview. BUG=1129108 Change-Id: I226f87d3583ea38be1a486ec623fb5d59a30f69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425050Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#811227}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601272286-d5061451d97ba33a632a304f531ce91f70d7428a.profdata to chrome-mac-master-1601294375-805284c073a4c807365387c8b737f70c270f4966.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id9156081c22a3a4e13f1fc038634c63f4941747d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435619Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d2f6cc6f606c..059781eddd4e 2020-09-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 7f9879b1b1fa to e1ba543c6789 (1 revision) 2020-09-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 9e17b9d07a25 to 4b07d50cd9a0 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I65dc84f58b6d2acca645cea0b4e972b0e59acbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435258Reviewed-by:
-
Viktor Semeniuk authored
This change adds possibility to edit username in Settings > Passwords. If edited username is already used for the same website error message is shown. Bug: 377410 Change-Id: Ifbd45f459e2d6731f8e5fd6bf7df069efd6999ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424315 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#811224}
-
Saurabh Nijhara authored
Currently we are only reporting metrics when force installed extensions either fail installation or ExtensionRegistry's OnExtensionLoaded (...) event is received. This CL reports the time elapsed for enterprise policy forced extensions to become ready for use by reporting statistics when force installed extensions either fail installation or ExtensionRegistry's OnExtensionReady(...) event is received. These statistics are being collected as part of the effort to improve force installed extensions reliability. Following histogram is added: Extensions.ForceInstalledReadyTime Bug: 1131418 Change-Id: Ief524819deb8cca81231765439700c265d9e7b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424286Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#811223}
-
Caitlin Fischer authored
The switch appears to be unused. Bug: 1126640 Change-Id: I07728ca316e91051c349615b49304e27c3e81ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427074Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#811222}
-
Adam Rice authored
Change the expectations for the web test fast/dom/Window/window-postmessage-clone-deep-array.html so that it no longer produces "unexpected pass" messages. The test still fails, but this is handled by an -expected.txt file only, without an entry in TestExpectations. Change-Id: Icfb89c4942cc9147fa3d24972464d5f2eeda31aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432704Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#811221}
-
Maksim Sisov authored
RGBX_8888 shall be used as buffer format with images without alpha. However, Chromium doesn't allow it to use for scanout in some parts of the code, and allows to use in other. Thus, temporarily disable usage of RGBX_8888 and always use either RGBA or BGRA_8888 for images with alpha and no alpha. Bug: 1128997 Change-Id: I4a3a8ad102d46d6dc12ccaba4cbade41432d6b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434928 Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811220}
-
Maxim Kolosovskiy authored
has_script is going to be divided into |has_script| and |has_auto_change_button|. It will be done in several steps for easier reviewing: 1. The existing |has_script| will be renamed to |has_auto_change_button| 2. A "new" |has_script| will be introduced, where |has_script|== |has_auto_change_button| (this CL). 3. Implement special logic for the new |has_script|. Bug: 1132230 Change-Id: I71dd73842b406fd9c82f4f11e57b7631febfcb86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431925Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#811219}
-
Yunke Zhou authored
Bug: 1131570 Change-Id: Ibf136d963c183d40a87968e483bb01baac9fec67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435348Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#811218}
-
Omar Morsi authored
This CL removes PermissionsForExtension class from KeyPermissionsService* and converts it into a service (ExtensionKeyPermissionsService). With this CL, only service operations in the context of a profile should be handled by KeyPermissionsService and only service operations in the context of a (profile, extension) pair should be handled by ExtensionKeyPermissionsService. Bug: 1127284 Change-Id: I54acf3af8d234129c070a3342b9e90e447c6982c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429064 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#811217}
-
David Grogan authored
ComputeMinMaxSizes needs a ConstraintSpace when the child is not in a parallel writing mode. Flex wasn't providing one when it retrieved a table's intrinsic min size. Before this bug was introduced, flex was calling ComputeMinAndMaxContentContribution(..., table, ...) instead of table.ComputeMinMaxSizes(...). ComputeMinAndMaxContentContribution builds its own ConstraintSpace for ortho items, so flex didn't need to provide one. We originally switched from ComputeMinAndMaxContentContribution to table.ComputeMinMaxSizes because: * One input to the flex algorithm is the item's used min-width (for a row flexbox). The flex algorithm will never assign a flex item a width smaller than its used min-width. For most elements, we get this value via ResolveMinInlineLength(..., style.LogicalMinWidth(), ...). * But table's used min-width is defined specially to be "the greater of the resolved min-width, CAPMIN, and GRIDMIN". So to get the table-as-flex-item's used min-width, we need to retrieve max(CAPMIN, GRIDMIN) in addition to resolving style.LogicalMinWidth from the above step. * ComputeMinAndMaxContentContribution(table).min returns max(CAPMIN, GRIDMIN, style.LogicalWidth()). I.e. it obeys any specified width on the table. * But table.ComputeMinMaxSizes().min returns only max(CAPMIN, GRIDMIN)[1], which is what we want. In the example below, the flexbox will try to shrink the table's width to 75px. Using ComputeMinAndMaxContentContribution for the table's min-width computation would result in the table being 100px wide. Using table.ComputeMinMaxSizes would make it 75px wide. 75px is correct. <div style="display: flex; width: 75px;"> <table style="width: 100px; min-width: 0px;"> <td> <div style="float: left; width:50px"></div> <div style="float: left; width:50px"></div> </td> </table> </div> https://jsfiddle.net/dgrogan/gwu4ac82/3/ [1] This is actually not true today but is true for TablesNG. Switching to table.ComputeMinMaxSizes gets us closer. Bug: 1128262 Fixed: 1131890 Change-Id: Ie5a4eac97e4a6a2e96104397bd5c5ec483d40e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433594 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#811216}
-
Stephen McGruer authored
This rolls up to sha e7928355119c150c784d2d32da699717f61ed346 This brings in the async_test return-value change, as well as some changes to testdriver. Bug: None Change-Id: I49022e105c8ea6070eeee7031b3002eefbdb0d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432628Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#811215}
-
Stephen McGruer authored
Bug: None Change-Id: I8dcbf7f1e583df2f20560a6f6dc2337847c42805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432629Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ed2b465f8607..145f115c5496 2020-09-28 cwallez@chromium.org SerialQueue/Map: Take the serial type as type paramater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8ccb9e1ebf00cdb56fc02e1ea592c41a00f42530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435260Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ae0cd6c31b5..ba3d5932bb28 2020-09-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-28 jacktfranklin@chromium.org Migrate TimelineFrameModel to TypeScript 2020-09-28 jacktfranklin@chromium.org Fix rendering of NodeText in LayoutPane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1129881 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic99bc19475684eb7b8e5b8f263a1a98800fddcda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435261Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601078369-47e552b1186c97497a87b26292e838c6fba2ff82.profdata to chrome-win32-master-1601098956-d2e0aa4048f1f94bf1822bc14b11121ebd74fc3b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia8b69f87d028ed46ab1484c0b5607cdfe6df17d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433076Reviewed-by:
-
Omar Morsi authored
This CL removes the static function KeyPermissionsService::IsCorporateKeyForProfile because it does not account for device-wide keys which are currently always "corporate". KeyPermissionsService::IsCorporateKey can be used instead. Bug: 1127326 Change-Id: I927611abe296f710c6b7d2187cd1c6c6b5ae47e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426607 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e79440e7..667efcdc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I779461b9fc9e5586ed436ec8574b0b3a0be95769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434907Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811209}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1601066350-377534304780c9dba5c0cc3dbbf14390e280f62b.profdata to chrome-win64-master-1601098956-2811654f54d3946c8e0477e7d77d36d5dbdfab8f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6a98bd2a6c84555c59eeb9d9d2730e9d1f555146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433263Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/111de34102c7..55c178693cdc 2020-09-28 eshr@google.com Add support for NV12 frame generation for tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie04a2193ac57197b157072f2b66884227e6ca16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435257Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e4f36ef0. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id114ec1b4e10541007ad67112c91b4e93d698ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434906Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811206}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1fb6b3e1b5c0..5ae0cd6c31b5 2020-09-28 tvanderlippe@chromium.org Remove one gradient from iPhone5 device emulator images 2020-09-28 mathias@chromium.org Migrate ChangesView to TypeScript 2020-09-28 jacktfranklin@chromium.org Migrate diff/DiffWrapper to TypeScript 2020-09-28 wolfi@chromium.org Fix focus ring when tabbing through service worker details If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1130980 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8b217d17ab60c10d759e0c869c49609562c981bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435256Reviewed-by:
-
Anton Ohontsev authored
At some point we have lost update the label text. When we create it hung_pages_table_model_->RowCount () == 0 but suppose to be equal to 1. This happens cause we counting hung pages after setting label text. So a plural form of text is "Exit pages" instead of "Exit page". The bug is not so terrible in Eng locale. But for other languages (ex. Russian) plural form of zero pages invoke eyes bleeding. Bug: 1132338 Change-Id: I8ba0f2e36404323d862ff6967e6a7127dd80939b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431965 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Auto-Submit: Anton Okhontsev <movax01h@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#811204}
-
Mark Cogan authored
The Discover help bubble hits DCHECKs on (at least) iPads, creating a crash loop on canary. This CL disables it until a proper fix can be made. Bug: 1132757 Change-Id: I7e4dc0dc9cf2fbc46e600ff00581979710697652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434927Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#811203}
-
Reda Tawfik authored
This CL changes the text of "User other password" to "User other username" if the user is about to fill a username field. Skips the warning dialog and show the bottom sheet immediately if the user is about to fill a username field. Bug: 1104132 Change-Id: Ife3c835cc9a7742c862bd4d71942472cc4686a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425051 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#811202}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icfc6153b5ea7b86b7f61bcce2e32260912fd91a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433907Reviewed-by:
-
Olivier Robin authored
If the RL view is in background scene when the model is modified, reloadData is called, and the number of items is updated, but rendering is postponed until the screen is displayed. If the model is modified again before that, it is possible that the view access items that have been deleted since. Bug: 1097027 Change-Id: Ibbd4d19700cf86bfda9db4ddb4d2285203f5ce0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428966Reviewed-by:
-
