- 08 Sep, 2020 40 commits
-
-
Natalie Chouinard authored
Test is also failing on android-bfcache-rel: https://ci.chromium.org/p/chromium/builders/ci/android-bfcache-rel so further disabling it on all devices. TBR=wychen@chromium.org Bug: 1119322 Change-Id: Iff4476a20e05af9d8fac79a259b111c64bf22d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399564Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#805112}
-
Miguel Casas authored
This CL adds a GPU driver bug workaround for VP8 video decoding on Broadwell (BDW) devices, which are hard-disabled via driver patch now. Having this disabling in chrome:gpu is better for developers and testers on the field. [1] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/chromiumos-overlay/x11-libs/libva-intel-driver/files/Disable-VP8-decoder-on-BDW.patch;bpv=1 Bug: 1126058, b/167923822 Change-Id: Ifb74a66dd8a0e4d4b081b7e4bc42009803f4be72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398906Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805111}
-
Anthony Cui authored
Bug: 949716 Change-Id: If26c31874dd529ce3a37cfdd22eb4d7dfe61c14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385635Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/heads/master@{#805110}
-
Ilia Samsonov authored
Adding mac11.0 ci and try builders to builders list. Setting fallback path to mac11/10.16 and adding sub path for 10.15. Also adding missing mac10.15 ci builder. Bug: 1108410 Change-Id: Ifcd712696534393713b916d467d4a568e02dfaa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374046 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#805109}
-
Sven Zheng authored
Briefly went through the last 200 jobs and disable these flaky tests caused the jobs fail. Bug: 1111979 Change-Id: I33211e2e3eb14de37927fe7e35e476a1debe57bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399501 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805108}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I69deb938115a91d411d9f96932f209f6ca4eb9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399442Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805107}
-
Lijin Shen authored
Add new unit tests for testing whether Util can decide promo action correctly based on the given external states by mocking Deps. Bug: 1109255 Change-Id: I3e7f653e4c156b2fadcdbb605ce40ecda3a738f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396601 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#805106}
-
Liquan (Max) Gu authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2388561 Reverting CL: https://chromium-review.googlesource.com/c/chromium/src/+/2393061 Reverting reason: The original CL was landed before its dependent CL got reverted, so the original CL got reverted later. This CL is to reland it after its dependent CL got relanded[1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2392763 Bug: 1107039 Change-Id: I04c2025310ceeea01f51ceb30231cefb6a134bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399520Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805105}
-
John Abd-El-Malek authored
Also bring WebLayer's implementation closer to Chrome's (e.g. deleting safe browsing cookies and some other content types). Bug: 1123034 Change-Id: I0bb03c1096aa749215dda9cc137c9f859667021c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391560 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#805104}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/62442aceb0fb..22e5e179fa28 2020-09-08 aleksi@sapon.ca Vulkan: unused resolve attachments must be marked as such If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibab670ec568f8c39fffc46b5d8db9d64e82a8a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805103}
-
Thomas Guilbert authored
These tests verify that a we can't create a VideoFrame from a closed ImageBitmap or encode a destroyed frame. Bug: 1116636, 1121255 Change-Id: Iba02d61128f5544550351408020223681a29b5a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399448 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#805102}
-
Joel Hockey authored
iron-list provides better focus management for tab/chromevox navigation. Bug: 1096143 Change-Id: Icaf2d27da606c9792a5aef9ac27226a77c63e76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390939 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805101}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ie6d82daf29d48260a6b6adc7e6d177b73b092251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396496Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#805100}
-
Tibor Goldschwendt authored
Collapsing/expanding hides/shows the local module UI. Before: https://screenshot.googleplex.com/7YpsgDQZg6EQbjT After: https://screenshot.googleplex.com/3wv7qaoupMtPQj5 Bug: 1124089 Change-Id: I80d88b1c2311da6a4d047e2ffb4837b6d4158add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388977 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805099}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9dd5f6257f3e..dc9083e4831f 2020-09-08 jleconte@google.com Fix WebRTC repo when retrieving git hash. 2020-09-08 hypan@google.com Explicitly check the root status when RunShellCommand has as_root set to True. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1052434,chromium:1123318 Tbr: rmhasan@google.com Change-Id: I716202a0dd28b4d86484dffba895135d03422e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399365Reviewed-by:
-
Anatoliy Potapchuk authored
The API is only available in kiosk mode, but the documentation does not specify that. Bug: 1099688 Change-Id: Ia0d067d77d4fc75991e447c59ff77d9595ff8e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398623Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#805097}
-
Sunny Sachanandani authored
Texture quads are considered as "requires overlay" quads which means that non-opaque occluded texture quads will be put into an overlay without any possibility of blending. This is ok for video since overlay compatible YUV video quads don't have any alpha, but texture quads can have alpha. A totally transparent texture quad would show up as black. This CL fixes that by applying the underlay validation check to texture quads. Multiple texture quads are still promoted if possible, but a quad could be skipped if it's occluded and non-opaque. This CL also adds a pixel test for this scenario. Bug: 1122638 Change-Id: I5c4f120d88ce8ad2bd340b7a4aa33d59fe1ef116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380161 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805096}
-
Gang Wu authored
This is different from current app menu redesign divider lines. AppMenu#mItemDividerHeight added long time ago, from the screenshot in crbug.com/331960,it seems app menu had divider lines between each items. And mItemDividerHeight is for calculate the height for that divider lines. And from https://codereview.chromium.org/377083002, we start to use OverflowMenuTheme in styles.xml(now it named OverflowMenuThemeOverlay), and it set <item name="android:listDivider">@null</item>, so we are no longer need AppMenu#mItemDividerHeight. Change-Id: I8c6bf1a5c9aeb5b5ac82eda7c6a5e924c7432156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393523Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805095}
-
David Black authored
This CL: * Adds drag-and-drop behavior to holding space views * Adds a new base class for holding space browsertests * Adds browsertests to verify drag-and-drop behavior Still TODO: * Add drag image Bug: 1124581 Change-Id: I4a2e7fe63b26b10b7a7563adcfe7569d095ea7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392263 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805094}
-
Becca Hughes authored
The NTP team have raised concern with loading data on the NTP that takes a few seconds so this adds a feature that will load the data the first time but hide the module and then on the second load and beyond show the cached data. BUG=1121360 Change-Id: Ib1288dfccc026c5a6b37814c32a1d0561bfded0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393176Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#805093}
-
Sammie Quon authored
Adds a way to pipe data from WmGestureHandler -> DeskController -> DeskAnimationBase -> RootWindowDeskSwitchAnimator in preparation for the touchpad continuous desks gestures feature. This CL will remove the touchpad animation temporarily, if the feature is on, but will still switch desks. Done in this CL: 1) WmGestureHandler uses different path if the feature is enabled. 2) DesksController has 3 new functions for WmGestureHandler to use. 3) DesksAnimationBase has Update and End functions. Test: manual, with and without feature Bug: 1111445 Change-Id: I08af31452a6614de3d72c42433d1dde8b5704cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388276 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805092}
-
Dan Harrington authored
This was testing code previously removed Bug: 1115745 Change-Id: I68ce48491f7529c88ab29a915837eedb5b8bfc88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398900 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#805091}
-
Torne (Richard Coles) authored
When we're not expecting an error but we get one, fail stating the actual error we received, not just the error count. Bug: 1106472 Bug: 1117289 Change-Id: I355b307a9dcf2ba0ecf24191541d6e74db761ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399522 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805090}
-
Adrienne Walker authored
Bug: 1114430 Change-Id: I8379fe033e39ffc898e8799cd3c1e1e8e1743984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393188 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#805089}
-
Connie Wan authored
We have approval to launch to 100% in crbug.com/1022943. Per go/finch-best-practices, enabling on ToT before launching to 100%. Bug: 905491 Change-Id: Ie3dbdab198a01289a749daf19b8495c0c41272ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398962 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805088}
-
cfredric authored
Change-Id: I9b5a18cf21d5ee465466c0a66501ef8a6c88bc5a Bug: 1126207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398957 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805087}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c107c7e93630..0e8358a4dead If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic3ddce15183cf71efea80d9fea247a9d358473e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399017Reviewed-by:
-
Jimmy Gong authored
- ConnectionManager exposes SendMessage to send a message through the client channel. - Adds the OnMessageReceived() to ConnectionManager's observer to notify clients of new messages from the client channel. Bug: 1106937 Test: unit_tests Change-Id: I9b2de4c7c05855deaf1ea8cebf2d01b2d4e3c69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390972 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Pranav Batra authored
Add unit tests for SettingsToCupsOptions() in printing_context_chromeos.cc. Also refactor the code a bit to expose this function for testing. Bug: 1001398 Test: ./printing_unittests Cq-Depend: 2390967 Change-Id: Id0c0765e5ce6a3f3cde3d294afce33c9720f215a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389102 Commit-Queue: Pranav Batra <batrapranav@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805084}
-
Etienne Bergeron authored
This CL is fixing a race condition that can happen when two threads are trying to load a DLL at the same time. The problem was that the priority boost may happen on the wrong thread (see: https://crbug.com/1124759). The solution is to add a std::atomic_bool already_loaded and set the flag when exiting the scope. It is fine that two threads enter the scope and try to load the DLL at the same time. Both thread will have and increased thread priority. R=gab@chromium.org, fdoray@chromium.org Bug: 1124759 Change-Id: I650ff99f56f1abeba6175024909cf344cad6bc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392746Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805083}
-
Matt Jones authored
This patch replaces the custom tab supplier used in the LayoutManager with the standard ActivityTabProvider. The fact that the top toolbar overlay now uses a 'push' model to update instead of a passive 'pull' means the tab sends the correct information immediately when ready instead of the guessing that needed to happen before. This simplifies the logic and reduces the number of tab sources. Bug: 1100332 Change-Id: I49667aebed4de36fd34be957a5fbf421e510713d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354996Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#805082}
-
Hesen Zhang authored
- This CL implements persistence layer of video tutorial metadatas. Bug: 1115755 Change-Id: Ic86d088cc0ad2934d172abc50e35f134e612f8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391932 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805081}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6b0afc48ae3d..9d7944292456 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If390c64139c1b24b220b4c0866bb26f9e6fb0db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399439Reviewed-by:
-
Akihiro Ota authored
This patch only changes the text content on the screen. There are no functionality changes as a result of this patch. Also, we are adding these strings so they can be tested before finalizing them as official string resources. Please see the follow-up change that implements localization: https://chromium-review.googlesource.com/c/chromium/src/+/2254345 Bug: 1124066 Change-Id: Id83e67a6b610a54627c01a395e197c760f98f094 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390959 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Auto-Submit: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#805079}
-
James Vecore authored
Adds a mojo interface and implementation that will allow the receive ui to enter high visibility mode and accep/reject incoming shares. See https://crrev.com/c/2392396 for usage. Bug: b:163148440, b:163147818 Change-Id: I141193fcd622c186f326fc158528ac62df8cf77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391737 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Owen Min authored
Disable SitePerProcessBrowserTest. TwoSubframesCreatePopupMenuWidgetsSimultaneously on Linux and Chrome OS due to flaky. Bug: 1126165 Change-Id: I56b956c03578a1ecf55e79cead3a6f1b676a379f Tbr: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399307Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805077}
-
Hans Wennborg authored
Otherwise a bad match can be chosen by longest_match, since it assumes that match[2] and scan[2] are equal when the hashes and the other bytes match. That assumption doesn't hold when using CRC hashing and a low number of hash bits (which can be set by via the 'memLevel' parameter). For example, the two hex byte sequences 2a 14 14 14 and 2a 14 db 14 have the same lower 9 bits CRC, and only differ in the third byte. This could cause longest_match to consider them as matching. This was already handled for x86; do the same for ARM and add a test. Bug: 1113596 Change-Id: I251150594264f401e4d8bc6e91b44b39998ab029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392457Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#805076}
-
Yusuke Sato authored
BUG=chromium:1085456 TEST=./testing/xvfb.py ./out/Release/chrome Change-Id: Ibdfb20f03846266033e55956d10a2552f5529640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398892Reviewed-by:
Long Cheng <lgcheng@google.com> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#805075}
-
Stephanie Kim authored
Bug: 1072012 Change-Id: Ibc69569b5dd521be8a02cfaffac469c83fe6727a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393060 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#805074}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e659214bc6cf..b6030fb2c818 2020-09-08 jlavrova@google.com Direct paint by default; remove save/translate/restore 2020-09-08 jvanverth@google.com Use Microsoft's ComPtr to wrap D3D12 objects. 2020-09-08 bsalomon@google.com Don't set BASE/MAX mip map level on PowerVR. 2020-09-08 borenet@google.com [infra] Fix Git package for Housekeeper-PerCommit-InfraTests_Win 2020-09-08 jvanverth@google.com Close disabled warning pragmas If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1123874 Tbr: reed@google.com Change-Id: I19a6d7006c94cd7ca37aa653d6d5d2f1c25a2c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399279Reviewed-by:
-
