- 18 Nov, 2017 40 commits
-
-
Stephen McGruer authored
This CL implements most of the getKeyframes() algorithm from the web-animations spec[0]. There are a few deviations from the spec: * We always include the 'composite' property. This is because we don't yet track the general composite operation for the KeyframeEffect, so cannot tell when a Keyframe has the same operation. * Shorthand CSS properties in the input keyframe argument will have been expanded to longhand properties in getKeyframes(). This is because we improperly expand shorthand properties when creating a StringKeyframe. Despite the deviations this implementation allows us to pass >40 additional WPT tests. It also makes the failure reasons for many more tests explicit, as they no longer just fail on "getKeyframes doesn't exist". [0]: http://w3c.github.io/web-animations/#dom-keyframeeffectreadonly-getkeyframes Bug: 777971 Change-Id: I80cf62bc0121b946b1bf896890e96afd27437057 Reviewed-on: https://chromium-review.googlesource.com/758921Reviewed-by:Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#517701}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/276e0454b797..8762632eb725 $ git log 276e0454b..8762632eb --date=short --no-merges --format='%ad %ae %s' 2017-11-17 tandrii Reland "bot_update: make --output_json required in script invocation." Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Icbf9290a52ae3f54007b02947701c1cbb9afc6e9 Reviewed-on: https://chromium-review.googlesource.com/777944Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517700}
-
Liquan (Max) Gu authored
Before we extend the custom user timing from performance.measure(), we want to count the usages of start-mark/end-mark being an object in performance.measure(), and identify references to navigationTiming strings, to predict how much the custom user timing will impact the current user cases. Bug: 783960 Change-Id: Id4f5cf5a6dc05eeb150c0a9cdc4f13a43dbb820c Reviewed-on: https://chromium-review.googlesource.com/769932Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Liquan Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#517699}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: Iab9bd0c975a83575a639dc4d95c86ed8cd67599f Reviewed-on: https://chromium-review.googlesource.com/777594Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#517698}
-
Pavel Feldman authored
This change does not change the semantics, only plumbs the token through the constructor instead of a separate setter. Change-Id: I85151adfb4fe3817954f85517ccc8d2ccdc1de38 Bug: 783506 Reviewed-on: https://chromium-review.googlesource.com/764554 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#517697}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/3f286cd1b6e2..758bc6a90b67 $ git log 3f286cd1b..758bc6a90 --date=short --no-merges --format='%ad %ae %s' 2017-11-18 zmo Revert "Clean up the TType class." Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I44211c7cc5274c9fd30bdaac2694465ac21fcc11 Reviewed-on: https://chromium-review.googlesource.com/777990Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517696}
-
Kenneth Russell authored
Forgot this the first time around. BUG=786572 TBR=dpranke@chromium.org NOTRY=true Change-Id: I24cd1a3053e80a7e661f92f26d01011a6cf0bddb Reviewed-on: https://chromium-review.googlesource.com/777853Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517695}
-
Benjamin C. Wiley Sittler authored
Bug: 786539 Bug: 661819 Change-Id: I26167fe8cf6f5959420d15fbed9e49a118f445b7 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/778019 Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#517694}
-
Kenneth Russell authored
The driver is generating GL_OUT_OF_MEMORY errors when it's used. Stop exposing it to the application level. BUG=702980 NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5d3ec20941ce0d032f37293db71926347a1652aa Reviewed-on: https://chromium-review.googlesource.com/777982 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#517693}
-
Rachel Blum authored
The spellcheck panel on OSX can be invoked via two editor commands: ToggleSpellPanel, and showGuessPanel. It used to be that one was invoked as an EditorCommand with no parameter, and the second as a command with empty string as parameter. This changed at some point. As an additional hurdle, editor commands without a parameter also get a capital letter as initial (mandatory). The fix here removes the invokation via the selector name - a.k.a. showGuessPanel - and renames that to ToggleSpellPanel. It does *not* address the issue of two separate invokation paths. (That is a follow-up CL, since it might require rollback) BUG=781971 Change-Id: I2023c5d3b91f491706ea2401c9cd03dbd87ae71e Reviewed-on: https://chromium-review.googlesource.com/759658Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Rachel Blum <groby@chromium.org> Cr-Commit-Position: refs/heads/master@{#517692}
-
Erik Luo authored
Console's custom copy handler tries to determine the selected text on its own. In some cases, the browser's default copy handler offers much better behavior: - Include styles and colors - Include table indentation that can be pasted into spreadsheet editors - Account for text selections across shadow boundaries Bug: 673746, 697149, 649828 Change-Id: I4b5e3a225234e28fe84197a73f655af9c4c9f418 Reviewed-on: https://chromium-review.googlesource.com/773462 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517691}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e6c939ba..e3ddaa1b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I20266ea140ef06b25c58c103c06e7b24cde0fed5 Reviewed-on: https://chromium-review.googlesource.com/777999Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517690}
-
Nathan Bruer authored
In the event that a url once encoded is more than 200 characters we will do partial hashing to it in order to ensure it plays well with operating systems like windows which only supports ~255 character total length paths. R=lushnikov BUG=754371 Change-Id: I6120ad13bff71a4933dd38088b81ecf480771360 Reviewed-on: https://chromium-review.googlesource.com/777602 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#517689}
-
Varun Khaneja authored
TBR=asvitkine Bug: 754336 Change-Id: I316e03853095b49dc9da6d6d19fccfd9cefb7bf5 Reviewed-on: https://chromium-review.googlesource.com/773505 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#517688}
-
James Cook authored
It's flaky under --mash. Bug: none Test: browser_tests --mash with filter file Change-Id: Icdb071cd350f07f0b176d7a9ff1496d3700329d5 Reviewed-on: https://chromium-review.googlesource.com/778123Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#517687}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/39631f3df172..f5beefd34df7 $ git log 39631f3df..f5beefd34 --date=short --no-merges --format='%ad %ae %s' 2017-11-17 brianosman Fix shader linker errors on several GL benchmarks 2017-11-17 benjaminwagner Add Nexus5x Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I7586b5563185e9f149c4419a0a7ef671fa7659a5 Reviewed-on: https://chromium-review.googlesource.com/777550Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517686}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/ec2209da1587..07b4727a34d2 $ git log ec2209da1..07b4727a3 --date=short --no-merges --format='%ad %ae %s' 2017-11-18 xlou Make clip optional in FPDFPage_TransFormWithClip. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I904c7a5dace4a8c3abf24a1c1775b6d0d6403f03 Reviewed-on: https://chromium-review.googlesource.com/778039 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517685}
-
Bill Orr authored
BUG=782445 Change-Id: Iec695a4db2bf2851f8f23b2c8ab1568a5bbfa588 Reviewed-on: https://chromium-review.googlesource.com/757859Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517684}
-
Frank Barchard authored
Bug: libyuv:760 Test: LibYUVConvertTest.H420ToRAW_Opt Change-Id: I648ac9f86627496995bc2a54b9719b339280ee73 Reviewed-on: https://chromium-review.googlesource.com/777543Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Frank Barchard <fbarchard@google.com> Cr-Commit-Position: refs/heads/master@{#517683}
-
Sadrul Habib Chowdhury authored
Rename the flag to is-running-with-mus instead, since it is possible to run with mus, without running in mash. Also, provide an optional value for the flag. If value for the flag is set to 'viz', that means mus is the viz host. Otherwise, the browser will be hosting viz. BUG=786453 Change-Id: I14385c16ee36ac8c46788955ab2381bf8b53d334 Reviewed-on: https://chromium-review.googlesource.com/777359Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#517682}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/3d70ca9cc194..3f286cd1b6e2 $ git log 3d70ca9cc..3f286cd1b --date=short --no-merges --format='%ad %ae %s' 2017-11-17 jmadill Clean up the TType class. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I26d3ab3a304c8b2b631365c04361785fd9f4ddf0 Reviewed-on: https://chromium-review.googlesource.com/777614Reviewed-by:
-
Devlin Cronin authored
NavigateParams has a number of different constructors and many different variables. Having each constructor define the value for the member in the initializer list makes it hard to see what's changing between the constructors. Instead, use in-class member initialization for the default values to make a) defaults clear and b) deviation from these defaults clear. Bonus: -80 LOC. Bug: None Change-Id: I26ecc6e1b27989017dba154e1e012cdab541a58a Reviewed-on: https://chromium-review.googlesource.com/775079Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517680}
-
Kevin Cernekee authored
If wifi and ethernet are both connected, and then the ethernet adapter is unplugged, network_list_ can end up looking like: network_list_[0] -> ethernet, idle network_list_[1] -> wifi, online shill will generally update the service's State property before it updates the manager's Services / ServiceCompleteList properties, leaving the now-idle service in the list. Since ConnectedNetworkByType() assumes that connected networks are listed first, it won't return the newly-active wifi network. Fix this by sorting the network list, and changing the sort function so that it doesn't prioritize idle ethernet services. BUG=768053 TEST=manually verify order with debug prints TEST=unit tests Change-Id: I3a110da7d99bd5e6463b86e17bc557124e875b85 Reviewed-on: https://chromium-review.googlesource.com/777970Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kevin Cernekee <cernekee@chromium.org> Cr-Commit-Position: refs/heads/master@{#517679}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/12192b9..e4919fa BUG=775202, 778770, 784817 TEST=bots TBR=zmo@chromium.org, kainino@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I296437377a0d5084f2ede5f50d6b6519436bc62f Reviewed-on: https://chromium-review.googlesource.com/773625 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Conley Owens authored
Currently characteristics are not getting marked discovered. This change fixes that. At the moment, this does not bubble up a services discovered event, so a test for this will be made in a subsequent change. https://chromium-review.googlesource.com/c/chromium/src/+/730653/ BUG=507419 Change-Id: Ie6a510ee2ae6d97e34760822fe7b01f65e28337d Reviewed-on: https://chromium-review.googlesource.com/735983 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#517677}
-
Kevin Cernekee authored
BUG=none TEST=unit tests Change-Id: Ia734c40400e722cf979231af398fa4a38611cfb7 Reviewed-on: https://chromium-review.googlesource.com/777971 Commit-Queue: Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
-
Adrienne Walker authored
This moves test-only paint op comparisons from unittests into paint ops themselves. This is to support a fuzzing correctness test that serializing and then deserializing an op results in the same op. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I351b4fb5329ee9ff64d54bb9dd49d0a1a34f7b13 Reviewed-on: https://chromium-review.googlesource.com/777840Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517675}
-
Xianzhu Wang authored
- When click the toolbar to select a view during animation, show the view for 1 second. This is convenient to briefly view a specific view without stopping the animation. Previously the time showing the clicked view was random. - Let GUI.getExpectation(el) handle cases that the el is under result-frame, so that keyboard navigation still works when the focus is under result-frame (e.g. after the toolbar or the image result is clicked). - Let GUI.activeExpectation() return the open expectation if no expectation line can be found from the focused element, so that keyboard navigation can be based on the open expectation if the focus is neither under the expectation line nor result-frame. - Correct total count. Previously the total count didn't include expected failures, skipped and wontfix tests, etc. Change-Id: Ibc4b697c52a7b5d37f0ebbfb5c925cc478f15f06 Reviewed-on: https://chromium-review.googlesource.com/777469 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#517674}
-
Evan Stade authored
of direct access to MessageCenter. Manual test: add `LowDiskSpace(10000);` to end of constructor. Bug: 783018 Change-Id: I3c1f7dd591e4c84b9d41742e6c042e63c7003138 Reviewed-on: https://chromium-review.googlesource.com/775059 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Kenneth Russell authored
Seems the earlier problems have been fixed. BUG=779991 NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8e5563ce02c2817e84611e0758edc44a19edc602 Reviewed-on: https://chromium-review.googlesource.com/775999 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Conley Owens authored
Previously, we notified discovery complete on a device before our async discovery calls actually finish. Additionally, we only partially recorded discovery. This change remedies both of these issues. BUG=507419 Change-Id: I730a52d74a0d11d8a62fb041d2103b78f566cc18 Reviewed-on: https://chromium-review.googlesource.com/730653 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by:
-
danakj authored
The test for this is in https://chromium-review.googlesource.com/c/chromium/src/+/775759 which converts all TextureMailbox-based tests over to ImportedResources. R=piman@chromium.org Bug: 769423 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9eefcd5a8783a6c2359fb46e1e2efb076302f13e Reviewed-on: https://chromium-review.googlesource.com/777695 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517670}
-
David Bokan authored
This reverts commit 55c943bf. The bots are convinced it's repsonsible for the linked perf regression, though it doesn't make much sense to me and couldn't reproduce locally. This patch has also caused lifecycle issues and isn't urgent so I'll back it out for now and consider better ways to do this. Bug: 742339 Change-Id: I271c5fa31512beefc74dcb1936f570edf1cc1175 Reviewed-on: https://chromium-review.googlesource.com/777040Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517669}
-
Conley Owens authored
Several device unittests test whether things behave properly after a device is deleted. This change enables those tests on Windows. These tests will become more relevant as service discovery is completed on Windows in a subsequent change. https://chromium-review.googlesource.com/c/chromium/src/+/730653/ BUG=507419 Change-Id: I1a6060692d9bb7f46b05acca78336015c72ce047 Reviewed-on: https://chromium-review.googlesource.com/776355Reviewed-by:
-
Sky Malice authored
Per guidance at about data coming from untrusted sources, such as disk or network, removed DCHECKs when handling data Loopback storage, see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/LU6NWiaSSRc/oolO8fg5AAAJ Instead null entities are returned which are essentailly just dropped. Also includes some minor cleanup, including deletion of un-used fake_server_entity.cc file, consistent usage of un-templated WrapUnique, nullptr for empty unique_ptrs, and pushed test constant back to test file (single_client_wallet_sync_test.cc). Bug: 771811 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I73045ed11982e6c44d5b623855163e61c1961fa2 Reviewed-on: https://chromium-review.googlesource.com/713556Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#517667}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0844d0e4444c..276e0454b797 $ git log 0844d0e44..276e0454b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I2b2eebd702461162110cdc0a5399a8e9d460a0bf Reviewed-on: https://chromium-review.googlesource.com/777847Reviewed-by:
-
Xiaohui Chen authored
BUG=b:69178309 TEST=login as supervised user, see assistant settings gone Change-Id: Ib84d9dc34288b9edaffcddd3f42ecdacd0e7d0a8 Reviewed-on: https://chromium-review.googlesource.com/777961Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#517665}
-
Tim Brown authored
Change-Id: I852031b2c7dcf210c05ed9f2b0f0cea7ee9faf3e Reviewed-on: https://chromium-review.googlesource.com/778048Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#517664}
-
James Cook authored
Enable all passing tests. Categorize all failing tests and file bugs for the most common ones. Bug: 678687 Test: browser_tests --mash Change-Id: I13bbf84322aaa3d6dcceb36a2fceff1fc16280f1 Reviewed-on: https://chromium-review.googlesource.com/777848Reviewed-by:
-
Ryan Landay authored
changwan@ pointed out it would be a good idea to add a test for the autocorrect attribute (e.g. <input autocorrect="off">) since we don't appear to have one already. Change-Id: Ifb21a7e68950e60d66a1a5c8ee618b436c4620c6 Reviewed-on: https://chromium-review.googlesource.com/740373 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517662}
-
