- 18 Apr, 2013 40 commits
-
-
vitalybuka@chromium.org authored
> Native api to get OAuth2 access tokens in Print Preview Web UI. > > BUG=179229 > > Review URL: https://chromiumcodereview.appspot.com/14093016 TBR=vitalybuka@chromium.org Review URL: https://codereview.chromium.org/13898008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194803 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Converts hanging tests to failures. Also disables a couple more flakey manual tests. BUG=225517 TEST=InstantExtendedManualTests.* R=jered@chromium.org Review URL: https://chromiumcodereview.appspot.com/14130012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194802 0039d316-1c4b-4281-b951-d872f2087c98
-
rockot@chromium.org authored
Platform apps do not use an Options page. This change makes OptionsPageHandler a no-op when parsing a platform app manifest. BUG=229584 Review URL: https://chromiumcodereview.appspot.com/14130005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194801 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=109818 Review URL: https://chromiumcodereview.appspot.com/14126008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194800 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
R=gene Review URL: https://chromiumcodereview.appspot.com/14107007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194799 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Delete lots of related code in both Chrome and CF. BUG=229940 TEST=NONE Review URL: https://chromiumcodereview.appspot.com/14030003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194798 0039d316-1c4b-4281-b951-d872f2087c98
-
yongsheng.zhu@intel.com authored
For the convenience of debugging android webview test shell TEST= BUG= Review URL: https://chromiumcodereview.appspot.com/13888004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194797 0039d316-1c4b-4281-b951-d872f2087c98
-
davidroche@chromium.org authored
OAuth2TokenService was refactored into an abstract base class without dependencies on Profile and the TokenService's OAuth2 login refresh token. Added ProfileOAuth2TokenService as an implementation of OAuth2TokenService that requires a Profile and the user's login refresh token from TokenService. Migrated the existing OAuth2TokenServiceFactory and OAuth2TokenServiceRequest to Profile* varients that use this new class. Added DeviceOAuth2TokenService that serves up API access tokens for enterprise enrolled devices (via a robot account with an any-api refresh token). These tokens are global to all accounts on the device including Public Accounts, and hence don't depend on a particular profile's login credentials. BUG=164606 Review URL: https://chromiumcodereview.appspot.com/12647008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194796 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194795 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
Made header and source ordering consistent. And more importantly, grouped relevant methods as much as possible, and sorted in the order of execution, so that the source code is easily read from top to bottom. BUG=none. Review URL: https://codereview.chromium.org/13896005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194794 0039d316-1c4b-4281-b951-d872f2087c98
-
jorgelo@chromium.org authored
BUG=232068 TEST=daisy loads and GPU acceleration works together with a policy change. TEST=desktop Chrome works with NVIDIA graphics. Review URL: https://chromiumcodereview.appspot.com/14271005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194793 0039d316-1c4b-4281-b951-d872f2087c98
-
agayev@chromium.org authored
BUG=157187 TEST=net_unittests --gtest_filter="FlashCacheTest.*" --gtest_repeat=10 --shuffle Review URL: https://chromiumcodereview.appspot.com/14265009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194792 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
Original code could not detect an error when the parent entry is missing. BUG=232054 TEST=unit_tests Review URL: https://codereview.chromium.org/14249007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194791 0039d316-1c4b-4281-b951-d872f2087c98
-
mad@chromium.org authored
BUG=None Review URL: https://chromiumcodereview.appspot.com/14261006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194790 0039d316-1c4b-4281-b951-d872f2087c98
-
sammc@chromium.org authored
Previously, if the MIME type of a file passed to a file handler of a platform app, the app would be launched without the file, even if the file handler accepted * or */*. With this change, a file with an unknown MIME type is treated the same as one with a MIME type of application/octet-stream. BUG=219402 TEST=browser_test PlatformAppBrowserTest.LaunchNoType Review URL: https://chromiumcodereview.appspot.com/14254002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194789 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This patch moves the butter bar in the new Files.app's UI to the left side bar. TEST=Launch with --file-manager-new-ui, copy some files. Verify if legacy Files.app still work. BUG=226912 Review URL: https://codereview.chromium.org/14167008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194788 0039d316-1c4b-4281-b951-d872f2087c98
-
hidehiko@chromium.org authored
This introduces a new utility interface ReaderProxy, which will be used to implement DriveFileStreamReader, and its implementation for local file, named LocalReaderProxy. BUG=127129 TEST=Ran unit_tests Review URL: https://chromiumcodereview.appspot.com/14237004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194787 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
BUG=128079 Review URL: https://chromiumcodereview.appspot.com/14235015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194786 0039d316-1c4b-4281-b951-d872f2087c98
-
hkuang@chromium.org authored
Enable video painting on Canvas for Chrome on Android. This change should land after another patch landing in https://codereview.chromium.org/13685002. BUG=147265 TEST=visited the following site: http://html5doctor.com/demos/video-canvas-magic/demo1.html Visit http://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_canvas_drawimage_video. Change different parameters of the canvas and video. Compare the result between desktop chrome and android chrome to see if video painting results are the same. Canvas 500X400 ctx.drawImage(v,60,60,320,176) PASS Canvas 500X400 ctx.drawImage(v,0,0,320,176) PASS Canvas 200X100 ctx.drawImage(v,0,0,320,176) PASS Canvas 200X100 ctx.drawImage(v,50,50,320,176) PASS Canvas 500X400 ctx.drawImage(v,0,0,30,30,5,5,260,125) PASS Canvas 500X400 ctx.drawImage(v,0,0) PASS Canvas 600x700 ctx.drawImage(v,90,90,80,80,100,100,260,125) PASS TODO: More complex and mixed 2D Canvas operation to see if the painting result is right(Need to learn some more JS for that). Review URL: https://chromiumcodereview.appspot.com/13620008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194785 0039d316-1c4b-4281-b951-d872f2087c98
-
gbillock@chromium.org authored
BUG=None Review URL: https://chromiumcodereview.appspot.com/12647013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194784 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
Now, the only outside caller of the method is drive-internals. However, after we have moved to DB store, loaded is equivalent to having changestamp > 0. So there's no need to have both in the UI. BUG=none Review URL: https://codereview.chromium.org/14271007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194783 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=179229 Review URL: https://chromiumcodereview.appspot.com/14093016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194782 0039d316-1c4b-4281-b951-d872f2087c98
-
yhirano@chromium.org authored
BUG=226933 Review URL: https://chromiumcodereview.appspot.com/13936002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194781 0039d316-1c4b-4281-b951-d872f2087c98
-
cjhopman@chromium.org authored
This action is triggered whenever the top-level library is re-linked. This file being touched then triggers generating a Java file, and then rebuilding/installing the APK. This is all unnecessary. Instead, only write this file if the output has changed. Then, since the ninja generator uses restat=1, dependent actions will only be retriggered when this actual changes (almost never). BUG=158821 Review URL: https://chromiumcodereview.appspot.com/13891010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194780 0039d316-1c4b-4281-b951-d872f2087c98
-
qiankun.miao@intel.com authored
There are a lot of warnings when build chromium with gcc4.8, which are in "typedef ‘foo’ locally defined but not used" pattern. Add "-Wno-unused-local-typedefs" to suppress these warnings. BUG=227506 TEST=build with gcc4.8 and check no above warnings appear. Review URL: https://chromiumcodereview.appspot.com/13811009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194779 0039d316-1c4b-4281-b951-d872f2087c98
-
kkimlabs@chromium.org authored
BUG=231028 Review URL: https://chromiumcodereview.appspot.com/14095010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194778 0039d316-1c4b-4281-b951-d872f2087c98
-
benquan@chromium.org authored
BUG= 232274 Review URL: https://chromiumcodereview.appspot.com/14060013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194777 0039d316-1c4b-4281-b951-d872f2087c98
-
mgiuca@chromium.org authored
Now it explicitly says that apps and extensions may use any size of icon, but still recommends certain basic sizes, in particular 128x128. BUG=230281 Review URL: https://chromiumcodereview.appspot.com/14037008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194776 0039d316-1c4b-4281-b951-d872f2087c98
-
aboxhall@chromium.org authored
Modify AccessibilityTreeFormatter to build up an internal representation of the tree in the form of DictionaryValue et al. This may be used at a later stage to create a JSON representation of the tree. Also modify the Mac platform implementation to use the NSAccessibility attribute names rather than method names. BUG= Review URL: https://chromiumcodereview.appspot.com/13479003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194775 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
Created method for obtaining signin profile. Signin profile used instead of "DefaultProfile" during login phase. BUG=225116 R=nkostylev@chromium.org TBR=brettw Review URL: https://codereview.chromium.org/13633003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194774 0039d316-1c4b-4281-b951-d872f2087c98
-
epenner@chromium.org authored
On certain Android builds, ANativeWindow_fromSurface will fail during startup, and we we don't handle this failure. BUG=230359 NOTRY=true No try, since it's Android only. Review URL: https://chromiumcodereview.appspot.com/14017019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194773 0039d316-1c4b-4281-b951-d872f2087c98
-
calamity@chromium.org authored
Fix an oversight where the current command line's program was being used instead of getting the program from PathService. BUG= Review URL: https://chromiumcodereview.appspot.com/14011005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194772 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=224531 Review URL: https://chromiumcodereview.appspot.com/13888010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194771 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
Instead of hardcoding GL_TEXTURE_2D BUG=230300 Review URL: https://chromiumcodereview.appspot.com/13870013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194770 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This patch introduces new awesome scrollbars as well as restyles the file list, including: checkbox to the right side, removing the pinning checkbox, auto-sizing of the columns. TEST=Run with --file-manager-new-ui. Legacy version should also not be broken. BUG=226912 Review URL: https://codereview.chromium.org/14096016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194769 0039d316-1c4b-4281-b951-d872f2087c98
-
calamity@chromium.org authored
Previously the NTP apps page would not show if the app launcher was installed. Now it will show regardless. This patch also restores apps to chrome://apps when the app launcher is installed. BUG=225371 Review URL: https://chromiumcodereview.appspot.com/13926002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194768 0039d316-1c4b-4281-b951-d872f2087c98
-
ramankk@chromium.org authored
Autofill:Autocheckout: In addition to "Enable Experimental Form filling" flag, support second method of enabling Autocheckout: using finch experiment. Autocheckout will be enabled if either of the conditions is true. Will remove "Enable experimental form filling" flag, once finch experiment is setup completely. BUG=230026 Review URL: https://chromiumcodereview.appspot.com/13811045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194767 0039d316-1c4b-4281-b951-d872f2087c98
-
rlarocque@chromium.org authored
This change removes SyncSessionJob entirely. The first step towards this goal was to refactor all functions that depended on SyncSessionJob. All these functions have either been inlined or modified to take different parameters instead. DoSyncSessionJob was split into two separate functions, one for configure jobs and one for nudge jobs, which removes the need for SyncSessionJob's "purpose" member. The SyncScheduler's pending_configure_job_ has been replaced with a ConfigParams member, since that was the only part of the job still being referenced. The pending_nudge_job_ has been replaced with scheduled_nudge_time_ (which is similar to the old scheduled_start_ member of SyncSessionJob) and a new object called a NudgeTracker. The NudgeTracker inherits the SyncSessionJob's responsibilities with respect to coalescing nudge sources. The plan is to extend this class to support more sophisticated nudge coalescing in the future. For now it tries to emulate the old SyncSessionJob behaviour as closely as possible. Some of the refactoring does change behaviour. In particular, the decision-making logic has been updated to fix issues 179515 and 155296. BUG=175024,179515,155296 Review URL: https://chromiumcodereview.appspot.com/13743003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194766 0039d316-1c4b-4281-b951-d872f2087c98
-
crogers@google.com authored
Some audio hardware is presented as separate input and output devices even though they are really the same physical hardware and share the same "clock domain" at the lowest levels of the driver. A common of example of this is the "built-in" audio hardware: "Built-in Line Input" "Built-in Output" We would like to use an "aggregate" device for these situations, since CoreAudio will make the most efficient use of the shared "clock domain" so we get the lowest latency and use fewer threads. BUG=none TEST=extensive manual testing with built-in Mac hardware http://chromium.googlecode.com/svn/trunk/samples/audio/visualizer-live.html Review URL: https://chromiumcodereview.appspot.com/13403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194765 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
Because of typo, gallery wasn't showing up. This patch fixes the typo and also converts every instance of toggleFullscreen to toggleFullScreen for consistency. TEST=Enter Files.app, go to gallery, fire the slide show. BUG=232087 Review URL: https://codereview.chromium.org/14316003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194764 0039d316-1c4b-4281-b951-d872f2087c98
-