- 17 Jul, 2019 40 commits
-
-
Miguel Casas authored
crrev.com/c/1600950 update the calls to |decoder_| but didn't update the corresponding unit tests expectations. Since |mock_decoder_| is a nice mock, nothing broke. This CL updatese |mock_decoder_|s expectations and makes MockAcceleratedVideoDecoder a StrictMock. Bug: 984836 Test: media_unitests on any cros target, including CQ bots. Change-Id: I339b657502ea27702ce8c90b94c0f9d847e97b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706553Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#678405}
-
John Lee authored
With crrev.com/650435, focus and other accessibility attributes were moved to the radio button itself instead of the host element. Change-Id: I42cf86b2ea4bb67cb55add00dc6602e692a8800c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706909Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#678404}
-
Sunny Sachanandani authored
HIGH_PRIORITY_CLASS uses priority level 10 for THREAD_PRIORITY_LOWEST, which is higher than THREAD_PRIORITY_NORMAL (8) used by most Chrome threads. ABOVE_NORMAL_PRIORITY_CLASS should give us the same benefit without the drawbacks. This only affects the GpuProcessHighPriorityWin experiment. Bug: 965778 Change-Id: I59fa93bd534bfe0e0c2014735bb7d13e82715f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705575Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#678403}
-
Peter Beverloo authored
Change-Id: I2b193903f0c16d92b26a3d66df9f570819ebe235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690962 Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#678402}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/64f2cec30c96..0662a4afb5d1 git log 64f2cec30c96..0662a4afb5d1 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 sugoi@google.com MacOS WSI Created with: gclient setdep -r src/third_party/swiftshader@0662a4afb5d1 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Id52348e60fbde859b574094f96d4e263a1664687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706360Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678401}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/66c4e85a160b..a552be46f95c git log 66c4e85a160b..a552be46f95c --date=short --no-merges --format='%ad %ae %s' 2019-07-17 vapier@chromium.org move from filter builtin to list comprehensions Created with: gclient setdep -r src/third_party/chromite@a552be46f95c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ie0af8229da1f2ad8beadcec093753c3fd83f2886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678400}
-
Brian Sheedy authored
Halves the number of iterations in TestControllerInputRegistered. With the old value of 10, the test runtime was ~9 seconds, which was uncomfortably close to the default JS timeout of 10 seconds. It's suspected that if the test machine was a bit slow, the test would end up timing out. 5 iterations should still be plenty to verify that input works. TBR=alcooper@chromium.org Bug: 984989 Change-Id: Ie6c67725c692ea47aa83a4adc3c8fcf0aa9e9692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706774Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#678399}
-
Esmael El-Moslimany authored
Bug: 870742 Change-Id: Ie24c86d270212f2dd2d630ea91f751f0bcebf1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698645Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#678398}
-
Nina Satragno authored
When DevTools reports an error with code InvalidParams, translate it into an InvalidArgument error instead of UnknownError. This lets us perform certain checks on the devtools side that are not possible on the chromedriver side and return InvalidArgument when they fail without comparing against the error description on chromedriver. Additionally, we can avoid duplicating certain parameter checking on the chromedriver side. This patch also adds tests for the ParseInspectorError function. Bug: chromedriver:3025 Change-Id: I4a01136c87a53a1c5b2baac20c1ea65a60699d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706618 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#678397}
-
Reilly Grant authored
In r626961 and r643767 we removed the CancelRead() and CancelWrite() calls from ~SerialConnection() with the assumption that since the SerialPortPtr was being closed it would cancel I/O in the process of closing the OS-level file handle. The problem is that SerialIoHandler explicitly retains a self-reference when submitting a read or write operation and until those are completed (or canceled) the object won't be destroyed and the OS-level file handle closed. SerialConnection solved this problem by explicitly canceling the I/O in its destructor and this patch moves that logic to ~SerialPortImpl(). A better long-term fix is to remove the self-references and make SerialIoHandler uniquely owned by SerialPortImpl but that requires other refactoring work. Bug: 964683 Change-Id: Ie5e59696df23c48dc9e9224772c621db5438c1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707028 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#678396}
-
Pavel Shmakov authored
Bug: 984205, 984300 Change-Id: I6d3c9344a51fa12fe61d000b7d78706b3635ba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705897 Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#678395}
-
Geoff Lang authored
These extensions were being exposed as requestable but failing to initialize because they weren't requested. Allow GL_OES_compressed_ETC1_RGB8_texture in all cases when the driver supports it. ANGLE has been updated to only expose this extension with native support. TBR=kbr@chromium.org BUG=angleproject:3675 BUG=983142 BUG=983750 Change-Id: Idb4b20638990432d3526d5559396a695fc814b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702765 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#678394}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0be40bf53fc4..3a51b0e9d143 git log 0be40bf53fc4..3a51b0e9d143 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 oprypin@webrtc.org Reland "Reland "Add wrapper to normalize flags."" Created with: gclient setdep -r src/third_party/webrtc@3a51b0e9d143 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia084a5be237c3347f30511f5cf420c5474d3136a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678393}
-
Ian Kilpatrick authored
This adds an optimization to speculatively place floats based on either: - The previous layout's "forced" BFC offset. - The previous layout's "optimistic" BFC offset. - The current layout's BFC block-offset. (in that order). This turns out to be an important optimization for sites which always trigger a 2-pass layout when we can't determine the "exact" position of them during the 1st pass (washingtonpost.com was one of these sites for example). If the "optimistic" BFC block-offset isn't set, this shouldn't change the control-flow of the current layout algorithm. This also saves some more stack space by removing a: Vector<NGUnpositionedFloat, 1> from the stack. Change-Id: Iae2ce8684e00ab166d810e875d7d0c420202a194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619047Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#678392}
-
Yao Xiao authored
Why: All call sites that create a non-empty network isolation key must provide a top-frame-origin. Bug: 984157 Change-Id: I26c15816073a6424fe8bad23c52494114ba08e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704522 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#678391}
-
Yi Su authored
Bug: 983776 Change-Id: I96b5e093b2c33e94339051625b75fe9733e915ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706852 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#678390}
-
Dominik Röttsches authored
In preparation for moving Blink fallback to an API call on all Windows versions instead of using a hard-coded list, add a test to retrieve fallback fonts for a larger set of languages and establish a test baseline for those. It is important to note that the results are not only affected by fallback but also by what we configure as default preferences fonts for certain scripts, which needs updating too (issue 960450). Bug: 976737 Change-Id: Ibdf990e9ea8beb6c9742774d97fff4b4981a00b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705916 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#678389}
-
Jeroen Dhollander authored
Previously we used a capture delay (i.e. the delta from 'now'), which 1) was rounded to milliseconds and 2) started losing accuracy if the message took a while to process. This has been replaced by a |TimeTicks| instance. BUG=335335,587291,978644,b/79769953 Change-Id: Ieb4434e8ba44348b251593425236a0481ee601d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691787 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#678388}
-
Francois Doray authored
Changes in this CL: - Make FrameSchedulerImpl::main_thread_scheduler_ const. - Remove unnecessary MainThreadTaskQueue::DetachFromFrameScheduler(). Reason: - Make it easier to reason about association between MainThreadTaskQueue and (MainThread|Frame)Scheduler in upcoming frame interference CL https://chromium-review.googlesource.com/c/chromium/src/+/1689339. Bug: 984057 Change-Id: I0ba99a7ce6126ddf3ac5cf661c3bd3b32e8d82b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706714Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#678387}
-
Roberto Carrillo authored
This changes the component scraping to use the nearest ancestor's component/team/os tag if the current directory does not define one. Also, allow multiple teams mapping to the same component, and modify presumbit to use the same criteria, warning instead of failing when such situation arises. Note that the 1:1 component to team mapping will continue to be present in the mapping output, but it will show the team that is defined at the topmost OWNERS file in the tree that is tagged with such component. R=chanli,dpranke Bug: 981713 Change-Id: Ie6f51f0beeb4ce63cedf302f4f15b2e2af25b451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693362 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#678386}
-
Yi Gu authored
[VizHitTesing] Fix flaky test SitePerProcessHitTestBrowserTest.SurfaceHitTestPointerEventsNoneChanged The test was flaky due to a race condition which can be fixed by using HitTestRegionObserver::WaitHitTestDataChange(). Test is updated with setTimeout in JavaScript to reliably reproduce the flakiness. Bug: 968970 Change-Id: I7a90429aa0d405165083147ae2f8eba41eb35fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703813Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678385}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b243a2a4f27b..c44d2c7919d7 git log b243a2a4f27b..c44d2c7919d7 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 syoussefi@chromium.org Fix glGetProgramResourceName filling output with 0 Created with: gclient setdep -r src/third_party/angle@c44d2c7919d7 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: Ie08cb0e1fe11214e5b2b5c0fc618733211d73f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706356Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678384}
-
Vasiliy Telezhnikov authored
This is follow-up CL to 1695991 Bug: 981934 Change-Id: I9db3fed87596d5da5b96fae8d3db72be44bac938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697762Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#678383}
-
Ken Buchanan authored
This is a minor cleanup to add some NOTREACHED() calls, so that if Bluetooth methods are called on a non-Bluetooth FidoDevice, it will crash with DCHECKs on. Change-Id: I5aa948c5a254581ffb50a25e246b8ff7cfad2e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704320 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#678382}
-
John Lee authored
https://imgur.com/a/x0iNkYr Bug: 973674 Change-Id: I817474ff3a681f625c86be9cc1e6eb57f04eea26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700260Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#678381}
-
Anatoliy Potapchuk authored
Change-Id: Icaf5588af67c8e3da50e7148dd57c4f0e63f93ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706439Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#678380}
-
Christian Biesinger authored
We only need to ignore percentages when the flex item has a definite height; if it doesn't, percentages get treated as height: auto which is the desired behavior. This fixes the two regressions that were filed because of this. Bug: 984606, 981481 Change-Id: I008d9ec316e4ff233eac03ead30f09ed85c4c120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705578 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#678379}
-
vikassoni authored
This is a reland of 6a42b67c with a test Pixel_Video_Context_Loss_VP9 being marked as failing on webview. Original change's description: > Update pixel video tests to use higher tolerance. > > 1. Update pixel video tests to use higher tolerance value for all > formats on all devices. A tolerance of around 10% is required for > all the pixel tests to match gold/color expectations on all the > devices. > > 2. Add viewport metadata to the html page to scale correctly on mobile > devices. > > 3. This CL fixes 5 pixel tests on android - Pixel_Video_MP4, > Pixel_Video_MP4_FourColors_Aspect_4x3, Pixel_Video_MP4_FourColors_Rot_180, > Pixel_Video_VP9 and Pixel_Video_Context_Loss_VP9. Remove the test > expectations from pixel_expectations.txt. > > Bug: 925744 > Change-Id: I6d9dbd270dcc45e38f45826f98cf9035563b5f46 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699401 > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#677548} Bug: 925744 Change-Id: Ib0fb98627ac654c09b217e67bafef0412a9a9887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704392Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#678378}
-
Clark DuVall authored
We are in the process of migrating NavigationURLLoaderImpl to the UI thread. Since AppCache is implemented as a NavigationLoaderInterceptor, it must be able to support running on the UI thread. This CL allows AppCache to be used on the UI thread when the NavigationLoaderOnUI feature is enabled. Bug: 824856 Change-Id: I0be1102bc0bda3a4757171756d6f7c8c6ceb2417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702983 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#678377}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I8f28f3beca2de6591f8e675aad2c14bb474432bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704357 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#678376}
-
khmel@chromium.org authored
This collects metrics for runtime performance and reports it via UMA for set of apps. DD: https://goto.google.com/arc++app-runtime-performance-metrics TEST=Locally + unit tests BUG=b:134705131 For trivial change in c/b/ui/webui/chromeos/arc_graphics_tracing/* TBR=xiyuan@chromium.org Change-Id: I564151ff2aff6a0b63f4a34b0facd3f2d536f9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691067Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#678375}
-
John Lee authored
The --cr-actionable mixin wasn't too meaningful and only applied a pointer cursor. We should use [actionable] in places where we can and just manually add the pointer cursor to places where we can't. Bug: 973674 Change-Id: Ie0e43f6e463276417701f1f172c9f91987b3a09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705016Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#678374}
-
Luke Zielinski authored
This is a leftover review from crrev.com/c/1677161. It ensures we always include the current manifest file for WPT. Bug: 937369 Change-Id: I2200cb5644d1518129e577f8612d1e83a4a79c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706640 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#678373}
-
Owen Min authored
Full profile reports are append into the report for all activated profiles. Multiple requests are created if total report size exceeds the limitation. Bug: 956237 Change-Id: Iee36c34857346ca2a6aa2dbbfe7c09301fd3d129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702770 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#678372}
-
Dan Harrington authored
As our team will be maintaining this in the future Change-Id: I9382de5a7ef6fec6bdb517b12a9d952cf23f38bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706796Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#678371}
-
Mark Mentovai authored
For Apple Developer accounts associated with multiple development teams (as mine is), altool requires --asc-provider to select a team any time --username is used. Arguments are added to the sign_chrome.py and notarize_thing.py notarization drivers whose values are propagated to altool as needed. For most Apple Developer accounts associated only with a single development team, --asc-provider is not necessary. This also removes --no-dir-entries from the zip command used to build an archive for notarization, because if the code was signed with empty directories, they need to be present for notarization too. Bug: 980334 Change-Id: I646f3ee5729030df01ea200b9e72138626208931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682685 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#678370}
-
Alberto Herrera authored
Class that gets the battery level of a connected Bluetooth device through the standardized GATT Battery Service. Polling is done periodically and updates the corresponding device::BluetoothDevice. Instances for this class are expected to be created and owned by the GattBatteryController class (to be implemented in a separate CL), for each connected BLE device. Design doc at go/cros-bt-battery. Bug: 785758 Change-Id: Ic0de3e9b3d813537610378480cac6daaf8e25204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674716 Commit-Queue: Alberto Herrera <ahrfgb@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#678369}
-
Robert Ogden authored
This is needed to allow functioning of the lite pages URL Throttle. Bug: 977603 Change-Id: Ica66cb83d355c35ff4e5c2486255d18e332d5acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707049 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#678368}
-
Drew Stonebraker authored
Report 100% of crashes on debuggable builds. This may help us find dogfood/dev/etc related issues more quickly. Bug: 984619 Test: Add logs in is_debug_android to test expected values. Change-Id: I3132b42d42ce1a5609c3ab688c4d56749fee1598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704693Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Cr-Commit-Position: refs/heads/master@{#678367}
-
Evan Stade authored
A new helper called BrowserActivityWatcher is introduced to encapsulate BrowserList observation. This results in fewer platform macros since Android doesn't use BrowserList (or NOTIFICATION_BROWSER_[...] before it). The structure of ThreadWatcherObserver, particularly startup and shutdown, was unorthodox so that's also made more idiomatic. The class can move entirely to the cc file. Bug: 268984 Change-Id: I46a8948349e62993c96e85963cae3420679ae45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695831Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#678366}
-