- 18 Jun, 2018 40 commits
-
-
Takuto Ikuta authored
Recently, I saw some tests has large shard duration. http://shortn/_XYVwYNWZJb This CL increases the number of shard so that tests in CQ has 15 minutes average shard duration. Change-Id: If4011de7a6c3c6f98e98bc70ba2fa9a87aca8f90 Reviewed-on: https://chromium-review.googlesource.com/1104277Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#567993}
-
Mustaq Ahmed authored
Bug: 802291 Change-Id: I2b8e7ee5cd61cc31e07bd7d2ed6da69a43743b80 Reviewed-on: https://chromium-review.googlesource.com/1097796Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#567992}
-
Marc Treib authored
It's too slow and times out. TBR=fukino@chromium.org Bug: 851988 Change-Id: I868d846e3fae5f7dd16b2a2c7203602008221396 Reviewed-on: https://chromium-review.googlesource.com/1104424Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#567991}
-
Douglas Creager authored
This updates the Reporting implementation to include the naming changes in https://github.com/WICG/reporting/issues/72. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2446a8baaf512760949ac5bcaae56088def7d600 Reviewed-on: https://chromium-review.googlesource.com/1073060 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#567990}
-
Daniel Nicoara authored
The curent implementation tries to order one window in a list of potentially unordered windows. The window list is not always ordered since we never order hidden windows. Use stable_sort to order all windows by ID. Between windows with the same ID, promote the window currently becoming visible. BUG=NONE TEST=Verified on device and wrote unittests to cover window ordering. Change-Id: I52a760a6fbb84752a523c89ba39963f443ab4712 Reviewed-on: https://chromium-review.googlesource.com/1103296Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#567989}
-
Bence Béky authored
Bug: 807724 Change-Id: I018eb874f2e9097dba9d8acdf58d6a18c569cc9d Reviewed-on: https://chromium-review.googlesource.com/1100354Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567988}
-
Jared Saul authored
(Also alphabetized the autofill category) Change-Id: I18f03d1404c166ce5d46c8abd7db935aff360615 Reviewed-on: https://chromium-review.googlesource.com/1103587 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#567987}
-
Marc Treib authored
TBR=minch@chromium.org NOTRY=true Bug: 838756 Change-Id: I3cf207f31b7063f64c87d7cc0d8a93e6299ed5cd Reviewed-on: https://chromium-review.googlesource.com/1104418Reviewed-by:
-
Ioana Pandele authored
This dialog is prompted when the user taps the password generation button in the keyboard accessory or in the accessory sheet and is meant to replace the password generation popup. It is currently made to display the generated password and 2 buttons to accept and reject it. It will (not included in this CL) also display the explanatory text that is currently present in the generation popup. Bug:835234 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I98107745678c153819f00555ebdb61917121606a Reviewed-on: https://chromium-review.googlesource.com/1064611 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567985}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f3ce003c2baa..d994c8643744 git log f3ce003c2baa..d994c8643744 --date=short --no-merges --format='%ad %ae %s' 2018-06-18 perezju@chromium.org [soundwave] Include request made in RequestError Created with: gclient setdep -r src/third_party/catapult@d994c8643744 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2bc78ab8bff01d5f9f281569a33c67d23d6690d1 Reviewed-on: https://chromium-review.googlesource.com/1104097Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567984}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I422994c678006f6b009bf50fbe9fee8645be0cfe Reviewed-on: https://chromium-review.googlesource.com/1104297 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567983}
-
Mohamed Amir Yosef authored
This CL adds support for importing and exporting sync metadata to the BookmarkModelTypeProcessor. Sync metadata are compiled into BookmarkModelMetadata proto. This proto is used to communicate the sync metadata out and into the processor. This CL prepares for another CL that would actually persist/load the sync metadata to/from disk. Bug: 516866 Change-Id: I0a4af54383ac336a759c0504e4feee1ff1bda7c1 Reviewed-on: https://chromium-review.googlesource.com/1098918 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567982}
-
Taiju Tsuiki authored
This reverts commit c4662e1a. Reason for revert: This seems to gain the binary size by 0.3~0.9% on mac and win. Original change's description: > Oilpan: Reduce the size of heap_page.h. > > heap_page.h is used in 6,000+ compilation units, and this CL reduces its > estimated expanded size from 1.72MB to 1.40MB. > > Bug: 242216 > Change-Id: I0f53c3f57511378289a841b89c6e01c4a2748d4a > Reviewed-on: https://chromium-review.googlesource.com/1104080 > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567972} TBR=keishi@chromium.org,tkent@chromium.org Change-Id: I54c95f8102aadf8459a833db0d27b970d291eb93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 242216, 853703 Reviewed-on: https://chromium-review.googlesource.com/1104357Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#567981}
-
clamy authored
This CL is part of a serie of CLs to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: I98d76530c98b62f9c1a5cdd729aea52d39b13575 Reviewed-on: https://chromium-review.googlesource.com/1102679Reviewed-by:
-
Florent Castelli authored
RangeErrors are not DOMException and the function we used to translate them to DOMException couldn't handle anything else. Using an ExceptionState, we can properly reject the promises with the right type of exception. Bug: 849214 Change-Id: I14ad11ba43910a83770d66c6976509c0feba3408 Reviewed-on: https://chromium-review.googlesource.com/1097325 Commit-Queue: Florent Castelli <orphis@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#567979}
-
Dave Tapuska authored
This reverts commit 7223839e. Reason for revert: Possibly per regression: https://bugs.chromium.org/p/chromium/issues/detail?id=852988 Original change's description: > Silence 64 to 32 bit truncation errors on WTF strings. > > strlen returns size_t which can be 64 bits yet all of the WTF strings > use 32 storage lengths. Add a helper function string_unsigned which > returns the strlen with a SafeCast to unsigned. Place it in an > implementation file to avoid increase in binary size due to inlining. > > BUG=588506 > > Change-Id: I3b5025c1fee9b1eda9cd017af6bdfc66d808e802 > Reviewed-on: https://chromium-review.googlesource.com/1096133 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuta Kitamura <yutak@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566415} TBR=yutak@chromium.org,haraken@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 588506 Change-Id: I85d200afa3816ffefdbfa34ad86f8bddc168ccb1 Reviewed-on: https://chromium-review.googlesource.com/1101761Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#567978}
-
Thiemo Nagel authored
Also add a privacy subfolder and an OWNERS file. BUG=853154 Change-Id: I1b527c9a7244eb932677897a46774463409ac4c0 Reviewed-on: https://chromium-review.googlesource.com/1102418 Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#567977}
-
Matt Falkenhagen authored
It was using two data members to determine if there was a controller. It only needs one. Minor cleanup for the linked bug. Bug: 850839 Change-Id: I1d816453047721d79503d47defc8f8cb3e25c7d9 Reviewed-on: https://chromium-review.googlesource.com/1103981 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#567976}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/16e54609..f2bcc477 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I18c46bb079d50642dfeb5e38f6bfb1d5777dc186 Reviewed-on: https://chromium-review.googlesource.com/1103943Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567975}
-
Dave Tapuska authored
The implementation isn't there yet but this flag controls whether the eventual implementation should do something or not. BUG=348877 Change-Id: I72a5a0eb2873d0a06ae5ce84c494b4d24b91434d Reviewed-on: https://chromium-review.googlesource.com/1100942 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Balazs Engedy authored
AuthenticatorRequestSheetView defines the basic structure of sheets shown in the authenticator request dialog. Each sheet corresponds to a certain step of the authentication flow, and encapsulates the controls above the Ok/Cancel buttons, namely: -- an optional `back icon`, -- the title of the current step, -- the description of the current step, and -- a view with step-specific content, filling the rest of the space. AuthenticatorRequestSheetModel will be subclassed for each step of the authenticator request UX flow, and, for each step, the subclass is going to encapsulate: (1) knowledge of the set of actions possible to the user at that step, (2) pieces of data required by views to visualise the sheet: (a) strings to use on labels/buttons rendered by the SheetView and the AuthenticatorRequestDialogView, and the state of the buttons, (b) data for additional step-specific contents rendered by SheetView subclasses, if any, (3) logic to handle user interactions with: (a) the `Back`, `Accept`, `Cancel`, buttons, even though the latter two are actually rendered by the AuthenticatorRequestDialogView, (b) the step-specific contents, if any. For now, only a sheet with the original static content is shown. Bug: 849323 Change-Id: I8b92f180a3dc3abc901dcb2ad0200e45271416a3 Reviewed-on: https://chromium-review.googlesource.com/1097321 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:Trent Apted <tapted@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#567973}
-
Kent Tamura authored
heap_page.h is used in 6,000+ compilation units, and this CL reduces its estimated expanded size from 1.72MB to 1.40MB. Bug: 242216 Change-Id: I0f53c3f57511378289a841b89c6e01c4a2748d4a Reviewed-on: https://chromium-review.googlesource.com/1104080Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#567972}
-
Oscar Johansson authored
This commit will enable Jumbo for chrome/browser/extensions. By enabling and running Jumbo the effort of building is reduced by 7 times (around 40 CPU minutes on the test computer). Bug: 850484 Change-Id: Icd42cbbf53dc58d64143c6979ba500d3ec9315c5 Reviewed-on: https://chromium-review.googlesource.com/1101017 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567971}
-
Koji Ishii authored
Following CL:1087192, this patch fixes block-level baseline for flipped-lines (vertical-lr.) Particulally, this patch fixes when the inline-block contains multiple lines, and that the offset-to-linebox needs to be flipped. The sample raised by mstensho@ in CL:1087192 now passes. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ica615f230403e3266031410ac389f48b5db12784 Reviewed-on: https://chromium-review.googlesource.com/1098909Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567970}
-
Yoichi Osato authored
This patch implements painting text match markers. Logic is copied from inline_text_box_painter.cc, which is very simple: 1 paint background rect with a given color 2 paint foreground text with a given color This patch fixes: paint/invalidation/text-match-pre-wrapped-text.html paint/invalidation/text-match-transparent-text.html paint/invalidation/text-match.html paint/markers/first-letter.html Bug: 850448 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic09ef1748620d5d353f89fc5c8ebced768d5a5ed Reviewed-on: https://chromium-review.googlesource.com/1103990Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#567969}
-
Marc Treib authored
TBR=thomasanderson@chromium.org NOTRY=true Bug: 853079 Change-Id: I982e23595e1ca923c6ebbc09470b74e7b41ab20f Reviewed-on: https://chromium-review.googlesource.com/1104171 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Joyee Cheung authored
Update and unskip fast/js/constructor-length.html now that V8 has been updated to reflect the spec change on DateView.length. See https://chromium-review.googlesource.com/c/chromium/src/+/1097455 Bug: v8:7816 Change-Id: Ife1c177d1bd177b5a51371ce8c719c9b754d5ad0 Reviewed-on: https://chromium-review.googlesource.com/1099357 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#567967}
-
Mikel Astiz authored
This is a reland of 42c62276 The underlying issue in SyncedTabDelegateAndroid::GetSessionId() has been reverted, which introduced an accidental behavioral difference in the original version, causing crashes on Android for placeholder tabs (i.e. tabs without WebContents). TBR=avi@chromium.org,treib@chromium.org Original change's description: > Avoid a proxy tab helper on Android for sync delegation > > Prior to this patch, TabContentsSyncedTabDelegate was itself a tab > helper (WebContentsUserData) that was created on all platforms, with the > whole purpose to reuse a partial implementation of > sync_sessions::SyncedTabDelegate. > > This was a bit weird because > a) The life cycle diverges across platforms: created lazily on Android, > early otherwise. > b) On Android there was no real need to register a tab helper. > c) On Android, it's weird to reason about two tab delegates coexisting, > one of which is a proxy but also overrides some logic. > > Instead, let's make TabContentsSyncedTabDelegate a base class that is > *NOT* a WebContentsUserData, and let platform-specific subclasses > decide whether they want to register as WebContentsUserData, as well > as which logic they need to override. > > This also removes code that is dead on some platforms, because the > base class is abtract and doesn't implements all methods (as opposed > to a proxy object which cannot be abstract). > > Bug: 851905 > Change-Id: I305ad85e2392fdd2ce428c0464b7750ac599babf > Reviewed-on: https://chromium-review.googlesource.com/1097405 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567213} Bug: 851905 Change-Id: I9e060ecf1272fec1ceebd4353fd390b95e64b669 Reviewed-on: https://chromium-review.googlesource.com/1103717Reviewed-by:
-
Michael van Ouwerkerk authored
This reverts commit d51d3420. Reason for revert: A DCHECK is failing on the bots, see bug 853388. Original change's description: > VR: Adding move support for the platform UI > > This enables touch interaction with the web contents, effectively > enabling long press, drag, selection, etc. > > Context menu and selection handles are disabled for VR in this CL. > > Bug: 842916, 733656, 848740 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr > Change-Id: If50401ddbc130abde697b57d580bc492de2c4dda > Reviewed-on: https://chromium-review.googlesource.com/1091281 > Commit-Queue: Aldo Culquicondor <acondor@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567745} TBR=sky@chromium.org,mthiesse@chromium.org,jam@chromium.org,tedchoc@chromium.org,tdresser@chromium.org,acondor@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 842916, 733656, 848740, 853388 Change-Id: I24b609f9c2c92efde74b53020a44907e0a30627e Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr Reviewed-on: https://chromium-review.googlesource.com/1104217Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#567965}
-
Marc Treib authored
TBR=kbr@chromium.org NOTRY=true Bug: 853651 Change-Id: If04328135ede460ae8957e2e135c96ae691ae221 Reviewed-on: https://chromium-review.googlesource.com/1104165 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Olivier Robin authored
DnsConfigService on iOS doesn't watch the config so its result can become inaccurate at any time. Disable it to prevent promulgation of inaccurate DnsConfigs. https://cs.chromium.org/chromium/src/net/dns/dns_config_service_posix.cc?q=dns_config_service_po&sq=package:chromium&g=0&l=64 shows that this is not implemented on iOS. Calling the method produces parasite log at startup. Bug: 852369 Change-Id: I3d24bcb1089fb3c9099b1fffcb829c2a5a2449dc Reviewed-on: https://chromium-review.googlesource.com/1102317 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567963}
-
clamy authored
This CL is part of a serie of CL to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: Iac1ba1e85dc4b7b523c40cb64d9e0280f540ca22 Reviewed-on: https://chromium-review.googlesource.com/1102459Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#567962}
-
Daniel Bratell authored
Some mostly harmless *_aura* files were included by mistake in the non-aura build of content/renderer. They turned out to not be quite so harmless in a jumbo build if combined with the non-aura version of the same code. Change-Id: Idfe65638ca16a2e700b485acd67f253073ae5867 Reviewed-on: https://chromium-review.googlesource.com/1102426Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#567961}
-
Benoit Lize authored
Adds a tool to dump the content of all anonymous mapping in a given process, and one to show statistics about the content. From a process, this shows: - Total anonymous mappings size - For each page, whether it's present XOR swapped - The total number of 0 pages - Pages with identical non-zero content - Compressed size of non-zero pages. The compression ratio is derived using zlib, which is likely to be overestimating the compression ratio, as it's better than ZRAM's compression algorithm. Tested on Android and Linux. Sample output (cnn.com on Android Go): Total pages = 36532 (149.64MB) Total zero pages = 15191 (41.58%) Total present zero pages = 754 (3.09MB) Total size of non-zero pages = 87412736 (87.41MB) Total compressed size = 28994296 (33.17%) Duplicated non-zero pages = 812 Max non-zero pages with the same content = 387 Swapped pages = 231 (946.18kB) Non-present pages = 14667 (60.08MB) Freed = 5232960 (5.23MB) TBR: brucedawson@chromium.org Change-Id: Iba991f8a57d01591e72359163711064297ea8658 Bug: 845459 Reviewed-on: https://chromium-review.googlesource.com/1087059 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#567960}
-
clamy authored
This CL is part of a serie of CLs to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: Ibeba64f207ece1e02025beba9bc4ea7350e63402 Reviewed-on: https://chromium-review.googlesource.com/1102514Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Hwanseung Lee authored
replace std::find() with base::containsValue() at components/translate Bug: 561800 Change-Id: I8ec6023122fb42e7abcf1105bf24e4a0c1f9c5d0 Reviewed-on: https://chromium-review.googlesource.com/1102440Reviewed-by:
-
clamy authored
This CL is part of a serie of CLs to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: Id57db819996d8502fc58510aa6508ea2fc5e5bfb Reviewed-on: https://chromium-review.googlesource.com/1102473Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#567957}
-
Marc Treib authored
TBR=imcheng@chromium.org NOTRY=true Bug: 853114 Change-Id: I1155d8f2c59bd5a55bc99c334ea78e7689b07a7d Reviewed-on: https://chromium-review.googlesource.com/1104137 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
They were accidentally mixed up in both the IDL and the tests. (I used a macro to generate the tests from the IDL, so the same bug crept into both.) Bug: 844540 Change-Id: I04023b609402e2b795a69a785c7f04af3c9459f7 Reviewed-on: https://chromium-review.googlesource.com/1103447Reviewed-by:
-
Koji Ishii authored
This patch changes a test to non-quirks mode, that hits not-defined, non-interoperable line-height quirks. When all characters on a line is above baseline or below baseline, by applying e.g., 'vertical-align: 1em' or 'line-height: 0': * Blink/WebKit assumes the baseline is part of line-height, except for atomic inlines. * Gecko does not include baseline to line-height. * Edge always include baseline to line-height. * This problem appears only in line-height quirks mode, because otherwise we have a strut that includes baseline. It's not hard to fix this, but does not seem to worth. We can revisit if webcompat proves this is necessary. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I46fa04beae3f216a9293d029520cff69e8e63656 Reviewed-on: https://chromium-review.googlesource.com/1065751 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
-
