GitLab

base::ProtectedMemory is being deprecated because it's not widely used
enough to make a security impact and justify its maintenance burden.
Replace use of base::ProtectedMemory with raw function pointers and add
an attribute to disable CFI-icall checking.

Bug: 1018834
Change-Id: I0bc25d3a803c51a5d1d4c06d21925486393b1808
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884456
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710366}

This fixes a bug where docked DevTools in PWAs doesn't work (and would
affect anything that attempts to put two WebContents in a PWA).

This function was never implemented because it involved passing a
map of NSView*s over mojo. Since various refactorings, we now have a
ScopedNSViewIdMapping which helps with this.

Starting at the bottom of the change's stack and working to the top:
* Change NativeWidgetNSWindowBridge::SortSubviews to take a
  std::vector of NSView ids, instead of a std::map ranking NSView*s.
  In the function, create the std::map ranking from the std::vector.
* Change the caller, NativeWidgetMacNSWindowHost::ReorderChildViews.
  to build a std::vector of NSView*s, and then from that create a
  std::vector of NSView ids.
  * If the NSView*s do not have an id (that is, if they are not a
    WebContentsView, which only happens in tests), then create a
    temporary remote_cocoa::ScopedNSViewIdMapping to create an id.
* Rename NativeWidgetMacNSWindowHost's SetAssociationForView,
  ClearAssociationForView, and associated_views_ to reflect that the
  "associated views" are a map from views::NativeViewHosts (a subclass
  of views::View) and NSView*s.

Then there is an iffy part of the change
* Allow looking up an NSView's id (the uint64 that is sent over mojo
  to refer to the NSView) from the NSView.
* Arguably, we should change gfx::NativeView to also carry an id
  with it. But that is a too-large-scope change for now.

Bug: 991598, 1017446
Change-Id: I2371d1716f98c2e6223a5db0272984c98c6fa4db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885950
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710365}

This CL is lifting the parameterized unittests originally
wrote for windows to a common file to be available to
other platforms.

Test from KnownExpectedFonts will now also run on Linux.
  * Added the test cases for linux.
Test from Glyphs are now running on every platforms.

Adding a matching_glyphs count to font_fallback_linux.cc.
Previously, a default font was returned for a single character
even if it was not matching the character, it was still the
best match. If no codepoints are found, the font is considered
a no match.

Change-Id: Ie4f871281737e254bbdbea9e04f8e527f1049569
Fixed: 3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879956
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710364}

Using wpt-import in Chromium 0f9edb78.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I42e9dcaeeb0b356cf1a047ffd28045ae7ee81aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886374Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710363}

This removes the PROCESSING_* states and introduces
processing_navigation_throttle_ which is true iff NavigationThrottles
are running an event.

Bug: 916537
Change-Id: I72bdc5d8f51d68efcea29890915da1adb4243c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883518
Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710362}

Theme color was being stored in WebContentsImpl which meant that a page
coming from the bfcache would not correctly restore the theme color as
no OnThemeColorChanged event gets fired from the restored renderer.

So instead this patch stored the theme color in the RVH (that way it
gets restored automatically when the RVH is swapped) and WebContentsImpl
will check the color when a navigation happens and fire observers as
needed.

Bug: 1001087

Change-Id: Ic2ede6d3412bfc9581de1501f74d704145481f12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816476
Commit-Queue: Carlos Caballero <carlscab@google.com>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710361}

FakeServer::SetWalletData() now takes care of delivering invalidations
by broadcasting OnCommit() to observers, which is better aligned with
the production server and real-life scenarios.

Wallet-specific code in FakeServer refactored to adopt timestamps as a
better way to implement waits. Alternatives to achieve the same without
exposing the underlying timestamp for a progress marker run into the
issue that some tests still use TriggerGetUpdatesAndWait() without
actually changing the server data.

Bug: 1019108
Change-Id: Ia6df0f6c0a25a52e19ea4af33f6b96050a5c2968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886815
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710360}

First of all, bear in mind that this change affects only to
intrinsic size computation in legacy layout.

During the intrinsic size computation of blocks with inline children,
we are determining the breaking opportunities for each child. When the
word-break: break-word is used, each of this breaking opportunities
should account for the min-content size.

We only consider breakable locations for start and end if they are
br elements or spaces, under auto-wrap, to compute the intrinsic size
of a box. This is fine, since we are already using a break iterator
to determine the min-size of each word. However, we were incorrectly
summing the first_line_min_width for each inline sibling, even when
they were part of the same text line.

This change tries to avoid that problem by assuming that there is
always a breaking opportunity after every character, since the
spec now states that break-word should behave as normal and
overflow-wrap: anywhere.

Bug: 1013644
Change-Id: I04261b323cd029a624724363a566fccc826863af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856959Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#710359}

UnifiedConsent feature is now enabled on all platforms.

This CL does the following:
* It removes dead code from the SyncDisableObserver and cleans up its
tests.
* It removes a series of tests from the UKMBrowserTest that are no longer
relevant (UKM only depends on sync for purging extensions).

Note that the name SyncDisableObserver is no longer relevant:
* UKM does not really depend on Sync for UKM consent anymore
* UKM depends on sync for purging extensions.
As a follow-up CL, it may be a good idea to rename ukm::SyncDisableObserver to
ukm::ConsentStateObserver and rename the internals to avoid using SyncState as
the per-profile state.

Bug: 1015805

Change-Id: I0e20134c03fc5d35b6a4a619ee3e6df466461164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869007Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710358}

Sometimes after session restoration the NavigationItem URL is placeholder.
Because -currentURLWithTrustLevel:trust_level will return the virtualURL,
compare with a NavigationItem virtualURL as well here.

Change-Id: Ie189fdb435a43aa7ffffe41fdd9c62183b55e2e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887271
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710357}

https://skia.googlesource.com/skia.git/+log/d4b95d213d6f..ee08d523f60a

git log d4b95d213d6f..ee08d523f60a --date=short --no-merges --format='%ad %ae %s'
2019-10-29 robertphillips@google.com Move creation of AAQuadIndexBuffer to GrResourceProvider

Created with:
  gclient setdep -r src/third_party/skia@ee08d523f60a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: None
Change-Id: I546af6bdf83fa754b040535904054520532a668f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886366Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710356}

This will make some internal testing easier.

Change-Id: Ie38c61d892bdc78dd3d7c35f95436d1ea1ffb12b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881234Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710355}

Since upstream llvm/clang has moved to Github, there are no longer any svn revisions.
Instead, our package versioning scheme now begins with the number of commits since
the initial commit in the repository, prefixed by an "n".

These "n" numbers are NOT comparable to svn revisions.

Ran `tools/clang/scripts/upload_revision.py 55c223a7ed522293cf9995d07d348368c345d1f2`.

Bug: 1011815
Change-Id: If2b9dce272182ca4f0881424e1d64410b796b4c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879890
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710354}

This patch means refactor function name according what function do.
And, it might make sense to move the static merge functions to
autofill_profile_comparator which has functions related to merge logic.

Bug: 913940
Change-Id: I5a6d71b45fadf225e33541dc2b3a17bb7794ec1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885864Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710353}

This (mostly) reverts commit 274ea563,
excepts that it increments the current_version.gni instead of
reverting it.

Reason for revert: I need to modify the shell apk and push it now
but this CL needs to wait for WAM server change to be pushable.

Original change's description:
> [Android WebAPK] Create resources for web shortcuts.
>
> Resources used need to be pre-declared in the shell.
>
> Since we don't know how many shortcuts are needed for a web app until
> the creation request, we create 4 copies of the needed resources to
> declare a shortcut, since that is the maximum number of shortcuts
> allowed on Android.
>
> The following resources are needed (per shortcut):
> - name
> - short_name
> - icon (placeholder taken from
>    https://material.io/resources/icons/?icon=filter_1&style=baseline)
>
> The shortcuts.xml is also partially generated to use the resources, so
> that building the shell apk doesn't fail. They are all disabled by
> default, and will need to be re-enabled on the server-side.
>
> Bug: 1010471
> Change-Id: I5371b145afd943029de8eb679b0cf3044545cbe3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875755
> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
> Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
> Commit-Queue: Rayan Kanso <rayankans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709189}

Bug: 1010471
Change-Id: Iee87449e0c2f60117e542b605d8cd08beffc0ff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885250Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Henry Jian <hzjian@google.com>
Cr-Commit-Position: refs/heads/master@{#710352}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/588b98f2..d50a9c98

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iecc251cf632099e8054994d47f108feed6003712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886373Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710351}

DidFirstVisuallyNonEmptyPaint will not fire again if the page is
restored from the bfcache. So keep track of whether it fired, and fire
it again if the page is restored from the bfcache.

Bug: 1001087
Change-Id: Ie64f2706d6dcff8935d10b58185394f0fd245f2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827361
Commit-Queue: Carlos Caballero <carlscab@google.com>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710350}

This reverts commit 77f24899.

The check never triggered, so it's safe to assume that interior objects
are not accessed in the write barrier.

Change-Id: I7e0857011114cd36068239dbda96d1f0d21801cc

Bug: 1009683
Change-Id: I7e0857011114cd36068239dbda96d1f0d21801cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886679Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710349}

+ Always create a module native library target (not only for
  patitioned lib build) to simplify selection logic.

Change-Id: I6b4de3a9e883ad5087c38dac6783fea28b55ddd3
Bug: 870055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877249
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710348}

This change removes the HTTP FOAS feature flag. The corresponding
feature was enabled by default in M79, which is why the client code can
be cleaned up now.

Bug: 914765
Change-Id: Iffe7aafcde5abcac2133efe678a6b2a99fd3a7f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886335Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710347}

TBR=eugenebut@chromium.org

Bug: 1016368,   1016367
Change-Id: Id1596414616fc839472a85c1a7db1b66a717acd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886899
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710346}

Type casting related functions like IsHTMLXXXXElement,
ToHTMLXXXXElement, and ToHTMLXXXXElementOrNull are being phased out in
favor of new downcast helpers in t_p/blink/renderer/platform/casting.h.
There is still a long run to fully remove old type casting mechanism,
but this CL aims at preventing new uses to take place.

Bug: 891908
Change-Id: I6a079b9524d2e94805528bdcf17baaa66fe091da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879628Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#710345}

Bug: 1017175, 1016367
Change-Id: I0c12c811c347a5f7981ea2985e550aad72167860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886860
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710344}

https://android.googlesource.com/platform/external/perfetto.git/+log/0877b946198e..0668f3ddd97f

git log 0877b946198e..0668f3ddd97f --date=short --no-merges --format='%ad %ae %s'
2019-10-29 primiano@google.com Merge changes I0d2677c1,If1a8bfcd

Created with:
  gclient setdep -r src/third_party/perfetto@0668f3ddd97f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I605d047538448d7d6eab504200b7c5e5b417c9a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886358Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710343}

https://chromium.googlesource.com/devtools/devtools-frontend/+log/70f122128c..a2ca5d5c44

TBR=aerotwist@chromium.org

Change-Id: I1dace02c1820a41d95e4cda22451126dbd82301d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886678Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710342}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2c887d9d2df6..b6a2156a1346


Created with:
  gclient setdep -r src-internal@b6a2156a1346

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I660ba07b9aeca2346538687ee4f661738dc8e9f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886362Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710341}

Android side: https://android-review.googlesource.com/c/platform/frameworks/support/+/1138298

Bug: 1012753
Change-Id: I6cc6e045fad9044f72cda7f751390abb39fea94a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848701Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710340}

As requested by UX team, disable the ink drop effect of the scrollable
shelf's arrow button by this CL.

Bug: 1019012
Change-Id: I6a7224911cafb70167d4f152b53b93fdd3fa6004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885500
Auto-Submit: Andrew Xu <andrewxu@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710339}

Screenshots:
https://drive.google.com/open?id=1FtWB0KqauDTnX-PicF1aMets092Jo2rj
https://drive.google.com/file/d/1Scn70Xe29D4rno6OmMkif1N64XlswnPR
https://drive.google.com/file/d/1mQunVKqxB63hxet8WdmP3BSTLrMsV0Nu

Bug: 1014660
Change-Id: I5ea1e7fbb486d49303fbfdf0db995c1792374f4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882322
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710338}

This is a precursor to adding a new scoped_refptr(std::nullptr_t)
constructor. The implicit conversion from NULL to scoped_refptr<T>
causes a compilation error with the new constructor. Replace NULL with
nullptr in any files where this is a problem.

This CL was uploaded by git cl split.

R=liberato@chromium.org

Bug: 1018887
Change-Id: I589a654b9f76a8e066533ea789fdd9c6f7bb3c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885079
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710337}

This reverts commit 6089b211.

Reason for revert: Failure here: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/4085

I'm half assuming that this test is a bit flaky?

Original change's description:
> [devtools] Allow reloading of extension with devtools
> 
> This patches restricts the changes from [1] to pdf embeds.
> 
> [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1659983
> 
> Bug: chromium:997521
> Change-Id: I8a94c9c1eecf132388508ceed47b426f2c842ed0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798350
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: James MacLean <wjmaclean@chromium.org>
> Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#708538}

TBR=yangguo@chromium.org,wjmaclean@chromium.org,luoe@chromium.org,janscheffler@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:997521
Change-Id: I79849fb39d89d84c4e7a5a9eb72494da13bf5119
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886817Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710336}

With UAv2 shipped, token based user activation state maintenance
through a UGI is redundant except for a dependency from extension
messaging.  Unfortunately we can't remove that dependency right away
because of compat implications (crbug.com/957633).  For now, we will
trim down UGI to a minimal class to prevent new usage as much as
possible.

This CL trims down UGI to support barebone token functionalities.

Bug: 959850
TBR: haraken@chromium.org
Change-Id: Ifef73e338cff2f07273bc0faf5208eaa172fcb87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872152
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710335}

Previously would fail if another annotation came after @NativeMethods.

Bug: 1018296
Change-Id: Id80385d0a0ad0594134d5e04d87f28f9efd77888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885017
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710334}

This patch is exploring how we can implement V8 callback
functions in the new bindings generator.

Attempts to implement the following utilities:
- make_v8_to_blink_value
- bind_blink_api_arguments
- bind_blink_api_call
- bind_return_value
- bind_v8_set_return_value

Bug: 839389
Change-Id: Ie949eca6119806611125fc4e8265601a6888e52b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880904Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710333}

This is the final of five CLs breaking crrev.com/c/1860025 into smaller
chunks.

This CL updates the classes in ui/authentication to accept a Browser
instead of a BrowserState, and updates their callers, who at this point
all are created with Browsers to pass in.

The workarounds in the parent CL are removed, and now all of the inits
for SettingsNavigationController use Browser.

Bug: 1018746
Change-Id: Iaa6b20279daa64d377730c74c29b14f25c9d1404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883724
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710332}

With UAv2 shipped, token based user activation state maintenance
through a UGI is redundant except for a dependency from extension
messaging.  Unfortunately we can't remove that dependency right away
because of compat implications.  For now, we will trim down UGI to a
minimal class to prevent new usage as much as possible.

This CL removes UGI's token status as part of the cleanup.

Bug: 959850
Change-Id: I9b3858b85cf980d879124ed49b18c67b4ec9a566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869118
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710331}

Failures during the processing of test results should be marked
unexpected.

Bug: 1019137
Change-Id: Ib3b880a462a038ea98fc8c56e3ec815ba613ec93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886894
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710330}

Bug: 82078
Change-Id: Iba91aaf15643c3a3ca9ebbfc930bec634b6eda14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886170
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710329}

This is a precursor to adding a new scoped_refptr(std::nullptr_t)
constructor. The implicit conversion from NULL to scoped_refptr<T>
causes a compilation error with the new constructor. Replace NULL with
nullptr in any files where this is a problem.

This CL was uploaded by git cl split.

R=reillyg@chromium.org

Bug: 1018887
Change-Id: Id52b62e25cd452a6558c2660c72e1c8d501da2cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884520
Commit-Queue: kylechar <kylechar@chromium.org>
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710328}

The feature "Article suggestion UI tweaks - Chrome iOS" has been shipped
in M77. The feature flag can be removed now.

Bug: 979143
Change-Id: I1be8aaae408236d4141dc61c214b11eba94292aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886613
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710327}