- 26 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c5bc9d6da851..d6eab9edafe8 git log c5bc9d6da851..d6eab9edafe8 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 489dde9b..1fa0f66d (699869:699974) Created with: gclient setdep -r src/third_party/webrtc@d6eab9edafe8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If2f5077d9316b744e41c80ccb546eb867aab53e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826203Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700077}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f0faf48ddb89..9a5bb612e624 git log f0faf48ddb89..9a5bb612e624 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 ehmaldonado@chromium.org git-cl: Make Ctrl+C work again. Created with: gclient setdep -r src/third_party/depot_tools@9a5bb612e624 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:961724 Change-Id: I32dd482c3596ac91f9114a33d7841cce8d5058f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825664Reviewed-by:
-
John Z Wu authored
The intermediate "ChromeWebView" folder was never created, so writes to files in that folder just fails. Change-Id: I2d0880fd9ce600fab08f4e23ed116febdaf76b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825735 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#700075}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ie75dcaff77f5ee2a7ade334b2e4f2498f38a45da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825383Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700074}
-
Jay Harris authored
In incognito and guest profiles, the BadgeManagerFactory does not create a BadgeManager. As there are no apps in incognito/guest profiles this would not normally be a problem. However, in BadgeManager::BindRequest, we were attempting to add the null BadgeManager to a mojo reciever set, causing a crash. Note: This does not affect the API exposed to the, so this cannot be used to detect incognito mode. Bug: 1004122 Change-Id: I5024665257a67aaaf28aa7f3bb8cd9cfcdef2d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824041Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#700073}
-
Darren Shen authored
These files are only compiled for chrome os, so no need for the checks. Bug: 1005619 Change-Id: I15cd1c3000223bf8aa1c2656389b3e32fbfaee71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811404 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#700072}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6f282594. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0233205edf18670ca44ecb5d98a794b280670b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825405Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700071}
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces all uses of WebLocalizedString::kFooBar with IDS_FOO in QueryLocalizedString functions in TestBlinkWebUnitTestSupport. This CL replaces below ones with matched IDS_FOO. - kCalendarClear - kCalendarToday - kFileButtonNoFileSelectedLabel - kOtherDateLabel - kOtherMonthLabel - kOtherWeekLabel - kSelectMenuListText - kThisMonthButtonLabel - kThisWeekButtonLabel - kValidationRangeOverflow - kValidationRangeUnderflow - kValidationStepMismatch - kValidationTooLong - kValidationValueMissing - kValidationValueMissingForSelect - kWeekFormatTemplate Bug: 995644 Change-Id: I1873b90d26c2f86f09fd9aa66e9cb65196f8333d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820500Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#700070}
-
Julie Jeongeun Kim authored
This CL converts ContentTranslateDriverPtr and ContentTranslateDriverRequest to new Mojo types using PendingRemote or Remote, ReceiverSet and PendingReceiver. Bug: 955171 Change-Id: I85bea0c14c8537a57bdd43d1157c16e441a01126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816483 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#700069}
-
Chih-Yu Huang authored
The UnwrapFrame() method is only used between PlatformVideoFramePool and MailboxVideoFrameConverter implementation. It is not a general method. This CL moves the method from DmabufVideoFramePool interface to PlatformVideoFramePool implementation. BUG=b:136716638 TEST=run video_decode_accelerator_tests on kevin Change-Id: Icfd5d99fb2319ec904e0d8c298572cb0af1031b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824500 Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#700068}
-
Mark Pearson authored
TBR=nikunjb Change-Id: Icdba90b45dfe414afcf3a977e1476253774d47ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825665Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#700067}
-
Kouhei Ueno authored
Before this CL, we required the pages to reach "load" event to be put into BFCache. This CL relaxes the constraint to have the page: - reach DOMContentLoaded, and - have no inflight subresource network requests. Bug: 1002345 Change-Id: Ibfb5d8b73162261aa1d5e0e98d3345ae40ef23b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809192 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#700066}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8aa759f0bb96..56c87856cd03 Created with: gclient setdep -r src-internal@56c87856cd03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iba5948705825ddf2fad09d656f5a23e411202422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825934Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700065}
-
Shakti Sahu authored
Bug: 850608 Change-Id: Ia68fed867cea8c7d175b29dfaaa25f03579fec9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804384 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#700064}
-
Hiroki Nakagawa authored
WorkerGlobalScope, not WorkerThread, is responsible for script fetch and evaluation. Therefore it would be clearer to place InstalledScriptsManager in WorkerGlobalScope, not in WorkerThread. Bug: 938219 Change-Id: Iee76b943ef435326ea055e65fb75e579dd7d75ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824522 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#700063}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I980489adbce321402af8d6ce93009af1c38ecf6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815991Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700062}
-
Sunny Sachanandani authored
Make DCLayerOverlayProcessor keep track of output rects of each child render pass that has filter operations and compare that with the quad target rect when deciding whether to promote to overlay. Bug: 997517 Change-Id: Iee6cc6acfea1ae00ce1aa676138440949cfabd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817269Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#700061}
-
Steven Bennetts authored
In C++ mojo uses StructPtr for embedded structs, regardless of whether they are required, so it is possible to pass 'nullptr' for required properties, causing a runtime error when the properties are received. This CL: * Ensures that required ManagedString properties are provided in the C++ code, and fixes the set of properties provided for VPNs based on type. * Fixes some CSS causing incorrect indicators, and cleans up some logic in the JS. Bug: 1008230 Change-Id: I51484fc74e672b7b8434228abd219428461b92f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824320 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#700060}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/30c2b66fbabe..c5bc9d6da851 git log 30c2b66fbabe..c5bc9d6da851 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 qingsi@webrtc.org Treat wlan as a WiFi adapter name on all platforms. Created with: gclient setdep -r src/third_party/webrtc@c5bc9d6da851 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I2dac97cad9b3d941e4e3ba1dedea48466ab323af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826009Reviewed-by:
-
Andrii Shyshkalov authored
R=jbudorick Bug: 988217 Change-Id: I380cca75ce78086e5768b2c4dfa5e5464487d8d1 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826055 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#700058}
-
Brandon Wylie authored
Bug: 1006939 Change-Id: I80660992d19533dde83f47fb24ed358ef3a58669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824065Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#700057}
-
Miyoung Shin authored
This change converts ShareService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I26f60a0ae23e851bc19b8a157a2f3923005d822e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824049Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#700056}
-
Sam Maier authored
The plan was to migrate everything over to this, but it didn't happen. Since there are no users of this, it's better to not support this anymore. See https://chromium-review.googlesource.com/c/chromium/src/+/1803394/2 for an example of confusion with using compress = true. Change-Id: Ib6d666c2a937c3e024ca5fde6b59eddbd560a13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825919 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#700055}
-
Kenichi Ishibashi authored
We can remove the IPC from FailedTo{LoadClassic,FetchModule}Script() because: * After crrev.com/c/1819282 ServiceWorkerGlobalScope calls close() when top-level script fetch failed. Close() eventually invokes ServiceWorkerContextClient::WorkerContextDestroyed() which sends the IPC. * The reason we sent OnStopped IPC from FailedTo{LoadClassic,FetchModule}Script() was to support on-the-main-thread script fetch. We no longer support it. This CL also ensures that we have test coverage of the linked bug. Following browsertests fail without crrev.com/c/1819282 when this CL is landed. * ServiceWorkerVersionBrowserTest.StartNotFound * ServiceWorkerBlackBoxBrowserTest.Registration Bug: 1005650 Change-Id: Ie61b633b213ca4e8646c009d2f5a0569c55820a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824727Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700054}
-
Tim Song authored
The font rendering system seems to take into account screen resolution when deciding whether to elide the text or not. However, this looks very bad and we should never elide for these buttons. BUG=1005764 Change-Id: I5f147f47a7cad3890b7997c08a377f5ae6f381fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819560Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#700053}
-
Yun Liu authored
Bug: 1008224 Change-Id: I4ce423f92d58c5cc00630abd0479686b2edb6621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825795Reviewed-by:
-
Joel Hockey authored
The existing static Is*[Enabled|Allowed] functions in crostini_util are difficult to manipulate for tests. The CrostiniFeatures and FakeCrostiniFeatures make it easier to fake these methods in tests. TBR=calamity@chromium.org Bug: 1004708 Change-Id: If6381de5b1d0faf581112782d2734a5360379140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809199 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#700051}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6ac5a9250dff..64f4dd71278a git log 6ac5a9250dff..64f4dd71278a --date=short --no-merges --format='%ad %ae %s' 2019-09-26 jiawei.shao@intel.com Add check between color state format and fragment shader output 2019-09-25 mchiasson@gmail.com Fixed compilation issues when using libstdc++ Created with: gclient setdep -r src/third_party/dawn@64f4dd71278a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I9510ae1e6417f564cf534cd287063778b66182a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825931Reviewed-by:
-
Glen Robertson authored
Change-Id: Ief702a3e9c02086063576532358da0eb5f12402c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826058 Commit-Queue: Glen Robertson <glenrob@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ic0889ad21e7e491f515a51fe24e40397c0b05cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808075Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700048}
-
Tommy Steimel authored
Since we're not releasing GMC in M78, this CL disables GMC by default. Bug: 1007486 Change-Id: I8c0131710abbb393faad4d739fac53aca41e8939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823437 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#700047}
-
Steven Bennetts authored
This removes the last remaining use of networkingPrivate in Chrome OS WebUI! Bug: 1001598 Change-Id: I984ae41a3dc6949862ffb8e4556a95cef646d251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825873Reviewed-by:
-
Gyuyoung Kim authored
This CL applies pending_receiver to CreateLayeredWindowUpdater in DisplayClient. According to the change, related classes are also changed with mojo::PendingReceiver, mojo::PendingRemote, and mojo::Remote. Bug: 955171 Change-Id: Ib40de7fdf35bace79e97d1aa8a5f55e8c7c414b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824792Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
-
Darwin Huang authored
Bug: 990234 Change-Id: I6c8754c21ef2a1f5b712790cd43145e4853fea55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823728Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700044}
-
Xiaohan Wang authored
File chrome_child.dll is only available when CHROME_MULTIPLE_DLL_BROWSER is defined. Check CHROME_MULTIPLE_DLL_BROWSER and fix the logic in cdm_host_file_path.cc. Bug: 1008039 Test: Manually build Chrome and verified the behavior. Change-Id: I92d23b7a449ddfdfcdadc231ab0f012b7bd8b95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825163Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#700043}
-
Miyoung Shin authored
This change converts SensorProvider mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I77090420741c2f274133e6dbf7f06862dd79b919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820717 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#700042}
-
Mounir Lamouri authored
This reverts commit 00d10067. Reason for revert: feature not ready to launch in M78, reverting in trunk then merging. Original change's description: > [Lock screen media controls] Enable by default > > Enable the lock screen media controls by default > since these are shipping in M78. > > BUG=965546 > > Change-Id: I159052753625fe4eb8bf3653bf2c7bdffe09615e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773325 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690893} TBR=jamescook@chromium.org,beccahughes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965546 Change-Id: I97211dd536f71ee8fed4b08b1124089343f797a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826043Reviewed-by:
-
Steven Bennetts authored
This fixes a bug where certificate updates were not triggering a refresh in the new mojo based JS. While testing that I discovered that the current default certificate selection logic is broken. This is a subtle thing so was not noticed previously. This fixes the logic, cleans up some code, and adds some tests. Bug: 1001598 Change-Id: Ib81d7f6e093e1e5837d5272c848a3422d6a80b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825120 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Lei Zhang authored
Use constants from base/numerics/math_constants.h instead. Then there is no need to add _USE_MATH_DEFINES for MSVC. Along the way, fix some nits: - Use the right math function variant for floats. - Mark more constants as constexpr. - Do IWYU. - Fix lint errors. Change-Id: I9b5efe6f19a6f568aede3ad8c80012a2a7c76ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825893Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#700039}
-
Wez authored
Reason for revert: Reverting to an SDK revision that allows the "chromium" package to be updated to a local build. The previous SDK revert didn't go back far enough to fix things. TBR=sergeyu Bug: fuchsia:37329 Change-Id: I3accef797ccb4110f8bcacd7f559d6d19d1e4c3f Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825903Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#700038}
-
