- 25 Oct, 2016 40 commits
-
-
horo authored
This CL depends on https://codereview.chromium.org/2410333006/ FetchEvent.navigationPreload will be implemented in the following steps. [1/4] Introduce FetchEventPreloadHandle to pass the preload response to FetchEvent. https://codereview.chromium.org/2417793002/ [2/4] Implement ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(). https://codereview.chromium.org/2410333006/ [3/4] Implement FetchEvent.navigationPreload. https://codereview.chromium.org/2416843002/ This CL. [4/4] Add browser tests for NavigationPreload. https://codereview.chromium.org/2413643005/ If ServiceWorkerContextClient::FetchEventDispatcherImpl receives preload_handle, it creates a PreloadRequest. This PreloadRequest is a mojom::URLLoaderClient owning mojom::URLLoader. ServiceWorkerContextClient::DispatchFetchEvent() stores the PreloadRequest to |context_| and calls ServiceWorkerGlobalScopeProxy::dispatchFetchEvent() with |navigationPreloadSent| flag set. If the flag is set, ServiceWorkerGlobalScopeProxy::dispatchFetchEvent() calls FetchEvent::createPreloadResponseCallback() to create WebServiceWorkerPreloadResponseCallbacks and calls registerPreloadResponseCallback to pass the callback to ServiceWorkerContextClient. ServiceWorkerContextClient::registerPreloadResponseCallback() calls PreloadRequest::RegisterCallback() and the callback will be called when OnStartLoadingResponseBody() is called or OnComplete() is called with an error. BUG=649558 Review-Url: https://codereview.chromium.org/2416843002 Cr-Commit-Position: refs/heads/master@{#427303}
-
jif authored
This fix is necessary to enable by default the iPad tab switcher. It is a partial reland of https://codereview.chromium.org/1725533004 This CL: -Always register/deregister for notifications. -Centralizes the logic to use a LRU cache. -Centralizes the logic to use an in-memory cache. -Replaces msarda with jif in OWNERS. -Triggers memory warning instead of calling |handleLowMemory| from tests. BUG=None Review-Url: https://codereview.chromium.org/2394253002 Cr-Commit-Position: refs/heads/master@{#427302}
-
sakal authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/5a1b3fe..7938471 $ git log 5a1b3fe..7938471 --date=short --no-merges --format=%ad %ae %s 2016-10-24 ehmaldonado@google.com Roll chromium_revision 13622877..9b5bb47f (426760:426837) + roll Android SDK to N 2016-10-24 philipel@webrtc.org Drop VP8 frames older than the last sync frame in the RtpFrameReferenceFinder. 2016-10-24 aleloi@webrtc.org Elimiteted race condition in the AudioMixer. 2016-10-24 terelius@webrtc.org Revert of Fix some chromium style warnings in remote_bitrate_estimator.h (patchset #1 id:1 of https://codereview.webrtc.org/2387113008/ ) 2016-10-24 danilchap@webrtc.org Add tests and fix thread annotations 2016-10-24 kwiberg@webrtc.org Eliminate left shift of negative value by using multiplication instead 2016-10-24 hbos@webrtc.org RTCTransportStats[1] added, supporting all members. 2016-10-24 terelius@webrtc.org Remove unused variable from delay based BWE. 2016-10-24 terelius@webrtc.org Fix chromium-style warnings. 2016-10-24 terelius@webrtc.org Fix some chromium style warnings in remote_bitrate_estimator.h 2016-10-24 kjellander@webrtc.org GN: move webrtc/video/ targets from webrtc/BUILD.gn into webrtc/video/BUILD.gn 2016-10-24 sakal@webrtc.org Implement framesEncoded stat in video send ssrc stats. 2016-10-24 perkj@webrtc.org Remove cricket::VideoCodec with, height and framerate properties Since WebRtcVideoSendStream have reconfigures the send codec to match the incoming captured frames widht and height they have not been used. Framerate has just been set when parsing sdp to 60fps and not changed elsewhere. 2016-10-24 nisse@webrtc.org Delete always-zero ByteBufferWriter::start_. 2016-10-24 nisse@webrtc.org Reland of Delete webrtc::VideoFrame::CopyFrame. (patchset #1 id:1 of https://codereview.webrtc.org/2397943003/ ) 2016-10-24 sakal@webrtc.org Allow using Java classes that don't require JNI in Chromium. 2016-10-24 nisse@webrtc.org Revert of Add method cricket::VideoCapturer::NeedsDenoising, use in VideoCapturerTrackSource. (patchset #5 id:80001 of https://codereview.webrtc.org/2334683002/ ) 2016-10-24 nisse@webrtc.org Delete unused class AudioSourceWithMixStatus. 2016-10-23 brandtr@webrtc.org Integrate FlexfecReceiveStream with Call. 2016-10-22 peah@webrtc.org Several subcomponents inside APM copy render audio from the render side to the capture side using the same pattern. Currently this is done independently for the submodules. 2016-10-22 peah@webrtc.org Added the missing ReadQueuedRenderData() call to the AECM bitexactness test 2016-10-22 peah@webrtc.org Added the missing ReadQueuedRenderData() call to the gain controller bitexactness test 2016-10-22 peah@webrtc.org Added the missing ReadQueuedRenderData() call to the AEC bitexactness test TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2449483002 Cr-Commit-Position: refs/heads/master@{#427301}
-
clemensh authored
We had to rebaseline a test several times just because the script on V8 side changed. Excluding the position information of the evaluate method avoids this in the future. BUG=656622,652939 R=kozyatinskiy@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2440293002 Cr-Commit-Position: refs/heads/master@{#427300}
-
ben authored
Wires the specs thru the ServiceManager to clients. Doesn't do anything interesting with them yet (i.e. doesn't pass them thru service_manager::Service). Hence no tests. That'll come next since I don't want to update all Service impls in this CL. R=rockot@chromium.org,tsepez@chromium.org Review-Url: https://codereview.chromium.org/2425563004 Cr-Commit-Position: refs/heads/master@{#427299}
-
jb authored
Flushing deferred messages might lead to a request being canceled (e.g. when an ImageResource loads a corrupt image). The code didn't fully take this into account which would cause crashes (and resource leaks if it would have survived). BUG= Review-Url: https://codereview.chromium.org/2425173003 Cr-Commit-Position: refs/heads/master@{#427298}
-
Xiaohan Wang authored
This is missed in the previous CL (r427294). TBR=jam@chromium.org BUG=657276 Review URL: https://codereview.chromium.org/2449793002 . Cr-Commit-Position: refs/heads/master@{#427297}
-
thestig authored
Revert of Roll DEPS for sfntly 1ef790a..e33ba7a (patchset #1 id:1 of https://codereview.chromium.org/2444123002/ ) Reason for revert: Broke some font rendering. e.g. https://crbug.com/659006 Original issue's description: > Roll DEPS for sfntly 1ef790a..e33ba7a > > https://chromium.googlesource.com/external/github.com/googlei18n/sfntly/+log/1ef790a..e33ba7a > > e33ba7a Merge pull request #60 from leizleiz/leizleiz-crbug > 1bc53e1 Fix undefined shifts in ReadableFontData::ReadShort. > d651349 Check for negative size in NameTable::NameAsBytes. > 8475d2f Avoid NULL derefs inside FontHeaderTable::Builder. > 1fba3b3 Fix undefined shifts in ReadableFontData::ReadLong. > 083b02b Fix NULL pointer derefs in sfntly::Font::Builder. > 6d1efaa Fix out of bound access in subtly sample program. > cafc4c8 Merge pull request #59 from HalCanary/pronounciation > 7d5169e README: pronounciation guide > > BUG=638573,641452,646300,646347,654663,655914 > TBR=behdad@chromium.org > > Committed: https://crrev.com/0c0e20baae5cfc32465e84d0e56a82ab874788e9 > Cr-Commit-Position: refs/heads/master@{#427203} TBR=behdad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=638573,641452,646300,646347,654663,655914 Review-Url: https://codereview.chromium.org/2445303002 Cr-Commit-Position: refs/heads/master@{#427296}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#427295}
-
xhwang authored
Now the meaning of "service" has changed. InterfaceFactory makes more sense since this is similar to shell_manager::InterfaceFactory. TBR=dcheng@chromium.org BUG=657276 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2444623002 Cr-Commit-Position: refs/heads/master@{#427294}
-
dmazzoni authored
Revert of Add Ctrl+Alt+H as global shortcut to toggle high contrast mode. (patchset #2 id:20001 of https://codereview.chromium.org/2352213002/ ) Reason for revert: http://crbug.com/653330 This shortcut conflicts with some web pages, and there's no consensus on the proper fix (let web pages override, or switch to another key). Original issue's description: > Add Ctrl+Alt+H as global shortcut to toggle high contrast mode. > > BUG=644758 > > Committed: https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e > Cr-Commit-Position: refs/heads/master@{#419884} TBR=jamescook@chromium.org,mpearson@chromium.org,suppasitaung6@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=644758 Review-Url: https://codereview.chromium.org/2448663002 Cr-Commit-Position: refs/heads/master@{#427293}
-
alshabalin authored
show_ssl_decision_revoke_button_ field was never assigned when constructing WebsiteSettings with about:blank url. BUG= Review-Url: https://codereview.chromium.org/2440183002 Cr-Commit-Position: refs/heads/master@{#427292}
-
fukino authored
This CL updates the layout/colors to match the following latest spec: https://folio.googleplex.com/md-storage-management-spec BUG=629438 TEST=manually confirmed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2435033003 Cr-Commit-Position: refs/heads/master@{#427291}
-
tapted authored
WebContentsViewCocoa has a hook to resize all subviews to match its size. The problem is that the size of a RenderWidgetHostViewCocoa is allowed to get out of sync with its superview while waiting for a WebContents paint to be committed. If an autolayout is triggered while waiting for that commit, the WebContents thinks it's been resized and spawns a new paint. Since r424609, for 10.11+, Chrome stopped replacing the NSThemeFrame (which AppKit does not support) and instead started using NSFullSizeContentViewWindowMask. This seems to opt the window into additional autolayout triggers, coming from CoreAnimation. This can engage the code to "re-sync" the sizes of the RenderWidgetHostViewCocoa and WebContentsViewCocoa when it wasn't done previously. To fix, "re-sync" sizes in an override of -setFrameSize: rather than -resizeSubviewsWithOldSize:. This ensures a re-sync only occurs when the size of the WebContentsViewCocoa changes. BUG=655112, 655665, 264207 TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2442573003 Cr-Commit-Position: refs/heads/master@{#427290}
-
hs1217.lee authored
rotate() and rotateSelf() function 1. If rotY and rotZ are both missing, set rotZ to the value of rotX and set rotX and rotY to zero. 2. If rotY is still missing, set rotY to zero. 3. If rotZ is still missing, set rotZ to zero. 4. If rotX or rotY are non-zero, set is2D of the current matrix to false. 5. Post-multiply a rotation transformation on the current matrix around the vector 0, 0, 1 by the specified rotation rotZ in degrees. 6. Post-multiply a rotation transformation on the current matrix around the vector 0, 1, 0 by the specified rotation rotY in degrees. 7. Post-multiply a rotation transformation on the current matrix around the vector 1, 0, 0 by the specified rotation rotX in degrees. 8. Return the current matrix. rotateFromVertor() and rotateFromVertorSelf() function 1. Post-multiply a rotation transformation on the current matrix. The rotation angle is determined by the angle between the vector (1,0)T and (x,y)T in the clockwise direction. 2. Return the current matrix. spec list: - https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateself - https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotate - https://drafts.fxtf.org/geometry/#dom-dommatrix-rotatefromvectorself - https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotatefromvector BUG=388780, 645878, 645882 Review-Url: https://codereview.chromium.org/2444733002 Cr-Commit-Position: refs/heads/master@{#427289}
-
calamity authored
This CL disables clicks in the date header of cards as this was causing the first item to be selected when the date was clicked. BUG=654998 NO_DEPENDENCY_CHECKS=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2420583003 Cr-Commit-Position: refs/heads/master@{#427288}
-
eugenebut authored
Chrome for iOS does not present URL spoofing error after switching to WKWebView. BUG=579697 Review-Url: https://codereview.chromium.org/2424643002 Cr-Commit-Position: refs/heads/master@{#427287}
-
tkent authored
When a color chooser is closed, we dispatches a 'change' event asynchronously. Some tests need to be updated due to this behavior change. BUG=658535 Review-Url: https://codereview.chromium.org/2447653002 Cr-Commit-Position: refs/heads/master@{#427286}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/cbc5a0a3ff3f55f5059b1ce3fd0712084a6a4ea8 use_goma_module=True in chromium_libfuzzer_clang_tot (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2446973002 Cr-Commit-Position: refs/heads/master@{#427285}
-
rune authored
This is split out of the work for async stylesheet updates [1], but is also part of the work on componentized style resolving in general. The moved resetAuthorStyle method on StyleEngine may soon be gone altogether as it does so in [1]. The plan is that TreeBoundaryCrossingScopes will also be completely gone when we remove support for Shadow DOM v0. For Shadow DOM v1 we can look up the scoped resolvers for the affecting scopes directly like we already do in StyleResolver::matchScopedRules for the pure v1 case. The documentation of the special casing of VTT and custom pseudo elements is updated to not suggest that these rules are handled as part of boundary crossing scopes as the current solution is better once v0 shadows go away. [1] https://codereview.chromium.org/1913833002 R=meade@chromium.org BUG=567021,401359 Review-Url: https://codereview.chromium.org/2443933002 Cr-Commit-Position: refs/heads/master@{#427284}
-
chanpatorikku authored
Move FakeFileRefInterface from fake_pepper_interface_html5_fs.{cc,h} to fake_file_ref_interface.{cc,h} to share the code with the future code. depot_tools/clang-format was run so the formatting of code is accepted in the code review by policy. It was run in all the {.cc,.h} files. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk Review-Url: https://codereview.chromium.org/2435323002 Cr-Commit-Position: refs/heads/master@{#427283}
-
shuchen authored
BUG=344834 Review-Url: https://codereview.chromium.org/2445253002 Cr-Commit-Position: refs/heads/master@{#427282}
-
bashi authored
|idl_name| comes from filename but it's a bad idea to control code generation by using filename. Fortunately we no longer use it, so let's remove it. BUG=658098 Review-Url: https://codereview.chromium.org/2446923002 Cr-Commit-Position: refs/heads/master@{#427281}
-
yosin authored
This patch gets rid of flat tree version of |createVisibleSelection()| taking one |Position| by replacing with |SelectionInDOMTree| version to reduce number of overloads for improving code health. BUG=657237 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2442673002 Cr-Commit-Position: refs/heads/master@{#427280}
-
ananta authored
This test was initiating a navigation to the chrome\test\data folder and performing a number of find requests on the page returned. With PlzNavigate the request to navigate to chrome\test\data folder would get blocked in ResourceLoader::OnReceivedRedirect because the process id (-1) did not have access to the url being navigated to. In the non PlzNavigate case this is not an issue because the child process is given access to the URL during navigation. Proposed fix for PlzNavigate is to not do the ChildProcessSecurityPolicy check in the ResourceLoader::OnReceivedRedirect function and instead do this check on the UI thread in the NavigationRequest::OnRedirectChecksComplete function. Additionally we also grant access to the URL in the NavigatorImpl::RequestNavigation function. The above test is now enabled for Windows. BUG=175711 Disabled due to crbug.com/175711 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2436253002 Cr-Commit-Position: refs/heads/master@{#427279}
-
xianglu authored
BUG=646083 TEST=third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html Review-Url: https://codereview.chromium.org/2440243002 Cr-Commit-Position: refs/heads/master@{#427278}
-
hidehiko authored
Currently ArcSupportHost is the ARC's implementation of NativeMessageHost. Because of the system structure, the instance is created and managed by the module outside of ARC. This CL extracts the implementation of that part into ArcSupportMessageHost so that the ArcSupportHost, which will be the main interface to show UI things for ARC, can be managed along with the ARC's life-time. There is a plan to extract non authorization related part from ArcAuthSerivce. Meanwhile, the instance is managed by ArcAuthService, temporarily. BUG=657687, 636218, 633258, b/31079732 TEST=Ran on test device. Ran trybots. Review-Url: https://codereview.chromium.org/2436903003 Cr-Commit-Position: refs/heads/master@{#427277}
-
bajones authored
BUG=389343 Review-Url: https://codereview.chromium.org/2445083002 Cr-Commit-Position: refs/heads/master@{#427276}
-
yucliu authored
1. Change |output| from vector<uint8_t> to uint8_t*. 2. Add param |data_offset|. BUG=internal b/31219712 TEST=build cast_shell Review-Url: https://codereview.chromium.org/2450563002 Cr-Commit-Position: refs/heads/master@{#427275}
-
wangxianzhu authored
This is a follow-up of https://codereview.chromium.org/2445123002/ Removed the file first in the CL and re-add here to avoid problems on platforms using case-insensitive file names. TBR=pdr@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2448633002 Cr-Commit-Position: refs/heads/master@{#427274}
-
warx authored
CL reasoning: (1) in line with the pref setting name prefs::kEnableAutoScreenLock (2) making it more generic for other call usages BUG=658390 TEST=trybot test Review-Url: https://codereview.chromium.org/2446453002 Cr-Commit-Position: refs/heads/master@{#427273}
-
tapted authored
A test is allowed to request a 200% resource and fallback to a 100% resource. Currently only the last-added 100% data pack provides fallbacks, which may only be a small supplement. Instead, scan through all 100% data packs. But only when InitSharedInstanceWithPakPath() has invoked ResourceBundle::LoadTestResources(). BUG=636995 Review-Url: https://codereview.chromium.org/2406763002 Cr-Commit-Position: refs/heads/master@{#427272}
-
hiroshige authored
According to codesearch, there are no usage of setMemoryCacheCapacities from JavaScript in the tests. BUG=603462 Review-Url: https://codereview.chromium.org/2416803002 Cr-Commit-Position: refs/heads/master@{#427271}
-
tkent authored
Also, wptserve.py shows a warning before certificate expiration. BUG=623613 NOTRY=true Review-Url: https://codereview.chromium.org/2443863002 Cr-Commit-Position: refs/heads/master@{#427270}
-
thakis authored
Ran `tools/clang/scripts/upload_revision.py 284979`. BUG=656667 Review-Url: https://codereview.chromium.org/2443963002 Cr-Commit-Position: refs/heads/master@{#427269}
-
lushnikov authored
BUG=658089 R=dgozman Review-Url: https://codereview.chromium.org/2435043003 Cr-Commit-Position: refs/heads/master@{#427268}
-
hiroshige authored
Preparation for removing didAccessDecodedData() in https://codereview.chromium.org/2411243004. BUG=603462 Review-Url: https://codereview.chromium.org/2435873003 Cr-Commit-Position: refs/heads/master@{#427267}
-
sammc authored
Remoting requires control over the security descriptor used for its named pipes. This adds this as an option when creating server handles from named pipes on Windows. BUG=604282 Review-Url: https://codereview.chromium.org/2444793002 Cr-Commit-Position: refs/heads/master@{#427266}
-
xidachen authored
Currently, there are two important API calls for OffscreenCanvas, which are transferToImageBitmap and commit. This CL adds usage counter to these two API calls. BUG=653599 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2411703004 Cr-Commit-Position: refs/heads/master@{#427265}
-
tmartino authored
BUG=656121, 652345 Review-Url: https://codereview.chromium.org/2416333003 Cr-Commit-Position: refs/heads/master@{#427264}
-