- 09 Apr, 2020 40 commits
-
-
Lei Zhang authored
Change-Id: I3ba220a79a2094ea3bb9c338215c8a14c363ecef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142717 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#758032}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/08dd1a3ca3a5..605c93fb246c git log 08dd1a3ca3a5..605c93fb246c --date=short --first-parent --format='%ad %ae %s' 2020-04-09 tmathmeyer@chromium.org Catch json parsing error in media tab Created with: gclient setdep -r src/third_party/devtools-frontend/src@605c93fb246c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia4080755f2991934df7bd0046d1d81ba6962c46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144650Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758031}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9f6ff832d99a..059c1b75eb67 git log 9f6ff832d99a..059c1b75eb67 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9fa8abd9..ca551bc6 (757716:757925) 2020-04-09 henrika@webrtc.org Adds tiny rtc::StringFormat utility 2020-04-09 peah@webrtc.org AEC3: Remove deprecated parameter Created with: gclient setdep -r src/third_party/webrtc@059c1b75eb67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I41d896c70c06a42d4c9a0bf8aa40cc005f9ab5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144973Reviewed-by:
-
chrome://appsDaniel Murphy authored
This adds back the "Create Shortcut" functionality to chrome://apps for the BMO system. R=loyso@chromium.org Bug: 1009302, 1069298 Fixed: 1069293 Change-Id: Ic14e71155a0eb7a6a02fb5a82aab9c3362f8b015 Tested: Manually, with BMO turned on and off Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121421 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#758029}
-
Charlie Hu authored
This CL makes DocumentPolicyParserTest use mocking feature, instead of real feature in document policy. Change-Id: Ib49b6b0f73f8a5fe85450104d3837f746039a9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134580Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#758028}
-
Lily Chen authored
This adds a NetworkIsolationKey field to ReportingReport, which represents the report to be sent via Reporting API to some previously configured endpoint. This NetworkIsolationKey will eventually be filled in with the NetworkIsolationKey of the request for which the report was generated. For now this field is always empty, except in tests. Bug: 993805 Change-Id: Ie957d4600007f4a46c4fc32b3381d55f518b1a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137924 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#758027}
-
Ben Joyce authored
Bug: 896775 Change-Id: Ia8b56274328b16b1255038c05bd49cba94c97471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144817Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#758026}
-
Tiancong Wang authored
New Clang update reports new warnings when C++ code provides anonymous typedef structs. The suggested solution is to either add a tag to the name or use C++-style struct. This patch fixes the warnings for the next toolchain update. Bug: 1068297 Test: Tested on Chrome OS Change-Id: I6863bc10d9094497b0d634ddee04891df8372906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144413Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Tiancong Wang <tcwang@google.com> Cr-Commit-Position: refs/heads/master@{#758025}
-
Jerome Jiang authored
New static library libvp9rc is added. Bug: 1060775 Change-Id: I3a641b096cf2a975f2abcc80c0fac34b9dbaa7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140903Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Auto-Submit: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#758024}
-
Kartik Hegde authored
BUG=chromium:956783 TEST=unit_tests --gtest_filter=NetworkDiagnosticsRoutineTest.* Change-Id: Idaefb63874cb26360a7d22f1ad7ed9cfe4da7810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113736Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#758023}
-
Mathias Bynens authored
A V8 CL [1] improves the terminology that’s used for internal promise state. Per the spec [2], a resolved promise may be “pending, fulfilled, or rejected”, but previously V8 incorrectly used the term “resolved” instead of “fulfilled”. This change is user-observable through the DevTools Console, and so a previous patch [3] updated the affected test’s expectations and temporarily disabled it. This patch re-enables the test. [1]: https://chromium-review.googlesource.com/c/v8/v8/+/2144011 [2]: https://tc39.es/ecma262/#sec-properties-of-promise-instances [3]: https://chromium-review.googlesource.com/c/chromium/src/+/2144095 Bug: v8:6751, v8:5416 Cq-Depend: chromium:2144711 Change-Id: Id31fcbf5b21476d0e94fea4545824230946b9520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144068 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#758022}
-
chrome://discardsSigurdur Asgeirsson authored
While I'm in there add a style to make the swimlane dividers impossible to select, which was a persistent nuisance. Bug: 1068233 Change-Id: Ie4b1b10fe39823102e9ec36d6396865b49e5de32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144261 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758021}
-
Garrett Beaty authored
Change-Id: Ieaa7dd3aab2e677967f3af9bd48d1a793c56c23b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142832 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#758020}
-
Dan Harrington authored
- Learn more, send feedback, download page - Each counts as a feed interaction (Feed.EngagementType) - We'll add histogram or user actions for these events later. Bug: 1044139 Change-Id: I4965f637abdbff6f6630d88a28e7814ef7ef59ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138236 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#758019}
-
Greg Thompson authored
This reverts commit 0c6bc2e3. Reason for revert: reverting to avoid perf analysis surprises -- to be relanded with a trace event. Original change's description: > Take user data snapshots on canary builds for each minor upgrade. > > Bug: 958893 > Change-Id: I987a99d3db2b659babe46d2f15cfac6627bc573c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134396 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757835} TBR=grt@chromium.org,ydago@chromium.org Change-Id: Ie5bc93a13e952ae13ab90249adb93623eb3261c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144173Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758018}
-
Kai Ninomiya authored
Deprecates GPUBindGroupLayoutEntry.textureDimension. Bug: 1069302 Change-Id: Idbf0928116bf01f702808f95ecc6d0a63a2caea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143378Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758017}
-
Nicolás Peña Moreno authored
This CL removes flakiness in the FCP-only tests by: * Adding a 50ms wait when FCP is not expected. This way, tests that would surface FCP would have enough time to do so. * Rely on PerformanceObserver to verify that FCP is surfaced in the cases where it should be. * Use a 300 ms timeout to declare that FCP was not surfaced when it is expected. This is larger than the non-FCP wait time since it sometimes requires waiting on CSS images to load. Bug: 1062984 Change-Id: I876b5bcdba3c795dc63326839899f3d5bb7a7dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139362Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#758016}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/aad6472eff7b..99ccc1759668 git log aad6472eff7b..99ccc1759668 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 treehugger-gerrit@google.com Merge "Rename smaps table to profiler_smaps." Created with: gclient setdep -r src/third_party/perfetto@99ccc1759668 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7b9ded6e0ed5342f3f9291c9d6ae532adcf2ed66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144645Reviewed-by:
-
Sean Harrison authored
Add a dialog to confrim a user want to disable safebrowsing Bug: 1067288, 1032584 Change-Id: Iddd781a3f369f5ee6359afb94ac18230b231a388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137404 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
-
Danyao Wang authored
This reverts commit b666bbd0. Reason for revert: broke tests: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.payments.ExpandablePaymentHandlerChangePaymentMethodTest%23testThrowBasicCard Original change's description: > [Web Payments] Use PaymentAppServiceBridge JNI in PaymentAppService. > > This CL contains the final steps to make the Java PaymentAppService > invoke the C++ PaymentAppService: > - Moved remaining PaymentHandlerFinder functionality, namely, > onInstalledPaymentHandlerFounder() and onInstallablePaymentHandler() > from ServiceWorkerPaymentAppBridge to PaymentAppServiceBridge. > - Exposed the native method fireCanMakePaymentEvent() via a static > method on ServiceWorkerPaymentAppBridge so it can be used by > PaymentAppServiceBridge. > - Proxied ServiceWorkerPaymentAppBridge.setCanMakePaymentForTesting > to PaymentAppServiceBridge. This will be cleaned up in a subsequent > CL. > - Fixed a bug from a previous CL to pass payment apps to callbacks by > value instead of by reference. > > Bug: 1063118 > Change-Id: I87e254d6dc11e12f890353c9a0a6dde6cca73c9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141436 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757827} TBR=rouslan@chromium.org,danyao@chromium.org,maxlg@chromium.org Change-Id: I73fda6a9cf222a684d05e1b24229cfc26ae3630c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1063118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144682Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#758013}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5d1c16380705..73e334469e89 git log 5d1c16380705..73e334469e89 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 reed@google.com fix computation for localToWorld 2020-04-09 bungeman@google.com Take MorphologyImageFilter radii as SkScalar. 2020-04-09 kjlubick@google.com [infra] Update dimensions for Golo Windows machines 2020-04-09 mtklein@google.com example of overdraw CF that we can JIT 2020-04-09 egdaniel@google.com Fix PinnedImageTest to make current original context at end. 2020-04-09 robertphillips@google.com Clean up GrText-related headers a bit 2020-04-09 reed@google.com Add markCTM(id) api, to replace functionality of saveCamera. 2020-04-09 tdenniston@google.com Sort viewer slides by filename when traversing a directory. Created with: gclient setdep -r src/third_party/skia@73e334469e89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1068726 Tbr: csmartdalton@google.com Change-Id: I5dcaca1ad872b265fe4a99ce6a09df640870237c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144644Reviewed-by:
-
Ryan Sleevi authored
The smart card password dialog is invoked by NSS when it needs to access a smart card, and must not return control back to NSS until it has the password. The dialog itself is configured as a global, but any NSS operations that may interact with smart cards (such as signing messages or verifying certificates) are invoked on worker task runners and with the base::MayBlock() trait. Bug: 1058070 Change-Id: Ib18c26e3d4c0b5063fe5337c6bf0da514ed4db73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142715 Auto-Submit: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#758011}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8ab783931f9..bb2c6c025366 Created with: gclient setdep -r src-internal@bb2c6c025366 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:790886 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I226572383d4e02ab57063d4ce5a2eac53aaffce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144640Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758010}
-
Raymond Toy authored
As with other fixes, use HasSampleAccurateValuesTimeline() to determine if there are sample-accurate values which is either caused by timeline events or connected inputs to the AudioParam. Tests added to handle possible different combinations of a-rate and k-rate frequency and detune AudioParams. Bug: 1015760 Test: k-rate-oscillator-connections.html Change-Id: I0d90d19b3cafbe353bc9495aa7e493bd20eb9e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111412 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758009}
-
Lukasz Anforowicz authored
Bug: 1066070 Change-Id: I34ed854437671242426918e0461e5baa71c519b1 Tbr: olivierrobin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141112 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#758008}
-
Aaron Leventhal authored
- Expose value, but not name, based on descendant text - Expose correct role on Mac (popup button) Bug: 1069150 Change-Id: I16119966a1e6c8a1eee88ef61c7268c5d3384341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142611 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758007}
-
Ana Salazar authored
This animation happens during transition between hotseat states. Bug: 1058609 Change-Id: I817b5af80703b8b2fcc1737d62668d77195cfd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101230 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#758006}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I9463d5bd0c777715411dc694968322ce8150188b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144400Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#758005}
-
Maggie Chen authored
This reverts commit 15ab8559. Reason for revert: <The data has been collected from the crash dumps. Debugging code is no longer needed. > Original change's description: > Record the GPU watchdog arm_disarm_counter in the main thread > > It is for the debugging purpose only and it wil have a performance impact. > The code will be removed immediately once valid crash dumps are collected. > > Bug: 885066,885066 > Change-Id: Ie8761ed4e6050a07e76af0a030b67dab5bb011e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129028 > Commit-Queue: Maggie Chen <magchen@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756461} TBR=zmo@chromium.org,magchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 885066 Change-Id: If5d439c97c3bf4732297b9a756423c18f024b865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144812Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758004}
-
Kai Ninomiya authored
Non-breaking. Bug: 1069302 Change-Id: I4cc7bfe3f75f9f79f8c8592b517181fbec1dbfc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143377Reviewed-by:
-
Robbie McElrath authored
This CL renames RoundedIconGenerator to FaviconFallbackGenerator and moves it from //chrome/browser/ui/android/favicon to //components/favicon/android so it can be reused by WebLayer. We'll move FaviconHelper there as well once we sort out its dependencies. Bug: 1058597 Change-Id: I8c47c046db36da17646c6db7ad78f50b90590a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136278 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758002}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3999e2615f58..e9a5bd129758 git log 3999e2615f58..e9a5bd129758 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 sadrul@chromium.org rendering: Add a metric for total cpu/wall time ratio. 2020-04-09 sadrul@chromium.org rendering: Add a missing param. Created with: gclient setdep -r src/third_party/catapult@e9a5bd129758 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058155 Tbr: oysteine@google.com Change-Id: Ic2367f0ff31906ce01ee606caadb8ff8927c9ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144642Reviewed-by:
-
Sujie Zhu authored
Update the suggestion second line label for all platforms when user focuses on cardholder name/expiration date field, using new NicknameOrNetworkLastFourDigitsAndDescriptiveExpiration (replace bankname since bankname is already deprecated). Here is the display text changes for suggestion label (subtitle) on non-credit-card-number field: Desktop: Before: "Network ****2345, expires on MM/YY" After: "Nickname ****2345, expires on MM/YY" Clank Keyboard accessary: No change. "****2345" Clank Drop down: Before: "Network ****2345" After: "Nickname ****2345" iOS: No change. "****2345" When nickname feature is not enabled or nickname is not valid, fall back to display network. Note that we don't enforce that the card has to be Masked server card when we display suggestions. We will display nickname as long as nickname is available (However, as of now, nickname is only available for server card). Later we don't need to update this logic if local nicknames share the same UI. UI deck(googler only): https://docs.google.com/presentation/d/1i-C4SeAHgpvn5Q-DXlHIM-In2ORURXN6nDlY05BtBsE/edit?usp=sharing Bug: 1059087 Change-Id: I57802b8fa8da372e96c09b4245c054af4146ae76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141791 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#758000}
-
Adithya Srinivasan authored
This CL adds a change similar to https://crrev.com/c/2024110, but for the automation API. Bug: 1057598, 1045608 Change-Id: Ib27c661a6fda9c1ac0c952abf727367d9f0a79b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112512 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757999}
-
Renato Silva authored
- Hide the option to opt-in for emails if the user is managed. - Determine the default toggle state for the email opt-in based on geolocation. Bug: 1056672 Change-Id: Idc137975e6187c3e4aec02941fedac7e00c98c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132327Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#757998}
-
wutao authored
This patch wraps the ambient mode subpage path in Chrome OS settings behind the ambient mode feature. Bug: 1068816 Test: manual Change-Id: I7e1cdf2dabdc7da15d818304ee6d18c231b99a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142140Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#757997}
-
Kai Ninomiya authored
Deprecates GPUBufferCopyView.{rowPitch,imageHeight}. Bug: 1069302 Change-Id: Ib756ac5402c4da53e2ba02dc7f298290e5b4e8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143376Reviewed-by: -
Abigail Klein authored
subpage. The captions settings subpage must be outside of the main content div. This fixes a regression in which the caption settings subpage was not linked to the a11y settings subpage. It also fixes a regression discovered: "Regression: The spinner keep on spinning in 'chrome://settings' page." Bug: 1069422, 1055150 Change-Id: Id40f612c09e97983be7b30dd26bbc0c09201a9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144315Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Abigail Klein <abigailbklein@google.com> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#757995}
-
Reilly Grant authored
This test crashes flakily on Chrome OS. Bug: 1069608 Change-Id: I6639574666195b7e3ceb3b7ec17e532b5235df80 Tbr: mcasas@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144899Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757994}
-
Garrett Beaty authored
Bug: 1067057 Change-Id: I4bab32dc91dad5b3b75d6e6792512b7e0b46a8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140308 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
