GitLab

These tests fail because of stale or no-longer-necessary
flag-specific expectations. Updated or removed by reviewing
the recent test results.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I83fb87ec7820c9e99342f37aeabc292e711f61f2
Reviewed-on: https://chromium-review.googlesource.com/1250384
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594997}

popup-allowed-from-gesture-initiated-event was changed to
testharness.js. LayoutNG had flag-specific expected.txt due
to different space collapsing in text dump. This patch
removes the stale expected.txt.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Id6b262611153d3cc0ad44a6454c3d7ede44d7d48
Reviewed-on: https://chromium-review.googlesource.com/1249472
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594996}

These failures are due to recent changes in its base
expectations, but LayoutNG flag-specific rebaselines were
still old.

Re-reviewed the differences from the new base, they are
only inline positioning differences.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7261b7a2a380acb46da3832c780c2d5dbe7e61a7
Reviewed-on: https://chromium-review.googlesource.com/1249470
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594995}

This reverts commit 3e67df64.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 594943 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzNlNjdkZjY0YmJmOTFkOGE3YjYxZDliZGYwYjBmMWVkZTNmMDViZmEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/8744

Sample Failed Step: chromeos_unittests

Original change's description:
> Install Messages PWA when host is set or verified.
> 
> This change moves the logic for installing the Android Messages PWA into
> a helper class which is a HostStatusProvider::Observer. This allows it
> to install the PWA when a host is set and also when signing into a new
> Chromebook if the account already has a valid host.
> 
> Bug: 887775
> Change-Id: I1a1433b03010d391f9b8256754fc578dfb8a140b
> Reviewed-on: https://chromium-review.googlesource.com/1248130
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Commit-Queue: Jeremy Klein <jlklein@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594943}

Change-Id: I7c249598402a82eaa23aca2e8c06acb429d9097c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 887775
Reviewed-on: https://chromium-review.googlesource.com/1249737
Cr-Commit-Position: refs/heads/master@{#594994}

It looks we forgot to move these at https://crrev.com/c/640275.

Bug: 738794
Change-Id: I0cd4cf3f90068619a8899dddcf4dd1d5fc871378
Reviewed-on: https://chromium-review.googlesource.com/1250385Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594993}

- Placed behind sync flag.
- Hooked up signinclient and tokenprovider to use CWVSyncController.
- Don't persist signin state between cold launches.

Bug: 867548
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Icf49e985aadec33b690552ff9973aadb4a5d1dba
Reviewed-on: https://chromium-review.googlesource.com/1211976
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594992}

Removes the FilteredSender abstraction that was created specifically for
tests, and replaces it with a simpler method to initialize GpuChannel
for tests.  Should make it simpler to change IPC channel initialization
for associating image decode accelerator mojo interface.


Bug: 868400
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifc57407fe8fac36daa0ace155c88cd54c04b39b4
Reviewed-on: https://chromium-review.googlesource.com/1250139Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594991}

Also move more GLRenderer API from protected into private.

BUG=None

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I56a923febc502ab68cda4680d6f006f2f6ebd121
Reviewed-on: https://chromium-review.googlesource.com/1235341
Commit-Queue: Xing Xu <xing.xu@intel.com>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594990}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5315071e31be..a82c66710062


Created with:
  gclient setdep -r src-internal@a82c66710062

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id04ecffe20de19ca9c5a228ffe66a0e9cb1ec13b
Reviewed-on: https://chromium-review.googlesource.com/1250115Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594989}

The special code was already in place and working, but with this CL it
will be skipped for fragments with block children.

This eliminates the need for checking whether an object is inline-level
in AssociateWithLayoutObject() (and bailing if it's not). Just DHCECK
that it's the case instead. Multicol was the only known case where this
could happen, but once we support NG painting of fragments with block
children, this will happen a lot.

This is a preparatory patch for NG fieldset painting.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iac13f27c51993dc5f3c211941d11a282201469bf
Reviewed-on: https://chromium-review.googlesource.com/1249273Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594988}

Add to chrome::mojom::AppShim a CreateContentNSViewBridgeFactory
method. This will instantiate a content::NSViewBridgeFactoryImpl.

The caller of this method (AppShimHost, in the browser), creates
a content::NSViewBridgeFactoryHost to manage this interface. This
may be used (e.g, by content::RenderWidgetHostViewMac::
MigrateNSViewBridge), to create NSViews in an app shim process.

Add content/browser as a dependency of app_shim.

R=dominickn
TBR=avi

Bug: 821651
Change-Id: Ice2b46f2d75a9725f5e8e8ad7d2c05e3d70b18eb
Reviewed-on: https://chromium-review.googlesource.com/1240154
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594987}

As we now have CORS-cross-origin, we don't need to rely on
kNotSharableCrossOrigin for scripts coming from network. This CL
completely removes kNotSharableCrossOrigin by migrating occurences to
either kSharableCrossOrigin or kOpaqueResource.

Bug: 875153
Change-Id: I12d12e9d67ca3329fe8b5e1dd7b74798f4817729
Reviewed-on: https://chromium-review.googlesource.com/1179509
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594986}

There members are no longer necessary after Incremental Shadow DOM is shipped.

Bug: 887827
Change-Id: Ic1e389f248de401f367d031f5ae13242e1fe6dca
Reviewed-on: https://chromium-review.googlesource.com/1249474Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594985}

This flag is no longer necessary because updateViaCache was enabled by default
in M68:
https://www.chromestatus.com/feature/6059838387781632

Bug: 675540
Change-Id: I03c5e00b83b150f83edd7022dd38d1fa657d324f
TBR: kinuko@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1249471
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594984}

This is not the kind of fix I like, that gets to the core of the problem
and fixes it for good.

BUG ANALYSIS:
The bug was that the floats were not being painted.

Floats were supposed to be painted by NG container.

They were not being painted because layer did not
paint with PaintPhase::kFloat.

PaintLayer did not paint with kFloat because it did not
have needs_paint_phase_float_ flag set.

The flag was not set because float's
ContainingBlock().ContainsFloats() returned false.

ContainsFloats() returned false because none of the floats
it knew about had ShouldPaint() == true.

ShouldPaint() was false because in first part of the test
float was self-painting. In 2nd part of the test, float
becomes not self-painting, and should have its flag reset.

This does not happen in NG, because LayoutBlockFlow::InsertFloatingObject
never resets the flag because flags do not get set if
floating object is already there.

How does the flag get reset in Legacy? In Legacy,
all floats get cleared on Layout, so when float is
added again, the flag gets set correctly.

Removing all floats in NG on layout would be the
"correct" fix, matching existing behavior. But,
this cannot be done easily. Float descendants
from cached fragments do not get added back on relayout.
Adding descendants from cached fragments would be a big
fix, we'd need to keep a list in cache. We can talk about whether
we want to do this. I can imagine there are other
not-tested float scenarios, that fail even with this patch.
But since I am not a float expert, I can't come up with
any.
Long term, the need for legacy float list will go away.
I'd hold off on complicated fix until we encounter
real-world problems.

THE FIX:
Instead of resetting flag by removing the float, NG
resets the flag after insertion.

Bug: 864398
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ib09b59669644ebe574a6e41cb1ef6426598296c5
Reviewed-on: https://chromium-review.googlesource.com/1249839Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594983}

TBR=mstensho@chromium.org
NOTRY=true

Bug: 890135
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ic9cdb318551df65d26a7d4c52749f48278fd7b33
Reviewed-on: https://chromium-review.googlesource.com/1250462
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594982}

Adds the skottie animation class that is a wrapper around the Skia's
implementation of lottie player. The class manages its own timeline with
the help of a timer object.

This is the phase 1 implementation of native skottie which rasterizes
the animation on the UI thread. Subsequent changes will move this
rasterization to worker threads(phase 2) and then to GPU (phase 3).

Adds unittests as well.

Design Doc: go/cros-skottie

Bug: 867147
Change-Id: I2501710a38874f247ab3ab56a743675e3d07edfb
Component: gfx, skottie, vector animation
Reviewed-on: https://chromium-review.googlesource.com/1189056
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594981}

This will allow us to try different weights from finch.

Bug: 871674

Change-Id: I20412f7a0d15fab4c2f1fc45aba4e817b472ea0b
Reviewed-on: https://chromium-review.googlesource.com/1248404
Commit-Queue: Charles . <charleszhao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594980}

The Great Blink Rename renamed all data members named in m_fooBar
format, but it didn't update comments.  This CL corrects m_fooBar
in comments, found by code search query [1].
This CL also updates other errors in comments around m_foo.

This CL has only comment changes. No behavior changes at all.

[1] https://cs.chromium.org/search/?q=//.*%5Cbm_%5Ba-z%5D+file:blink/renderer/core/(dom%7Cediting%7Chtml)&sq=package:chromium&type=cs

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I9494ad83ebdb04d79fe1480890cb27fc17d7559a
Reviewed-on: https://chromium-review.googlesource.com/1248881
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594979}

TBR: hubbe@chromium.org
Bug: 890124
Change-Id: Ic8e40e59883f43fcee5ad263ac6f551ecd2e59c0
Reviewed-on: https://chromium-review.googlesource.com/1250343
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594978}

The zip archiver NaCl module is lazily loaded crrev.com/594919. Remove
the browser_test special case handling added to control when that NaCl
loaded (only for zip tests); lazy loading should do that for us.

Bug: 889703
Change-Id: I726f32849a6278765a4932a405328faff78bd594
Reviewed-on: https://chromium-review.googlesource.com/1250341Reviewed-by: Anand Mistry <amistry@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594977}

Use AssignedNodes() directly. The abstraction here is no longer
necessary since we removed IncrementalShadowDOM flag.

Bug: 887827
Change-Id: Id5c7e4139ad89ce2ade6efd62bdfc1cbb50c0340
Reviewed-on: https://chromium-review.googlesource.com/1249467Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594976}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/10f3ee914d20..8241a7599974


git log 10f3ee914d20..8241a7599974 --date=short --no-merges --format='%ad %ae %s'
2018-09-28 dgarrett@google.com Create a "buildspec" builder.
2018-09-28 yunlian@google.com cros_chrome_sdk: add options to enable thinlto and cfi
2018-09-28 dgarrett@google.com CIDB: Add index for build_config, branch, id.
2018-09-28 bpastene@chromium.org cros_vm: Add an option to create and boot from a temporary qcow2 image.


Created with:
  gclient setdep -r src/third_party/chromite@8241a7599974

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: If9e075185d7baf16d23594f897c9ca137d156bf8
Reviewed-on: https://chromium-review.googlesource.com/1250114Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594975}

Put radio buttons in a paper-radio-group. Also ensure that behavior
stays the same. Specific behaviors that were tested:
(1) Selecting "custom" radio button when "all" radio button was
    previously selected should automatically focus the custom input.
    However, focusing it if it was already selected does not have this
    effect.
(2) Shifting focus from an empty custom input field, or from the
    "custom" radio button while it is selected and the input is empty,
    automatically reselects the "all" radio button, unless the focus is
    shifting to the custom radio button or input.
(3) left/right arrow keys in the custom input move through the user's
    entered text and do not change to the "All" radio button.
(4) Keep feature of radio group that the radio-button that is not
    selected is not in the tab order. However, if custom is selected,
    the custom input should be in the tab order as well as the
    custom radio button.
(5) Behavior for which bug was filed - i.e. up/down arrow keys should
    work to change between the radio buttons.

Bug: 884645
Change-Id: I88bb990db3a3c760892c65e704ac6ca877a15d96
Reviewed-on: https://chromium-review.googlesource.com/1248129
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594974}

This reverts commit 5dea8c2f.

Reason for revert: Causes TabCaptureApiPixelTest.OffscreenTabEvilTests is flaky


Original change's description:
> Don't update the surface range at every activation
>
> Updating the fallback lowerbound is not necessary anymore and will just
> waste time by causing an unnecessary commit and draw.
>
> Bug: 870456
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Change-Id: Icd553c179c5a2eb98c1608524d9c1caf42a27835
> Reviewed-on: https://chromium-review.googlesource.com/1226366
> Commit-Queue: Saman Sami <samans@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594380}

TBR=fsamuel@chromium.org,khushalsagar@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 870456, 890084
Change-Id: Ia3cb2aa4b405f9e9f9c2a282ae0ec7fdc62e8682
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1249284
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594973}

These changes are necessary to eventually integrate the zip archivers
unit tests.

Changes include:
- virtual -> override
- Un-inlining overridden functions
- Correcting types

BUG=889703

Change-Id: I83030c6b77dda026c4a3fee50df2ecbcedb898f6
Reviewed-on: https://chromium-review.googlesource.com/1250281Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594972}

There's no reason to keep this flag, zip creation should always be enabled.

BUG=None

Change-Id: Id88aeeff60bf220f4a0457a807e7a321a1cc1f85
Reviewed-on: https://chromium-review.googlesource.com/1242644Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594971}

Bug: 881499
Change-Id: Icbf4bdeabbe59f60ff4ca971fd7db868c13e9426
Reviewed-on: https://chromium-review.googlesource.com/1250138Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594970}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=cmasso@chromium.org

Change-Id: I5e3ad45995ebe78a3abbce3b89d0cdaacc7f6441
Reviewed-on: https://chromium-review.googlesource.com/1250224Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594969}

This works better for hit testing with mash.

BUG=879791
TEST=none

Change-Id: Ie87e72933f80a77955f301da2195934109d7f569
Reviewed-on: https://chromium-review.googlesource.com/1250123Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594968}

Mostly fixing some vertical alignment.

Here are screenshots of the real UI and one with long fake strings to
mock a long translation:
https://drive.google.com/drive/folders/13FE9SeGanXukvaICOqusW5S7GVgFfd5r?usp=sharing

Bug: 878644
Change-Id: Iabe0ed9c7daaeef7b2929af37f3c869168cae4d3
Reviewed-on: https://chromium-review.googlesource.com/1249820Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594967}

This CL adds following UMAs & histograms:
* StatusArea_NightLight_Enabled
* StatusArea_NightLight_Disabled
* StatusArea_NightLight_Settings
* StatusArea_QuietMode_Enabled
* StatusArea_QuietMode_Disabled
* StatusArea_Notifications_ClearAll
* ChromeOS.SystemTray.IsExpandedOnOpen

For the descriptions of UMAs, see the .xml.

TEST=manual
BUG=none

Change-Id: I253a69578645f834a32f42fb7ba3aefbbd3bb112
Reviewed-on: https://chromium-review.googlesource.com/1245004Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594966}

This test still fails on Mac with Chrome m68 and m69.

TBR=crouleau@chromium.org

Bug: chromedriver:1945
Change-Id: Ia4aa9d824e365655513a8a486c849b7d51193f33
Reviewed-on: https://chromium-review.googlesource.com/1249573Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594965}

This will be merged to M70 and reverted in M71.

Bug: 890021
Change-Id: I4b6e940db961739ec938029d7ccd185b8f7441a9
Reviewed-on: https://chromium-review.googlesource.com/1250122
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594964}

This should save a lot of disk space on a Mac VM, and stop it from clobbering
the caches after every build.

Tested locally:

$ tools/mb/mb gen -m chromium.mac -b 'Mac Builder' //out/ci

Writing """\
ffmpeg_branding = "Chrome"
is_component_build = false
is_debug = false
proprietary_codecs = true
strip_absolute_paths_from_debug_symbols = true
symbol_level = 1
use_goma = true
"""

Bug: 888223
Change-Id: Ic4014f99232b1929e13dc0ca1e9b983e662a7733
Reviewed-on: https://chromium-review.googlesource.com/1249568Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594963}

stayed upon resizing the window.

Bug: b/112668689
Bug: 841886
Test: Created a PIP window and it had rounded corners. Rounded corners
Change-Id: Ie57223d8c5a2701a0013eee0bce2cf5333d2c304
Reviewed-on: https://chromium-review.googlesource.com/1219426
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594962}

This replaces the current WIDEVINE_CDM_IS_COMPONENT macro defined in
widevine_cdm_common.h. Buildflag is safer, also this avoids tricky cases
where widevine_cdm_common.h must be included before the define can be
evaluated.

Bug: 349182
Test: No functionality change
Change-Id: Ifc26d2fa87b00997e9335a977cb6417c4ec4432d
Reviewed-on: https://chromium-review.googlesource.com/1248132Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594961}

This is apparently now being hit on Android Chromium builds as
a result of the field trial testing config.

Bug: 889950
Change-Id: Id1beefe02127726e1198c8a4fdb679a019a6e62b
Reviewed-on: https://chromium-review.googlesource.com/1249493Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594960}

The test results format says that the key should be 'is_unexpected', not
'unexpected'.

TBR=dpranke

Bug: 890072, 890075
Change-Id: I49d49b9a0ee7ebaf2346658eb8f334cef1cf8a19
Reviewed-on: https://chromium-review.googlesource.com/1250202
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594959}

This reverts commit 3225e1d5.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 594844 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzIyNWUxZDVlYTQ2MjZhNzcwZDgzNWRkMDNhMjViNmMwOTViNThiNQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/72634

Sample Failed Step: events_unittests

Sample Flaky Test: X11EventTest.AutoRepeat

Original change's description:
> Use accurate X11 event timestamp computation.
> 
> X events have a timestamp which is only well defined relative to the X11 Server
> time. The previous computation for timestamp for X11 events was making the
> assumption that Server time and Chrome time were the same. This assumption is
> not always true -- this is likely the root cause of "bad" timestamps observed in
> https://bugs.chromium.org/p/chromium/issues/detail?id=650338#c1
> 
> This CL changes event timestamp computation to make a roundtrip to the X11
> Server to get an accurate base::TimeTicks. This logic was lifted out of the
> responsiveness calculator, which was already doing this computation. The latter
> will subsequently be changed to use the computation in this CL.
> 
> Change-Id: I963019cd8bfb8ce14e06b3743a159c9c85f2cb82
> Bug: 859155
> Reviewed-on: https://chromium-review.googlesource.com/1249383
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594844}

Change-Id: I911f8bd268739b5e91c550e3f6a6186ae4dfbecb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859155, 890121
Reviewed-on: https://chromium-review.googlesource.com/1250210
Cr-Commit-Position: refs/heads/master@{#594958}