- 01 Aug, 2018 40 commits
-
-
Doug Arnett authored
This only holds the hint data for now. Another CL to follow will use it. Moves the recently added activation list into the hint cache as well. Bug: 867651 Change-Id: I188cab0b8539439d859186eecc8185a66ba34efb Reviewed-on: https://chromium-review.googlesource.com/1150739 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#579842}
-
wutao authored
This patch adds a toggle to the Settings to enable/disable notifications. Bug: b/111505289 Test: VoiceInteractionControllerClientTest.PrefChangeSendsNotification Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7b1ba03cc326abb098f9f902f0c51d68f4938133 Reviewed-on: https://chromium-review.googlesource.com/1142503 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#579841}
-
Stephen McGruer authored
This CL implements the writable part of KeyframeEffect's target member. This brings us into line with the spec, except that Chromium still don't support CSSPseudoElement and so we only allow setting Elements. Bug: 813902 Test: external/wpt/web-animations/interfaces/KeyframeEffect/target.html Test: external/wpt/web-animations/interfaces/KeyframeEffect/idlharness.window.js Change-Id: I91faf22473e7776a8cad6165ff60c5d9ee47a9a6 Reviewed-on: https://chromium-review.googlesource.com/1157002 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579840}
-
Zhenyao Mo authored
So we can zip all the scripts from chrome src tree and run on a target machine without checking out the chrome src tree using the following command: python tools/mb/mb.py zip out/Release telemetry_gpu_integration_test_scripts_only out/my_scripts.zip BUG=867155 TEST=perf R=kbr@chromium.org,nednguyen@chromium.org Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ia3706abad6aadb4904fc7584837a511b72be71e8 Reviewed-on: https://chromium-review.googlesource.com/1157251Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#579839}
-
Jan Wilken Doerrie authored
This change implements reading and writing of Remote Gatt Descriptors for WinRT. Furthermore, it enables corresponding tests. Bug: 821766 Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe Reviewed-on: https://chromium-review.googlesource.com/1156703 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#579838}
-
Robert Flack authored
Currently this test verifies that after setting the scroll position there are no paint invalidations, however paint invalidations could occur as part of the lifecycle after script runs. By waiting for the next frame we allow the lifecycle to become clean and commit the frame. This is also a speculative fix for what may have caused the old flakiness on the linked bug. Bug: 520166 Change-Id: I2cfe8fe47a89c39c81f83b23388f945549b8bc8e Reviewed-on: https://chromium-review.googlesource.com/1158718Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579837}
-
Xiyuan Xia authored
- Add mash_content_unittests that runs content_unittests under mash; - Make FakeRenderWidgetHostViewAura only install delegate frame host when it is supported (i.e. RWHVAura has a valid |frame_sink_id_|); - Early out a few of tests that do not work in mash; And content_unittests still uses TestWindowTreeClientSetup since the tests are happy with it and do not need test_ws. Bug: 866942 Change-Id: I664470f0efba1f350a2ae22cb978e0f3f9b2d1f5 Reviewed-on: https://chromium-review.googlesource.com/1153768Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#579836}
-
Christopher Thompson authored
This CL updates secure_origin_whitelist::GetWhitelist() to delegate parsing the set of whitelisted sites to a new function, ParseWhitelist, which takes in a string and returns the parsed vector of strings. This allows callers in the browser process to explicitly parse a whitelist from either prefs or command-line switches. This allows SecurityStateTabHelper to have its own custom IsOriginSecureWithWhitelist function to which it can bind an explicitly passed whitelist of origins, rather than just using content::IsOriginSecure as the callback to security_state functions. content::IsOriginSecure uses GetWhitelist() which only loads the whitelist from command-line flags, which are only correctly set for renderer processes. The custom callback for SecurityStateTabHelper allows it to also check prefs for the whitelist, which is how the enterprise policy is accessible in the browser process (where security indicator UI logic occurs). This can cause the pref and the switch to be two different sources of truth for the origin whitelist, however this simpler fix will be easier to backport. This fix favors the switch over the pref if both are set, allowing developers to still set temporary overrides while maintaining the policy behavior for general users. More general fixes may involve changing how the whitelist propagates between parts of Chrome (including in content and blink). Bug: 869422 Change-Id: I93b46d66844af8cee00d919537ce66fc2c56cd46 Reviewed-on: https://chromium-review.googlesource.com/1157029Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579835}
-
Pavol Marko authored
Ensure that the SequenceLocalStorageMap and consequently objects still stored in the sequence-local storage are destroyed while the owning Sequence's SequenceToken is set for the current thread. This makes sure that objects stored in the sequence-local storage which expect to be destroyed on the same Sequence they've been created on do not (D)CHECK in their destrutor. Bug: 869272 Test: base_unittests && browser_tests --gtest_filter=*UserAffiliation* Change-Id: I8c76b274a746a35c4ad038e7d8f04ea212ef1514 Reviewed-on: https://chromium-review.googlesource.com/1156510 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#579834}
-
Michael Spang authored
This is not used anywhere except in tests, so move it to the test code. There's probably more to be done here; the test should probably mock GBM instead of mocking dumb buffers, which have been completely removed everywhere else. Bug: 869206 Change-Id: I7900956d617d1341d222f0568516ae5027f6a9eb Reviewed-on: https://chromium-review.googlesource.com/1155921 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#579833}
-
Ramin Halavati authored
The list of preferences that are stored in user profile when changed from incognito mode are moved from 'chrome/browser/prefs/pref_service_syncable_util.cc' to 'chrome/browser/prefs/pref_service_incognito_whitelist.cc'. Bug: 861722 Change-Id: Ic13e7c45f5c82193bf29cfdeac2d3ffe7c186fc9 Reviewed-on: https://chromium-review.googlesource.com/1158064 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Peter Collingbourne authored
These don't appear to be necessary: almost all clients return non-null pointers from their CreateContent*Client functions, so we can use the content clients directly. The one exception is the chromecast utility client whose use of that functionality seems unintentional. Bug: 855193 Change-Id: I9b835de11dfe37799b30bba7921513438a0d5a9e Reviewed-on: https://chromium-review.googlesource.com/1157659Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579831}
-
Jan Wilken Doerrie authored
This change implements obtainining Remote Gatt Descriptors for WinRT by hooking up the appropriate logic into GattDiscovererWinrt. Furthermore, appropriate tests are enabled. Bug: 821766 Change-Id: I20475478367c2ab6b18940b4271de70ec138f676 Reviewed-on: https://chromium-review.googlesource.com/1156392 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Guohui Deng authored
The Chromecast Service Name is now defined in one file, and duplicated definitions are eliminated. Bug: internal b/111850629. Test: Build cast_shell. Change-Id: I8856313bf925c4db5c444bbb7a94515c89442b28 Reviewed-on: https://chromium-review.googlesource.com/1155654Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Bailey Forrest <bcf@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#579829}
-
Sam Maier authored
This is to give better visibility of the threads which are Chrome's and threads which are Android's. Bug: 843745 Change-Id: Ie7f75cb915e70b13ef8957f7320d93d890f23a18 Reviewed-on: https://chromium-review.googlesource.com/1158398Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#579828}
-
khmel@google.com authored
Sometimes checking version code is clearner than using requestes for to extract instance for method. BUG=None TEST=In context of another CL. Change-Id: Id666ee06678affc7bd88eec8c5129d1d801af070 Reviewed-on: https://chromium-review.googlesource.com/1157283 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
-
David Bertoni authored
[EXTENSIONS] Fixed bug where height and width were swapped in image_utils::IsIconSufficientlyVisible. Bug: 805600 Change-Id: I8a56269864d6785d5eb895dc92b55271e5ca3e83 Reviewed-on: https://chromium-review.googlesource.com/1157210Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#579826}
-
Eric Robinson authored
This updates the ad_page_load_metrics_observer so that it accounts for ad frames that trigger ads without a navigation (via a script identified as an ad via subresource filters). Bug: 849268 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I81b9dee7e3556719e40337f2efd818f784130b78 Reviewed-on: https://chromium-review.googlesource.com/1120347 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579825}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd98c2c87164..70c787ae5bbc git log fd98c2c87164..70c787ae5bbc --date=short --no-merges --format='%ad %ae %s' 2018-08-01 timliang@google.com implemented copy surface as draw then blit for metal gpu backend 2018-08-01 benjaminwagner@google.com [Bazel] Add lottie as dm source. 2018-08-01 egdaniel@google.com Move GrVkInterface out of public API. 2018-08-01 nigeltao@google.com Have CodecTest's check not skip 'complete' tests 2018-08-01 nigeltao@google.com Avoid infinite loop in Codec_requiredFrame test Created with: gclient setdep -r src/third_party/skia@70c787ae5bbc The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Idc5b6d6a74448d64cacc87c88fd883b0e351a9ec Reviewed-on: https://chromium-review.googlesource.com/1158724Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579824}
-
Xiaohan Wang authored
This reverts commit 3a127077. Reason for revert: The test is still failing on Win64 trunk and Win trunk on official continuous desktop builder. Original change's description: > media: Reenable TestPolicyCheck() on Windows for Widevine > > The original problem has been fixed in the latest Widevine CDM. > > Bug: 851027 > Change-Id: I9aced3ea2152e33fcc8a5bcddc8a587c45dee6cc > Reviewed-on: https://chromium-review.googlesource.com/1154087 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579615} TBR=xhwang@chromium.org,liberato@chromium.org Change-Id: I1446eb5919ac014420fe7095d7916ee92cbb3d57 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851027 Reviewed-on: https://chromium-review.googlesource.com/1158767Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#579823}
-
Michael Spang authored
Since GbmBuffer moved, the only class this file defines is GbmPixmap. So rename it. Bug: 869206 Change-Id: If58f4590c8a118d557059368617e1521e9f16802 Reviewed-on: https://chromium-review.googlesource.com/1155920 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Ian Vollick authored
This reverts commit 2698a26d. Reason for revert: this did not fix the build errors. Original change's description: > Reland "Reland "[ar] Do not refer to ARCore shim in APK merger"" > > This is a reland of f3f5b838 > > I think I've finally fixed the root issue and this is ready > to land again. > > Original change's description: > > Reland "[ar] Do not refer to ARCore shim in APK merger" > > > > This is a reland of 58e4a081 > > > > Original change's description: > > > [ar] Do not refer to ARCore shim in APK merger > > > > > > This hard-coding should no longer be required. > > > > > > Bug: 839191 > > > Change-Id: Id44f0f19da6efcee90ef79ea3e241eb2a7ea5843 > > > Reviewed-on: https://chromium-review.googlesource.com/1147706 > > > Commit-Queue: Ian Vollick <vollick@chromium.org> > > > Reviewed-by: Richard Coles <torne@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#577662} > > > > Bug: 839191 > > Change-Id: I42c3d31c0cbe49c1fe2d68c55d0db18dcdc3381d > > Reviewed-on: https://chromium-review.googlesource.com/1151567 > > Reviewed-by: Richard Coles <torne@chromium.org> > > Commit-Queue: Ian Vollick <vollick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#578347} > > Bug: 839191 > Change-Id: I2618d967b214fb8f21264d6303837b08729222c4 > Reviewed-on: https://chromium-review.googlesource.com/1152275 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579391} TBR=vollick@chromium.org,torne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 839191 Change-Id: I5857ff149053eda03acbd6d2ccb8403667455b2c Reviewed-on: https://chromium-review.googlesource.com/1158764 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#579821}
-
Elly Fong-Jones authored
This change is in preparation for a fix to the right-click selection behavior on Mac. This change also has RenderTextHarfBuzz EnsureLayout() when getting a substring range. Bug: 856609 Change-Id: I85c81c630fc2e6ac79d01a7a25a6f3e30756fdb5 Reviewed-on: https://chromium-review.googlesource.com/1156844 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#579820}
-
Kevin Bailey authored
In the final OnPaintBackground() method, it currently uses a standard rectangle to "dim" the background on hover (or animation). This resulted in some dimming outside a rounded button. This change uses a rounded rectangle instead, using the existing corner radius. Bug: 866136 Change-Id: Ifb8ad476e231049efbf73e1dc64c0c1f0f113897 Reviewed-on: https://chromium-review.googlesource.com/1156877 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#579819}
-
Antonio Gomes authored
This CL exposes a method that allows the creation of FileURLLoaderFactory instances. through the content/browser public API. This is a preparation for CL https://crrev.com/c/1066370. BUG=773295,844928 Change-Id: I89c9cd2e82ee54f4dae1c121d5e0f7b5c0597fb1 Reviewed-on: https://chromium-review.googlesource.com/1156885 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6e250820b17e..7a1c7f782a14 git log 6e250820b17e..7a1c7f782a14 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 hta@webrtc.org Modified peerconnection's "observer" slot to be nulled on close. 2018-08-01 kthelgason@webrtc.org Support compiling with the lastest iOS SDK. 2018-08-01 alessiob@webrtc.org RNN VAD: more specific build target names. 2018-08-01 peterhanspers@webrtc.org The pixel buffer pool is currently recreated on every call to encode. 2018-08-01 kthelgason@webrtc.org Include RTCMTLVideoView even on archs without metal. 2018-08-01 nisse@webrtc.org Reland "Delete root header file typedefs.h. Part 2." Created with: gclient setdep -r src/third_party/webrtc@7a1c7f782a14 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:868337,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6e2ac484f7508ffc83bec8414a94d4905e7f0f3b Reviewed-on: https://chromium-review.googlesource.com/1158347Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579817}
-
Ian Kilpatrick authored
This was pretty mechanical, but everything I think still makes sense. Effectively everything that references "resolving a BFC offset" now turns into "resolving a BFC block offset". There should be no behaviour change. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I1215520ab21eae6fb45b4ab53be08a0fdde232ac Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/1155266Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#579816}
-
Owen Min authored
Refactor the class as one instance only supports one policy type and domain pair. PolicyDomain is now the member of class which indicates the type/domain instance owned. Also, 1) Remove domain to DomainConstants converting as there're two policy types use the same policy domain. 2) Store()/Delete() check whether the policy namespace matches the owned domain or not. 3) Purge() only filters on the owned domain. Bug: 867028 Change-Id: I7fc5650bb11e0ea6db362efc113eca049fdd2fb1 Reviewed-on: https://chromium-review.googlesource.com/1155653 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#579815}
-
Marina Ciocea authored
This CL leaves enabled the tests that pass: - WebRtcAudioQualityBrowserTest.MANUAL_TestCallQualityWithAudioFromFakeDevice - WebRtcAudioQualityBrowserTest.MANUAL_TestCallQualityWithAudioFromWebAudio and disables failing tests: - WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainIsOffWithAudioProcessingOff - WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainControlOnLowAudio Bug: 850936 Change-Id: Ib19073f01f0880cda81bd9900d2d07c354c71ae3 - NOTRY because these tests don't run by default on bots - TBR because owners are OOO. NOTRY=true TBR=hbos@chromium.org Change-Id: Ib19073f01f0880cda81bd9900d2d07c354c71ae3 Reviewed-on: https://chromium-review.googlesource.com/1158699Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#579814}
-
Colin Blundell authored
This CL fixes a timing issue with the implementation of IdentityManager::Observer::OnRefreshTokenUpdatedForAccount(): - It is fired from IdentityManager::WillFireOnRefreshTokenAvailable() - which is fired from ProfileOAuth2TokenService::OnRefreshTokenAvailable() - just *before* ProfileOAuth2TokenService calls CancelRequestsForAccount(). The upshot is that any access token requests made from IdentityManager::Observer::OnRefreshTokenUpdatedForAccount() implementations will be immediately cancelled. Yikes! On desktop, it also means that access token requests that are made from ProfileOAuth2TokenService::Observer::OnRefreshTokenAvailable() clients after any such cancellations will also be cancelled, as MutableProfileOAuth2TokenServiceDelegate has a policy of immediately canceling access token requests for some amount of time after it has seen a cancelled access token request (this is part of its backoff policy). The fix is the following: - Move the firing of the IdentityManager::Observer callbacks to its (new) implementation of the corresponding OAuth2TokenService::Observer callbacks. Note that the updating of IdentityManager's internal state must still be done in IdentityManager::WillFireOnRefreshToken{Available, Revoked}; this ensures that it updates its state before any observers of ProfileOAuth2TokenService are notified of the state change, and thus that any such observers see a consistent state between IdentityManager and ProfileOAuth2TokenService. To decouple the internal update from the firing of the observer callbacks, some state is now saved from the internal updates firing to forward in the observer callbacks. This change is unittested via extensions to the PrimaryAccountAccessTokenFetcher unittests that ensure that the fetcher does not have a request cancelled that is made in its implementation of IdentityManager::Observer::OnRefreshTokenUpdatedForAccount(). Before the production fix, the extended unittests would have failed, as the fetchers were seeing a cancelled request and then retrying it (which succeeded). Bug: 869376 Change-Id: Ic5d3208ef893ad0e821c38bbb88c713d68042a1a Reviewed-on: https://chromium-review.googlesource.com/1152731 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#579813}
-
Mounir Lamouri authored
This allows the submitter to update the LocalSurfaceId (by modifying the child component) before submitting a new frame. The SurfaceLayerBridge will be notified of the change and update its internal surface id. Bug: 868008 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iee17f20c753cc236b9ccce5d5bdfe05fb655b08e Reviewed-on: https://chromium-review.googlesource.com/1157882Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#579812}
-
Ovidio Henriquez authored
This change updates the BrowserTestNonsecureURLRequest set up code to use a URLLoaderInterceptor to handle URL requests. Using URLLoaderInterceptor enables the test to work properly when using Network Service code. Bug: 778860 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5898b166967bd8d54608b78444c0aa7c99429df5 Reviewed-on: https://chromium-review.googlesource.com/1150826 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579811}
-
Christopher Thompson authored
This CL enables the previous HTTP-Bad condition "WarningAndDangerousOnFormEdit" by default, which shows a warning on all http:// pages and a dangerous warning if a form field is edited. This also updates security state tests accordingly. Bug: 868575 Change-Id: I6ec68a756b40e5cc312dc15e0df477891e85287a Reviewed-on: https://chromium-review.googlesource.com/1153828Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579810}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/68afb50705f8..226b95461af2 git log 68afb50705f8..226b95461af2 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 perezju@chromium.org [telemetry] Remove android_platform_backend.IsAppRunning Created with: gclient setdep -r src/third_party/catapult@226b95461af2 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:869573 TBR=sullivan@chromium.org Change-Id: I1522430003ba65bb5b8a8755d6fd19d067b45467 Reviewed-on: https://chromium-review.googlesource.com/1158326Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579809}
-
Ross McIlroy authored
Use As<Boolean>/<Integer>/<Number> instead of deprecated Value::BooleanValue/IntegerValue/ NumberValue. BUG=v8:7786 Change-Id: I4123b5e135b58d3b6a88da6eec3fa8634dd06b5c Reviewed-on: https://chromium-review.googlesource.com/1158406 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#579808}
-
Reilly Grant authored
This change ports ExternalPolicyDataFetcher from net::URLFetcher to SimpleURLLoader. Bug: 844951 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I4ec5dcc5904f3bb1f35ec5c8ba8c30865d5cc126 Reviewed-on: https://chromium-review.googlesource.com/1139229Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#579807}
-
Rune Lillesveen authored
Instead of doing this call inside RebuildChildrenLayoutTrees, wait until we have finished all pseudo element children as well. This is done in preparation for ::first-letter update changes and split out from [1]. The other call-site for RebuildChildrenLayoutTrees, ShadowRoot::RebuildLayoutTree, already cleared this flag afterwards. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1155591 Bug: 847218 Change-Id: I72816c5249bcb863fab906ffef90c026619d8165 Reviewed-on: https://chromium-review.googlesource.com/1156387Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#579806}
-
Mark Cogan authored
This CL fixes the flash of grid visibility under the grid toolbars that happens during the grid transitions. The fix has two parts. The first is to fade the grid toolbar backgrounds to black (masking out the other grid cells) instead of fading them to alpha zero. The toolbar controls still fade out, however. The second part is to move the expanding tab in the view hierarchy so that it sits on top of the tab grid, while the rest of the animating cells are inserted inside it. The API for this is somewhat clumsy at this stage; the animation class (itself a UIView) exposes the animating cell as a property, and the animator reparents it to be above the presenting view during the animation. Bug: 865454 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9ced094dfc053233f0dcbb5adb856639528c5daa Reviewed-on: https://chromium-review.googlesource.com/1154974 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579805}
-
Ramin Halavati authored
Removes rhalavati@ from clang_update watch lists. Change-Id: Icf5b347249ce10faef5c4c40f971b8403bc20462 Reviewed-on: https://chromium-review.googlesource.com/1158690Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#579804}
-
Mitsuru Oshima authored
See bug for details. Bug: b/74845106 Test: manual. Change-Id: I079ab633524e8cbee7ff19abe1202a43b8b7edfe Reviewed-on: https://chromium-review.googlesource.com/1156864Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#579803}
-
