- 20 Mar, 2020 40 commits
-
-
Salvador Guerrero authored
This reverts commit ea08b9b5. Reason for revert: caused build failure in arm64-builder-rel https://ci.chromium.org/p/chrome/builders/ci/arm64-builder-rel/21172 Original change's description: > base/allocator: Improve PartitionAlloc perftests. > > Add: > - Comparison with the system allocator > - Better concurrent workloads for competing threads (identical as the > test) > - Reporting of the total allocation rate, and the worst thread > - Varying number of competing threads > > This is useful to evaluate the performance of PartitionAlloc with > various changes, such as changing its locking to base::Lock, or > implementing a thread cache. > > Bug: 998048 > Change-Id: I4c5f837f9e1b5af19b2f80bd79f3d3181166d930 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111160 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752077} TBR=haraken@chromium.org,lizeb@chromium.org Change-Id: I02421083b4765a68138544307ba238aa481b0a41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112589Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#752090}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/1e859054c31ec7b974e998373e85fadea56d93ad..5298ef99bf2b2d77600b3bb74dd572027bf495be The following commits have Chromium bugs associated: 0b710a305 Trust Token Key Generation. The following commits have update notes: 5298ef99b Configure QUIC secrets inside set_{read,write}_state. Bug: 1014199 Change-Id: I8c615e4137bf8b8e2fbfed1f8fc705a7d8abd568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108823 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#752089}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/976cc1ae1901..dfeb0dff731d git log 976cc1ae1901..dfeb0dff731d --date=short --first-parent --format='%ad %ae %s' 2020-03-20 handellm@webrtc.org RtpParameters: respect https://abseil.io/tips/1. 2020-03-20 danilchap@webrtc.org In PacketBuffer simplify stored buffer. 2020-03-20 peah@webrtc.org AEC3: Rename main filter Created with: gclient setdep -r src/third_party/webrtc@dfeb0dff731d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5344e9ad6742e09378f3e19c494949cec329c812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112301Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752088}
-
Kevin Ellis authored
The animationcancel event was missing from the set of supported events for a CSSAnimation. This patch adds support for the missing event. The event includes an elapsed time member for the animation, which is also plumbed through in this patch. With support for animationcancel, most of the remaining test timeouts have been addressed for CSSAnimations. The next step is to handle reattachment of an event delegate after a call to animation.effect. Spec: https://drafts.csswg.org/css-animations-1/#eventdef-animationevent-animationcancel Bug: 1059968 Change-Id: I83714a06c328a77dc4969928c2c926f3cb207fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107302 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#752087}
-
John Pham authored
The unexpected behavior sanitizer picked up an issue in ToolbarAccountIconContainerViewBrowserTest.ShouldUpdateHighlightInNormalWindow where |save_card_icon| was reporting an incorrect size. The problem is that |save_card_icon| was reporting it's bounds as (0, 0). This was happening on both Linux and Windows. The size would then be used as a divisor. Floating point division-by-zero behavior isn't defined in the C/C++ spec and it's up to the compiler implementation. Windows (clang) will return NaN while Linux (gcc/g++) will raise an exception. The fix is to have the parent view, |container| reapply the layout after setting |save_card_icon| to visible. This will set the bounds of |save_card_info| correctly. Change-Id: I51796979292c0a65d40a28aeb5a255a80acae510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110396Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: John Pham <johnp@microsoft.com> Cr-Commit-Position: refs/heads/master@{#752086}
-
Mikel Astiz authored
In the error-handling codepath where a mismatch is found on the cache GUID, when sync is starting for Nigori, the new cache GUID should be stored in the ModelTypeState. Otherwise, it would remain empty, which means the next sync start the mismatch detection doesn't take place. This can explain cache-GUID mismatches being ignored, and bad consequences such as violating the sync protocol by sending a non-empty progress marker despite the sync birthday being empty. Bug: 1063021 Change-Id: I05c1c000c17b1f10ff37984d1b8b9f812f02a7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111301Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#752085}
-
Peter E Conn authored
Bug: 1059828 Change-Id: I198b6d206e7af1f6a4e272750214068926eb1a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107592Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#752084}
-
Brandon Wylie authored
Bug: 1055228 Change-Id: I1fd7a46b5728c6f36e0f79525c5c9ac5c2c9706e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111395Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752083}
-
Allen Bauer authored
TBR=xiaolingbao@chromium.org Bug: 1056944 Change-Id: I4fe3c01989c6361868647fa4db2dac4c525aeb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102646 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752082}
-
Mitsuru Oshima authored
* Modified VisibleWindowCanOccludeOtherWindows so that it takes the solid color's alpha into account. This shouldn't be applied when checking the parent because it should not affect children's opacity. Two unsolved issues: * Solid color animation is not addressed in this CL. That is, A window should be marked as VISIBLE when animation starts. This requires adding PropertyChangeReason to OnWindowTransparentChanged, OnLayerFillsBoundsOpaquelyChanged and so forth. and SOLID_COLOR layer. New test is added to cover the semi-opaque-solid-color with a opaque child. Bug: 1057024 Test: Updated opacity related tests to test with both TEXTURED Change-Id: Iec6dffe7880031dfc5d26f8d94d19c3e352e6145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104457Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#752081}
-
Matt Jones authored
This patch begins the process of moving individual users of the ScrimView to the new scrim component. The RootUiCoordinator now instantiates the component and passes it to the BottomSheet. The BottomSheet still references the ScrimView class because of other dependent features. Bug: 1062099 Change-Id: I2834a0a95880a6d7d6ad250849ae24d04a3b14ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106755 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#752080}
-
Nate Chapin authored
Bug: 1061686 Change-Id: Ia6ee7028e5a5e37041d61869792ef492213ba272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107311 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#752079}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f22744971516..85755f46a881 git log f22744971516..85755f46a881 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 brianosman@google.com Delete copy constructor and assignment operator on VariableReference Created with: gclient setdep -r src/third_party/skia@85755f46a881 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I6c46245730d980af5669d70938f9cb763a72be7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112613Reviewed-by:
-
Benoit Lize authored
Add: - Comparison with the system allocator - Better concurrent workloads for competing threads (identical as the test) - Reporting of the total allocation rate, and the worst thread - Varying number of competing threads This is useful to evaluate the performance of PartitionAlloc with various changes, such as changing its locking to base::Lock, or implementing a thread cache. Bug: 998048 Change-Id: I4c5f837f9e1b5af19b2f80bd79f3d3181166d930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111160Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752077}
-
Robert Ma authored
iclelland@: "Looks like the test is occasionally taking >6s to complete (and therefore timing out,) because it ends up loading 42 subframes, 7-at-a-time in promise tests, which necessarily run sequentially." Bug: 884445 Change-Id: I34a89ff6665a88455926155639df38c91db4af72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110172 Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#752076}
-
wutao authored
Bug: 1061271 Test: past build Change-Id: Ie363350b8499ef4e41c9236d9d8107ab2167ba7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112115 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Andrew Grieve authored
These flags were needed for me to run a target that lives in //clank. Also switches out multiprocessing.Pool for multiprocessing.dummy.Pool so that exceptions raised by the script don't cause it to hang forever, and so Ctrl-C actually works. Change-Id: Ib7c7aa7374ad67e179a5a54af53ceee7eb167587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112111Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#752074}
-
Vasiliy Telezhnikov authored
This CL adds reporting for GPU.ContextLost.DisplayCompositor uma for SkiaRenderer. It also fixes offline flag for reporting DidContextLost to browser. Bug: 927460 Change-Id: Iea14170b7e98f001376ae0602df1f870b1de5871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110216 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#752073}
-
Rushan Suleymanov authored
This patch removes old logic of setting cache GUID for old clients which had no this field. Clients must have set this field after one and a half years. Clients that haven't migrated will remove sync metadata (treat as cache guid mismatch) and go through download and merge procedure. There is one more little change: ConnectIfReady is removed from OnPendingDataLoaded because it does nothing and seems to be obsolete. Bug: 947044 Change-Id: I72a441c5ed9bfa2d77a58494aaa2181a1df54d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062277 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#752072}
-
George Steel authored
Set the OperationType in TransformOperation::Blend() according so that it is a 3D operation type iff either of the blended values are (previous behavior was to use the second value and ignore the first). This makes Is3DOperation() work for interpolated operations stops z values getting dropped during serialization. Bug: 1057307 Change-Id: Ibcbb3125660ab172a0f65f08b8ccd67534cdd665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102640Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#752071}
-
David Van Cleve authored
NetworkContext currently owns a trust token store that is constructed asynchronously; it has a TrustTokenStore*-typed getter that returns null until the store is ready. This change adds a "pending" class that allows enqueuing operations against the store, to be executed as soon as the store is ready, so that clients of the store can use the same asynchronous interface all the time, rather than having to check if the store exists or not. Bug: 1042962 Change-Id: Ib1c6e2a24f5db6796dd7033824e9b6dcf227a050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110474Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#752070}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65a94404..542f8a10 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I39550ed6b02001582b78507da9b1112065a8ab9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111578Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752069}
-
Vladimir Levin authored
As part of the resolution from https://github.com/WICG/display-locking/issues/139 we decided that we should use the contained size information when determining what to scroll into view. In the code, this means we shouldn't activate the element on scrollIntoView and rely on viewport intersection instead. Note that hidden-matchable now (correctly) doesn't unhide. R=chrishtr@chromium.org Change-Id: I9336868ddace68b85e6da4b99ad02ad2f9aa1314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109815Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I2c6d78fcaef48db306ac16f6f37d1bb92b954419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112238Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752067}
-
rbpotter authored
Bug: 1026426 Change-Id: Ib3b12943d0186861a4b2dfc74981626bdec19d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111766Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#752066}
-
Mathias Bynens authored
CL that temporarily disabled these tests: https://chromium-review.googlesource.com/c/chromium/src/+/2111179 DevTools front-end CL that modified the behavior: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2112361 Bug: chromium:1056588 Change-Id: Ic73c42cae0497111e86564c7a347c84ae32508bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112550Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#752065}
-
Bettina authored
If the UX is not ready, there is no place to manually set the enhanced protection for testing. The command line pref store allows mapping a command line flag with a pref. Bug: 1063110 Change-Id: Ib1bef9a8fd01e7db43aeb29c96b7865893206089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111054Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#752064}
-
Ilya Sherman authored
According to the UMA.TruncatedEvents.UserAction.Type histogram, this is one of the most commonly dropped user actions, so we're not getting good data about this event regardless. R=dmazzoni@chromium.org Bug: none Change-Id: Ib43171563b6208a5fbb4402bc1ee6d77275ab41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110398 Auto-Submit: Ilya Sherman <isherman@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Khushal authored
We shouldn't be parsing json data from untrusted sources in the GPU process. For this reason we allow skottie objects to be used only by the GpuChannel associated with the browser process. Fix an error in enforcing this. R=malaykeshav@chromium.org Bug: 894635 Change-Id: If5b0bfb3c95b7475e735b0b74e69d8c1cf533020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112334 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#752062}
-
rajendrant authored
Adds a browser test so that coverage ukm is recorded in both the modes of enabling and disabling the actual image redirection. Bug: 1047330 Change-Id: I97cfaa27f3089fc0d909c1357a3a3fa6b5c8405a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111784Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#752061}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f845b816079e..d423d43a0f50 git log f845b816079e..d423d43a0f50 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 jiancai@google.com chromite: disable DebugInfoTest for non-toolchain builders. 2020-03-19 pfagerburg@chromium.org lib/git: add grep option to git.Log 2020-03-19 cjmcdonald@chromium.org Mark test with pytestmark_output_test Created with: gclient setdep -r src/third_party/chromite@d423d43a0f50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I87595ee5ee9acc518e565c9c6dee045e785bfa27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112612Reviewed-by:
-
Francois Doray authored
This is a partial reland of https://crrev.com/c/chromium/src/+/2062692. We confirmed that the CL affected startup metrics on Mac. However, our assessment is that the change is correct (restored tabs are painted before non-restored tabs more often). As a precaution, the original CL is split in two: - Start loading restored tabs earlier (https://crrev.com/c/chromium/src/+/2095970) - Enforce stricter requirements in FirstWebContentsProfiler (this CL) Original change description: On Windows, a visible restored tab starts loading in the following stack, before FirstWebContentsProfiler is created: content::NavigationControllerImpl::LoadIfNecessary content::NavigationControllerImpl::SetActive ... content::WebContentsImpl::UpdateWebContentsVisibility content::WebContentsViewAura::UpdateWebContentsVisibility ... BrowserView::Show SessionRestoreImpl::ShowBrowser SessionRestoreImpl::RestoreTab SessionRestoreImpl::RestoreTabsToBrowser SessionRestoreImpl::ProcessSessionWindows SessionRestoreImpl::ProcessSessionWindowsAndNotify SessionRestoreImpl::Restore SessionRestore::RestoreSession ... StartupBrowserCreator::Start ... content::BrowserMainLoop::PreMainMessageLoopRun On Mac, it starts loading in the following stack, after FirstWebContentsProfiler is created: content::NavigationControllerImpl::LoadIfNecessary content::NavigationControllerImpl::SetActive ... content::WebContentsImpl::UpdateWebContentsVisibility content::WebContentsViewMac::OnWindowVisibilityChanged -[WebContentsViewCocoa updateWebContentsVisibility] -[WebContentsViewCocoa windowChangedOcclusionState:] ... base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run ... ChromeBrowserMainParts::MainMessageLoopRun This prevents FirstWebContentsProfiler from having strict cross-platform expectations about events it observes. With this CL, we ensure that visible restored tab start loading in the following stack on all platforms: content::NavigationControllerImpl::LoadIfNecessary chrome::`anonymous namespace'::CreateRestoredTab chrome::AddRestoredTab ... SessionRestoreImpl::Restore SessionRestore::RestoreSession ... StartupBrowserCreator::Start ... content::BrowserMainLoop::PreMainMessageLoopRun This allows us to enforce strict cross-platform expectations about events observed by FirstWebContentsProfiler, and also have the nice benefits that navigation isn't delayed until we get a window visibility update during a Mac session restore. Bug: 1035419, 1020549, 1022492 Change-Id: I6885f0fc667423bc55cdc201c9ada4dca167ce92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097368Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#752059}
-
Robert Kaplow authored
Change-Id: I9d2ee1ddea4a1a8e0f392147813b5b68d925f58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108344Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#752058}
-
Robert Sesek authored
Bug: 1063349 Change-Id: Ib6c8f119d81a1158bcea66e83e6074c03ed376c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112236Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#752057}
-
Elly Fong-Jones authored
This change makes HistoryMenuBridgeTest and HistoryMenuCocoaControllerTest subclasses of BrowserWithTestWindowTest rather than CocoaProfileTest. It also fixes one subtle lifetime problem in the former - it left a dangling HistoryObserver at the test end, which was exposed by BWTWT's more defined teardown behavior. It also created a history DB on disk needlessly, which made the tests pretty flaky for me in local use; it now uses a memory DB instead. Bug: 39725 Change-Id: If4683d2baee146a071002a2dd9e1eb0d933d48f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108960Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#752056}
-
Elly Fong-Jones authored
Instead, have them use BrowserWithTestWindowTest, CocoaTestHelper, and the template URL service directly. Bug: 39725 Change-Id: I641c5641e7791758bd0445a843679f421a3c089d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112240Reviewed-by:
-
Dave Tapuska authored
The test is testing the return code of vibration not being supported. Some browsers (chromium) implement a user-activation check first. Ensure that a click is simulated first before executing the rest of the test. Change-Id: I960cb568be31b718f773a940271b9eb7d745416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110074 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#752054}
-
Daniel Rubery authored
Bug: 1058431, 1060367 Change-Id: Iccbcf2a53787019e92e9de24c0d2f4862a93e227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110077Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#752053}
-
John Lee authored
Bug: 973674 Change-Id: I479ce1fe1a3d2114bf3dd54c873a43e8b257b72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109039 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#752052}
-
Mark Schillaci authored
This CL expands on the work completed in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/2070232 Here we expand the work to only include the AccessibilityNodeInfo actions when a node is user scrollable, not just scrollable in general (e.g. only programmatically scrollable). We have added checks to IsScrollable() for all of our directional CanScroll...() checks, ensuring that we aren't looking strictly at position but whether or not the node is user scrollable. b/150010542 Change-Id: I70a9a30b62e165bda01fd05ea4f3513727065d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106534 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
-
