- 19 Mar, 2018 17 commits
-
-
Darren Shen authored
This patch adds support for motion path properties. We had to modify the computed style computation for <position> values. Previously, we parse a <position> value as a CSSValuePair, but compute them to a CSSValueList containing two items. This is very strange, so we just compute to a CSSValuePair. Since both serialize to the same string, this has no behavioural changes on CSSOM. Bug: 820299 Change-Id: I2131055dad0785eb47ea2d2d89f00229f4376bae Reviewed-on: https://chromium-review.googlesource.com/967915Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#543975}
-
Scott Violet authored
This calls it from OnLayerTransform(). That way, if the transform is changed outside of Window::SetTransform, everything still works. BUG=822917 TEST=covered by tests Change-Id: I27acb266c4a4993df0a71457af8aa3b4c2cde5d1 Reviewed-on: https://chromium-review.googlesource.com/967841Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#543974}
-
Kouhei Ueno authored
Bug: 803774 Change-Id: Idcf4ef761dc2646bd7dac41b8641209a831bbce3 Reviewed-on: https://chromium-review.googlesource.com/967910Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#543973}
-
Saman Sami authored
Create a base::Feature for using video capture API in DevTools so we can do finch trial independent of Viz. Bug: 813929 Change-Id: I44da043f473d8be663931306e7e9dd296143b1c4 Reviewed-on: https://chromium-review.googlesource.com/963183Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#543972}
-
Alexandre Courbot authored
This option was a no-op, and is being removed from autotests. BUG=819542 TEST=Verified that autotests were still passing CQ-DEPEND=CL:952036 Change-Id: I072a56faf78a3c453e9195e7a4f8cf5599872796 Reviewed-on: https://chromium-review.googlesource.com/954768Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#543971}
-
Raymes Khoury authored
With permission delegation, permissions should generally not be set for embedded origins from UI (e.g. prompts, etc.). Therefore the default scoping type should not be REQUESTING_ORIGIN_AND_TOP_LEVEL_ORIGIN_SCOPE going forward. Some existing settings use this scoping type even though they don't need to: -The user pref for CONTENT_SETTINGS_TYPE_BLUETOOTH_GUARD is never set from UI so the scoping type is not important. -Accessibility events should be using permission delegation when it launches and so having it set to the requesting origin is appropriate -Payment handler is allowed by default but can be blocked for specific origins. I would suggest that behaves like JS, popups, etc. in that if the user blocks a certain origin, all origins that are embedded on that page are also blocked. -Clipboard is only currently only allowed for top level origins. If/when it gets exposed to iframes, it should use permission delegation. Bug: 802945 Change-Id: I2aaa2b67634571422b564f0a4e23b8c5a3d965c2 Reviewed-on: https://chromium-review.googlesource.com/954522Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#543970}
-
Koji Ishii authored
Following bot results are included. 4253 4254 4256 4259 4262 4267 4268 4269 4270 4271 4272 240 lines were removed and 0 lines were deflaked by consecutive results since 2403. From this patch, the script was updated to look at TestExpectations to deflake/remove lines only with [ Pass ] if they're no longer needed. Large number of removal of [ Pass ] comes from this new logic. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If88b38822a82f0bd20476ce4d466cdbe83494e67 Reviewed-on: https://chromium-review.googlesource.com/966164 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#543969}
-
Megumi Hattori authored
This CL enables IME on lock screen behind flag, --enable-lock-screen-notification, in order to enable input of languages other than English in the inline reply on notifications. BUG=823184 TEST=manual Change-Id: I820e70855be414756d2d4f0ee9e90ee92edb2c3c Reviewed-on: https://chromium-review.googlesource.com/966248 Commit-Queue: Megumi Hattori <megumihattori@google.com> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#543968}
-
Hikaru Nishida authored
ConvertFromWebSelectionBound() Before this patch, cc_bound.type is computed using is_start and web_bound.is_text_direction_rtl. This is redundant because WebSelectionBound has .type which is computed in the same way in GetWebSelectionBound() at WebSelection.cpp. is_start and is_text_direction_rtl is exactly the same value used in both functions so we can convert kSelectionLeft to LEFT, kSelectionRight to RIGHT and kCaret to CENTER (default value). Therefore, we can introduce ConvertFromWebSelectionBoundType() which directly converts from blink::WebSelectionBound::Type to gfx::SelectionBound::Type and refactor ConvertFromWebSelectionBound() with it. This patch also renames ConvertWebSelectionBound() to ConvertFromWebSelectionBound() to clarify what type is input. See also: crrev.com/c/934106 TEST: No change in behavior. Change-Id: I3cbc4af607438841be6e2b47e10d12deaa273aa3 Reviewed-on: https://chromium-review.googlesource.com/942585Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Hikaru Nishida <hikarun@google.com> Cr-Commit-Position: refs/heads/master@{#543967}
-
Xiaocheng Hu authored
This patch adds test cases of LocalCaretRectOfPosition() for positions at BiDi boundaries but not logical line boundaries. Test cases are named in format: In{BlockDir}Block{BaseRunDir}BaseRun{Side}{NestedRun}{Deep} - BlockDir: Direction of containing block, either 'Ltr' or 'Rtl' - BaseRunDir: Direction of the lowest BiDi level in the block, either 'Ltr' or 'Rtl' - Side: Location of caret, either 'Before' or 'After' a nested BiDi run - NestedRun: Information of nested BiDi run(s) at the caret location. - Deep: Whether the caret position in DOM is affiliated to the inner most text node (i.e., 'Deep') or not See https://goo.gl/fV2sSN for more details about test generation. Bug: 822575 Change-Id: I171c17ace0ca38ef051db7a5c6ab14cc870be009 Reviewed-on: https://chromium-review.googlesource.com/965882Reviewed-by: -
Shinya Kawanaka authored
"Mac Builder Goma Canary" builder is failing with "Argument list too long". The length of command line exceeds 220K, so it's actually long. Though libtool on Mac does not support @rsp file, it supports -filelist. So we can pass a file list via a file. -filelist takes a file list separated by a new line, so we can abuse rspfile for this purpose. "solink", "solink_module", and "link" are doing the same thing, so I believe this is acceptable. Bug: 820900 Change-Id: I583d320ac96f959b1a7c3d878a882d17f63cb566 Reviewed-on: https://chromium-review.googlesource.com/964033 Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#543965}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Idefe84c799bbaf82f84da2892339cb3265c219d9 Reviewed-on: https://chromium-review.googlesource.com/966496Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#543964}
-
Hiroki Nakagawa authored
This CL renames functions to match with the coding standard. Bug: n/a Change-Id: Ic6eddf1b16f4415740c238beba10304691be9bc0 Reviewed-on: https://chromium-review.googlesource.com/966161Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#543963}
-
Jason Chase authored
Add a TODO linking to the bug as a reminder, in case the rename makes sense along with other changes. Also updated all the comments in the file to use "allowlist". Bug: 822317 Change-Id: I9ac55077491be776a50cadc723bf3cac41c8ebaf Reviewed-on: https://chromium-review.googlesource.com/964613 Commit-Queue: Jason Chase <chasej@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#543962}
-
Giovanni Ortuño Urquidi authored
Other test suites, e.g. HostedAppTest, need to check the security state of a tab. Change-Id: If6c5314d6878b73898011d18e8c5e18ea51b3a8b Reviewed-on: https://chromium-review.googlesource.com/958946 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#543961}
-
Hwanseung Lee authored
mix-blend-mode[1], object-fit[2], table-layout[3], text-orientation[4] are added to support in whitelist. and test file are also added. [1]https://drafts.fxtf.org/compositing-2/#propdef-mix-blend-mode [2]https://drafts.csswg.org/css-images-4/#propdef-object-fit [3]https://drafts.csswg.org/css-tables-3/#propdef-table-layout [4]https://drafts.csswg.org/css-writing-modes-4/#propdef-text-orientation Bug: 820299 Change-Id: I25a15000053a63e9aa776801e5676bf1adf5e9c5 Reviewed-on: https://chromium-review.googlesource.com/967902Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Cr-Commit-Position: refs/heads/master@{#543960}
-
Darren Shen authored
This patch: - Adds mutation tests for CSSUnitValue.value. - Clean up code style. Bug: 774887 Change-Id: I5a6398c4a4a2ad86f60165780ee8d48bb3d8b0a1 Reviewed-on: https://chromium-review.googlesource.com/954642 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
- 18 Mar, 2018 9 commits
-
-
Darren Shen authored
We're currently using InputMethodManager in the Wayland server to observe changes in the keyboard layout. However, under mash, exo will be in the ash process and InputMethodManager will be in the chrome process, so we cannot depend on InputMethodManager from the Wayland server. We remove the use of InputMethodManager in the Wayland server for observing keyboard changes by using ImeController instead, which uses Mojo for communication. We also add a way of retrieving the current keyboard layout from ImeController. This is a similar design to how ImeController handles caps lock, but it's simpler because we never need to set the layout from ash side. Changes to layout on the chrome side just propagate to the ash side from ImeControllerClient to ImeController. Bug: 772382 Change-Id: I84df1ee1b7e0f54716125fec9d4cd49f3442ed79 Reviewed-on: https://chromium-review.googlesource.com/961505 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#543958}
-
David 'Digit' Turner authored
The process_resources() GN template and the associated process_resources.py script are huge and difficult to understand because they can be used to perform two slightly related different things. In preparation for a future CL that will introduce a new resource compilation mode, this CL tries to clarify the situation by splitting them into two sets of GN template + script: - prepare_resources() + prepare_resources.py, which are used to create .resources.zip archives of raw/uncompiled resources for resource related targets, as well as generating a corresponding R.txt and .srcjar(R.java) file. This corresponds to what process_resources() did when it was called from android_resources() and junit_binary(). Note that this always generates non-final resource IDs, as well as a dummy onResourcesLoaded() method, necessary to compile, but not link, the ResourceRewriter class used to implement the system webview feature. - compile_resources() + compile_resources.py, which are used to compile all resource dependencies of a given binary (e.g. android_apk) into an intermediate .ap_ file. This corresponds to the behaviour of process_resources() when called from android_apk(). This generates final resource IDs by default, unless |shared_resources| or |shared_resources_whitelist| is used. Also, as a simplification, |shared_resources_whitelist| now implies |shared_resources|, except that it restrict the list of non-final resource IDs. - Removed generate_constant_ids, since compile_resources() will always generate constant ids unless shared resources are being used. And prepare_resources() always generates non-constant IDs, as before the CL. + Add documentation for the prepare_resources() and compile_resources() internal GN rules, to make them a little less intimidating. + Removed |app_as_shared_lib|, since even before this CL all resources were generated with package ID 0x7f anyway, or fixed a compile_resources() time. Hence |shared_resources| did the exact same thing. + Improve --help output for prepare_resources.py and compile_resources.py by using option groups for inputs and outputs. R=agrieve@chromium.org,yfriedman@chromium.org,estevenson@chromium.org,trevordixon@chromium.org Bug: 820459 Change-Id: If05ac24a57c4dfa11f9ce43c30ab22e957b2765d Reviewed-on: https://chromium-review.googlesource.com/957095 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#543957}
-
https://skia.googlesource.com/skia.git/+log/38c3d93810d7..a7b84c5a50da $ git log 38c3d9381..a7b84c5a5 --date=short --no-merges --format='%ad %ae %s' 2018-03-18 caryclark fix fiddle example Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I6d94d5c4b4029105372a7af9b9afde2f3343eec3 Reviewed-on: https://chromium-review.googlesource.com/967900Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543956}
-
Justin Novosad authored
The purpose of this change is to prevent the re-occurrence of flaky rendering bugs caused by missing calls to GrContext::resetContext. This change uses a new subclass of GLES2Implementation called GLES2ImplementationWithGrContextSupport, which takes care of calling GrContext::resetContext() whenever the gl state is changed. These calls are lightweight: they just perform an 'or' on an integer. To avoid calling GrContext::resetContext() when gl calls are made from within skia, the bindings were modified in CreateGLES2InterfaceBindings in order to signal the GLES2ImplementationWithGrContextSupport so that it knows the the current GL call is made from skia. Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I59470a8188df235a36d6de0e9aaff57b69ff9d6a Bug: 807974, 810159 Reviewed-on: https://chromium-review.googlesource.com/924616 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543955}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=stevenjb@chromium.org Change-Id: I23c215ddf53e773d05ef31b5d87ea6687bb59f5d Reviewed-on: https://chromium-review.googlesource.com/967884Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#543954}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I808a20a4eebf9c5e1089050f7711b1f1de304ccb Reviewed-on: https://chromium-review.googlesource.com/967883Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543953}
-
yiyix authored
As the Finch trial for draw occlusion has successfully completed, remove all metrics that added for collecting user data, including Display.Draw.Quads.Resized, Display.Draw.Quads.Skipped, Display.Draw.Quads.Smaller, Display.Draw.Quads.With.Complex.Transform, Display.Draw.Quads.With.Complex.Transform.Area. Bug: 672929 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I792cec955827a04e9a39968beb685f121b0669db Reviewed-on: https://chromium-review.googlesource.com/967061Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#543952}
-
Weiliang Chen authored
LayerImpl has IsActive function to check if layer is on active tree. Use that function instead of the PictureLayerImpl's GetTree function. R=danakj Bug: 822873 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I169e9ccbca359cc56cb48a7b3587d8bd2f5b753c Reviewed-on: https://chromium-review.googlesource.com/967268 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ie07ed3765cd857e540f6427f70c9b7153b318f9b Reviewed-on: https://chromium-review.googlesource.com/967880Reviewed-by:
-
- 17 Mar, 2018 14 commits
-
-
David Reveman authored
We should not be generating keyboard press events when a key is already pressed. Fix this issue by restoring the "pressed keys" set in the Keyboard class. Seat is still tracking pressed keys in order to ensure that accelerator key presses are not lost. Bug: 820641 Test: exo_unittests --gtest_filter=KeyboardTest.OnKeyboardKey Change-Id: I56c7110361c0894f3fd8d882c45c1d2bfe3d634f Reviewed-on: https://chromium-review.googlesource.com/967727 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#543949}
-
Jay Civelli authored
Now that it uses a Mojo service, SafeMediaMetadataParser can be simplified as it does not require thread hops. Which also means it does not need to be ref counted anymore. Also changed Bind calls to BindOnce where appropriate. Bug: 822922 Change-Id: Id684d9e7bb52f11f19d992f0d5dcb80c8d7e4770 Reviewed-on: https://chromium-review.googlesource.com/967364 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543948}
-
Weiliang Chen authored
This function is only called on tests, and it goes to effect tree to get correct information. Remove this from LayerImpl. R=danakj Bug: 822873 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I21e13b32de44a5a5c50fbdc5029f2fe620a17e09 Reviewed-on: https://chromium-review.googlesource.com/967089Reviewed-by:
-
Findit authored
This reverts commit 33cfbf08. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 543944 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMzY2ZiZjA4ODFlYmU3ZWQyMGRhNmU2ZjU2M2M3YjQ1YTkzNDRhNDMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4761 Sample Failed Step: compile Original change's description: > Add Chrome OS Account Manager > > - Loads Login Scoped Tokens (LSTs) from disk to memory > - Persists updates to LSTs to disk > > Design doc is linked in the bug id. > This CL creates the core of Account Manager and its ability to load > and persist its state. > Follow up CLs will: > - Link it with OAuth2TokenService via an OAuth2TokenServiceDelegate. > - Add UI components to modify Account Manager's state. > > Bug: 820046 > Change-Id: I1b43e11cfc7ed3592daf4a79ff664d377644f6a8 > Test: chromeos_unittests --gtest_filter="*AccountManager*" > Reviewed-on: https://chromium-review.googlesource.com/955523 > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543944} Change-Id: Idd138c68b9de07ed160651c3a948aceb8fb5d92e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820046 Reviewed-on: https://chromium-review.googlesource.com/967467 Cr-Commit-Position: refs/heads/master@{#543946}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd20cd72..6887bb98 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2fddf6ffe24f6f49f58a7744828924e485ba7e32 Reviewed-on: https://chromium-review.googlesource.com/967730Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543945}
-
Kush Sinha authored
- Loads Login Scoped Tokens (LSTs) from disk to memory - Persists updates to LSTs to disk Design doc is linked in the bug id. This CL creates the core of Account Manager and its ability to load and persist its state. Follow up CLs will: - Link it with OAuth2TokenService via an OAuth2TokenServiceDelegate. - Add UI components to modify Account Manager's state. Bug: 820046 Change-Id: I1b43e11cfc7ed3592daf4a79ff664d377644f6a8 Test: chromeos_unittests --gtest_filter="*AccountManager*" Reviewed-on: https://chromium-review.googlesource.com/955523 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543944}
-
Daniel Cheng authored
Bug: 822832 Change-Id: If46f840560b99b9dbc5c10ae7656df51c3083d1b Reviewed-on: https://chromium-review.googlesource.com/967013 Commit-Queue: Ojan Vafai <ojan@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543943}
-
Julien Isorce authored
This reverts commit ed312194. Reason for revert: It should have been "gpu_info.gl_vendor" instead of "gpu_info.driver_vendor" Original change's description: > Skip GpuOESEGLImageTest on ATI proprietary driver > > Detect the GL_VENDOR string from the default GL implementation. > If it is the ATI proprietary driver then do not switch to EGL/GLES2 > as there is a known bug and this driver crashes in eglInitialize > instead of failing properly. > > BUG=822716 > > Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I00b883012c31867f938bf3f68440058738bb312b > Reviewed-on: https://chromium-review.googlesource.com/966662 > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543735} TBR=kbr@chromium.org,cwallez@chromium.org,piman@chromium.org,julien.isorce@chromium.org Change-Id: I88454724ed1a39688f18278404ea28d978b1331d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822716 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/967821Reviewed-by:
Julien Isorce <julien.isorce@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#543942}
-
https://skia.googlesource.com/skia.git/+log/876dd31483bc..38c3d93810d7 $ git log 876dd3148..38c3d9381 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 egdaniel Don't emit empty command buffers in vulkan Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ia7a76ca236ddd37faa89a6ffdb6646f35a86a85d Reviewed-on: https://chromium-review.googlesource.com/967726 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=alemate@chromium.org Change-Id: I38aeda14a35b2f61590a0bc4ef940d89e60dcfb1 Reviewed-on: https://chromium-review.googlesource.com/967728 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
-
Daniel Bratell authored
There is a common helper method IsTouchOptimized() that is a shortening of ui::MaterialDesignController::IsTouchOptimizedUiEnabled(). That helper method is placed in anonymous namespaces which are merged in jumbo builds, causing clashes. Alternatives are to find a shared location for this method (maybe in //ui?) or inline it. This patch inlines it. Bug: 803406 Change-Id: Ia389432bfdb506d27b625c916a9baf73b7b70f30 Reviewed-on: https://chromium-review.googlesource.com/966204Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#543939}
-
Daniel Bratell authored
There are two different kTextContexts in chrome/browser/ui, living in different namespaces that in jumbo builds become the same namespace. This patch renames them so that they have unique names. This affects Opera builds but not Chrome builds yet since jumbo is not yet supported in chrome/browser/ui in Chrome. Bug: 803406 Change-Id: I3354881b9dedae9499356800cbaed4de3cc0da4c Reviewed-on: https://chromium-review.googlesource.com/966202Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 90fd0807. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13931 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=qyearsley No-Export: true Change-Id: Ia4bbca97799972b46cc9f468d6471b711642f216 Reviewed-on: https://chromium-review.googlesource.com/967725 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#543937}
-
Harald Alvestrand authored
This test would hang if anything ever went wrong, because failures were not being checked. Rewrote the test to always use failure callbacks. Also switched to using rtcp-mux. Tested by 120 runs on workstation. Bug: chromium:452623 Change-Id: Ie73c32edf22b4ca40e9f5e01b9e9fe5cc054623f Reviewed-on: https://chromium-review.googlesource.com/967761 Commit-Queue: Harald Alvestrand <hta@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#543936}
-
