- 02 Jul, 2018 40 commits
-
-
Andrey Kraynov authored
Looks like it is possible to move some includes to *.cc files with forwards, and even remove some unused ones. This can simplify compilers's work, for example touching script_function.h header leads to recompiling 4K targets without jumbo builds. No behavior changes. Bug: 242216 Change-Id: Id7aacfa32400fdb150acced4603f591b24db9361 Reviewed-on: https://chromium-review.googlesource.com/1120176 Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#571843}
-
Oscar Johansson authored
When building using jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variable kVlogSetCookies in net/cookies/canonical_cookie.cc and net/cookies/cookie_monster.cc. This commit solves the issue by moving the variable definition to net/cookies/cookie_util.h. Other kVlog variables defined in net/cookies/cookie_monster.cc are also moved. Bug: 772146 Change-Id: I850c27406f687dfffcf682b0957a41ecbeaca291 Reviewed-on: https://chromium-review.googlesource.com/1118382Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571842}
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I5974bf3d0576e383f1a1ae0b1163aed94ca88445 Reviewed-on: https://chromium-review.googlesource.com/1119906Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#571841}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9c58f741..3664662e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ibdc4cf9cd7a3a8775ab3dc84c5ebe0dcfacc756d Reviewed-on: https://chromium-review.googlesource.com/1121968Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571840}
-
Kenichi Ishibashi authored
We found that these histograms are not very useful. We would like to remove them because when S13nServiceWorker is enabled these histograms are not recorded for subresource requests, which may be a bit confusing. Bug: 852670 Change-Id: I6a6b036e239cc8d8b5e3475ab325937e9e05cc7f Reviewed-on: https://chromium-review.googlesource.com/1117731 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#571839}
-
Taylor Brandstetter authored
Since I'm leaving Google. NOTRY=True Bug: None Change-Id: I4c9d75d20e0168d16b064c661f8f15e9c510a592 Reviewed-on: https://chromium-review.googlesource.com/1121355Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#571838}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: I5275e611d2888dfd608b5770383be0e6453e986a Reviewed-on: https://chromium-review.googlesource.com/1118401Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#571837}
-
Yi Su authored
Initial version of text size accessibility feature use some arbitrary scaling numbers for adjusting text size. This CL substitutes those with more precise numbers calculated by fonts' point sizes of text categories. Bug: 836962 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id444031cbccfea40c2269792aeef1a3ee8df8670 Reviewed-on: https://chromium-review.googlesource.com/1121236Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#571836}
-
Luciano Pacheco authored
This reverts commit cb8862fc. Reason for revert: Flaky test found by Findit crbug.com/859422 method OnLookupAttemptComplete introduced on this CL is shown on the stacktrace. Original change's description: > Cleanup HostResolver timeout/retry tests. > > Instead of relying on sleeping and the actual clock, use a mock > taskrunner to simulate the passage of time. Makes the test more accurate > and stable, and it also speeds things up significantly (~1.5s->60-70ms). > > Also convert ProcTask to use unique_ptr and WeakPtrs instead of ref > counting to more cleanly cleanup the memory on completion instead of > waiting for unused scheduled retries. > > Change-Id: I22b741d8b29d8eb419d125147ef98eba01c658e4 > Reviewed-on: https://chromium-review.googlesource.com/1108078 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Commit-Queue: Eric Orth <ericorth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570840} TBR=isherman@chromium.org,rkaplow@chromium.org,mmenke@chromium.org,xunjieli@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I788443bc57d8eb9ece8cd572ef0b0e49f48ef793 Reviewed-on: https://chromium-review.googlesource.com/1121977Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#571835}
-
tzik authored
This CL replaces MockTimer with MockOneShotTimer or MockRepeatingTimer as a preparation of OnceCallback support of base::Timer. Bug: 850247 Change-Id: Ibe313bbf292c269b67782c169af173859c353db7 Reviewed-on: https://chromium-review.googlesource.com/1111482Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#571834}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=derat@google.com Change-Id: Iaaf7dc2de7a61e2e87c2d3156275bdfc65f50c3d Reviewed-on: https://chromium-review.googlesource.com/1121903Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#571833}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/34024a7c478c..8451daabb23d git log 34024a7c478c..8451daabb23d --date=short --no-merges --format='%ad %ae %s' 2018-07-02 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@8451daabb23d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I8774a362827fedfa2262d627ed23c2c426a99fb8 Reviewed-on: https://chromium-review.googlesource.com/1121877Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571832}
-
Kent Tamura authored
This is a preparation to add a UseCounter in Node::parentNode(). Bug: 859391 Change-Id: I056f60207e000b6f9b1acd6e412444f96a8daee2 Reviewed-on: https://chromium-review.googlesource.com/1121944Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#571831}
-
junweifu authored
Original CL got reverted because the Vision.Framework isn't loaded in services unit tests. This is a reland of 4db64ed1 Original change's description: > ShapeDetection: Start the minimum implementation of mojom::BarcodeDetection > > The new implementation is based on Mac OS Vision Framework[1] which recognizes > more barcode symbologies, then use the @available(macOS 10.13, *) in the barcode > detection provider to choose different implementation. > > Split original large CL[2] up in smaller subpatches including this CL. > > [1] https://developer.apple.com/documentation/vision > [2] https://chromium-review.googlesource.com/c/chromium/src/+/1088466 > > BUG=848182 > > Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng > Change-Id: I5cb8634240a35e52b3c0b696c1ccab9c24cd023e > Reviewed-on: https://chromium-review.googlesource.com/1107493 > Commit-Queue: Junwei Fu <junwei.fu@intel.com> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570336} Bug: 848182 Change-Id: I143f1c2b1977690d50aa4bf4b31d5eda1cb92ece Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1116258Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#571830}
-
Alexei Filippov authored
It should reduce overhead of performance recordings. BUG=849887 Change-Id: Ia3196c7c3a37273b720b82897d04f142868fddea Reviewed-on: https://chromium-review.googlesource.com/1087639 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571829}
-
Kenichi Ishibashi authored
Before this CL we didn't record EventDispatchingDelay_FETCH_SUB_RESOURCE when S13nServiceWorker is enabled because sub resource loading doesn't go browser process. Record the metric in ServiceWorkerSubresourceLoader. Bug: 852668 Change-Id: I3e7b2e833dda9d73f5b09917018e69275f29910c Reviewed-on: https://chromium-review.googlesource.com/1113157 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
tzik authored
EQT (Estimated Queueing Time) used to ignore tasks in a nested loop, that doesn't work well with Cooperative Scheduling, as it runs nested loops extensively. This CL updates the calculation logic to count nested loops and nested tasks into EQT. A nested loop splits the enclosing task to two, and the inner task execution is counted as if it's a toplevel task. The idle time of the nested loop is considered as idle as well for EQT calculation. Change-Id: Ib5397ca19c056d8e96c643c1c0d52be109e95194 Reviewed-on: https://chromium-review.googlesource.com/1075919Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#571827}
-
Luciano Pacheco authored
Test has been flaky on different builders. Tbr: alexmos@chromium.org Bug: 859315 Change-Id: Ie8f9c7238a5421baf3d28b075f1079d05fe8d5b4 Reviewed-on: https://chromium-review.googlesource.com/1121998Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/20868003..9c58f741 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib0b2e0b27d7e1cb2c6786ceb61b0b66d9ba95503 Reviewed-on: https://chromium-review.googlesource.com/1121963Reviewed-by:
-
Luciano Pacheco authored
ContextualSuggestionsTest#testScrollPageToTrigger test has been flaky. Tbr: twellington@chromium.org Bug: 859292 Change-Id: I3b6cc237c1771edeff12bbe19c1a85cd8797ef38 Reviewed-on: https://chromium-review.googlesource.com/1121997Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ibb2a660d292018527cb2aafe63af1f06b83c8b80 Reviewed-on: https://chromium-review.googlesource.com/1121965 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571823}
-
Darren Shen authored
Currently when no display is touchable, we show the virtual keyboard on the primary display. According to https://crbug.com/297858, this was just a basic heuristic to get it working. As mentioned in https://crbug.com/303429#c5, forcing the user to change their primary display all the time is not very user friendly. We change this so that when no display is touchable, we show the keyboard on the focused window (if any). Bug: 856613 Change-Id: I4e0524747c54e471607b2b546a3ef663ad215b55 Reviewed-on: https://chromium-review.googlesource.com/1118060 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#571822}
-
Stuart Langley authored
Prints either the team drive id or "default corpus" when logging message from change list loader in the chrome://drive-internals logs. Bug: 849813 Change-Id: I7463d99308f6c9ee30ce27f7e89641a0cf7b9526 Reviewed-on: https://chromium-review.googlesource.com/1121675Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#571821}
-
Stuart Langley authored
Command Run: $ /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \ -clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \ -checks=-*,modernize-use-nullptr,modernize-raw-string-literal,modernize-make-unique \ -header-filter= \ -fix chrome/browser/chromeos/drive $ git cl format There are no logic changes. Bug: 841659 Change-Id: I6d2e7e6e31a53fb662586b823e9084fc1009a82a Reviewed-on: https://chromium-review.googlesource.com/1121674Reviewed-by:
-
Matt Falkenhagen authored
It also fails on non-Debug and crashes. Bug: 814889 Change-Id: Ie6f68ec4eeb89df638478c0b2da3b0dc8273d6ee TBR: altimin@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1121950Reviewed-by:
-
Luciano Pacheco authored
The following tests have been failing on TSan builder: ImageWriterWriteFromUrlOperationTest.SelectTargetWithExtension ImageWriterWriteFromUrlOperationTest.SelectTargetWithoutExtension Tbr: rdevlin.cronin@chromium.org Bug: 859317 Change-Id: Ic75ece0e4cb2121220f490a24850da866d721f9c Reviewed-on: https://chromium-review.googlesource.com/1121996Reviewed-by:
-
Matt Falkenhagen authored
Bug: 789577 Change-Id: I9f9424b5fcb51e2a00e5aa528ade35737fd335b7 Reviewed-on: https://chromium-review.googlesource.com/1121940Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#571817}
-
Darren Shen authored
No changes were made to the test. Last time, it was broken on chromeos MSAN. I ran the MSAN try bots several times and they all pass, so I assume that the problem has been fixed. Will revert if this is still broken. TBR=rdevlin.cronin@chromium.org Bug: 515596 Change-Id: Icfdf04efa9650848d532bb105a33bad9b55cbe1a Reviewed-on: https://chromium-review.googlesource.com/1113704 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
Noel Gordon authored
Recover the test coverage mentioned in crrev.com/568798. Add new tests for Downloads and Drive to open a file in Gallery, and then once it is shown, open another file in the open Gallery window. Bug: 837551 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iae20fd22340c43a99902da4c21966c918febfb80 Reviewed-on: https://chromium-review.googlesource.com/1120446Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#571815}
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variables kMaxSegmentsSize in: net/third_party/quic/core/congestion_control/bbr_sender.cc net/third_party/quic/core/congestion_control/prr_sender.cc This commit solves the issue by moving the constant to net/third_party/quic/core/quic_constants.h. Bug: 772146 Change-Id: I07da21c2bc8c96f6ed5cc83e2724ae948d80a9be Reviewed-on: https://chromium-review.googlesource.com/1119689 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#571814}
-
Matt Falkenhagen authored
Bug: 857005 Change-Id: Ib94a898048dfaa68dfc68cbaafd181980432df9a Reviewed-on: https://chromium-review.googlesource.com/1119740Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Changed generate_policy_source.py to also parse the "required" field of dictionary policies and also changes schema.cc to check that all required properties are included in the policy. Bug: 850009 Change-Id: I466236a9439383b3e0a330f277eebc50d72305be Reviewed-on: https://chromium-review.googlesource.com/1090521Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#571812}
-
Kent Tamura authored
Bug: 637639 Change-Id: I2381fef29364924ca5d615ecf61222472c657d50 Reviewed-on: https://chromium-review.googlesource.com/1119947 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#571811}
-
Sasha Morrissey authored
Fixed a regression where context menus for Team Drive roots were no longer displaying. Also added test support for Team Drives and a test for a Team Drive root with default capabilities. Bug: 996832 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I70b384c79572803555626fd8af035ec883a00a5c Reviewed-on: https://chromium-review.googlesource.com/1117719 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#571810}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I1a07ccfa66caa3431525494addb2851d546046b9 Reviewed-on: https://chromium-review.googlesource.com/1121898Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#571809}
-
Hitoshi Yoshida authored
Before this CL, we took "partial interface mixin" a syntax error, but Web IDL spec now accepts it to extend interface mixins. This CL updates parser to accept it, and merges InterfaceMixin class into Interface class. Bug: 781257 Change-Id: I2b8584d5a1d4b8d2ffd53ba6a80c39e19feae11e Reviewed-on: https://chromium-review.googlesource.com/1119744Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#571808}
-
Koji Ishii authored
When a line box is [certain zero-height line boxes], most of line layout algorithm is not necessary and that we have a fast code-path for that case. However, there are some edge cases where we still need to create box fragments such as when the line has a containing block for out-of-flow objects. This patch runs the normal line layout algorithm even when the line box is "empty". We could detect when the algorithm is really needed, and/or run only necessary part of the algoirithm for the performance in future. [certain zero-height line boxes]: https://drafts.csswg.org/css2/visuren.html#phantom-line-box Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4d7c6a6b2a3155f1eb5c5ae2f17b78b89bfb833a Reviewed-on: https://chromium-review.googlesource.com/1121656 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#571807}
-
Luciano Pacheco authored
Test has been flaky on Win builders. Tbr: eroman@chromium.org Bug: 859387 Change-Id: I57bdda3903c30e06f05fe89d367f94429bb4e31a Reviewed-on: https://chromium-review.googlesource.com/1121917Reviewed-by:
-
Sasha Morrissey authored
Check for canCopy, canDelete and canAddChildren when cut, copy and pasting files into the Files App directory tree. This also adds support for drag-drop operations into the tree. Test: browser_test --gtest-filter="ContextMenu/FilesApp*" Bug: 719959 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1aa81f0a80be083c156fed9074a7c6031433bf5e Reviewed-on: https://chromium-review.googlesource.com/1104058 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
This test has been mostly crashing on builder Mac10.13 Tests (dbg) since its initial commit, so disabling it for now. Tbr: pfeldman@chromium.org Bug: 859382 Change-Id: Ie7ca15e76466ebadb879e26cf40dc2cd11561b65 Reviewed-on: https://chromium-review.googlesource.com/1121916Reviewed-by:
-
