GitLab

If ActiveTab permission is granted to an extension through a means other than
ActiveScriptController, have ActiveScriptController run any pending tasks for
that extension.

BUG=362353

Review URL: https://codereview.chromium.org/296483011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272413 0039d316-1c4b-4281-b951-d872f2087c98

Whitelisting an extension per: crbug.com/374955

BUG=374955
TEST=None
R=miket@chromium.org

Review URL: https://codereview.chromium.org/293813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272412 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Fix and re-enable some browser focus interactive ui tests. (https://codereview.chromium.org/296523002/)

Reason for revert:
Tests failing on WinXP waterfall bot:

2 tests timed out:
    BrowserFocusTest.FocusTraversal
    BrowserFocusTest.FocusTraversalOnInterstitial

Starting

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31296

Original issue's description:
> Fix and re-enable some browser focus interactive ui tests.
> 
> Fix FocusTraversal[OnInterstitial] except *OnInterstitial on Mac :(
> Fix InterstitialFocus and FindFocusTest.
> 
> Add a TestFocusTraversal helper function consolidated from tests.
> Simplify TestInterstitialPage and add a WaitForInterstitial helper.
> Move test server init to a common SetUpOnMainThread.
> Remove unnecessary helpers and includes.
> 
> TODO(followup): Fix more tests!
> TODO(followup): s/DisableFindBarAnimationsDuringTesting/ScopedAnimationDurationScaleMode/?
> 
> BUG=60973,62544,67301,81451,109770,163931
> TEST=Automated tests work and stay enabled...
> R=sky@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272259

TBR=sky@chromium.org,msw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=60973,62544,67301,81451,109770,163931

Review URL: https://codereview.chromium.org/299703018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272410 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272392 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272390 0039d316-1c4b-4281-b951-d872f2087c98

Updates the view manager sample app too.\

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/292813008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272389 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375416

Review URL: https://codereview.chromium.org/293983019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272388 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365762,374995

Review URL: https://codereview.chromium.org/296053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272387 0039d316-1c4b-4281-b951-d872f2087c98

This benchmark runs the one pointed by webkit.org/perf/DoYouEvenBench/

BUG=365446
NOTRY=true

Review URL: https://codereview.chromium.org/296213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272386 0039d316-1c4b-4281-b951-d872f2087c98

This removes some NOTREACHED()s in the base class which may be
reached when bad data comes along.  Merely tally such so that it
can be checked in the cases where we know it's "impossible".

We also need to be more lenient about the results of reading
from pipes.

BUG=376173

Review URL: https://codereview.chromium.org/297833007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272385 0039d316-1c4b-4281-b951-d872f2087c98

This will make the test pass for now on the bots and prevent further
regressions from the current state.

BUG=chromium:373094, chromium:375554, chromium:375556, chrome-os-partner:29017, chrome-os-partner:28982
TEST=Ran locally on link, alex, nyan_big.
NOTRY=true

Review URL: https://codereview.chromium.org/296773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272384 0039d316-1c4b-4281-b951-d872f2087c98

The GCM service will now be started when there is a consumer. It will be
automatically stopped when all consumers are gone. This does not change
the existing behavior that the GCM is always started for the signed-in
profile since invalidation consumes it.

BUG=356716
TEST=tests updated and new tests added
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/296053011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272380 0039d316-1c4b-4281-b951-d872f2087c98

Reason: build failure on Mac ASan 64

> Add UMA Counts for number of IPv4 and IPv6 interfaces detected for PeerConnection.
> 
> R=sergeyu@chromium.org
> BUG=N/A
> 
> Review URL: https://codereview.chromium.org/299103002

TBR=mallinath@chromium.org

Review URL: https://codereview.chromium.org/299843008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272379 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373842

Review URL: https://codereview.chromium.org/291603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272378 0039d316-1c4b-4281-b951-d872f2087c98

BUG=170921
TEST=everything still works

Review URL: https://codereview.chromium.org/81243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272377 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372617

Review URL: https://codereview.chromium.org/296983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272376 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375401
TEST=none
TBR=gbillock

Review URL: https://codereview.chromium.org/296113012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272375 0039d316-1c4b-4281-b951-d872f2087c98

R=sergeyu@chromium.org
BUG=N/A

Review URL: https://codereview.chromium.org/299103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272371 0039d316-1c4b-4281-b951-d872f2087c98

Now the multi-profile feature is turned on by default.
Files.app also always mounts per-profile separated "Downloads"
folder even in the test environment.

BUG=375131

Review URL: https://codereview.chromium.org/295943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272370 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/292353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272369 0039d316-1c4b-4281-b951-d872f2087c98

On platforms which have an overlay scrollbar (namely Mac) the toolbar in OOP PDF appears to be too low to the bottom and right of the screen. This adds a minimum offset for the toolbar.

BUG=303491

Review URL: https://codereview.chromium.org/293613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272367 0039d316-1c4b-4281-b951-d872f2087c98

The chrome.identity.getAuthToken API now uses a totally separate dialog for displaying its permissions, so the ExtensionInstallDialog implementation can be deleted.

BUG=304836

Review URL: https://codereview.chromium.org/290733006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272365 0039d316-1c4b-4281-b951-d872f2087c98

This bash is moderately archaic (version 3), and various tools (e.g. tput) are
missing.

This also modifies the ouput of the script so that in verbose mode, as it runs,
each filename is trimmed to fit on one line, including the throbber, then
replaced by the full filename when printing the final file status.  This makes
for a cleaner output spew with long filenames in particular.

BUG=none
TEST=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/291153007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272364 0039d316-1c4b-4281-b951-d872f2087c98

CRYPTO_EXPORT macro has to be before the non-void return type.

BUG=None
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/296223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272363 0039d316-1c4b-4281-b951-d872f2087c98

This enables some already-working targets and adds a missing cpufeatures dep to crypto to make it compile. I added a comment in the cpufeatures build file so I can find it more easily by grepping next time.

R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/291343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272362 0039d316-1c4b-4281-b951-d872f2087c98

TBR=aa@chromium.org

Review URL: https://codereview.chromium.org/294163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272361 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/293033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272360 0039d316-1c4b-4281-b951-d872f2087c98

Instead of a zoom direction and the number of pixels to be covered by the pinch
gesture, the gesture now takes a scale factor as parameter. From that, it
computes how to perform the gesture: the ratio of the final span and the initial
span equals the scale factor (modulo touch slop). The spans must not fall below
a certain threshold, provided by the gesture target (GetMinScalingSpanInDips).

Update the JS interface (chrome.gpuBenchmarking.pinchBy) to reflect the changes.
For (temporary) backwards compatibility, add another method to the interface to
tell Telemetry whether or not the browser supports the new interface. This is to
avoid crashes when Telemetry is run with the current stable version. Will be
removed once the stable version supports the new interface.

Update tough_pinch_zoom_cases page set to make sure all pinch gestures start
within the web content (tested on N4 and N10).

Update synthetic gesture controller unit tests to use the new parameter.

BUG=309484

Review URL: https://codereview.chromium.org/293683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272359 0039d316-1c4b-4281-b951-d872f2087c98

I spent many cycles tweaking these RST tables to no avail.

We shouldn't assume that people will have a site running, so we should de-link these.

BUG=374811

Review URL: https://codereview.chromium.org/297513012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272358 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361083
TEST=manually

Review URL: https://codereview.chromium.org/289693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272357 0039d316-1c4b-4281-b951-d872f2087c98

> Reland Linux Window Control Alignment
> 
> Modifying CustomFrameView to layout window controls based on user configurations. For linux begin observing the configs and changes. For other systems fall back on a default ordering.
> 
> Update tests that were originally missed.
> 
> Original review: https://codereview.chromium.org/240163006/
> Revert review: https://codereview.chromium.org/276173002/
> Revert "Revert of Linux Aura Task Manager Frame Buttons Misaligned (https://codereview.chromium.org/240163006/)"
> 
> This reverts commit 9031ef57.
> 
> TEST=CustomFrameViewTest
> BUG=351917
> 
> Review URL: https://codereview.chromium.org/281353009

TBR=jonross@chromium.org

Review URL: https://codereview.chromium.org/294473016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376549
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/299023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272355 0039d316-1c4b-4281-b951-d872f2087c98

Handling HTERROR WM_SETCURSOR messages apparently causes a regression.
Modals don't pulse, beep, and come foreground when the parent is clicked.
This originally regressed with my http://crrev.com/188817.

BUG=375181
TEST=Clicking a browser with a window-modal dialog causes the dialog to pulse, beep, and the window pair to come foreground.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/284313016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272353 0039d316-1c4b-4281-b951-d872f2087c98

Modifying CustomFrameView to layout window controls based on user configurations. For linux begin observing the configs and changes. For other systems fall back on a default ordering.

Update tests that were originally missed.

Original review: https://codereview.chromium.org/240163006/
Revert review: https://codereview.chromium.org/276173002/
Revert "Revert of Linux Aura Task Manager Frame Buttons Misaligned (https://codereview.chromium.org/240163006/)"

This reverts commit 9031ef57.

TEST=CustomFrameViewTest
BUG=351917

Review URL: https://codereview.chromium.org/281353009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272352 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://codereview.chromium.org/280483002/

BUG=314704

Review URL: https://codereview.chromium.org/295933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272351 0039d316-1c4b-4281-b951-d872f2087c98

In order to move SandboxIPCProcess into a thread, we need a mechanism
to make that thread exit.

BUG=322185
TEST=content_shell loads webpages, browser shuts down correctly.

Review URL: https://codereview.chromium.org/291173009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272350 0039d316-1c4b-4281-b951-d872f2087c98

This flag defaults to true for official builds and false for unofficial builds. If the flag is false, Chromium will connect to sandbox wallet servers.

Net effect: instead of being controller by Chrome vs. Chromium, the default is controlled by Official vs. Unofficial buildtype.

BUG=334088

Review URL: https://codereview.chromium.org/288003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272348 0039d316-1c4b-4281-b951-d872f2087c98

"tools/safely-roll-deps /src blink"
is the replacemnt syntax.  No need to keep dead code around.

BUG=242461

Review URL: https://codereview.chromium.org/291333007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272347 0039d316-1c4b-4281-b951-d872f2087c98

This also adds unittests for ServerLogEntry client code, with common code
pulled out to a separate file.

This doesn't affect LogToServer classes - they will be refactored in a
separate CL. Also fix some IWYU issues uncovered by the refactor.

TEST=unittests

Review URL: https://codereview.chromium.org/282063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272346 0039d316-1c4b-4281-b951-d872f2087c98

1) Use TOOLCHAIN_OS rather than OS for package names
2) gpu_nacl.gyp shouldn't include trusted code test dependencies.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032
R=bbudge@chromium.org, bradnelson@google.com, piman@chromium.org, sievers@chromium.org

Review URL: https://codereview.chromium.org/295933013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272345 0039d316-1c4b-4281-b951-d872f2087c98