- 13 Feb, 2020 40 commits
-
-
Stephen McGruer authored
This reverts commit 8495f49a. Reason for revert: Suspected of causing failure in external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-003v.html on multiple builders, https://crbug.com/1052029 Original change's description: > [Layout] SetNeedsLayout when an flex-item image loads > > Flex layout incorporates an image's intrinsic size even when it has a > specified height and width. > > Bug: 1042329 > Change-Id: I206ba12a07103b4b90c364fb19b70b8ba2784d7a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050821 > Commit-Queue: David Grogan <dgrogan@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#741091} TBR=dgrogan@chromium.org,fs@opera.com Change-Id: I7dbc00b05f9a14b955f5ac9cd89e3aeda1dbba0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042329 Bug: 1052029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054296Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741119}
-
Michael Ludwig authored
Bug: 224618 Change-Id: If7edeef0cc8b7970599388150c6d955171f555ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050665Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#741118}
-
arthursonzogni authored
It used to be a vector of pair (directive_name, source_list) with no duplicated |directive_name|. This is equivalent to a map<directive_name, source_list>. The main reason it wasn't a map was the ContentSecurityPolicy used to be transmitted using the old Chrome IPC system. It is now using mojo. Mojo support map<K,V>. Using a map slightly simplify the logic, there is no more need to loop through the list of directives for instance. std::map::find is used instead. Description of "future" patches relying on this: ------------------------------------------------ [1] https://crbug.com/888079 Browser process (rather than renderer) should calculate the origin to commit. [2] https://crbug.com/1041376 Compute the sandbox policy of a document before loading it. [1], which is blocked by [2]. [2] requires the CSP sandbox directive to be parsed in the network service before loading the document. The sandbox directive doesn't contain a CSPSourceList, but a SandboxFlag. It means we need to store different kind of "Value" for a directive. This can be achieved by declaring: union DirectiveValue { CSPSourceList source_list; SandboxFlag sandbox_flag }; It could potentially be extended for storing "empty" values for UpgradeInsecureRequest or TreatAsPublicAddress. The map<CSPDirectiveName, CSPSource> will become map<CSPDirectiveName, CSPDirectiveValue>. Then we could get access to the Directive value using: - csp->directives[kSandbox].get_sandbox_flag(); - csp->directives[FrameAncestors].get_source_list(); ------------------------------------------------ Bug 1041376 Change-Id: I63979802b15c55452cc8faf13fdeac4c7c29de86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050278 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#741117}
-
Jeffrey Cohen authored
Bug: 1024586 Change-Id: I5f153b14edfe3265cd6724a082494bd8cbf0d4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048847Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741116}
-
Rahul Arakeri authored
This CL fixes an issue where a GSB was getting sent without closing an existing scroll. There were some workarounds in place since a known bug (crbug.com/979408) prevented us from using mouseUpAt. Since that bug is fixed, the API mouseUpAt can now be used to send a GSE. Bug: 979408 Change-Id: I571c714b5612f2190828ad0d0b60f790a832bcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045213Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#741115}
-
Mikel Astiz authored
IsValidIndex() captures the very same preconditions but calling out the validity of the parent in dedicated DCHECKs helps readability and allows understanding user reports better. Bug: 1051614 Change-Id: If10e53fc52b3f6003dba9f9b2bf386ccf75de3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054165 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#741114}
-
Xiyuan Xia authored
- ui::WaitForNextFrameToBePresented take a timeout when waiting for frame presentation and return true/false based on whether a frame is presented during the wait; - ResizeHistogram flush pending draws until no presented frames for 100ms like https://crrev.com/c/2036873 before checking resize histograms; - Consolidate https://crrev.com/c/2036873 to use the new ui::WaitForNextFrameToBePresented; - Update ui::WaitForNextFrameToBePresented call sites to examine the returned value; Bug: 1047657 Change-Id: Ifcfa495c8bcddee5ad14b7c52d0107e6b6ed1099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052463Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#741113}
-
Xiaocheng Hu authored
This patch ensures a non-null CSSParserContext is passed to ConsumeAngle(), so that we can always count usage of min/max/clamp() in <angle> values. Bug: 1047784 Change-Id: I6839b025f09b1efad5c9968e828c3ea9d0574b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053253Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#741112}
-
Dave Tapuska authored
Remove some more typemappings that aren't necessary since gfx types can be used natively in blink. Change-Id: If0e6595f0410b7c696f962f45db4a7d3461a137d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050737 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741111}
-
Jérôme Lebel authored
Adding implementation for -[AddAccountSigninCoordinator interruptWithAction:completion:], and updating SigninCoordinator to call this method when the sign-in should be canceled. Also, when -[AddAccountSigninCoordinator stop] is called, the following instance variable should be nil: - signinCompletion - identityInteractionManager - userSigninCoordinator - alertCoordinator Those variables should set to nil in -[AddAccountSigninCoordinator runCompletionCallbackWithSigninResult:identity:]. Adding [super stop] and [super start] in start and stop methods of AddAccountSigninCoordinator. Bug: 971989 Change-Id: Icdb209a2edab58bd3bc42472534a7f3d4c7b3299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046529 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#741110}
-
Takuto Ikuta authored
subprocess42 is not used by test_runner.py anymore. Bug: 1050466 Change-Id: Ifd064b362d13c778c59cfd3e3d56939f6fe052c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053750Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#741109}
-
Nick Burris authored
Chromium has always had a scroll anchoring suppression trigger when the scroll offset is zero. This suppression trigger was added to the spec in https://github.com/w3c/csswg-drafts/pull/4679. Change-Id: I2f38b23803e610aa04976c43211357e173cecbb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045200 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741108}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97611c9403b4..0fd93555a59a git log 97611c9403b4..0fd93555a59a --date=short --first-parent --format='%ad %ae %s' 2020-02-13 tvanderlippe@chromium.org Migrate node_main/ to import cross-module 2020-02-13 tvanderlippe@chromium.org Migrate layers/ to import cross-module 2020-02-13 tvanderlippe@chromium.org Migrate timeline/ to import cross-module 2020-02-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-02-13 tvanderlippe@chromium.org Migrate cm_modes/ to import cross-module 2020-02-13 aerotwist@chromium.org [e2e] Deprecate e2e script and introduce screenshots script 2020-02-13 tvanderlippe@chromium.org Migrate animation/ to import cross-module 2020-02-13 tvanderlippe@chromium.org Migrate accessibility/ to import cross-module 2020-02-13 tvanderlippe@chromium.org Migrate changes/ to import cross-module 2020-02-13 tvanderlippe@chromium.org Migrate layer_viewer/ to import cross-module 2020-02-13 aerotwist@chromium.org [tests] Migrates and tidies test runner Created with: gclient setdep -r src/third_party/devtools-frontend/src@0fd93555a59a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I345d6bb125826bd98a312ad5148a674669a2bc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053296Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741107}
-
Julie Jeongeun Kim authored
This CL moves DidFailLoadWithError from content's FrameHost to blink's LocalFrameHost and removes DidFailLoad from WebLocalFrameClient. Bug: 1043768 Change-Id: I1daf8ca6992844682c6d68d65813b073fe3202bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016770Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#741106}
-
Matt Menke authored
When kPlzDedicatedWorker was enabled, requests for worker scripts made in cross-origin iframes would incorrectly include same-site cookies. This CL makes those requests use the site-for-cookies of the referring frame instead. If cross-site dedicated workers were supported, more work would be needed to handle them correctly, but it doesn't look like that's the case. Bug: 1046435 Change-Id: I3dd90fd7d46af7f9cee840730a824b053cf137f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040067 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#741105}
-
Marc Treib authored
After https://crrev.com/c/1989750, a few invalidations-related prefs are not used anymore. This CL adds code to clean them up. Bug: 1029481 Change-Id: I56b75b442fed2275d502ba63370e48f006bc9bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050591 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#741104}
-
Tricia Crichton authored
When running headless, calling requestFullscreen causes Chrome to hang. Headless mode will use the standard setBounds call, though it also has some flaws. See https://crbug.com/982071. Bug: 1049336 Change-Id: I092fef6444f2697614224afb723bb5306cb24c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048536Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#741103}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5dcdb89598ea..6df58e2de32f git log 5dcdb89598ea..6df58e2de32f --date=short --first-parent --format='%ad %ae %s' 2020-02-13 matthewb@google.com cros/test: Allow new drm_dp_aux group memberships. 2020-02-13 iby@google.com Update max symbol size to 1GB Created with: gclient setdep -r src/third_party/chromite@6df58e2de32f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I619075147b3be692a661b8b70cbf4e4ce0ca4a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053295Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741102}
-
Steven Bennetts authored
Crash was introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/1930832 Bug: 1047790 Change-Id: I4a603f4db03209e8e770b045ff981298988ccc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052201Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741101}
-
Chris Cunningham authored
The primary purpose of a LearningTask is to describe/configure a LearningTaskController. LearningTaskController's are registered by name, whereas LearningTasks have been registered by enum ID. This CL remedies the asymmetry, making retrieval of Tasks match that of Controllers by using a "name" in both places. Change-Id: Ibc58b42e9c92876134f3da524b0804f3e1d71809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053619 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#741100}
-
Xiaoqian Dai authored
Bug: 1009005b Change-Id: I89a79e12adc0b7c16e4ab219e3bc99f542725a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053145Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#741099}
-
Sean Harrison authored
New cookies subpage was not tagged as no-search, so any search containing any substring of "cookies" would cause settings search to fail. Bug: 1051418 Change-Id: I1d53d4fe8f7b0629b3dfc441412003c06a819af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052144 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#741098}
-
chrome://set-timeJames Cook authored
If the dialog is opened from OS settings, it does not show the timezone. However, the C++ code can sometimes send a timezone update while the dialog is open. Only update the timezone select if it is showing. Always send the current timezone from C++ when the dialog opens, such that we can adjust the time picker appropriately if the timezone changes. Bug: 1015179 Test: added to JS tests Change-Id: I1cd641c377a209c114d4c1359acbce775bf438c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052565Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#741097}
-
Ethan Jimenez authored
1. Refactoring `AXPosition::CreateNextLeafTextPosition` to take an optional input parameter `crossed_line_breaking_object` which will be set to `true` if any call to `CreateNextAnchorBoundary` made while moving to the next leaf anchor crosses a line breaking object. 2. Refactoring `AXRange::GetText` to remove usage of `AtEndOfParagraph`. This optimization comes from analyzing how paragraph boundaries are computed: in order to determine if the end of an anchor is the end of a paragraph, we traverse forward to the next unignored leaf node (if it exists), then go back to the previous non-whitespace unignored leaf node (if it exists) looking for any line breaking object boundary being crossed in our tree traversal. The procedure described above is very redundant if we're already traversing the leaf nodes of the tree to compute `GetText`, this change uses the new parameter in `CreateNextLeafTextPosition` to efficiently compute paragraph boundaries without "going back". Notice that we still need to call `AtStartOfParagraph` from the first non-whitespace leaf node in the range since there could be whitespace or ignored leaf nodes preceding the AXRange's start, but such scenario could only appear once in any given `GetText` call. 3. As a result of the previous changes, `AtEndOfParagraph` disappears completely from the `GetText` call stack, the `AtStartOfParagraph` call has no noticeable impact, and the weight of `GetText` is now entirely reliant on a single traversal over the tree's leaves. Considering the total weight of `CreateNextLeafTextPosition` as a reference of "linear" complexity, in average, computing `GetText` measures 3.41 times faster with the optimization. Bug: 1029867 Change-Id: I4ec070a6f96d9118ded08af4c93eb181451bb387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024910 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#741096}
-
Manu Cornet authored
Instead, call |UpdateLayout| from the widget itself. Bug: 1050788 Change-Id: I42be9e98f56df6c04b3662a832050069b1b689c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053125Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#741095}
-
Manu Cornet authored
Bug: None Change-Id: Ie5ce5db5a2dfb13f96ab370102f9f1f56782d663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049949Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#741094}
-
Sami Kyostila authored
Disable webrtc/pause_play_peerconnections on Windows since it is persistently red. NOTRY=true TBR=johnchen@chromium.org Bug: 1051644 Change-Id: If3f24a9232c10c78992f3fd14bcc82a511925ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054943Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#741093}
-
Gyuyoung Kim authored
This CL migrates the legacy SetPermission IPC message to the new Mojo defined in WebTestClient interface. Mojo doesn't support base::Optional<int>. So, this CL passes a value if it exists. It the value doesn't exist, a minimum integer value is passed instead. Then, the handler function sets the passed value to base::Optional<> again. Bug: 1039247 Change-Id: I75850e1d642812c7e930a38e317b3eccda51e8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045270 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#741092}
-
David Grogan authored
Flex layout incorporates an image's intrinsic size even when it has a specified height and width. Bug: 1042329 Change-Id: I206ba12a07103b4b90c364fb19b70b8ba2784d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050821 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#741091}
-
Tim van der Lippe authored
Ignored for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2054548 TBR=aerotwist@chromium.org Bug: 1006759 Change-Id: I5f6d871795c2b56142c618e54d76a4ff8a533ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054102Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#741090}
-
Roman Sorokin authored
TBR=antrim@chromium.org BUG=none Change-Id: Id2046f7aa2fc275198466e9bd1da03dfcb84536f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053807Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741089}
-
Xianzhu Wang authored
Change-Id: I2fb6037a3bed30a8d1d43c3f997471c695461e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053616Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741088}
-
Tomasz Wiszkowski authored
This change fixes a typo in recorded histogram name. - Android.Omnibox.Suggestion[s]View.CreateTime The metric has been introduced just few days ago so we dont care about losing data yet. Change-Id: I1ec41fd76ca0015fbc07b0df5e1676251a6ae297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052595Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#741087}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2d81e7897a7e..f912eb7116e9 git log 2d81e7897a7e..f912eb7116e9 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 tikuta@chromium.org Revert "Fix getservbyname assumption" Created with: gclient setdep -r src/third_party/catapult@f912eb7116e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1051916,chromium:869557 Tbr: skyostil@google.com Change-Id: I1185ee0c8eff9f6fe2739079821e9d4f5bf9b750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054434Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741086}
-
Robert Sesek authored
This CL also does some general cleanup: - Adds a ScopedHandle type to simplify resource management. - Removes vestigial TransitDescriptor passing, which had test-only users. - Fixes a double-close in AudioInputDeviceTest.CreateStream. Change-Id: I9f7a31baee32336583736c1fbcaa89508a90c127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050889Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#741085}
-
Fredrik Söderquist authored
Bug: 658305 Change-Id: I7ae3cb1534c3e86b33f7c033cb2d22c1b3032e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054107 Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#741084}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/77a5100d9a9a..e82ab75a4ca8 git log 77a5100d9a9a..e82ab75a4ca8 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 julien.isorce@chromium.org Provide default implementation of rx::DisplayEGL Created with: gclient setdep -r src/third_party/angle@e82ab75a4ca8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I389d254f6e871e898167dc39342066806a04470b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054430Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741083}
-
Dong Hwi Lee authored
Change-Id: I58b793e966a226895bf6ef917388a7bcab912be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053165 Commit-Queue: Dong-Hwi Lee <leedh@google.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#741082}
-
Ayu Ishii authored
Bug: 1007669 Change-Id: If7703f00ebfc63b993a564b2519fb8f4ffdd30a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050822Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#741081}
-
Marc Treib authored
After recent cleanups (see crbug.com/1029481), the jingle code isn't used anymore. Bug: 912042 Change-Id: Ia68783f77849d3efd37d43e87a390e464c56714f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052143 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#741080}
-