GitLab

This reverts commit b886f7f1.

Reason for revert: The enum values are not in sync with the error codes
in update engine code. The update engine team wants to first correct
the enum before adding more values to it.
This change needs to be re-landed after the enum is corrected by the update engine team with correct enum value.

Original change's description:
> Add enum value for error update download canceled per policy
>
> This CL adds error code for update download canceled due to
> DeviceAutoUpdateTimeRestrictions policy to the
> enum so that it can be reflected in the histogram. This error code is
> already added in update engine code in the following CL -
> https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2567121
>
> Bug: chromium:1117450
> Change-Id: I69d109553c28a4948d725183293640d8eb044731
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584984
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Commit-Queue: Saurabh Nijhara <snijhara@google.com>
> Cr-Commit-Position: refs/heads/master@{#836042}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:1117450
Change-Id: I8bf8eb277af123d8a220a1ea1bf488df059c2eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587729Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Cr-Commit-Position: refs/heads/master@{#836706}

Previously disabling word highlighting caused focus ring to highlight individual nodes instead of paragraphs, which caused the navigation control panel to bounce around too quickly.

Bug: 1157941
Change-Id: I3f73ac13f8595df9ceb5c205e1fb0c1041654931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587489Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Joel Riley <joelriley@google.com>
Cr-Commit-Position: refs/heads/master@{#836705}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/bd6d8e4204b5..a3edbfa983ba

2020-12-14 wl@gnu.org [type42] Pacify static analysis tools (#59682).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: I0aa14a64c054fe60cd58df829b868aa36033c990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589285Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836704}

R=gbeaty

Change-Id: Ic567bb94e9505b5e5b3f5f6c7908652fc00da20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589318
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836703}

Change-Id: Ifeb9bef8dae18092e105085b1497859bd67865c9
Bug: 1084332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589042Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836702}

* Replace base::PostTask*() calls with calling PostTask*() methods
  directly on TaskRunners.

* Use PostTaskAndReplyWithResult() instead of equivalent implementation
  based on PostTaskAndReply().

* Add comment clarifying that IndexedDBContextImpl::IDBTaskRunner() is a
  thread-safe getter.

* Fix incorrect mapping of failure (success = false) to
  blink::mojom::QuotaStatusCode::kOk in DidDeletedIDBData().

The last improvement may result in elevated error rates while attempting
to delete IndexedDB data. This is because this CL correctly propagates
reported errors in a situation where they were ignored before.

Bug: 1016065
Change-Id: Ibde1154fb1c42dc412a40c0ccbcd3cb6b8e3f627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588448
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836701}

Promoting a quad using the fullscreen overlay strategy results in a
segfault when using SkiaRenderer. This is because for fullscreen
overlays, we remove the frame's OutputSurfaceOverlayPlane [1]. In
turn, this means we call SchedulePrimaryPlane with a null frame which
sets a flag [2] that prevents |current_image_| from being cleared
later in PostSubBuffer [3].

On the next frame, there is no damage on the primary plane because
the entire contents have been promoted to a fullscreen overlay. Thus,
we never render the root render pass [4] which results in
|SkiaOutputDeviceBufferQueue::current_image_| never being set [5].
Since we never set a new |current_image_| and |current_image_| wasn't
cleared as mentioned in the first paragraph, we end up re-using the
|current_image_| from the last frame. This is where we get our
segfault because various |current_image_| members are reset after
their first use [6].

This CL fixes this issue by explicitly clearing |current_image_| (and
adding it back to the |available_images_| queue) if the output surface
plane is null. This makes sense because we shouldn't be presenting an
image anyways since the primary plane is empty.

[1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/overlay_processor_using_strategy.cc;l=232;drc=c6b95e6511da9afc58debb10a67fceb6b230341a
[2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=218;drc=58ff9e17fba96d56e68842b570b37d88a70d7f73
[3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=332;drc=c6b95e6511da9afc58debb10a67fceb6b230341a
[4] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/direct_renderer.cc;l=383;drc=0348a1421914f3609d287cb5645a856f5eb2542c
[5] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=506;drc=619ddf10544160ce22caec007a31873b2e28f691
[6] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/output_presenter.cc;l=103;drc=b621c956cfd2712c38f05b2240b0a5780066a07c

Bug: 1156158
Change-Id: I2f030652166212cf6e28073c660e07526e67dcce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585811Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Brian Ho <hob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836700}

In practice, this doesn't happen at all and cannot happen at all after
the incognito CL goes in

Change-Id: I0daf1c4cbb189840913ee4a368dda437e07efaca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587396
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836699}

Steps with junit_tests and resultdb ran successfully 3368 times,
but one failed. The failure was from the test itself.

https://screenshot.googleplex.com/AmZp5peQzJrzz3c
https://ci.chromium.org/p/chromium/builders/ci/Android%20arm%20Builder%20(dbg)/53534

R=gbeaty@chromium.org
CC=chanli@chromium.org,nodir@chromium.org

Bug: 1084332
Change-Id: I416787631a029491b758be2b5df17a4ffb59b41e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589640Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836698}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b46e4dd997f0..928ad2740611

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC atotic@google.com,ftirelo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: atotic@google.com,ftirelo@google.com
Change-Id: I2d178f89c423ff032b077777f1bed218f5cdd773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589665Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836697}

Previous: https://screenshot.googleplex.com/9kgVDiHMWknAeAN
Now: https://screenshot.googleplex.com/3nRzSdcki58YoQU

Bug: 1148843
Change-Id: If1c2bef46754f15496e4c9247fba9ff8e46cd17e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584564
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836696}

Possibly due to a bug on the version of M the tablet runs on (older than
the M phones we test on), or possibly due to the tablets being extremely
slow, this test times out on those devices.

This is extremely difficult to diagnose without access to a Nexus 7, and
not worth pursuing right now, so I'm disabling the test for that
configuration.

Bug: 1153686
Change-Id: I4e386f97b7052ebf0efc8c19f2683e21f73caafd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588646Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836695}

Bug: 688063
Change-Id: Ibf48e4ffe33ecf24aea08188b7579eab1de0e47b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586012
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836694}

This namespace will be necessary when (some of) the code is
componentized, and is isolated into a separate CL to minimize the size
of the future code relocation change.

Bug: 1147274
Change-Id: I2b3f2de04c9169b767c9abb7b1e9385e60bffe8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581032
Auto-Submit: Evan Stade <estade@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836693}

Adds sandbox mitigation flag to disable CET.

As these currently crash in v8 we apply this for renderer processes.

For the default build this will have no effect as CET is not yet
enabled for any binaries. However, for builds with
`enable_cet_shadow_stack = true` or where users have configured CET by
setting an appropriate `Image File Execution Option` in the registry
it should be possible to run Chrome on CET capable hardware.

A sandbox integration test is added which checks this policy works. On
hardware without CET support the test exits early.

Both browser_tests and content_browser_tests pass at least the same set
of tests that pass with CET disabled on test hardware. Manual tests
confirm chrome works with and without cetcompat, and with and without
IFEO to force strict checks.

Bug: 1131225
Change-Id: Icaf8d3f039c924e937973b6c01239c1635d43790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542726
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836692}

TBR=arbesser@chromium.org

Bug: 1158435
Change-Id: I3a1a17be1b5657cb85804db21bb77c089e536205
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588298Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836691}

Now that ExpandablePaymentHandler has been launched, this CL is to
remove the support of CCT PaymentHandler UI (PaymentHandlerActivity)
should be removed.

The names of the removed elements:
* PaymentHandlerActivity
* CustomTabsUiType.PAYMENT_REQUEST
* addPaymentRequestUIExtras
* isForPaymentRequest
* payments_handler_window_minimum_height

Bug: 1157896, 1085001
Change-Id: Icc78167a58d1b21261352c7f1a94d1f8f0ce2bf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585642
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836690}

The histogram has been expired. Cleanup the dead code.

BUG=1061971

Change-Id: I2bd0a6096b464261e0bf60c50dfea28b172002a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587374Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836689}

CVC Unmask Dialog:
Light mode: https://screenshot.googleplex.com/7V2eZSLwhQyMEwa
Dark mode:  https://screenshot.googleplex.com/3oPqiHUtd6hJueF

Autofill Suggestion:
Light mode: https://screenshot.googleplex.com/5NmaJyRkGKSediS
Dark mode:  https://screenshot.googleplex.com/AeKMk3r5ETbaiPw

Upstream Save Dialog:
Light mode: https://screenshot.googleplex.com/3hC25sp8ckmTwVz
Dark mode:  https://screenshot.googleplex.com/A4g4qREkFEPn99A

Bug: 1124968
Change-Id: I43985d7fc3fe5790713a93e8acf70a25c0d34b57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587581Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siddharth Shah <siashah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836688}

Bug: 1152278
Change-Id: If83a350ef97138a884ced934ab1f29f5d7819213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586159Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836687}

TBR: dgrogan@chromium.org
Bug: 1157962
Change-Id: Icdd1e0b4a15a1f4e6f729f35a77b66f13ba1483e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590165Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836686}

We need additional people be able to roll / update OTS.

Bug: 1158389
Change-Id: I0cea226158183545e8bc4b06aca2f21ff088a68d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590037Reviewed-by: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836685}

Bug: 1158410
Change-Id: Ic8f006dbb391699016a608c9cf328ea269b9e66c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590054Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836684}

There is no need to track and handle window occlusion changes
during shutdown. Disable it to make exit faster.

Bug: 1157976
Change-Id: I52f9e3ea333b0d390cd479f6dfd524935d1dfc4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587650
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836683}

This fixes a UI bug where the "Can't connect to scanners?" message
only shifts the Scanner dropdown and not also the Scanner label.

Before: http://screen/47MFUFFmwh4UMYm
After: http://screen/7Gm86RYfjAGWDV9

Bug: 1059779
Change-Id: I74bdd0cd50ff096dd0b54b9578526ae53c513691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588836Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836682}

This reverts commit 33cb4c97.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 836533 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzNjYjRjOTc5N2VlNjQ4YWEyNzMxMGU1NjMzODJjZjE3ZGYxNGUxMww

Sample Failed Build: https://ci.chromium.org/b/8860915097129113392

Sample Failed Step: content_browsertests_wayland

Sample Flaky Test: All/PrerenderTriggerBrowserTest.LinkRelNext/0

Original change's description:
> Prerender: Add browser tests for <link rel=next>
> 
> <link rel=next> is expected to trigger prerendering like
> <link rel=prerender>.
> 
> Note that when the feature flag `kPrerender2` is disabled,
> <link rel=next> triggers NoStatePrefetch.
> 
> Bug: 1155925
> Change-Id: If430701e125dcc55e9bded8350dcc43eed8a1a1f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578499
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#836533}


Change-Id: I17b153d7da65a5573a613bce4fd4da20c18f4623
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1155925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588013
Cr-Commit-Position: refs/heads/master@{#836681}

When toplevel window uses a native frame, the server-side decoration is
set and when toplevel window uses a custom frame, the client-side
decoration is set. UseCustomFrame() decides on which frame (native or
custom) to be used for a window.

Devtool chooses a native frame but also draws frame header
(client-side decoration) causing a duplicate decoration for a devtool
window.

BrowserFrame::ShouldDrawFrameHeader always returns `true` assuming
that custom frame is used but instead, this function should check frame
type before drawing a frame header.

Bug: 1155551
Change-Id: I903a194ecf875f51d5ade726b57651c57bd7b028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573711Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#836680}

Backport [1] to perform additional sanitization on maxp values.

[1] https://github.com/khaledhosny/ots/pull/227

Bug: 1153329
Change-Id: I4bc2288574802559f6c9c67a52b6dfcd8cc7467a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588339
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836679}

Bug: 688063
Change-Id: If407b5f87c8784613ef227b20aff3f96a48224f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586014
Auto-Submit: Eugene But <eugenebut@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836678}

Wire NetworkIsolationKey through DomainReliabilityUploader.

Bug: 1138994
Change-Id: Ic1a9a317d87c0e4b32315b61d0ab3f412c3ecf01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587455Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836677}

https://android.googlesource.com/platform/external/perfetto.git/+log/778b2c216924..54174aefa84c

2020-12-14 treehugger-gerrit@google.com Merge "Get rid of LookupSet."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I74413a225c310406da37cf59976804fc765c510b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589658Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836676}

Bug: 1152274
Change-Id: I4de8bb8ea36b9152c79460ef044814277f793980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587454Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836675}

Add two new methods to the MeetDevicesDiagnostics Mojo interface, which
gather device and process-related information from cros_healthd. Meet
devices will use this information to debug crashes and improve
reliability.

Bug: b:174846892
Change-Id: Ie685c543b75c3b2b636cada5406397e5891d066d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586095Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836674}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/406249fca52c..4747e2779d79

2020-12-14 jacktfranklin@chromium.org [DataGrid] allow columns to be resized by the mouse
2020-12-14 tvanderlippe@chromium.org [module.json extensions] emulation
2020-12-14 tvanderlippe@chromium.org [module.json extensions] css_overview
2020-12-14 tvanderlippe@chromium.org Add assertNever to platform for exhaustive switch statements

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1134103,chromium:1153066,chromium:1158395
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib0b35a17a018132f05e71ff31089925e12886b73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589662Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836673}

Found this while working on d8 transition.

Bug: 1015559
Change-Id: I6a28bc6574b0ac95a05213a9aa53393f8b404ec9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590060
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836672}

Bug: 1158237,1158257,1158343
Change-Id: I53e17d37f761d64f74e0bb05dc0dba916311876d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588299
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Auto-Submit: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836671}

`git diff-tree` should be used with the `-r` flag if we want to recurse
into subtrees (e.g. to check if css/css-animations is affected by a
commit as opposed to just css/). This is the only place where we forgot
to do that and it has caused some false positives of "affecting this
directory" in our bug filing.

Fixed: 850088
Change-Id: Ifdd1b9eeba2c5749effdab1041d86c6500160ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590014
Commit-Queue: Robert Ma <robertma@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Auto-Submit: Robert Ma <robertma@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836670}

Simple no-op refactor of this test code, to prepare for more tests that
will exercise the behavior of is_web_secure_context in similar contexts.

Bug: chromium:1126856
Change-Id: I06799e7114dde1b5addc2ee4c58f41f96f730912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587168
Commit-Queue: Titouan Rigoudy <titouan@chromium.org>
Auto-Submit: Titouan Rigoudy <titouan@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836669}

This reverts commit 314cbf4c.

Reason for revert: Breaks moving tabs to other windows - crbug.com/1158259

Original change's description:
> Create glue-layer TabModelOrchestrators
>
> TabModelSelectorImpl does not create or destroy TabPersistentStore
> anymore. Instead, TabModelOrchestrators manage the lifetime of TabModelSelectorImpl and
> TabPersistentStore.
>
> Give TabModelSelectorImpl a Supplier<TabPersistentStore> instead of
> passing TabPersistentStore directly.
>
> This is a step to break the two-way dependency between
> TabModelSelectorImpl and TabPersistentStore.
>
> Bug: 1138561
> Change-Id: Ie2fa4a2735e509ff816b3e2cf5f8f6fffda7999c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572639
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Ella Ge <eirage@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#835819}

TBR=dtrainor@chromium.org,eirage@chromium.org,hnakashima@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1138561, 1158259
Change-Id: Ie0ee144acde93ec4cc46d188602b39113ce24344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588640
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836668}

The pulse animation wasn't always centered on the page, sometimes had
the wrong aspect ratio, and left a blue line at the bottom of the page.

I wasn't able to reproduce the off-center behavior, but fixing the
width seems to have solved the aspect ratio and blue line problems. I
believe the cause may have had to do with the dimensions of the
cr-lottie element getting set before the page finishes rendering, and
then not updating because the width isn't set.

The radial gradient is also replaced with a linear gradient for
simplicity, but also because the right side of the page was perceptibly
less blue than the left.

The cr-lottie element is also moved to be the first child of its parent
div. The idea was to push it back in the z-order. It's difficult to see,
but the animation was actually getting rendered on top of the help text
before.

Screenshot: https://screenshot.googleplex.com/3X8u6cmSSsneUQT.png

Bug: 1157999
Change-Id: Id6b35dbfa0f21cd5019da99775a5fe47670de48b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587209Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Curt Clemens <cclem@google.com>
Cr-Commit-Position: refs/heads/master@{#836667}