- 22 Aug, 2014 40 commits
-
-
iannucci@chromium.org authored
TBR=szager@chromium.org BUG=370554 Review URL: https://codereview.chromium.org/499533002 Cr-Commit-Position: refs/heads/master@{#291341} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291341 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
This is needed by some files in these targets. The GYP build has this dependency. TBR=jam Review URL: https://codereview.chromium.org/478853005 Cr-Commit-Position: refs/heads/master@{#291340} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291340 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Revert of Create a new AccountTrackerService (patchset #8 of https://codereview.chromium.org/425823002/) Reason for revert: Likely causing chrome.browser.signin.OAuth2TokenServiceIntegrationTest failures on Android. TBR=rogerta@chromium.org NOTREECHECKS=true NOTRY=true Original issue's description: > Create a new AccountTrackerService PKS based on the existing AccountTracker. > > This CL is one part of the effort to change chrome to use gaiaid instead of > email address as the unique id for an account. > > BUG=341408 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291263 Review URL: https://codereview.chromium.org/490403002 Cr-Commit-Position: refs/heads/master@{#291335} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291335 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
BUG=none TBR=finnur@chromium.org, dtseng@chromium.org Review URL: https://codereview.chromium.org/493903003 Cr-Commit-Position: refs/heads/master@{#291330} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291330 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
The test is failing on all platforms with the following error message: "[FAIL] createGuestViewDOM: uncaught exception: Error in event handler for extensionOptionsInternal.onSizeChanged: Invocation of form guestViewInternal.setAutoSize(undefined, object) doesn't match definition guestViewInternal.setAutoSize(integer instanceId, object params) Stack trace: Error: Invocation of form guestViewInternal.setAutoSize(undefined, object) doesn't match definition guestViewInternal.setAutoSize(integer instanceId, object params) at Object.normalizeArgumentsAndValidate (extensions::schemaUtils:113:11) at Object.\u003Canonymous> (extensions::binding:326:30) at ExtensionOptionsInternal.resize (extensions::extensionOptions:178:21) at ExtensionOptionsInternal.onSizeChanged (extensions::extensionOptions:153:10) at ExtensionOptionsEvents.handleSizeChangedEvent (extensions::extensionOptionsEvents:66:33) at Object.EXTENSION_OPTIONS_EVENTS.sizechanged.customHandler (extensions::extensionOptionsEvents:20:15) at info.evt.addListener.instanceId (extensions::extensionOptionsEvents:55:12) at EventImpl.dispatchToListener (extensions::event_bindings:397:22) at Event.publicClass.(anonymous function) [as dispatchToListener] (extensions::utils:94:26) at EventImpl.dispatch_ (extensions::event_bindings:379:35) Error at extensions::test:93:22 at exports.handle (extensions::uncaught_exception_handler:15:3) at EventImpl.dispatch_ (extensions::event_bindings:384:9) at dispatchArgs (extensions::event_bindings:247:26) at dispatchEvent (extensions::event_bindings:256:7)", source: chrome-extension://obocclgnomgjhjnenilbpmgkgfmdhecn/test.html (0) > Implement smoother autosizing of the extension options overlay > > - Use element.animate to resize the overlay for embedded extension > options. When an <extensionoptions> element is embedded in a WebUI > overlay, if its size changes the overlay will smoothly expand to > surround the element. > - Add an API to <extensionoptions> to defer autosizing until its > embedder is ready. This is used to 'pin' the element's size until > the overlay is done expanding. > - Move the <extensionoptions> off screen until the overlay is done > expanding. > - Prevent <extensionoptions> from shrinking after the initial sizing. > This makes the look of the embedded options page more consistent. > > BUG=386842 > > Review URL: https://codereview.chromium.org/480243003 TBR=ericzeng@chromium.org Review URL: https://codereview.chromium.org/498633002 Cr-Commit-Position: refs/heads/master@{#291328} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291328 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
Cr-Commit-Position: refs/heads/master@{#291322} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291322 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
I suspect that we simply need to initialize the don't-animate flag earlier, as we did in the other tests. BUG=403824 TBR=sky@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/497583003 Cr-Commit-Position: refs/heads/master@{#291318} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291318 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#291317} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291317 0039d316-1c4b-4281-b951-d872f2087c98
-
blink-deps-roller@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180729:180745&mode=html TBR=dglazkov@chromium.org,wibling@chromium.org BUG= Review URL: https://codereview.chromium.org/474563005 Cr-Commit-Position: refs/heads/master@{#291316} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291316 0039d316-1c4b-4281-b951-d872f2087c98
-
leecam@chromium.org authored
Updated Arm, Mips, x86_32 and x86_64 syscall defines to match the latest kernel 3.17 at the time of this commit. BUG=406123 TEST=sandbox_linux_unittests Review URL: https://codereview.chromium.org/493603003 Cr-Commit-Position: refs/heads/master@{#291315} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291315 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
To make porting the QUIC EndToEndTest to Chromium possible with fewer Chromium-specific parts in shared code, I've made QuicDispatcher expose and accept a QuicDispatcher::PacketWriterFactory which it uses to create a new packet writer wrapper for every QuicConnection. I also changed QuicConnection to accept a QuicConnection::PacketWriterFactory (a second new type of factory) rather than the writer itself in its constructor, since the per-connection packet writers need to be created with the connection already existing. Merge internal CL: 73064412 Written by Daniel Ziegler <dmziegler@chromium.org> Original review URL: https://codereview.chromium.org/467963002/ R=rch@chromium.org,wtc@chromium.org BUG= Review URL: https://codereview.chromium.org/475113005 Cr-Commit-Position: refs/heads/master@{#291314} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291314 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
This will make it easier to move tests that use permissions from Chrome's unit_tests target to extensions_unittests. BUG=none TEST=extensions_unittests passes Review URL: https://codereview.chromium.org/496903002 Cr-Commit-Position: refs/heads/master@{#291313} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291313 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Reliability tests have been dead for a while. Review URL: https://codereview.chromium.org/479703002 Cr-Commit-Position: refs/heads/master@{#291312} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291312 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
BUG=403813 TEST=athena_unittests R=oshima@chromium.org Review URL: https://codereview.chromium.org/496793004 Cr-Commit-Position: refs/heads/master@{#291311} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291311 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
BUG=398467 NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/499453002 Cr-Commit-Position: refs/heads/master@{#291310} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291310 0039d316-1c4b-4281-b951-d872f2087c98
-
mfoltz@chromium.org authored
BUG=393969 Review URL: https://codereview.chromium.org/480173004 Cr-Commit-Position: refs/heads/master@{#291309} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291309 0039d316-1c4b-4281-b951-d872f2087c98
-
bryner@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/494143003 Cr-Commit-Position: refs/heads/master@{#291308} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291308 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
Step 1 - factor out current cache and increase its size. BUG=401758 R=pkasting@chromium.org Review URL: https://codereview.chromium.org/455563002 Cr-Commit-Position: refs/heads/master@{#291307} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291307 0039d316-1c4b-4281-b951-d872f2087c98
-
aelias@chromium.org authored
This changes CC to trust Blink's inner container layer size and apply Android top controls size as a delta on top of it. Prior to this patch, on Android we would clobber what Blink told CC with a from-scratch computation "physical device size - top controls impl size - keyboard overdraw size". This change makes it unnecessary for the renderer to be aware of keyboard overdraw size, but on the other hand CC now must know about how top controls size was applied to Blink layout size, to understand the size coming from Blink. So this patch replaces one float with the other. This simplifies the logic and is a step towards converging OSK codepaths between platforms (since ChromeOS didn't use overdraw_bottom_height, but used visible_viewport_size instead -- this patch unlocks the potential use of the latter on Android as well). NOTRY=true BUG=404315 Review URL: https://codereview.chromium.org/476113004 Cr-Commit-Position: refs/heads/master@{#291306} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291306 0039d316-1c4b-4281-b951-d872f2087c98
-
benwells@chromium.org authored
As there is no URL being displayed users need to be aware of what host they are on for security reasons. This is part of the experimental streamlined hosted apps window frame. BUG=368372 Review URL: https://codereview.chromium.org/490103003 Cr-Commit-Position: refs/heads/master@{#291305} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291305 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
This test was enabling a lot of categories that it should not have. When using impl side painting, we can use the trace events from blink.ImageFrameGenerator::decode to measure the time. On legacy compositing, this doesn't exist and we have to fall back to the "timeline.Decode Image" event still. Left FIXMEs to remove this. BUG=405244 NOTRY=true Review URL: https://codereview.chromium.org/480713004 Cr-Commit-Position: refs/heads/master@{#291304} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291304 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
This adds members to mojo::Event that are needed to construct a blink::WebInputEvent, as well as the boilerplate to carry those members on a ui::KeyEvent object, because the events aren't sent directly from the native event source to html viewer, but pass through multiple systems. BUG=403514 Review URL: https://codereview.chromium.org/492863002 Cr-Commit-Position: refs/heads/master@{#291301} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291301 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
This hopefully prevents implicit Fontconfig initialization from occurring later when queries are first made from gfx::FontRenderParams/Skia/Blink/etc. BUG=404311 Review URL: https://codereview.chromium.org/497523002 Cr-Commit-Position: refs/heads/master@{#291298} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291298 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
been implemented. R=yoz@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/474293007 Cr-Commit-Position: refs/heads/master@{#291297} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291297 0039d316-1c4b-4281-b951-d872f2087c98
-
jdduke@chromium.org authored
The current vsync subscription scheme in RWHVAndroid is rather ad-hoc. Formalize the request logic by creating explicit request types, avoiding redundant vsync requests (and the associated JNI call) while also enforcing the validity of such requests (for WebView). BUG=394604 Review URL: https://codereview.chromium.org/492923002 Cr-Commit-Position: refs/heads/master@{#291296} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291296 0039d316-1c4b-4281-b951-d872f2087c98
-
yfriedman@chromium.org authored
Replace me with Jared for ui/ places. I'm not familiar with what's going on in buildbot anymore. NOTRY=true TBR=sky Review URL: https://codereview.chromium.org/477133005 Cr-Commit-Position: refs/heads/master@{#291295} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291295 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
BUG=None Review URL: https://codereview.chromium.org/491023004 Cr-Commit-Position: refs/heads/master@{#291294} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291294 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
R=asvitkine@chromium.org BUG=404809,405295 Review URL: https://codereview.chromium.org/490733002 Cr-Commit-Position: refs/heads/master@{#291293} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291293 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
Instead of using an arbitrary Region, which is costly (slow), use a new SimpleEnclosedRegion. This class tracks only a single Rect at a given time so it is very fast and small. It tries to get something like the largest rect enclosed in the actual Region (were we to track such a Region) in an online fashion, ie it doesn't remember anything except its current largest possible rect. BUG=405663 Review URL: https://codereview.chromium.org/202523002 Cr-Commit-Position: refs/heads/master@{#291292} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291292 0039d316-1c4b-4281-b951-d872f2087c98
-
gpdavis.chromium@gmail.com authored
script injection permissions BUG=405671 Review URL: https://codereview.chromium.org/492803003 Cr-Commit-Position: refs/heads/master@{#291291} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291291 0039d316-1c4b-4281-b951-d872f2087c98
-
mlerman@chromium.org authored
BUG=306322 Review URL: https://codereview.chromium.org/466293003 Cr-Commit-Position: refs/heads/master@{#291289} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291289 0039d316-1c4b-4281-b951-d872f2087c98
-
hubbe@chromium.org authored
The RTCP sender API has reduntant information, getting rid of the redundencies means fewer lines of code. Review URL: https://codereview.chromium.org/499433002 Cr-Commit-Position: refs/heads/master@{#291288} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291288 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
Python always does reference counting and that handles most of the objects used by GYP. The GC is used to detect and drop circular references. If GC is turned off then the heap scanning can be skipped to save some CPU cycles, and the memory leaked due to circular references isn't noticeable. This saves about 1 second out of 16 on Linux in a Z620 workstation. BUG=None Review URL: https://codereview.chromium.org/495993002 Cr-Commit-Position: refs/heads/master@{#291287} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291287 0039d316-1c4b-4281-b951-d872f2087c98
-
ericzeng@chromium.org authored
- Use element.animate to resize the overlay for embedded extension options. When an <extensionoptions> element is embedded in a WebUI overlay, if its size changes the overlay will smoothly expand to surround the element. - Add an API to <extensionoptions> to defer autosizing until its embedder is ready. This is used to 'pin' the element's size until the overlay is done expanding. - Move the <extensionoptions> off screen until the overlay is done expanding. - Prevent <extensionoptions> from shrinking after the initial sizing. This makes the look of the embedded options page more consistent. BUG=386842 Review URL: https://codereview.chromium.org/480243003 Cr-Commit-Position: refs/heads/master@{#291286} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291286 0039d316-1c4b-4281-b951-d872f2087c98
-
rileya@chromium.org authored
BUG=399002 Review URL: https://codereview.chromium.org/495193002 Cr-Commit-Position: refs/heads/master@{#291284} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291284 0039d316-1c4b-4281-b951-d872f2087c98
-
amistry@chromium.org authored
Stolen from https://codereview.chromium.org/118373003 BUG=397019 Review URL: https://codereview.chromium.org/488353004 Cr-Commit-Position: refs/heads/master@{#291283} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291283 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
This is part of work to allow embedders to send a chunk when they do not yet know whether it is the final chunk. BUG=405678 Review URL: https://codereview.chromium.org/497553002 Cr-Commit-Position: refs/heads/master@{#291282} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291282 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
BUG=401667 Review URL: https://codereview.chromium.org/495923002 Cr-Commit-Position: refs/heads/master@{#291281} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291281 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=304341 TEST=popup menus still work Review URL: https://codereview.chromium.org/494993004 Cr-Commit-Position: refs/heads/master@{#291280} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291280 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#291279} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291279 0039d316-1c4b-4281-b951-d872f2087c98
-