GitLab

This patch introduces test cases for |PreviousWordPosition()| to record current
behavior as a preparation of the patch[1].

Note: The patch[2] introduces test case for |NextWordPosition()|.

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection
[2] http://crrev.com/c/895236 Introduce test cases for NextWordPosition()

Bug: 778507
Change-Id: Ie1b3933336ddd9d6afca246700a9f7e9a588d61d
Reviewed-on: https://chromium-review.googlesource.com/923686
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537595}

and handle empty or missing rpIds.

Add layout tests for various combinations of origins and rpId to
get(publicKey) just like the existing ones for create(publicKey).

Bug: 807774, 664630
Change-Id: I86d3d36c3f3825743f003da69245c74bdca10d5b
Reviewed-on: https://chromium-review.googlesource.com/896384
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537594}

This reverts commit d9b74d0c.

Reason for revert: See the FindIt message. It looks this CL has broken the "Linux Chromium OS ASan LSan Tests" bot

Original change's description:
> Add user to active sessions reporting.
> 
> Previously, active sessions and recent users were reported separately,
> that is confusing on the server side.
> This change adds 'user_email' field to ActiveTimePeriod proto message
> and populates it for affiliated users that are eligible for reporting.
> Also, user email is reported only if user reporting is turned on.
> 
> BUG=810093
> TEST=Browser tests added.
> 
> Change-Id: I92fec6725349972895ec0a439f78efa59853670e
> Reviewed-on: https://chromium-review.googlesource.com/904527
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Sergey Poromov <poromov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537435}

TBR=xiyuan@chromium.org,emaxx@chromium.org,poromov@chromium.org,pmarko@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 810093
Change-Id: I96152915d5da8d763c32132bade51b2bc5a4bcd7
Reviewed-on: https://chromium-review.googlesource.com/923228Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537593}

We no longer have multiple shadow roots, <shadow> behaves almost
identical to <content> without select attribute.
We only have to care for the case when <content> and <shadow> are
used in the same shadow root.

This CL simplifies code that used to handle multiple shadow cases
for <shadow> elements in V0 distribution logic.

No visible behavioral change is expected.

Bug: 624724
Change-Id: I88f237f2d26519cd400ef13605f4b3115843b4b7
Reviewed-on: https://chromium-review.googlesource.com/923446Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537592}

StaticSocketDataProvider and SequencedSocketData do not modify the
MockRead and MockWrite arrays that they are passed. Mark them const.

Change-Id: I0eea9dce572e2fd1c9c8cf8e2f08cdfb14b4fc1c
Reviewed-on: https://chromium-review.googlesource.com/917886Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537591}

This reverts commit b104c05a.

Reason for revert: Now SPv175 is live on M66, so return the bot
to SPv2.

Also update LayoutTests/FlagExpectations/enable-slimming-paint-v2.

Original change's description:
> [SPv175] Borrow the SPv2 bot for SPv175
>
> We are near to finish SPv175 development, and we need more test
> coverage. Borrow the SPv2 bot for SPv175 until we switch SPv175
> on for experiment.
>
> Bug: 771643
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I05f36f168269507961cdc102446e4b23159555dd
> TBR: testing/buildbot
> Reviewed-on: https://chromium-review.googlesource.com/860726
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#528517}

TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org,schenney@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 771643
Change-Id: Ib0e31c9e542936a0ac3baddf17b4896eff7aed47
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/925021Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537590}

Revert "Trying to re-re-land: Use a PromiseResolver to store reference to Element in getComputedAccessibleNode() implementation."

This reverts commit 537ea336.

Reason for revert: The newly added tests are failing on the "WebKit Linux Trusty" bot

Original change's description:
> Trying to re-re-land: Use a PromiseResolver to store reference to Element in getComputedAccessibleNode() implementation.
> 
> Bug: 792783
> Change-Id: Icdc8423c50eaa051b348c5226af4936e97b39251
> Reviewed-on: https://chromium-review.googlesource.com/923141
> Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537568}

TBR=jsbell@chromium.org,szager@chromium.org,aboxhall@chromium.org,haraken@chromium.org,altimin@chromium.org

Change-Id: If686ff2c3db54ff3492b46ee528c79a4250ff4c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 792783
Reviewed-on: https://chromium-review.googlesource.com/923251Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537589}

HostedAppTest now use https for all tests other than http-specific ones
(otherwise, all tests would show a location bar, and we wouldn't be
properly testing any of the other behaviour).

Bug: 811158
Change-Id: I0fe220055fb6574c3950f65971e06feadaeabcd9
Reviewed-on: https://chromium-review.googlesource.com/913191Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537588}

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug: 624694, 804694
Change-Id: Ic6983b6f0a2b5039db1473662d2e7627dd67b5e1
Reviewed-on: https://chromium-review.googlesource.com/903903Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537587}

Following bot results are included.
3800 3802 3812 3817 3830 3832 3833 3834

2 lines were removed and 28 lines were deflaked by consecutive results
since 3750.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5d2c0a665f013a4143ab31cfa98e39a0c6ce0af7
Reviewed-on: https://chromium-review.googlesource.com/923243
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537586}

Traffic annotation auditor file filter is expanded to ignore all files
that end with test.cc or test.mm.

Bug: 690323
Change-Id: Iac0eb5aca403f4fa40b6b81dd85a46c317fd6684
Reviewed-on: https://chromium-review.googlesource.com/924062
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537585}

The first implementation of CSS list in LayoutNG adds the logic to
NGInlineLayoutAlgorithm, and supports only when content of the list
item is inline level. Extending this to when list items have block
level children wasn't easy. Making them as inline blocks is likely not
web-compatible when floats affect part of the blocks.

The most common case is nested lists, because a list is block level.
This patch renders basic nested lists correctly.

This patch supports list marker as an unpositioned object in
NGBlockLayoutAlgorithm, similar to floats or out-of-flow objects, and
positions them when it lays out the next block, relative to its first
line baseline. It is much simpler than floats or out-of-flow objects,
because it is contained only within the list item.

The approach is still being discussed with Francois (msft) and Cathie.
Also this patch still doesn't support images, and customized
positioning of markers by setting padding/margin. These will be in
following patches.

Two tests that were incorrectly rebaselined were re-rebaselined.
Some image failures turned to text failures that need manual reviews
to rebaseline.

Bug: 725277
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I2e7f46fc6320c6986e4894a263ef99873db2f092
Reviewed-on: https://chromium-review.googlesource.com/919443
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537584}

This reverts commit 673d8eb6.

Reason for revert: Looks this has broken linux-chromeos-rel build. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=EGLApiTest.DisabledExtensionBitTest&testType=gl_unittests_ozone

Original change's description:
> GpuMemoryBuffer: add image_xb30 capability and RGBX_1010102 BufferFormat
> 
> This CL adds a new Gpu FeatureInfo::FeatureFlags and command buffer
> Capabilities to signal support for image_xb30, in parallel to the
> existing image_xr30. The new flag is used on platforms supporting
> glTexImage2D() with data format GL_RGB(A), namely >=gles3, >=gl3.3
> or those with the appropriate GL extension.
> 
> This CL also adds a new GpuMemoryBuffer format RGBX_1010102 to
> be used where image_xb30 is signalled.
> 
> With all this, Mac will use image_xr30 <-> BGRX_1010102, and the
> GLES3+/GL3.3+ platforms will use image_xb30 <-> RGBX_1010102.
> 
> Bug: 803975, 776093, 803451, 808172
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I00c834b68ce81d93e0f55694d891186ed3b75611
> Reviewed-on: https://chromium-review.googlesource.com/920361
> Reviewed-by: David Reveman <reveman@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537561}

TBR=avi@chromium.org,reveman@chromium.org,dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,rsesek@chromium.org,piman@chromium.org

Change-Id: I08563c74c65ed18ea7dd78e41220a3607b7c9ad5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 803975, 776093, 803451, 808172
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/923448Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537583}

History:
At some point in the past, SpokenFeedbackEventRewriter did not have the notion of |capture| (a boolean set by a calling extension). As a result, we had to hard code values into the rewriter so that they get rewritten by things like KeyboardDrivenEventRewriter. For example, F1->back.

This leads to us not being able to capture and prevent default on F1-F12 which map to hardware keys.

Bug: 687748
Test: Search+o, k; verify f1-f12 announce and don't trigger.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3ca70a8fc1159f9b5f60332ef5a77ecfe95482b7
Reviewed-on: https://chromium-review.googlesource.com/905283Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537582}

This is probably not going to fix the leak but will make things
clearer.

Bug: 808390
Change-Id: I625ed2fde63d1eb1bb09fcb5ed3e522929d9f025
Reviewed-on: https://chromium-review.googlesource.com/923447Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537581}

ResourceFetcher/ResourceLoader now saves the result of the CORS check on
the Resource object. Though the result of the CORS check varies
depending on the source origin, reusing an existing resource fetched by
a different source origin is allowed by mistake.

This patch introduces a logic to prevent MemoryCache entries from being
reused for requests with a different source (requestor) origin by saving
the source origin on the Resource object and comparing that with the new
source origin in Resource::CanReuse(), so that the result of the CORS
check is reused only when the source origin is the same.

An alternative possibly-better approach is to isolate MemoryCache for
different origins by changing the cache identifier to take into account
the source origin of requests. However, to keep the patch small and fix
the issue quickly, this patch just prevents reuse.

Bug: 799477, 809350
Change-Id: Ib96c9e728abe969a53f3d80519118a83392067b4
Reviewed-on: https://chromium-review.googlesource.com/897040
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537580}

When creating a ResourceResponse from another ResourceResponse,
we need to copy WasFetchedViaServiceWorker and
ResponseTypeViaServiceWorker.

Bug: 737648
Change-Id: I9405738221ef5232e235f9fc400f204b7b558596
Reviewed-on: https://chromium-review.googlesource.com/907012
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537579}

Make Element::CloneElementWithoutAttributesAndChildren private back.
This CL has no behavior changes.

Bug: 812089
Change-Id: I69b91ebcb436d721f8d54d904dd8b145cdc12607
Reviewed-on: https://chromium-review.googlesource.com/923506
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537578}

ContainerNode::CloneChildNodes() does the same thing.
This CL has no behavior changes.

Bug: 812089
Change-Id: Ida9fb4c6dbc34654b54e74285263f70411d50d36
Reviewed-on: https://chromium-review.googlesource.com/924108Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537577}

TBR=inferno@chromium.org

Bug: 813188
Change-Id: I70b1d84cc6e9f0538b7faac7ba27ce09c5bffab6
Reviewed-on: https://chromium-review.googlesource.com/923922Reviewed-by: Oliver Chang <ochang@chromium.org>
Commit-Queue: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537576}

virtual/gpu-rasterization/images/color-profile-image-filter-all.html
(likely) started failing from the patch for SlimmingPaintV175. As noted
in the patch, marking it as failing instead of reverting it.

Additionally, marking it as SLOW as it's failing for timeout also on
Mac in addition to Linux and Win which are already specified.

Bug: 771643, 726075
Change-Id: I15771a9e018428d3b729da40491d7bea3f7e2917
Reviewed-on: https://chromium-review.googlesource.com/923768Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537575}

Reviewed at https://crrev.com/c/920961 reverted because `gn gen` failed
when args.gn contained `enable_stripping = true`. Fixed by removing the
output_name override and updating the literal in code.

- Resurrects shell_dialogs_unittests on Mac
- Fixes 2 tests that had regressed since the gn transition.
- Tweaks the code to be more robust around complex object lifetimes.
- Adds test SelectFileDialogMacTest.Lifetime

TBR=avi@chromium.org,rsesek@chromium.org

Bug: 788271
Change-Id: I650f804386854d5fd05f76dfb0b55667786c8578
Reviewed-on: https://chromium-review.googlesource.com/925122
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537574}

Contextual search needs a full screen height to display its
contents but the height returned from the class OverlayPanelBase
was shorter by toolbar height. This CL sets it right.

Tested on mobile/tablet in both portrait/landscape mode.

Bug: 772205, 810297
Change-Id: I8a863ee2e53075a31d9dc8d61bd8482aa8454455
Reviewed-on: https://chromium-review.googlesource.com/910128
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537573}

Pull out a couple of hard-coded layout constants in LocationBarView and put them
in layout_constants.*. Also audit the uses of these layout constants and update
places that should be using them.

Bug: 801583
Change-Id: Ia157cd313020a17fa4f8ebda662545395c29855b
Reviewed-on: https://chromium-review.googlesource.com/923503Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537572}

ash/system/tray/tray_constants.h has number of constant values that are
not used anymore.

BUG=none

Change-Id: I4156f0b48951144416316b60d2bdf556b01e784f
Reviewed-on: https://chromium-review.googlesource.com/923742Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537571}

Bug: 801583
Change-Id: I7841e175a0aba57020775465cd191083bf8b19a4
Reviewed-on: https://chromium-review.googlesource.com/914984
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537570}

Shadowed variables can make code harder to read. Don't support them
in the content layer.

BUG=794619

This CL was uploaded by git cl split.

R=raymes@chromium.org

Change-Id: Ic204074056ad3a3a7060c520c34a0a6728340d3b
Reviewed-on: https://chromium-review.googlesource.com/923347Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537569}

Trying to re-re-land: Use a PromiseResolver to store reference to Element in getComputedAccessibleNode() implementation.

Bug: 792783
Change-Id: Icdc8423c50eaa051b348c5226af4936e97b39251
Reviewed-on: https://chromium-review.googlesource.com/923141
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537568}

This went all wrong, with a branch being duplicated and comments
to variables that no longer exist.

R=ericrk@chromium.org
TBR=ericrk

Bug: 730660
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iaf5d331798ed2b4343c57120e558546c40489b63
Reviewed-on: https://chromium-review.googlesource.com/919661
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537567}

In certain scenarios, there is a CSS bug in which an element
with mask fails to be a stacking context, but HasMask still returns
true.

Bug: 813348
Change-Id: I693cd9a8139cda335ac144ce600538b274e75c7a
Reviewed-on: https://chromium-review.googlesource.com/924767
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537566}

Shadowed variables can make code harder to read. Don't support them
in the content layer.

BUG=794619

This CL was uploaded by git cl split.

R=boliu@chromium.org

Change-Id: Iefa946eb8500d28baf16b7e7519303cc29233794
Reviewed-on: https://chromium-review.googlesource.com/923349Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537565}

Intent to ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/8vqcABTnDF4

Bug: 695939
Change-Id: I917909f4ee0e5cf2967ac4ed44b137e9a9b6e2a1
Reviewed-on: https://chromium-review.googlesource.com/923442Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537564}

Shadowed variables can make code harder to read. Don't support them
in the content layer.

BUG=794619

This CL was uploaded by git cl split.

R=vmpstr@chromium.org

Change-Id: I683ff26a587f65c1339fda72c4b20877974925f1
Reviewed-on: https://chromium-review.googlesource.com/923344Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537563}

Shadowed variables can make code harder to read. Don't support them
in the content layer.

BUG=794619

This CL was uploaded by git cl split.

R=dalecurtis@chromium.org

Change-Id: Ida89064c5c1c68cf24708d2f6536569812507186
Reviewed-on: https://chromium-review.googlesource.com/924169Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537562}

This CL adds a new Gpu FeatureInfo::FeatureFlags and command buffer
Capabilities to signal support for image_xb30, in parallel to the
existing image_xr30. The new flag is used on platforms supporting
glTexImage2D() with data format GL_RGB(A), namely >=gles3, >=gl3.3
or those with the appropriate GL extension.

This CL also adds a new GpuMemoryBuffer format RGBX_1010102 to
be used where image_xb30 is signalled.

With all this, Mac will use image_xr30 <-> BGRX_1010102, and the
GLES3+/GL3.3+ platforms will use image_xb30 <-> RGBX_1010102.

Bug: 803975, 776093, 803451, 808172
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I00c834b68ce81d93e0f55694d891186ed3b75611
Reviewed-on: https://chromium-review.googlesource.com/920361Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537561}

Merge internal change: 185728670

R=rch@chromium.org

Change-Id: I333dd3d85a4a3e47a34d5e5fdf59fa2143e70c68
Reviewed-on: https://chromium-review.googlesource.com/923533Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bin Wu <wub@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537560}

This fixes the following jumbo build error:

In file included from gen/third_party/WebKit/Source/platform/blink_platform_unittests_sources_jumbo_3.cc:26:
In file included from ./../../third_party/WebKit/Source/platform/graphics/paint/DrawingRecorderTest.cpp:8:
../../third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.h:19:23: error: target of using declaration conflicts with declaration already in scope
using blink::testing::DefaultPaintChunkProperties;
                      ^
../../third_party/WebKit/Source/platform/testing/PaintPropertyTestHelpers.h:29:36: note: target of using declaration
static inline PaintChunkProperties DefaultPaintChunkProperties() {
                                   ^
./../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:43:22: note: conflicting declaration
PaintChunkProperties DefaultPaintChunkProperties() {
                     ^
1 error generated.

Followup to https://chromium-review.googlesource.com/c/chromium/src/+/922391

TBR=chrishtr@chromium.org

Bug: 811269
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Icb472581bb3b9fc46c82d21b0566572b61732876
Reviewed-on: https://chromium-review.googlesource.com/924863
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#537559}

Add most of the ChromeDriver tests into the chromedriver_py_tests target
that is run in the commit queue. Some tests are skipped for various
reasons: not reliable enough, not adding enough value for commit queue,
or requiring additional setup not yet available.

Bug: 793370
Change-Id: Iec581b24e155b2dfb926cdba4899f26c173d2023
Reviewed-on: https://chromium-review.googlesource.com/919488Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537558}

TranslateHelper uses a sample of the page text to determine the page
language. This patch eliminates content of NOSCRIPT elements from the
text dump, so that non-text contents in NOSCRIPT elements are not passed
to TranslateHelper.

Bug: 813009
Change-Id: Icf1781a69d17538103574bd149cb3d5851852a08
Reviewed-on: https://chromium-review.googlesource.com/924111Reviewed-by: Rachel Blum <groby@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537557}

https://webrtc.googlesource.com/src.git/+log/80dd7b5d683c..707ca31ea4b5

$ git log 80dd7b5d6..707ca31ea --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7fa49b2063866446c793ce2c1e30de3af60ee39d
Reviewed-on: https://chromium-review.googlesource.com/924765
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537556}