- 11 Oct, 2019 40 commits
-
-
Marc Treib authored
After recent cleanups, these were completely unused: DomDistillerStore was purely a wrapper around DomDistillerModel, containing no functionality whatsoever. DomDistillerModel itself was always empty in practice: The only way it ever got any data was through an |initial_data| param passed to the constructor, which only tests used. TBRing mechanical ios/ changes TBR=noyau Bug: 1007942 Change-Id: Ibe96f0d1ed7692b6d38c401a6feb76ea612a57f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853405 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705168}
-
danakj authored
The order of operations for making a new RenderWidget for a frame is: 1. new RenderWidget. Now we have a pointer but it is not used because it is not initialized. 2. pass RenderWidget to WebFrameWidget as the WebFrameWidgetClient This gives the pointer out but it's just stored, which allows the WebFrameWidget to function correctly once it is used. 3. Initialize RenderWidget This includes calling into the WebWidget, which is why step 2 was important. Reviving a widget from undead should look like this too, but currently in step one, instead of just marking the widget as not undead, we also jump ahead and start to do initialization. That means the initialization code requires null checks around the WebFrameWidget being present or not, and fails to do some of its normal initialization steps in the revive-from-undead case. This CL fixes revive from undead to look like creating a new RenderWidget. Step one only marks the RenderWidget as no longer undead and performs the equivalent steps if needed as the RenderWidget's constructor. All initialization is deferred to the InitForRevivedMainFrame() which will run as step 3. The creation path is modified to be more explicit as well. When step 3 initialization happens, if the widget is undead, the LivingInit() steps are skipped. They will be run when the widget is revived from undead. And they will be run each time the widget is revived, if it happens multiple times over its lifetime. RenderWidget-specific logic is moved out of RenderViewImpl in the process. The RenderWidget::SetIsUndead(true) method is the replacement for Close() and it can do partial shutdown such as closing the WebWidget. This removes the need for SetWebWidgetInternal(), making the RenderWidget API for undead-ness closer to the normal APIs. As compositor and WebWidget initialization in step 3 is now always after the WebWidget is set, null pointer checks for the WebWidget can be removed, as was the original intention in this CL. R=avi@chromium.org Bug: 419087 Change-Id: I024c852d00110015308640f272220ed7d560d5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854818 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705167}
-
Collin Baker authored
This avoids re-encoding thumbnail images by requesting compressed image data directly from ThumbnailImage. Additionally, this changes the data URI generating code to reduce usage of temporary std::strings. Bug: 991393 Change-Id: Ia5cc679c383e5ef4a084c5b220492c824124b7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836146 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#705166}
-
Tim van der Lippe authored
The terminal experiment was initially proposed in 2016 [1]. Since then, no maintenance work was performed on promoting the experiment to a stable feature. Closer inspection of the feature shows that it does not work. After enabling the experiment, issueing the command "Show Terminal" results in an internal error in xterm. If we want to reconsider this experiment, we should re-evaluate the approach and come up with a proper design for the feature. For now, I would propose on removing the dead code. [1]: https://codereview.chromium.org/2372303003 Bug: 1006759,1011466 Change-Id: Ib433b44924d9ccb1f5665afba9affcccd04c2bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855923 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705165}
-
chrome://sync-confirmationdpapad authored
chrome://sync-confirmation is only available on Win,Mac,Linux, but its resources where unnecessarily included on CrOS as well. Moreover IDR_SIGNIN_SHARED_CSS_HTML was erroneously included in Android too. Bug: 1012533 Change-Id: Id9bacdea1f085beb3cf58b718152f8d6f45f5fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854793 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#705164}
-
Lei Zhang authored
This reverts commit 7fda4612. Reason for revert: testAggregateTraces is failing. Original change's description: > [tools/perf] Implement traces aggregation in Results Processor > > Bug: 981349 > Change-Id: I1a47afea1dedcd352a0d6999f7119246b74b737f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849855 > Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704705} TBR=perezju@chromium.org,khokhlov@google.com Change-Id: I480141f37e0b8420615e7fda92b3392d6c3e230f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 981349, 1013519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856360Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705163}
-
Raphael Kubo da Costa authored
Adjust to https://github.com/w3c/wake-lock/pull/234. Screen wake lock requests could be rejected with either AbortError or NotAllowedError depending on when the document became hidden. For consistency, always reject the promise with NotAllowedError. Bug: 257511 Change-Id: I00eb478af62a794692a8c439926ce89480cd0510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856166 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#705162}
-
Ken Rockot authored
ScopedFeatureList is unsafe to use after browser threads have been started. This constraint will imminently be enforced by DCHECK to prevent further erroneous usage from landing. This CL corrects usage within chrome/browser/ui/ This is split from a larger CL where in some rare cases, correction was too complex to resolve before landing the DCHECK, so corresponding test(s) may be disabled instead of fixed. Bug: 846380 Change-Id: Icf7980a928f4462e21f6d252fc04170a79be9393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850735 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#705161}
-
Chris Harrelson authored
There is no need to remove the method entirely, it serves a purpose in the end. Bug: 752327 Change-Id: Iab58f934be779a9e4bc0f53d19e1d82966e5af6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842632 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705160}
-
Yannic Bonenberger authored
Previously, service workers were resurrected when they were updated or when the same script was registered while the service worker was still alive. Now, registering a service worker will always create a new instance, regardless of whether there already is a running instance or not. Chrome status: https://chromestatus.com/feature/5646687634718720 Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/r176Lvgxfys/4W4IGM4uAgAJ Bug: 971571,988582 Change-Id: Id7748377af107099d7c10fb2e455f30f7423e5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768759 Commit-Queue: Yannic Bonenberger <yannic.bonenberger@gmail.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#705159}
-
Xida Chen authored
Right now a FrameSequenceTracker would report its throughput data at the end of a frame sequence only. That is, if we have a very long sequence, it would report once. That could easily bias the data. This CL makes changes such that a tracker would report data every 5s. Bug: 996752 Change-Id: I768583e71ad3431c5c29dddc7f07ddad8d9eba39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827580 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#705158}
-
Avery Musbach authored
The present CL is a step toward implementing the idea that when the MultiDisplayOverviewAndSplitView feature flag is enabled, each root window controller shall own a split view controller, and when the MultiDisplayOverviewAndSplitView feature flag is disabled, only the primary root window controller shall own a split view controller. As of the present CL, regardless of the MultiDisplayOverviewAndSplitView feature flag being enabled or disabled, only the primary root window controller shall own a split view controller. Bug: 970013 Change-Id: I6c6e1ac28ff5068d8bcdfe92f5cd6fa6fcd42482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850802 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#705157}
-
Adithya Srinivasan authored
The sequence of events causing the flake is as follows: 1) when flushing the touch event queue, we ack a touch event and generate a scroll update gesture event. 2) Before dispatching the GSU, we prepend a touch event (kTouchScrollStarted) which is non-blocking and gets acked immediately, causing us to run AckCompletedEvents. 3) AckCompletedEvents acks the remaining touch events in the queue, and in this test, acks a touch cancel event which generates and dispatches a scroll end gesture event. 4) The initial scroll update event is actually dispatched after the scroll end event (which is an invalid ordering). To fix this, we prevent AckCompletedEvents from being called while we're flushing the queue to prevent it from affecting gesture event ordering. Bug: 1010675 Change-Id: I00d102ccde0b4bd458d86737a660f5fb777a3c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849430Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#705156}
-
Roman Aleksandrov authored
LoginBaseBubbleView was using RootView as its container. The RootView uses FillLayout and LoginBaseBubbleView changes its size in its Layout. This could create an infinite layout loop and has strange problems. The CL works around the problem by using a container view that does not layout its children for LoginBaseBubbleView. Other fixes: - LoginExpandedPublicAccountView delete existing language and keyboard menu before it creates them again. - Ensure that language and keyboard menu hide on dismissal. Bug: 983892 Change-Id: I4aed9b1be8a7afe0c486de40d851a1400d01b367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849892 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
-
William Carr authored
Use the size of the underlying bitstream buffer and not the memory region size when creating the media::BitstreamBuffer Change-Id: I195daf984595fb27f22401ff4ad1a4220805cfde Bug: 1013437 Change-Id: I195daf984595fb27f22401ff4ad1a4220805cfde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850971 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#705154}
-
Johannes Henkel authored
New rev: a14dad30f0e5b0fc05911856d5a20b1ffe89fd9b Change-Id: I331d2e2c599fb866cb29ed7129eed7eae6e9c272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848120 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#705153}
-
Jonah Ryan-Davis authored
Add Linux beta trial to DefaultPassthroughCommandDecoder experiment config. Bug: 976283 Change-Id: I01450d70116079225054bb7a9da5a1a1c6a67699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841753 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#705152}
-
Daniel Vogelheim authored
Bug: 959693 Change-Id: I15712d202d410dda6237f7fbc259d8bdb421be10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626857 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#705151}
-
Jimmy Gong authored
- CupsPrintersEntryManager contains both saved and nearby printers. - This new class handles the model manipulation of printers and calls on its listeners to let the views know when the models have been updated. - Adds CupsPrintersEntryListBehavior to observe the change events from CupsPrintersEntryManager. - Updated tests to reflect this change. Bug: 1009659 Test: End to end manual, browsertests Change-Id: I86f2a4d521de644a0fb4b5e3c01ef55e704642a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830292Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#705150}
-
Matt Jones authored
This patch allows users of the BottomSheetContent api to choose the height that their feature peeks at. Supplementing this change are a number of height modes that the new getPeekHeight can return; namely DEFAULT and DISABLED. These changes roll two existing methods into a single, generic one. All users of the api have been updated and tests have been added for the new functionality. Bug: 986310, 968246, 1012231, 1006029 Change-Id: Ia4b4c2c2839909c3c8f9da39b1b35283dd47eb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832603 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705149}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/106e86516480..9b33e3602340 git log 106e86516480..9b33e3602340 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-11 borenet@google.com [infra] Fix presubmit by pinning tools/build 2019-10-11 egdaniel@google.com Fix GL RGB format bytes per pixel. Created with: gclient setdep -r src/third_party/skia@9b33e3602340 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I8ee0d98e7ec38e5b36ce3abe342b930f3bd9f2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856274Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705148}
-
rbpotter authored
Initialize everything to available, so that we don't briefly expand more settings due to having <= 6 available settings between setting availability from document settings and setting availability from destination capabilities for PDFs. Bug: 1013045 Change-Id: Idbcaa78d433f314415425e6ebaf699122c6d7803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853824 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
Replace uses of content::ExecuteScriptAndExtractString() and variations with content::EvalJs(). The code looks smaller, simpler and easier to understand. Change-Id: I1ebac4f1084176d490487d548eec931021df5f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855979 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Joe DeBlasio authored
This CL downgrades the security icon of pages when a Safety Tip is available for the page. The updated icon is the generic (i) NONE icon. It now looks like this, even on secure sites: https://drive.google.com/file/d/1J0oWA4yue1ydYTNT0R_bIj-cLm7LNUXV/view?usp=sharing This CL also moves the Safety Tip UI feature flag to security_state's feature set. This change was necessary to read the feature from within components. Bug: 1004849 Change-Id: I892b3d0c12d13e04bd486f33ed686b1f7398795a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848413 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#705145}
-
Sebastien Marchand authored
This CL creates a new ChromeBrowserMainExtraParts derived class to own memory management related classes. This includes the new EnterpriseMemoryLimitPrefObserver, which tracks changes to the TotalResidentSetLimitMb enterprise policy and starts/stops the EnterpriseMemoryLimitEvaluator (which the PrefObserver owns) accordingly. Larger project documentation here: https://docs.google.com/document/d/1W3FPDyjIAKBcFGNYsHA3EKR1FHrJlbBaqT4_RUnxzq0/edit?ts=5d3f5714# This also disable the memory::MemoryPressureMonitor as it's not being used (we're using base::util::MemoryPressureMonitor). Bug: 980965 Change-Id: Iae632b6681d1574006d38fee9b38bf4d6e5545af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790290Reviewed-by:
-
Scott Violet authored
BUG=none TEST=covered by various layout tests Change-Id: Ie0fb73cf53fd7d8fb2716738e53d41c16f3536ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851387 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#705143}
-
Lei Zhang authored
PrintJobWorker::UpdatePrintSettings() is used for printing, but does not log any information in case of a crash. Add a ScopedPrinterInfo here to capture printer driver info for the duration of the call, so crashes in this code path can give more clues as to what is causing the crashes. Bug: 1013433 Change-Id: Ic6e1dab3cb40a70c408fb8a0a3c6d08601b24cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855298 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#705142}
-
Avi Drissman authored
A parameter was added to the code signing configuration in https://crrev.com/c/1834843, but was not added to the notarization entry point. This correctly adds the parameter to avoid parameters ending up in the wrong positions. BUG=913074 Change-Id: I1ac340ea682e62c2f22607b3238bba714d7d8604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856560Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705141}
-
Joe Mason authored
I linked my @google.com and @chromium.org accounts and it made the @chromium.org account the primary in gerrit, which is the opposite of what I intended. Change-Id: I2899702c7235a63914908de6257f637340026a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852984Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
Richard Knoll authored
Instead of showing the raw timestamp as a number, format it according to ISO8601. Example output: Show Trigger Timestamp: 2019-10-11T14:56:38.351Z This will always use UTC as timezone. Bug: 1004118 Change-Id: I1f6b3980915cf24dea2bc896400587aa4b55dccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855969Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705139}
-
Tatiana Buldina authored
Update ExecuteClearElement() to check element type and state and throw kInvalidElementState if they are incorrect Bug: chromedriver:3005 Change-Id: I0ee8a35767113b1a9dc9bee29687290ae7325161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832664Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#705138}
-
John Chen authored
Disabling the following two failing perf tests on Android webview: * blink_perf.canvas/putImageData.html * blink_perf.canvas/putImageData_RAF.html?RAF NOTRY=true TBR=crouleau@chromium.org Bug: 1013618 Change-Id: I622829a643b8ec6ea477956abb28e06bf7912f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856559Reviewed-by:
-
Martin Robinson authored
View text fields need to emit text changed signals when kValueChanged accessibility events are received. We do this by following the hypertext generation path for these nodes. Bug: 1012423 Change-Id: I64684d380c1f3f72d1dd20c044e087c1c237e7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852244Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
-
Shakti Sahu authored
In the original UX, each day consisted of multiple sections based on mime types. The image section had menu button allowing us to select the entire group and perform share or delete. This adds complexity to mutator and should be cleaned up. Bug: 1013196 Change-Id: I71cf4d8e42784b8013bbda5c97fb90792ef38f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852405Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f5952b718415..8f41e5d14063 git log f5952b718415..8f41e5d14063 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 treehugger-gerrit@google.com Merge "Fix conversion of 'print' events from the field" 2019-10-11 primiano@google.com Merge "CI: run install-build-deps also on bazel bot" Created with: gclient setdep -r src/third_party/perfetto@8f41e5d14063 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ifd59f7837ccdf852465794401121ef4bcb2b6926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855475Reviewed-by:
-
Ken Rockot authored
ScopedFeatureList is unsafe to use after browser threads have been started. This constraint will imminently be enforced by DCHECK to prevent further erroneous usage from landing. This CL corrects usage within miscellaneous Chrome feature tests, including Password Manager, payments, page load metrics, etc. This is split from a larger CL where in some rare cases, correction was too complex to resolve before landing the DCHECK, so corresponding test(s) may be disabled instead of fixed. Bug: 846380 Change-Id: Ic4944308327312038d1e92523ac1188530f54b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850732Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#705133}
-
Jan Wilken Dörrie authored
This change modifies the Touch To Fill trigger logic to respond to WebAutoFillClient's DidReceiveLeftMouseDownOrGestureTapInNode event. Furthermore, this change introduces a ShouldSuppressKeyboard method on PasswordAutofillAgent returning true iff Touch To Fill is currently shown. Bug: 1013131 Change-Id: Ic88d83594458b3a975cf1f7bea70e51f4a5e4bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856040Reviewed-by:
-
Hitoshi Yoshida authored
In general, IDL prohibits to use keywords as identifiers. But the spec defines some places; arguments, operation names, and attribute names. This CL makes our IDL parser to be more consistent with current spec, and also updates few IDL files that can be consistent with their specs with this change. Bug: 839389 Change-Id: I60802ae211c3dffd4e9f3a76ad5dd2a3910791a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855623Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#705131}
-
Shakti Sahu authored
This CL adds : 1 - Security icon and URL for the preview page 2 - Updates title of the page when navigated to another page Bug: 1007499 Change-Id: I069e57e545907b2000eaebe996392d72da40d6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844341Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
-
Michael Thiessen authored
This CL does three things: 1. It moves unrelated logic out of launchWebApkIfSoleIntentHandler() 2. It unifies the browser fallback URL handling path. 3. It avoids unnecessarily calling isValidWebApk on a lot of packages There is a functional change here: we no longer require an intent URL to specify a package for its fallback URL to be handled by a WebApk. (The package could have been any package, even unrelated to the WebApk) Bug: 1006927 Change-Id: I1dd4bf26e40706a37900377e280623aa5ae129fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837478Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#705129}
-
