- 23 Mar, 2020 40 commits
-
-
bttk authored
Bug: 1048429 Change-Id: Ib5b5ee1d07492eb30b754320f6527acd5cda60f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079255 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#752614}
-
David Grogan authored
A stretched item's pre-flex layout was getting a fixed cross size equal to the container's cross size, ignoring the item's min/max cross size. Bug: 845235 Change-Id: I8ff2c160f6ede952297ac4f114e954d8dcc5538e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113809 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#752613}
-
Caleb Rouleau authored
- Update the dialog image. - Update the arguments to match the new UI. - Add information about story tags. (To see how the markdown file will look, click the perf_trybots.md file link and then click the "gitiles" link next to the patchset number.) Bug: 1023451, 1059913 Change-Id: Ie019338f64d3fc0649cc7fd63d7a84bd29b756e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112579Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#752612}
-
Jing Wang authored
VK and PK are abbreviations which are ambiguous to readers outside our team, so rename them with full words. Rename zhuyinSelectionKeys to zhuyinSelectKeys to match the code in google3. Rearrange the sequence of properties, move all non-language-specific options to top and sort them alphabetically. InputMethodSettings have not been used in production code, so it is safe to rename these properties. Bug: 1060906 Change-Id: Idcf8eedcb1f7c3ee7d97f894599753a35fcd9179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114515Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752611}
-
Ben Pastene authored
Reverts crrev.com/c/2108826 + properly configures all internal builders to build with official & is_chrome_branded. Now that crrev.com/c/2107709 has landed, it should be safe to convert everything to the new flow. Bug: 937821 Change-Id: I32c1eedd0748e75e1074ce2944245532c98c263c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116390Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#752610}
-
Daniel Clark authored
This change assigns the proper ARIA roles and attributes to the time picker popup to ensure a good experience with screen readers. Prior to this change the hour/minute/AM-PM columns were read as monolithic chunks of numbers and the individual values were not selectable. Now the columns and cells have the proper ARIA roles, labels, and selection management so that the popup works smoothly with a screen reader. Bug: 1026544 Change-Id: Ifb16eceed8c4211537aee46cd4d09f771fea8635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088553Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#752609}
-
Lukasz Anforowicz authored
This CL tweaks tests that used RenderProcessHostWatcher to verify that a rendeer process gets terminated because of a bad mojo message. After this CL, such tests use RenderProcessHostBadMojoMessageWaiter that provides an additional verification of the exact error message. Bug: 797360 Change-Id: I2d99190b7c2d3192687cd2869c0a6443be775041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115700 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752608}
-
Tibor Goldschwendt authored
Supports showing the (preview) image of static and animated doodles as well as iframing interactive doodles on the WebUI NTP. Support for playing animated doodles, resizing interactive doodles, etc. will be added later. To support iframing the interactive doodle, this CL adds chrome-untrusted://new-tab-page/iframe?<src> which lets us iframe arbitrary pages into the WebUI NTP. The iframing works by embedding an iframe pointing to <src> into an chrome-untrusted page, which in turn is embedded into the WebUI NTP. This is necessary since we cannot directly embed external pages into the WebUI NTP. + Adds support for a fresh-doodle query parameter to wait for the fetched doodle instead of displaying the cached one. Useful for testing. + Fixes vertical arrangement of elements on the WebUI NTP. Bug: 1039910 Change-Id: I3791a20d392f3f8e8a6d36cec4c1e90f302fc04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109172 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#752607}
-
Brian Norris authored
We're changing the behavior here, to also grab the metric at startup: http://crrev.com/c/2111743 This shouldn't substantially change the nature of the metric, except that it will have more coverage. Bug: b:150971082 Change-Id: I3b41b03fbebed0661db84ace9c886255b3889a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113702Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Brian Norris <briannorris@chromium.org> Cr-Commit-Position: refs/heads/master@{#752606}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/01ed358917aa..10d9c49f23c8 git log 01ed358917aa..10d9c49f23c8 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@10d9c49f23c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ia2e9c0885680160715da60d4cbfdebab0ebe3346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116472Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752605}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/165b68ebb6ad..3c358420df4a git log 165b68ebb6ad..3c358420df4a --date=short --first-parent --format='%ad %ae %s' 2020-03-23 brianosman@google.com Support for custom vertex data in SkSL and drawVertices 2020-03-23 reed@google.com add loadF() and storeF() helpers to Builder 2020-03-23 egdaniel@google.com Add GrD3DCommandList class. 2020-03-23 brianosman@google.com Remove workaround for ANGLE + NVPR + Persistent Shader Cache 2020-03-23 robertphillips@google.com Revert "Make TessellationTestOp and GrPipelineDynamicStateTestOp surface their programInfos at record time" Created with: gclient setdep -r src/third_party/skia@3c358420df4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I97f954672973a1f1aeffd8302ae4fc7e931f56d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116699Reviewed-by:
-
Peter Kasting authored
This converts runtime checking of BUILDFLAG output to compile-time checking. It also converts NOTREACHED to DLOG(ERROR). Bug: 346399 Change-Id: I85dc2e655a1badccb117bb566f8812c6962416b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114400 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752603}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/31e36a631345..6fead3754375 git log 31e36a631345..6fead3754375 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 jmadill@chromium.org Vulkan: No-op redundant FB state changes. Created with: gclient setdep -r src/third_party/angle@6fead3754375 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I29c5ff323b1cef467c44972996de31b105ba81d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115929Reviewed-by:
-
David Van Cleve authored
EqualsForTesting was comparing ResourceRequest's trusted_params field to itself, rather than to the trusted params of the other being-compared-to request. Change-Id: I6e5b37a03e58303b2ccc75026bfd85612fba0907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116910 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#752601}
-
Brian Sheedy authored
This is a reland of e9f81dc4 Failures that caused the revert are semi-expected and only on a bot marked as experimental. Original change's description: > Switch Win Exp bot to 26.20.100.7870 > > Switches the GPU Win10 Intel experimental bot to trigger tests on > machins with driver 26.20.100.7870 to test the stability. > > TBR=ynovikov@chromium.org > > Bug: 1053803 > Change-Id: I3fa8467656312288add0658a3e4b7dfb9c5ac2d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111470 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751911} TBR=ynovikov@chromium.org Bug: 1053803 Change-Id: I9cd2367326cd9314434f0a4f34618e959b605b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115777Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#752600}
-
Nico Weber authored
Bug: 346399 Change-Id: Ie7c99842e8630c606f3bb135e83ed14ecac5d5d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116597 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752599}
-
Vasilii Sukhanov authored
Bug: 1049177 Change-Id: I42c3fce0c89859199d82db053fd899a2ed464e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115655 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#752598}
-
Sahel Sharify authored
This cl moves PayerData.java class into components/payments so that the WebPaymentIntentHelper.java class can use it without depending on chrome/browser. It also introduces a new Address class and its converter utility class so that PayerData.java does not depend on mojom.PaymentAddress. Change-Id: Idb737bc2697212af7542d3abbd1488461a7d3074 Bug: 1026667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110678 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752597}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9340f3aaa1e..abf84e73de6c Created with: gclient setdep -r src-internal@abf84e73de6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1016929,chromium:1063174 Tbr: jbudorick@google.com Change-Id: I9a1d10165b66e5299f627e5674de893db817497e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116471Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752596}
-
Clark DuVall authored
Bug: 1025609 Change-Id: Ie4aca6a905a1f6818faf09be00499e1986d16880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065413 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#752595}
-
Jinsuk Kim authored
Multiple ProfileDestroyers destroying a single Profile is sorted out in ProfileDestroyer::DestroyOffTheRecordProfileNow by the first destroyer nulling out the pointer to the Profile in the others so they won't destroy the same Profile again. It has a bug breaking out the loop after handling the first one. The right way is finding and nulling out all the Destroyers. This CL fixes it. Bug: 1029677 Change-Id: I7d8efe60a28613040e0a2afd9db0640ea3602c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113391 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#752594}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1dea10da0ae8..85201b613e63 git log 1dea10da0ae8..85201b613e63 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 rmhasan@google.com [Telemetry] Add SUPPORTED_PLATFORM_TAGS list to Benchmark class Created with: gclient setdep -r src/third_party/catapult@85201b613e63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:992603 Tbr: sadrul@google.com Change-Id: Iea388a40bbef3d402713836c0581640db9ef6ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116692Reviewed-by:
-
Mila Green authored
Bug: 1064059 Change-Id: Id8362f5f70f82a5732b32746a71e4131223923a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116593Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752592}
-
Emilio Cobos Álvarez authored
See https://github.com/WICG/construct-stylesheets/issues/62 for the rejected promise bit. On top of that we were not returning so we were incorrectly applying the styles. Bug: 1063809 Change-Id: I63aa937f66871e3b8eee577a7f2ddd873f45d2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116092 Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752591}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dcbd802564ed..3e74fb81116b git log dcbd802564ed..3e74fb81116b --date=short --first-parent --format='%ad %ae %s' 2020-03-23 thestig@chromium.org Disambiguate CFX_PathData::IsRect(). 2020-03-23 thestig@chromium.org Use more spans in CGdiplusExt::DrawPath(). 2020-03-23 thestig@chromium.org Remove manual memory allocation in CGdiplusExt::DrawPath(). 2020-03-23 thestig@chromium.org Remove some unneeded includes. 2020-03-21 nigi@chromium.org Fix rendering issue for PDFs with incorrect first-page hint data. Created with: gclient setdep -r src/third_party/pdfium@3e74fb81116b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1012237 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1876b21d517db9ba967b1a3e6ff1d8d8f52cff02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116693Reviewed-by:
-
Clark DuVall authored
Passing command line arguments now works with, for example: $ autoninja -C out/Release run_weblayer_shell $ out/Release/bin/run_weblayer_shell https://google.com \ --args='--weblayer-user-data-dir=/data/data/org.chromium.weblayer.shell/some_dir' Bug: 1063945 Change-Id: Iffdda53a56950f74dd58df63faa5cb8604988ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116598Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#752589}
-
Andrey Kosyakov authored
... originally regressed by https://chromium-review.googlesource.com/c/chromium/src/+/2107302 Bug: 1063506, 1059968 Change-Id: Id7fd285c9e5cf9a70981e34c4645f778fbf2899f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113801 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#752588}
-
Peter Kasting authored
Bug: 968222 Change-Id: I5c9a711686f6af8d550b33e18e7b9419e016d09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114406 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752587}
-
Adam Langley authored
This reverts commit aa1faf82, i.e. it relands fccf3a8f. (After thinking about structure padding and writing a comment, I forgot to actually handle it! Probably too complex anyway; do something dumber.) > Revert "Give the desktop a public key in QR handshakes." > > This reverts commit fccf3a8f. > > Reason for revert: > This CL breaks on Linux MSan bot > FidoCableDiscoveryTest.TestDiscoveryFindsNewAppleDevice > FidoCableDiscoveryTest.TestDiscoveryFindsIncorrectDevice > > First failure: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/22909 > > Original change's description: > > Give the desktop a public key in QR handshakes. > > > > This change switches the QR-based handshake from NNpsk0 to KNpsk0. I.e. > > it gives the desktop a public-key. That key is included in the QR code > > and means that an attacker who sees the QR code cannot impersonate the > > desktop and pair with the phone. (The other direction is still possible, > > however, and seems fundamental without the user entering a confirmation > > code on the desktop.) > > > > BUG=1002262 > > > > Change-Id: I7254a8aa17df71d2bcabb4371a1c18914ed20641 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109032 > > Commit-Queue: Adam Langley <agl@chromium.org> > > Auto-Submit: Adam Langley <agl@chromium.org> > > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > > Cr-Commit-Position: refs/heads/master@{#752196} > > TBR=agl@chromium.org,martinkr@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1002262 > Change-Id: Id75ad0bab2862b3dafe73d20cf762883cc24faf9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113771 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752403} BUG=10022628 Change-Id: I993eab544edd2eca6bc5c5923f9dab9b2d07c393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115799 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#752586}
-
Mikel Astiz authored
When the user goes through a reauth flow to retrieve trusted vault keys, the page should be closed upon completion. In order to achieve this, NavigateParams.created_with_opener is set to true, which allows Javascript on the page to close itself. In addition, the reuse of the NTP is disallowed because, in many relevant scenarios such as FRE, the NTP is the only existing tab and cannot be closed. As a fallback mechanism, a URL parameter is added to the reauth URL, in case the page decides to redirect instead of closing (or if closing the tab was rejected). Change-Id: I124ddd299c47a7c5705b410829a38130ea78e208 Bug: 1062977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108731 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#752585}
-
rbpotter authored
Bug: 1026426 Change-Id: I909df5d209fa574def562b572d5dcf4ad8c774e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113817 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#752584}
-
Wenbin Zhang authored
Refactoring work to make the process_perf_results cleaner. Bug: chromium:1045256 Change-Id: I8f5304364a111d5d7319cca7a297650af0ab721d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115698 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752583}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6e4869ebbb0c3cfbac28a29994c000601e6b8bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115797Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#752582}
-
Nico Weber authored
No behavior change. Bug: 346399 Change-Id: Ia658bb2a3ba42f7da364688691bd926bb0c0bbb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115783 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
John Lee authored
https://imgur.com/a/d54f4Ql Fixed: 1063811 Change-Id: I2cf58c15bbd9b5fe005c94e29e582acc3a32c829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116012Reviewed-by:
-
Steven Bennetts authored
For c/b/ui/ash/network OWNERS (will update in a followup): TBR=khorimoto@chromium.org Bug: 1054951 Change-Id: Ic24e51c04ca75a62a65bcdbfdba276580878dc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079131Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752579}
-
Robert Ma authored
No-Try: True Bug: 1062984 Change-Id: I26141a5bb5c53765c6cabbc30e09cd2de4b92f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115767 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
-
Tina Wang authored
chrome/browser/browser_process.h imports chrome/common/buildflags.h but doesn't include the target in BUILD.gn. chrome/test/base/testing_profile.h ditto. As the result, the files above maybe compiled before the buildflags.h is generated, which caused multiple flaky build failure. This CL added necessary target to deflake the build. TBR=sky@chromium.org Bug: 1063513 Change-Id: Ic3a74260351937382a9eabd32b9251d8d6057cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116591 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#752577}
-
Jeremy Apthorp authored
This removes logic in the MessagePort mojo handler that prevents MessagePorts from starving the message loop. This logic is redundant since https://chromium-review.googlesource.com/c/chromium/src/+/1145692. Change-Id: I379a8429675844837b5e51390cb803a288c2fe81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112954Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#752576}
-
danakj authored
The file contains one class and should represent the name of that class. R=nasko@chromium.org Bug: 866140 Change-Id: I7fe53fd31c593ac5053883480e2a274527d97542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113437 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#752575}
-
