- 11 May, 2018 40 commits
-
-
kylechar authored
VideoResourceUpdater currently uses LayerTreeFrameSink as the interface through which to notify the display compositor about shared bitmaps. This doesn't work UseSurfaceLayerForVideo where there is no LayerTreeFrameSink. Pull the two required functions out of LayerTreeFrameSink and into SharedBitmapReporter. LayerTreeFrameSink has SharedBitmapReporter as a subclass and doesn't implement the functions so nothing changes with regards to it. VideoResourceUpdater now takes a SharedBitmapReporter instead of a LayerTreeFrameSink. An implementation of SharedBitmapReporter that calls into mojom::CompositorFrameSinkPtr can be added trivially to support UseSurfaceLayerInVideo after this patch. Bug: 807840 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9a5a07140f8aa1614d1b647f3af1dd5d7aab2cd2 Reviewed-on: https://chromium-review.googlesource.com/1053054 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#558011}
-
Patrick Monette authored
The ModuleEventSink interface was bound on the UI thread, which caused cross-process IPC to retrieve information about a loaded module in the renderer process. A new sequence with background priority is instead used so that it doesn't impact startup. Bug: 832286 Change-Id: I5ab50bc45386c9a1ddb2888f80293d78bd768a88 Reviewed-on: https://chromium-review.googlesource.com/1037935Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#558010}
-
Aaron Leventhal authored
Fixes incorrect platform role mappings for IA2 and ATK. Adds the following new roles to Chrome: New landmark roles: docAcknowledgments, docAfterword, docAppendix, docBibliography, docChapter, docConclusion, docCredits, docEndnotes, docEpilogue, docErrata, docForeword, docGlossary, docIndex, docIntroduction, docPageList, docPart, docPreface, docPrologue, docToc Acts like a heading: docSubtitle Acts like a note: docTip, docNotice, docFootnote Acts like a section/region: docAbstract, docColophon, docCredit, docDedication, docEpigraph, docExample, docQna Acts like an image: docCover, graphicsSymbol Acts like a link: docBackLink, docBiblioRef, docNoteRef, docGlossRef Acts like a list item: docBiblioEntry, docEndnote, docFootnote Acts like a separator: docPageBreak Acts like a document: graphicsDocument Acts like a pane: graphicsObject Note: these are the internal names. In the role attribute used in HTML, the role names are lowercase and hyphenated with "doc-" or "graphics-" prefixes, e.g. “doc-endnotes”. More DPub info: Spec: https://www.w3.org/TR/dpub-aria-1.0/ Platform implementation notes: https://www.w3.org/TR/dpub-aam-1.0/#mapping_role_table More Graphics ARIA info: Spec: https://www.w3.org/TR/graphics-aria-1.0/ Platform implementation notes: https://rawgit.com/w3c/graphics-aam/master/#mapping_role_table NOTRY=true Bug: 812243, 839871 TBR: jcivelli@chromium.org,stevenjb@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If2d5ec8aca551cb1fb611cc3614f4f4617f958a9 Reviewed-on: https://chromium-review.googlesource.com/1044347 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#558009}
-
spqchan authored
A crash in the AutofillPopupControllerImplMac might be caused by checking the layout model to see if the popup is for a credit card. This CL potentially fix the issue by storing that value. Bug: 838660 Change-Id: I3bbe0b53139d4582313e4eabe91a42e6f3816f3e Reviewed-on: https://chromium-review.googlesource.com/1048969Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558008}
-
xlai authored
As this use case is too small to be worth the effort, we archive this task and modify comments. TBR=junov@chromium.org Bug: 683172 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic1f55ed6c5a8b7ae074f7e03b8c07fa1bc7a4815 Reviewed-on: https://chromium-review.googlesource.com/1055814 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#558007}
-
Wenzhao Zang authored
In |ReloadWallpaper|, the |current_wallpaper_| should be reset, however if the current wallpaper is the preview wallpaper, it's not available from |ShowUserWallpaper| yet because the preview wallpaper hasn't been set for the user. So we need some other ways to retrieve the image. Although we can remove the reset of |current_wallpaper_| for the preview case, in that way we lose the ability to resize the preview wallpaper based on the new display size (|current_wallpaper_| stores the image after resizing, but we need the original image to go through the resizing process again in order to show an accurate preview.) So creating another callback should be a better solution. Bug: 835349 Change-Id: I6a76646eacb99dae26867303647206d316275950 Reviewed-on: https://chromium-review.googlesource.com/1052686Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558006}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Bug: 841567 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9bca44365295cd5ca2d41175a87f8ef07952dedd Reviewed-on: https://chromium-review.googlesource.com/1055825 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558005}
-
Devlin authored
This reverts commit 1a6e52ab. Reason for revert: Re-enabled test is failing on Linux CrOS: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27415 [ RUN ] TabindexFocusDownloads/FileManagerBrowserTestWithLegacyEventDispatch.Test/0 [1570:1570:0511/120258.095371:WARNING:user_policy_manager_factory_chromeos.cc(207)] No policy loaded for known non-enterprise user [1570:1570:0511/120258.202042:WARNING:user_session_manager.cc(1096)] Attempting to save user password for non enterprise user. [1570:1570:0511/120300.805728:INFO:file_manager_browsertest_base.cc(632)] FileManagerBrowserTest::StartTest tabindexFocusDownloads [1570:1570:0511/120306.899468:INFO:CONSOLE(1169)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (1169) [1570:1570:0511/120306.921159:INFO:CONSOLE(5028)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5028) [1570:1570:0511/120306.988321:INFO:CONSOLE(4360)] "Waiting for the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4360) [1570:1570:0511/120307.027400:INFO:CONSOLE(5030)] "Volume list fetched with: 2 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5030) [1570:1570:0511/120307.030481:INFO:CONSOLE(5040)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5040) [1570:1570:0511/120307.036408:INFO:CONSOLE(5443)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5443) [1570:1570:0511/120307.107297:INFO:CONSOLE(5040)] "Initializing volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5040) [1570:1570:0511/120307.107935:INFO:CONSOLE(5443)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5443) [1570:1570:0511/120307.497407:INFO:CONSOLE(5491)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5491) [1570:1570:0511/120307.537188:INFO:CONSOLE(5044)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5044) [1570:1570:0511/120307.892689:INFO:CONSOLE(5491)] "File system obtained: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5491) [1570:1570:0511/120307.896753:INFO:CONSOLE(5044)] "Initialized volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5044) [1570:1570:0511/120307.897292:INFO:CONSOLE(5048)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5048) [1570:1570:0511/120307.965385:INFO:CONSOLE(4357)] "Received the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4357) [1570:1570:0511/120312.721349:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [1570:1570:0511/120312.837968:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161) [1570:1570:0511/120315.831155:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161) [1570:1570:0511/120318.719753:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161) [1570:1570:0511/120322.994251:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161) [1570:1570:0511/120324.716075:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161) [1570:1570:0511/120327.609187:INFO:CONSOLE(0)] "[SUCCESS] [tabindexFocusDownloads]", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0) [1570:1609:0511/120328.005035:WARNING:audio_sync_reader.cc(193)] AudioSyncReader::Read timed out, audio glitch count=10 [1570:1570:0511/120328.049612:ERROR:frame_sink_provider_impl.cc(34)] No RenderWidgetHost exists with id 3 in process 8 [1570:1570:0511/120328.049891:ERROR:frame_sink_provider_impl.cc(51)] No RenderWidgetHost exists with id 3 in process 8 [1570:1609:0511/120329.166852:WARNING:audio_sync_reader.cc(193)] AudioSyncReader::Read timed out, audio glitch count=20 [1570:1609:0511/120329.325388:WARNING:audio_sync_reader.cc(175)] ASR: No room in socket buffer.: Broken pipe (32) [1570:1570:0511/120329.451110:WARNING:event_router.cc(421)] Not all file watchers are removed. This can happen when the Files app is open during shutdown. [1570:1570:0511/120329.531088:FATAL:frame_sink_manager_impl.cc(58)] Check failed: sink_map_.empty(). #0 0x000000972721 (/b/s/w/ir/out/Release/browser_tests+0x972720) #1 0x00000f472f9c (/b/s/w/ir/out/Release/browser_tests+0xf472f9b) #2 0x00000f288153 (/b/s/w/ir/out/Release/browser_tests+0xf288152) #3 0x00001617a0e7 (/b/s/w/ir/out/Release/browser_tests+0x1617a0e6) #4 0x00001617a9ce (/b/s/w/ir/out/Release/browser_tests+0x1617a9cd) Original change's description: > Re-enable TabindexFocusDownloads/FileManagerBrowserTest > > Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. > > No-Presubmit: true > Tbr: fukino > Bug: 836254 > Change-Id: Ib9b497a92e1112a4061c6d863620b3ae07cfa252 > Reviewed-on: https://chromium-review.googlesource.com/1055252 > Commit-Queue: Noel Gordon <noel@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557884} TBR=noel@chromium.org,fukino@chromium.org,slangley@chromium.org Change-Id: I8b4ac33592cb5ff61a414416de04dea03f5d89da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836254 Reviewed-on: https://chromium-review.googlesource.com/1055216Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558004}
-
David Tseng authored
New gestures - tap4: opens ChromeVox menus to the most recent menu used - swipe up/down, left/right within menus: performs keyboard equivalents rather than ChromeVox commands. Feature Description When using a tablet, a user navigates the page using multi finger gestures or touch exploration. When the user wishes to navigate by a specific role, a four finger tap moves ChromeVox to the most recently used ChromeVox menu. For example, navigate to www.chromevox.com. A four finger tap brings the user to the headings menu. A single finger swipe right moves to the links menu. Single finger flick down moves to the feedback link. A double tap finally moves ChromeVox back to the page and places focus on the link. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I453079ffe9900955a63caf3156ef2bfbc9188410 Reviewed-on: https://chromium-review.googlesource.com/1054220 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
xlai authored
To avoid confusion TBR=zakerinasab@chromium.org Bug: None Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9f1b5412790672b2792d004840bcca2fbf44c997 Reviewed-on: https://chromium-review.googlesource.com/1055753 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#558002}
-
Xianzhu Wang authored
Every call site is already passing an integral size to GraphicsLayer:: SetSize() but had to convert it to FloatSize. Also even if non-integral size was allowed, the fractional part was discarded instead of being covered by expanded layer size: https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/graphics/graphics_layer.cc?rcl=8b66f9ce6dced8ecb247d89105008867a273c698&l=1018 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ieba3dd0f1857bf6e4f0430740deaa0885bdbe8b1 Reviewed-on: https://chromium-review.googlesource.com/1055605Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558001}
-
Kevin Bailey authored
Within the chrome://omnibox results page, adds a column that shows whether the match's URL matches an open tab, but only when 'Show all details' is selected. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9ac6e0cecf2e95593c863f4c762ba189c470d917 Reviewed-on: https://chromium-review.googlesource.com/1055619 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#558000}
-
Daniel Nicoara authored
Floating point rounding errors on ARM64 is causing a few pixel tests to have small variations from the base image. Define the fuzziness to have them pass. BUG=b:79372424 TEST=Ran cc_unittests on ARM64 device and verify they pass. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I47e7600313ea784723f1270ef7c6ea88e029e92c Reviewed-on: https://chromium-review.googlesource.com/1055820 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#557999}
-
Carlos IL authored
crrev.com/c/1055647 had an experiment name mixed up with the study name, fixing that. Change-Id: Id140d3aff38f2e96ae279651bcd3709cd4278114 Reviewed-on: https://chromium-review.googlesource.com/1055686Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#557998}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I30b80115ca4db9d23ecec6941f46b730e207bab5 Reviewed-on: https://chromium-review.googlesource.com/1055859 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557997}
-
CJ DiMeglio authored
This CL allows for the proper handling of context lost during video playback. Previously, if we lost the context while running video with cc::Surfaces enabled, we experienced a crash. With this CL, we request a new context_provider upon loss, and prevent frame submission until it is regained. The effect of this is that we seamlessly continue video playback once the context_provider is regained. Bug: 768565 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I503cacd01c0a819408e813109e5e2e03c673dd13 Reviewed-on: https://chromium-review.googlesource.com/1050801Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#557996}
-
Caleb Rouleau authored
Also upload chromedriver symbols to symbol server. Also add PRESUBMIT for FILES.cfg to prevent syntax errors like I made last time. Also fix the overall chromium PRESUBMIT to not try to run a PRESUBMIT_test.py that doesn't exist. (This was regressed by https://chromium-review.googlesource.com/c/chromium/src/+/966906 and then partially fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1015976 ) It was hitting this line: https://cs.chromium.org/chromium/tools/depot_tools/presubmit_canned_checks.py?q=%22files,+found+none+that+matched%22&sq=package:chromium&dr=C&l=511 "Out of %d files, found none that matched w=%r, b=%r in directory %s" Bug: 835950 Change-Id: I365204bb87e6f642c12ee03a646b28d28cc4abab Reviewed-on: https://chromium-review.googlesource.com/1054967Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#557995}
-
Sadrul Habib Chowdhury authored
Add a couple of investigative dumps to understand better where and how a large number of LatencyInfo objects are accumulating. BUG=834421 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ieea6e47c4a1acf5c89384048e19b742e3e21e5a8 Reviewed-on: https://chromium-review.googlesource.com/1054153Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#557994}
-
Ryan Sleevi authored
The hardcoded list of CT logs is only safe for clients that support regular updates and the capability of rapid updates, such as Google Chrome. Hardcoding a list log logs in products that are not regularly updated runs the risk of ossifying or fragmenting the CT ecosystem. To avoid accidental misuse, move from //net into //components/certificate_transparency, moving it further away from the notion as a "base service" and more into "an optional component with caveats". BUG=702062 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6be05436a916779bd5c8fcf7fe93b120bda47828 Reviewed-on: https://chromium-review.googlesource.com/1052073 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Eran Messeri <eranm@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557993}
-
Sadrul Habib Chowdhury authored
Add a speculative fix in SurfaceAggregator::Aggregate() to make sure it doesn't accumulate too many LatencyInfo objects. BUG=834421 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifd41d901050a954279b642cab972ca6ec6d560e2 Reviewed-on: https://chromium-review.googlesource.com/1053793Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
Nico Weber authored
Currently, generate_library_loader generates an #include line looking like: #include "out/Debug/gen/library_loaders/libudev1.h" Since this contains the (variable) name of the build dir, these files can't be cached by goma. Instead, rely on the header always being next to the cc file in practice (and add a check enforcing that), and use: #include "libudev1.h" Similarly, use LIBRARY_LOADER_LIBUDEV1_H_DLOPEN instead of LIBRARY_LOADER_OUT_DEBUG_GEN_LIBRARY_LOADERS_LIBUDEV1_H_DLOPEN as guard macro name. No intended behavior change. Bug: none Change-Id: I90dfe365e07ecc7df22d48f7ae05bc525d665dd5 Reviewed-on: https://chromium-review.googlesource.com/1054523Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#557991}
-
https://webrtc.googlesource.com/src.git/+log/e72ea24d884b..739351d4760f $ git log e72ea24d8..739351d47 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2fe1d778182bed4ef5596876ff48e07f9c1f6756 Reviewed-on: https://chromium-review.googlesource.com/1055471Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557990}
-
Ella Ge authored
Turn blink runtime_enable_feature flags to stable; Removes content_feature flags used for finch trial; Makes related histogram as obselete. intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/l5PCVakcOCE Bug: 805650, 625198 Change-Id: I873a77f98670f5f293b20a1b3a4373ace93027db Reviewed-on: https://chromium-review.googlesource.com/978626Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#557989}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b6e96e16f364..1d2e7600b0b4 $ git log b6e96e16f..1d2e7600b --date=short --no-merges --format='%ad %ae %s' 2018-05-11 eyaich Adding --smoke_test_mode to telemetry to not repeat stories Created with: roll-dep src/third_party/catapult BUG=chromium:840427 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Iee4ae15aea0c7dc2e76c18f19f21cdcff03624c8 Reviewed-on: https://chromium-review.googlesource.com/1055800 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557988}
-
Nico Weber authored
The nacl browser_test failures on Win7 that caused the last revert are fixed. There's a known bug about this regressing binary size (crbug.com/838449), but with in-progress patches binary size will soon be 200 kB smaller and these should all be rolled in by branch point, so let's reland this to find more unknown unknowns. Original change's description: > win: Link with lld instead of MSVC's link.exe by default > > lld is LLVM's linker. It produces PE/COFF and PDB files just like > link.exe, but it's significantly faster and it can also handle LLVM's > internal representation, which will enable us to do link-time > optimization and control-flow integraty checks with Clang. > > While lld is much faster at linking, it doesn't support incremental > links, meaning builds that only touch a few files and re-link a large > executable may become slower. > > This is the first attempt at switching everything over, with the > purpose of gathering data and finding unknown unknowns. It's likely > temporary until something breaks. > > is_win_fastlink is implicitly ignored when using lld, as lld without > fastlink is faster than link.exe with it. > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's > link.exe to make sure that configuration keeps working. > > Bug: 792131 Change-Id: I18aba7a66c54c87092a13745f0ca213171ec25db Reviewed-on: https://chromium-review.googlesource.com/1054521 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#557987}
-
François Beaufort authored
Intent to Experiment: https://groups.google.com/a/chromium.org/d/msg/blink-dev/xQiDYZEnwaA/MNGbYJnaBwAJ Bug: 806249 Change-Id: I0828e52221100f6b6ae576304650466bfdd79188 Reviewed-on: https://chromium-review.googlesource.com/1047671 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#557986}
-
Weiliang Chen authored
For single tile mask layers |visible_rect| is only used as bool to check for non empty. For tiled mask layers correct |visible_rect| is needed to limit the amount of resource we generated for raster the tiled masks. This bug was discovered when we have a tiled mask layer with big scale and we try to create tiles to covered enlarged space and eventually OOM. Compute |visible_rect| correctly results in breaking the assumption that tiled mask layer's |to_target| is only a scale. This changes the computation in |RenderSurfaceImpl| of how to convert tile quads into tiled mask render pass quads. This CL is aimed to fix release blocking bug and thus has limited scoped. There are two potential follow-ups: check for scale of tiled mask layer, and adjust render surface rect. For scale check: ideally tiled mask layer should be in the same space as the render surface, this should simplify computation when converting from tiled quads to render pass quads. For render surface rect: it does not make sense for render surface to have different size than the mask layer's visible rect. Right now render surfaces are unclipped and bounded by maxium texture size, while tiled mask visible size is clipped. To make these two sizes match there needs more investigation into whether unit tests still make sense, and should be in another CL. R=danakj Bug: 820727 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I62c7c992d99088c1f8cdbe4ffbac520b0a7d1a53 Reviewed-on: https://chromium-review.googlesource.com/1037629 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
Rational: if bad canary is pushed, causing build failures, CQ would false reject ~13% of CLs (and on retry, CL is highly likely to land). How is 13% figure obtained? Monte-carlo simulation of 1M CLs! def simulate_cl(builders=31, canary=0.1, max_retry_total=3): """True means OK, False means CQ falsely rejects CL.""" import random bad = sum(random.random() < canary for _ in xrange(builders)) if bad > max_retry_total: return False still_fail = sum(random.random() < canary for _ in xrange(bad)) return still_fail == 0 def monte_carlo_cq_false_rejection_rate(times=10**6, **kwargs): fp = float(sum(simulate_cl(**kwargs) is False for _ in xrange(times)) * 100.0) / times return '%0.1f%% false rejection rate' % fp monte_carlo_cq_false_rejection_rate(builders=31, canary=0.01, max_retry_total=3) # '0.3% false rejection rate' monte_carlo_cq_false_rejection_rate(builders=31, canary=0.05, max_retry_total=3) # '12.8% false rejection rate' monte_carlo_cq_false_rejection_rate(builders=31, canary=0.10, max_retry_total=3) # '49.5% false rejection rate' R=nodir@chromium.org No-Try: True Change-Id: I04bbdbb50bbeb0e9aea70fd5ca8aa89fd22d3fcf Reviewed-on: https://chromium-review.googlesource.com/1045501Reviewed-by:Nodir Turakulov <nodir@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557984}
-
James Cook authored
The touch HUD mojo app is a new way to support the "Show taps" ash UI feature. Previously it only worked with out-of-process ash ("mash") but we're getting it working with in-process ash ("classic"). This CL adds support for the touch hud app to the ash_shell_with_content executable, which is used by developers to work on ash without building chrome. Introduce --show-taps-app so it can run without turning on ash's built-in touch hud impl. Make the app open its window on startup so it can run without the mash:launchable mojo interface, similar to quick launch. This avoids //mash dependencies. Introduce a constant for "touch_hud_app". TODO: Remove the launchable interface from touch_hud_app entirely Bug: 840380 Test: ash_shell_with_content --show-taps-app opens a window Change-Id: Ief7433e61916025c1dff349142ea9802a7238963 Reviewed-on: https://chromium-review.googlesource.com/1055208Reviewed-by:Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#557983}
-
Devlin Cronin authored
[Sheriff] Update crashy test virtual/enable_wasm/external/wpt/wasm/wasm_indexeddb_test.https.html on MSAN Tbr: tmartino@chromium.org No-Try: True Bug: 842262 Change-Id: I92323428b9a035d7789711038454a97d6c8b90ad Reviewed-on: https://chromium-review.googlesource.com/1055847Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
-
Nico Weber authored
No intended behavior change. Bug: none Change-Id: I1191d7dd55108a4ae9fdab19ee299bf6c6c08ec2 Reviewed-on: https://chromium-review.googlesource.com/1055749Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#557981}
-
Mike Dougherty authored
Bug: 817810 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0b8847322c6cae9d53421a7778b1852e8a1a0a43 Reviewed-on: https://chromium-review.googlesource.com/1055802 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#557980}
-
Xiyuan Xia authored
Bug: 817995 Change-Id: I305739b830ad9c628f6adc88ca930adccc4bfeea Reviewed-on: https://chromium-review.googlesource.com/1054219Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557979}
-
François Beaufort authored
This makes sure enterpictureinpicture and leavepictureinpicture events are fired when user enters and leaves Picture-in-Picture from native video controls. Bug: 806249 Change-Id: I8d8717ce6fa97c3882913e73d8599cede6ec92dc Reviewed-on: https://chromium-review.googlesource.com/1029951 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
jonross authored
There had ben a series of Mac testing failures tracked by issue 817827, 817830. These have been fixed, so re-enabling the tests. TBR=fsamuel@chromium.org TEST=viz_browser_tests, viz_content_browsertests Bug: 760181 Change-Id: I4df4a3cdb659a4226dcd9b2a3e174bf41e064052 Reviewed-on: https://chromium-review.googlesource.com/1055664Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#557977}
-
Christos Froussios authored
The feature is now fully rolled out. Bug: 838789 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icdd315779899230fe78b7d90a17680736722a2ea Reviewed-on: https://chromium-review.googlesource.com/1047867 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#557976}
-
Bence Béky authored
This change was made possible by https://crrev.com/c/1028984, which left chromium as the only directory in //net/spdy. This change is not git cl formatted, and presubmit checks are skipped (there are pre-existing presubmit errors), because this is only a move. NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I670e6e7204870a78d738b7e2fe18569b6c8f0264 Reviewed-on: https://chromium-review.googlesource.com/1054470Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557975}
-
bill.2714 authored
This CL updates Daum related url to the newest. 'search_url' adds 'w' and 'DA' param to recognize this url is from chrome omnibox. This will be used for handling abuse control, redirect issues and serving extra options for users from chrome omnibox. 'search_url' deletes 'ie' param which no longer valid. The domain for 'suggest_url' has changed and older url no longer valid, updated to the newest. R=pkasting@chromium.org, vasilii@chromium.org Change-Id: Ib60e54b5e29c0d84493174fc43e4c4efb84f0363 Reviewed-on: https://chromium-review.googlesource.com/1025544 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#557974}
-
mark a. foltz authored
Replaces usages of content::PresentationInfo with blink::mojom::PresentationInfo. There should be no change in behavior. The presentation ID length check in the typemap is moved to PresentationServiceImpl. Presentation IDs are always generated by the browser and a too-long ID is a bug. Bug: 817903 Change-Id: I6518abbab6d8b6f24925f1fb649a150b08221622 Reviewed-on: https://chromium-review.googlesource.com/1026987Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557973}
-
Weidong Guo authored
AppListPresenterDelegateHomeLauncherTest.BackgroundOpacity and BackgroundBlur are flaky because IsBackgroundBlurEnabled() saves feature flag in static variable. Changes: Remove static variable. BUG=842027 Change-Id: I26c056ee72bac8490ca8a7b0b2555b90594b4980 Reviewed-on: https://chromium-review.googlesource.com/1055793Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#557972}
-
