- 07 Sep, 2018 40 commits
-
-
Andrew Grieve authored
Change-Id: I111afe4c1cd7c0c152333d678c22dc9eb284adf3 Reviewed-on: https://chromium-review.googlesource.com/1205805 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589523}
-
Reilly Grant authored
This takes a hint from r588692 and moves ownership of the ProxyingURLLoaderFactory objects a user data object that hangs off of the content::ResourceContext. This prevents these objects from outliving this object on the IO thread. The previous ownership model was open to a race condition between the destruction of the BrowserContext keyed service ProxyingURLLoaderFactoryManager on the UI thread and the tasks posted to the IO thread to destroy each ProxyingURLLoaderFactory. These would be scheduled after the task to destroy the ResourceContext. Change-Id: I600b1604526b644c3ac9e010d1cb82f4b3740925 Reviewed-on: https://chromium-review.googlesource.com/1211913Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589522}
-
Roger McFarlane authored
This CL turns on deletion of disused address and credit card data. This data has already been suppressed (i.e., not suggested) for the last two quarters. As a result of this CL: * Address data will be deleted 13 months after last use (it stops being suggested 6 months after last use). * Local credit card data is deleted 13 months after the later of expiry or last use; it stops being suggested 6 months after expiry/last use). Cards coming from Google Pay stop being synced 12 months after expiry. Their lifetime is independent of this CL. Bug: 868406 Change-Id: I6113f6f96e7854b8684e3258f372c91475aa96a8 Reviewed-on: https://chromium-review.googlesource.com/1101168 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589521}
-
Nico Weber authored
Update Windows Deterministic whitelist after https://chromium-review.googlesource.com/c/chromium/tools/build/+/1185911 Like https://chromium-review.googlesource.com/1194469 but for Windows. Most of them are due to v8_context_snapshot.bin. Bug: 330260 Change-Id: I01b2194d3a64269f6332bc36b2783fdcc5749de0 Reviewed-on: https://chromium-review.googlesource.com/1213524Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589520}
-
Nico Weber authored
Merges the contents of an always-true block with the contents one scope up. There were several if (is_win) etc blocks at that scope; merge these too. No intended behavior change. Bug: 832676 Change-Id: I89ecdec3babec570c631714001edb71cfb1cca66 Reviewed-on: https://chromium-review.googlesource.com/1213522Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589519}
-
Markus Heintz authored
Change-Id: I759941dd004f4cd72966a268bb383a64b2932fec Reviewed-on: https://chromium-review.googlesource.com/1206336Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589518}
-
Tanja Gornak authored
Bug: 880204, 801985 Change-Id: Iefce8533a32ba4d77961cee9d42845503b25c839 Reviewed-on: https://chromium-review.googlesource.com/1203833 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#589517}
-
Miguel Casas authored
The original CL was reverted bc it caused a gn gen --check problem -- I assumed this was checked somewhere in our CQ :-( Anyways, fixed: //components/viz/service/main:main used the removed dependency to use //media/gpu{:buildflags,:vaapi}, so these are added explicitly. gn gen --check passes locally now w/ the diffs: crrev.com/c/1208418/2..11 TBR=rsesek@ for services/viz/privileged/interfaces/gl/gpu_service.mojom and lhchavez@ for components/arc/common/BUILD.gn (since there are no new changes in this CL re those files). Original CL ---------------------------------------------------------- Do not use components/arc/common in non CrOs builds I found that (at least win) bots are using components/arc/common stuff (see e.g. [1]), when this are supposed to be limited to CrOs. This CL corrects that by sandwiching the appropriate BUILD entries between if(is_chromeos). [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936282730877054816/+/steps/compile/0/stdout /BUILD.gn mojom(media) Bug: 732531 Change-Id: Ie870b0ccb90216b9b455a25f34761a03d5a13b16 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1208410Reviewed-by:Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589056} Reviewed-on: https://chromium-review.googlesource.com/1208418 Cr-Commit-Position: refs/heads/master@{#589516}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c61b09bf..157216ad Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifc151c1d799359e93dd79c2b20540c30c4a9289c Reviewed-on: https://chromium-review.googlesource.com/1212749Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589515}
-
Raphael Kubo da Costa authored
Supplementing LocalFrame causes the same SensorProviderProxy to be used across navigations, and so is the connection to the actual sensor provider via mojo. Making SensorProviderProxy supplement Document also helps with testing: as described in the related bug, running a manual test (which does not use sensor mocks) and then a regular test causes the latter to fail because we never establish a connection to the mock we need, but rather try to use an actual sensor that is not present. Bug: 861675 Change-Id: Ic3d2ea42f5b4654ba5ef42b6ad757a49d3e5ef08 Reviewed-on: https://chromium-review.googlesource.com/1160161Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#589514}
-
Mohsen Izadi authored
It replaces content::GpuDataManagerImpl::DomainGuilt and viz::GpuHostImpl::Delegate::DomainGuilt. BUG=709332 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5a802e53ec770835954b77ba62e9fe9920377381 Reviewed-on: https://chromium-review.googlesource.com/1201704Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589513}
-
Mike West authored
Apparently this makes a big difference to the cookie settings backend. Bug: 881715 Change-Id: Id87fa0c6a858bae6a3f8fff4d6af3f974b00d5e4 Reviewed-on: https://chromium-review.googlesource.com/1212846 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#589512}
-
Fredrik Söderquist authored
When the 'transform' presentation attribute (or CSS property) was mutated on a <clipPath>, its clients were not notified. Make sure they are. Bug: 881700 Change-Id: Id42aedf814472d8156804a955e6bbf2aa2792ec2 Reviewed-on: https://chromium-review.googlesource.com/1213142Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589511}
-
Markus Heintz authored
This reverts commit 303d77a1. Reason for revert: Did not fix the issue Original change's description: > Revert "Add UnencodableHandling::kNoUnencodables" > > This reverts commit b4edab24. > > Reason for revert: > > Webkit tests on Android nx4 are failing since: > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29/82322 > > speculative revert (sorry) since this is the only CL in the blame list realted to text encoding and the error says: > > " > UnicodeDecodeError raised: 'ascii' codec can't decode byte 0xe2 in position 146896: ordinal not in range(128) > ... > " > > Original change's description: > > Add UnencodableHandling::kNoUnencodables > > > > The are no unencodable characters in UTF-8, however previously callers > > to blink::TextCoder::Encode had to pass a dummy UnencodableHandling > > argument. Add a kNoUnencodables value to the UnencodableHandling which is > > an explicit no-op. Also add DCHECKs that is is only used for UTF-8 or > > UTF-16. > > > > Convert callers to use kNoUnencodables where the encoding is statically > > known to be UTF-8. > > > > It's still valid to use other values for the UnencodableHandling > > argument with UTF-8 or UTF-16; kNoUnencodables simply documents that it > > makes no difference. > > > > Change-Id: I5eebe4c76ae4006ee91f3884f94ec3b5e410685b > > Reviewed-on: https://chromium-review.googlesource.com/1206055 > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Joshua Bell <jsbell@chromium.org> > > Commit-Queue: Adam Rice <ricea@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#589451} > > TBR=jsbell@chromium.org,ricea@chromium.org,yhirano@chromium.org,haraken@chromium.org > > Change-Id: Iaddd13dc7e2fe9473528710dcdaf080f50d01ecc > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/1213085 > Reviewed-by: Markus Heintz <markusheintz@chromium.org> > Commit-Queue: Markus Heintz <markusheintz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589501} TBR=jsbell@chromium.org,ricea@chromium.org,markusheintz@chromium.org,yhirano@chromium.org,haraken@chromium.org Change-Id: I51221bfefd2e5d9505b05615ab38e5b1602e2fdf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1213172Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589510}
-
Anna Malova authored
Remove the dynamic module interface defined in the Chromium repository in favor of the copy pulled in via DEPS and updates the build files correspondingly. Bug: 873098 Change-Id: Ic8b38906eceb7f9bf46ed9c95e5d7e3dd82b8e5e Reviewed-on: https://chromium-review.googlesource.com/1172427 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#589509}
-
Jérôme Lebel authored
When unified consent flag is enabled, the settings link in the sign-in dialog should open the Google services settings (instead of the sync settings). This patch adds the code to open the Google services settings when the settings dialog is already opened and when the settings dialog is not opened. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I560a959d49f983943ec8d39e421ba28b8992e448 Reviewed-on: https://chromium-review.googlesource.com/1196519 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#589508}
-
Vaclav Brozek authored
As described in the associated bug, the |layout| data member of |PasswordForm| contributes less benefit than it causes complexity. It is not used in the new FormData -> PasswordForm parser, and this CL also remvoes it from the old one, as well as removing all related code. Bug: 852772 Change-Id: Icdc6979a9c0a57093a459f2dfc2e27766f9e9142 Reviewed-on: https://chromium-review.googlesource.com/1209582Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589507}
-
Raphael Kubo da Costa authored
The test was originally crashing with DCHECKs enabled, but it no longer seems to do that according to the flakiness dashboard. TBR=foolip Bug: 762017 Change-Id: I1a67b94ff5fef93906ae471d49341d59d51fcb78 Reviewed-on: https://chromium-review.googlesource.com/1213165Reviewed-by:
Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#589506}
-
Benoit Lize authored
Bug: 877044 Change-Id: I6b3e7be16ade21bd9c511a6a4fda10930575efa4 Reviewed-on: https://chromium-review.googlesource.com/1210782 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#589505}
-
Jeremy Roman authored
This is a final attempt to flush out any recursive acquisition before support is totally removed for WTF::RecursiveMutex. For pthreads, this requires maintaining the recursion_count_ variable even in non-DCHECK builds. This is still quite cheap, and is temporary in any case. Bug: 856641 Change-Id: I2b550fd58e8c4cf6293ad7628dd49aa366b41ae9 Reviewed-on: https://chromium-review.googlesource.com/1212453Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#589504}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 44b7822b. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24208 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4fef3ca36c31ed9310d909a74ed437bc49f806f5 Reviewed-on: https://chromium-review.googlesource.com/1212748 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589503}
-
Hugo Holgersson authored
Scenario for bug: 1. The focused element F is inside a scrollable area A. 2. F is offscreen (=clipped) but A is (partly) visible. Problem: Spatnav started to search from the document's edge, not from A's edge. Solution: Set the "search origin" to one of A's outer edges. To solve this problem we redefine the "search origin" of spatial navigation. The search origin is either activeElement itself, if it's being at least partially visible, or its first [partially] visible scroller. If both F and its enclosing scroller A are completely offscreen, we recurse to the scroller’s scroller up until the root frame's document. The root document is a good base case because it's, per definition, a visible scrollable area. This builds onto the idea of: https://chromium-review.googlesource.com/c/chromium/src/+/873645 Bug: 804669 Change-Id: I15b0f41426d7632fe9ec62d77a414d592e3631c0 Reviewed-on: https://chromium-review.googlesource.com/883533 Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589502}
-
Markus Heintz authored
This reverts commit b4edab24. Reason for revert: Webkit tests on Android nx4 are failing since: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29/82322 speculative revert (sorry) since this is the only CL in the blame list realted to text encoding and the error says: " UnicodeDecodeError raised: 'ascii' codec can't decode byte 0xe2 in position 146896: ordinal not in range(128) ... " Original change's description: > Add UnencodableHandling::kNoUnencodables > > The are no unencodable characters in UTF-8, however previously callers > to blink::TextCoder::Encode had to pass a dummy UnencodableHandling > argument. Add a kNoUnencodables value to the UnencodableHandling which is > an explicit no-op. Also add DCHECKs that is is only used for UTF-8 or > UTF-16. > > Convert callers to use kNoUnencodables where the encoding is statically > known to be UTF-8. > > It's still valid to use other values for the UnencodableHandling > argument with UTF-8 or UTF-16; kNoUnencodables simply documents that it > makes no difference. > > Change-Id: I5eebe4c76ae4006ee91f3884f94ec3b5e410685b > Reviewed-on: https://chromium-review.googlesource.com/1206055 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Commit-Queue: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589451} TBR=jsbell@chromium.org,ricea@chromium.org,yhirano@chromium.org,haraken@chromium.org Change-Id: Iaddd13dc7e2fe9473528710dcdaf080f50d01ecc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1213085Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589501}
-
Dominik Röttsches authored
This reverts commit 5bc5a4c5. Reason for revert: Test passes only flakily on Linux Original change's description: > Connect Linux Font Unique Name Lookup to Blink > > Provide a new subclass for font unique name lookup for Linux. Connect > via WebSandboxSupport to FontLoader which provides the out of process > fontconfig calls for us. Tested by content_browsertests with a DevTools > based test checking used fonts. This test was previously active on > Android and is enabled for Linux in this CL. > > Bug: 880832 > Change-Id: I04d72fc1cfcfa55a01a9877ac8a3a45dbff38771 > Reviewed-on: https://chromium-review.googlesource.com/1206337 > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589482} TBR=dgozman@chromium.org,eae@chromium.org,drott@chromium.org Change-Id: I811960048b2f37130e4be4cb9c693dc90040f30d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880832 Reviewed-on: https://chromium-review.googlesource.com/1213168Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#589500}
-
Roman Kuksin authored
This is a reland of ebe80ad0 Original change's description: > Wait for ukm entry in TryAutoplay > > The test fails due to a race of UkmRecorder::AddEntry with DOMMessageQueue::Observe: > https://cs.chromium.org/chromium/src/services/metrics/public/cpp/delegating_ukm_recorder.cc?q=src/services/metrics/public/cpp/delegating_ukm_recorder.cc&sq=package:chromium&g=0&l=137 > > Bug: 880217 > Change-Id: Icf099c3eb1094d8a571dc6f87b152e3c838807dc > Reviewed-on: https://chromium-review.googlesource.com/1204011 > Reviewed-by: Tommi <tommi@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Steven Holte <holte@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589317} Bug: 880217 Change-Id: I6c5cd4107f74f3102b6bd491323a6ab68f56f911 Reviewed-on: https://chromium-review.googlesource.com/1212802Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589499}
-
Jan Wilken Doerrie authored
This change implements selecting a service revision to FidoBleConnection. This is mandated by the CTAP spec when the fidoServiceRevisionBitfield characteristic is present. Furthermore, this change simplifies FidoBleConnection's interface by dropping the unused ReadServiceRevisions() and WriteServiceRevision() APIs. Appropriate tests are added. Bug: 880053 Change-Id: I35f6b39be9f90e7c668f5714f6cc26830966ae1c Reviewed-on: https://chromium-review.googlesource.com/1204013Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#589498}
-
Markus Heintz authored
This reverts commit 92df23c1. Reason for revert: Failure size on mac_rel https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-rel/546 speculative revert due to: HINT: To get this list, run tools/mac/show_mod_init_func.py # HINT: diff against the log from the last run to see what changed /b/s/w/ir/cache/builder/src/out/Release/Chromium Framework.unstripped 0x0000000001fe9410 @ _GLOBAL__sub_I_mime_handler_view_frame_container.cc (in Chromium Framework.unstripped) (mime_handler_view_frame_container.cc:0) Original change's description: > Implement MimeHandlerViewFrameController > > This CL implements the renderer side of MimeHandlerView based on > cross-process frames (behind a flag). > > The new subclass of MimeHandlerViewContainerBase will use a content > frame inside a plugin element for loading the MimeHandlerViewGuest's > extension. > > The current implementation is not complete and the missing features > such as postMessage support will be added in the follow-up CLs. > > This CL also introduces a new class of parametric browser tests > (MimeHandlerViewCrossProcessTest) which will be the destination of > the current MimeHandlerViewTests as more features are integrated into > the frame-based version. The new test class runs the test on both > BrowserPlugin-based and cross-process-frame-based versions. > > Document: https://docs.google.com/document/d/10g7Y9cprYKkch9JZ0TBUWaEnHBJT1nzhskQIt1nHbWM/edit#heading=h.qw81a2bk3v6w > > Bug: 659750 > TBR=thestig@chromium.org > > Change-Id: Ia69aeed47f4fa1c7f5b81cdde71a8d8b5ff59165 > Reviewed-on: https://chromium-review.googlesource.com/1187231 > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589284} TBR=lazyboy@chromium.org,thestig@chromium.org,sammc@chromium.org,alexmos@chromium.org,ekaramad@chromium.org,wjmaclean@chromium.org Change-Id: Ice96f16404a1026693a72425535929bd883264fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 659750 Reviewed-on: https://chromium-review.googlesource.com/1213148Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589497}
-
Mugdha Lakhani authored
This adds the following metric: BackgroundFetch.RatioOfIdealToChosenIconSize Bug: 877512 Change-Id: Id4289b13178ca9e3bd76e1ea9371f778788b5699 Reviewed-on: https://chromium-review.googlesource.com/1199591 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#589496}
-
Rob Buis authored
Add negative tests to SignedExchangeUtils unit test to test how we deal with questionable/wrong content types. Bug: 803774 Change-Id: If726951a4fb96506251ad7fd1ac26a6940174e6c Reviewed-on: https://chromium-review.googlesource.com/1203995Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#589495}
-
Arthur Hemery authored
To be able to completely get rid of pending_navigation_params_ we need to get rid of the same_document dependency on it. It is currently used to store common and request params in CommitSameDocumentNavigation, to later create a new state in DidFinishSameDocumentNavigation. We now imitate what we did for cross-document navigations, pass down to the loader the navigation information. An issue with this is that same-document navigations only update NavigationState. The structure used for now is only accessible in content. To blink it is an opaque structure. This means that for now, we just carry the structure all the way back to DidFinishSameDocumentNavigation. This adds a lot of boilerplate code but will probably be completely stateless when we have an adequate structure residing in the loader. Bug: 789577 Change-Id: If872abf20477ee6bdf42053781a2a9077960fe6c Reviewed-on: https://chromium-review.googlesource.com/1186406Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#589494}
-
Kouhei Ueno authored
This CL prepares for measuring PageLoadMetrics for pages loaded through SignedExchange. This CL adds |NavigationHandle::IsSignedExchangeInnerResponse()| getter, which can be used to distinguish signed exchange navigations. The getter will be used in the following CL to selectively enable the signed exchange page load metrics observer for recording drill-down UMAs. Bug: 863305 Change-Id: Ia3bad8d6c9daeef237879538fb8999b7f3df4a46 Reviewed-on: https://chromium-review.googlesource.com/1212375Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#589493}
-
momohatt authored
This patch adds pause_when_not_identical option for making ServiceWorkerCacheWriter::MaybeWriteData() return before writing the new body into the storage when the scripts are not identical. This option is necessary for extending byte-for-byte update check of service worker importScripts() resources. Bug: 648295 Change-Id: If33412cd6e63393ad3fdae514b1588a33f17399a Reviewed-on: https://chromium-review.googlesource.com/1198651 Commit-Queue: Momoko Hattori <momohatt@google.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#589492}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/104cb056..c61b09bf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I86e3dd9cc1d015cf16053a5a68572af779e17593 Reviewed-on: https://chromium-review.googlesource.com/1212747Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589491}
-
Mathias Bynens authored
This is an ECMAScript feature, implemented in V8. Proposal repository: https://github.com/tc39/proposal-global Intent to ship: https://groups.google.com/d/msg/v8-users/Vkoh0wXRwaM/Yt7MpzhkAgAJ Bug: v8:5537 Change-Id: Id322937a8368a952178a8e9049e514b4f64549d4 Reviewed-on: https://chromium-review.googlesource.com/1210803 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#589490}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/30d7c2688aa9..cfe528ef2d04 git log 30d7c2688aa9..cfe528ef2d04 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 fmayer@google.com Merge "Fix incorrect references to libprotobuf in comments." Created with: gclient setdep -r src/third_party/perfetto@cfe528ef2d04 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4e7270177ae234aaa61d6a5f6295fa42841305c4 Reviewed-on: https://chromium-review.googlesource.com/1213043Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589489}
-
Eric Seckler authored
Updates prerender and safe browsing browser tests to initialize the SafeBrowsingDatabaseManager after BrowserThreads were created (but before they are started). This is required for the upcoming move of BrowserThread::PostTask to base/task/post_task.h, as construction of SafeBrowsingDatabaseManager obtains a TaskRunner for the IO thread. In the future, this has to happen after thread initialization. Bug: 878356 Change-Id: I1d4c614690ba3aacf4887fefe57d378c23668706 Reviewed-on: https://chromium-review.googlesource.com/1211735Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#589488}
-
Friedrich Horschig authored
Currently, the DeferredViewStubInflationProvider will accept null as view stub and try to inflate the non-existent stub much later. To prevent this deferred NullPointerException, assert that used stubs are never null. Fix the usage that uncovered that issue. Bug: 876215 Change-Id: I51deb6aaa1ac3d3283e6794c0cae37c536b43aa5 Reviewed-on: https://chromium-review.googlesource.com/1210783Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589487}
-
Elad Alon authored
Add a comment warning against changing WebRtcEventLogManager- related strings which may be relied upon by web-apps. Bug: 775415 Change-Id: I7717d87437c72756ed2a2ecda61d9abb30a6a778 Reviewed-on: https://chromium-review.googlesource.com/1212943Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#589486}
-
yoshiki iguchi authored
This is reland of crrev.com/c/1206551 after fixing the memory leak (crrev.com/c/1208694). The diff is completely same as the previous CL. The previous CL had been reverted due to the ASAN failure (see. crbug.com/880227). [Original description] The feature is not launched on M70. This CL should be merged to M70 branch as well. TBR: yamaguchi@chromium.org TBR: oshima@chromium.org Bug: 880227 Change-Id: Id0ca9b5ee488130d7fb0c414b4a9522117d462dd Reviewed-on: https://chromium-review.googlesource.com/1212902Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#589485}
-
Hayato Ito authored
This is in preparation for https://chromium-review.googlesource.com/c/chromium/src/+/1205924, so we don't need to do forward declarataion for template definitions in NodeTraversal and any other traversals. Bug: 880052 Change-Id: Ie2decfb0763f4dfe3f85cace21601c893f263563 Reviewed-on: https://chromium-review.googlesource.com/1212374Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#589484}
-