GitLab

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2319373004
Cr-Commit-Position: refs/heads/master@{#417377}

When a tab that a dialog controller is associated with gets moved to another
window, we need to allow the dialog controller to update its reference to the
toolbar action (associated with a window). This fixes the bug in which the
icon gets pressed in a wrong window.

The comment for SetMediaRouterAction() is also updated, as it is okay for the
action to be null, and we expect it to become null when it gets removed from
the toolbar.

BUG=644972

Review-Url: https://codereview.chromium.org/2321163002
Cr-Commit-Position: refs/heads/master@{#417376}

https://pdfium.googlesource.com/pdfium.git/+log/d827111fb10c..a31da74cffa8

$ git log d827111fb..a31da74cf --date=short --no-merges --format='%ad %ae %s'
2016-09-08 tsepez Pass CFX_WideString further down widget callers
2016-09-08 tsepez Remove unused context parameter from JSGetStringFromID
2016-09-08 tsepez Replace CJS_Runtime::Observer with CFX_Runtime<CJS_Runtime>::Observer

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2326683002
Cr-Commit-Position: refs/heads/master@{#417375}

ANGLE still uses GYP for a standalone build. Until we switch to full
GN (not currently being worked on) we need this script for all of our
build files.

BUG=605987

Review-Url: https://codereview.chromium.org/2320743002
Cr-Commit-Position: refs/heads/master@{#417374}

Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to
fix download request limiter test for renderer-initiated case in
PlzNavigate.

R=clamy@chromium.org, dominickn@chromium.org
BUG=510836

Review-Url: https://codereview.chromium.org/2319733002
Cr-Commit-Position: refs/heads/master@{#417373}

Keeps track of scripts injected by extensions installed. Checks if a script is
already injected, and injects a script only if it has not been injected.

BUG=248627, 631247
TEST= Run target browser_tests with
--gtest_filter="ExtensionApiTest.ContentScript*"

Committed: https://crrev.com/90d8dd145246616da02f5a54f1da1f5bfe6680e9
Review-Url: https://codereview.chromium.org/2213603002
Cr-Original-Commit-Position: refs/heads/master@{#407016}
Cr-Commit-Position: refs/heads/master@{#417372}

BUG=

Review-Url: https://codereview.chromium.org/2320003002
Cr-Commit-Position: refs/heads/master@{#417371}

Discussion resulted in zero-ish cases where this would be useful.

BUG=644848

Review-Url: https://codereview.chromium.org/2328703002
Cr-Commit-Position: refs/heads/master@{#417370}

BUG=644050

Review-Url: https://codereview.chromium.org/2316303004
Cr-Commit-Position: refs/heads/master@{#417369}

This CL removes the implementation of -[TabView mouseUp:] which should never be
called, since -[TabView mouseDown:] always triggers a nested run loop that
swallows the -[TabView mouseUp:] event. There's an AppKit bug that -[TabView
mouseUp:] on inappropriate views, so it's doubly important that the
implementation not do anything.

BUG=511095

Review-Url: https://codereview.chromium.org/2314873004
Cr-Commit-Position: refs/heads/master@{#417368}

https://chromium.googlesource.com/skia.git/+log/4cea3b9e9d98..85c922acec37

$ git log 4cea3b9e9..85c922ace --date=short --no-merges --format='%ad %ae %s'
2016-09-08 msarett Revert of Checking for valid colorType, alphaType, colorSpace in SkCodec (patchset #2 id:100001 of https://codereview.chromium.org/2319293003/ )
2016-09-08 msarett Checking for valid colorType, alphaType, colorSpace in SkCodec
2016-09-08 brianosman Cache the inverse matrix on SkColorSpace. Rename xyz() to toXYZ().
2016-09-08 mtklein GN: add a helper script for running Android builds

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2328543003
Cr-Commit-Position: refs/heads/master@{#417367}

This change:
1) Introduces color_utils::ImplicitAlphaBlend, which does an alpha
   blend using the alpha of the foreground color;
2) Introduces a NativeTheme color ID for the shading of a pressed
   button;
3) Uses ImplicitAlphaBlend to blend that shade, instead of calling
   into PlatformStyle;
4) Deletes PlatformStyle::BackgroundColorForMdButton

BUG=644543

Review-Url: https://codereview.chromium.org/2319313003
Cr-Commit-Position: refs/heads/master@{#417366}

Use of a wall clock to drive an animation is dangerous. We should be using the monotinic time.

BUG=645098

Review-Url: https://codereview.chromium.org/2326643002
Cr-Commit-Position: refs/heads/master@{#417365}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/1f827fb3b6b4ce5185228c00ddbbe0fe53a12fa8 Canary seems to be working, bump actual LogDog. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:643243

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2324653004
Cr-Commit-Position: refs/heads/master@{#417364}

BUG=639467

Review-Url: https://codereview.chromium.org/2319533003
Cr-Commit-Position: refs/heads/master@{#417363}

media_recorder_handler: Changed deprecated ScopedVector to std::vector, and introduced emplace_back().

This CL is a code refactoring, no new code added.

R=mcasas@chromium.org
BUG=643714
TEST=all content_browsertests passing.

Review-Url: https://codereview.chromium.org/2314403003
Cr-Commit-Position: refs/heads/master@{#417362}

BUG=635948
NOPRESUBMIT=true (for protocol.json)

Review-Url: https://codereview.chromium.org/2295913003
Cr-Commit-Position: refs/heads/master@{#417361}

Review-Url: https://codereview.chromium.org/2317273003
Cr-Commit-Position: refs/heads/master@{#417360}

This object hooks into existing data saver code to track savings based
on host, data used, and original size of the data.

BUG=615565

Review-Url: https://codereview.chromium.org/2257533003
Cr-Commit-Position: refs/heads/master@{#417359}

refactored codebase accordingly. This is the first step towards achieving
the "Don't use so many inner classes for NetLog" cleanup ticket, which
seeks to make the codebase more "Include what you use" clean.

There are many "net/log/net_log.h" includes in the codebase. Since 'net_log.h'
has many includes itself, this leaves the codebase susceptible to the
undesirable scenario where clients of 'net_log.h' could be relying upon
'net_log.h' not for its contents but its inner includes.

Extracting NetLog's inner classes into their own files will help with the
above issue. For instance, once these inner NetLog classes are extracted:
ThreadSafeObserver, Entry, EntryData, NetLog enum types, then
ThreadSafeObserver clients will not need to include "net_log.h".

Here are a couple historical notes:

1) In refactoring "NetLog::TYPE_SSL_PRIVATE_KEY_OPERATION" to
"NetLogEventType::SSL_PRIVATE_KEY_OPERATION", the removal of "TYPE_" from
"TYPE_SSL_PRIVATE_KEY_OPERATION" created a compiler error when compiling
an ssl-based object file because it turns out that SSL_PRIVATE_KEY_OPERATION
is a macro definition in the ssl translation unit; this resulted in
a macro collision. To resolve, "NetLogEventType::SSL_PRIVATE_KEY_OPERATION"
was changed to "NetLogEventType::SSL_PRIVATE_KEY_OP".
    - There aren't any dependencies in the [netlog viewer] code
       that depend on the old naming so this should be fine.

2) The new enum classes, as opposed to enums, made it so that
[NetLogEnumClass]::LABEL needed to be statically cast to int at times.
-e.g.- In NetLog::GetEventTypesAsValue()'s for loop to
       iterate through all enums.
       - Also had to do this in 2 or 3 instances outside of net_log.cc.

BUG=473710
R=eroman@chromium.org,tfarina@chromium.org
TBR=asargent@chromium.org,thestig@chromium.org,bengr@chromium.org,avi@chromium.org,zea@chromium.org,rohitrao@chromium.org,sergeyu@chromium.org,mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2315613002
Cr-Commit-Position: refs/heads/master@{#417358}

It's weird to have a perf test for BSP tree stuff in the same file
as perf tests for CalcDrawProps.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2320883002
Cr-Commit-Position: refs/heads/master@{#417357}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/328391fbc1e3..8917fb02c5d6

$ git log 328391fbc..8917fb02c --date=short --no-merges --format='%ad %ae %s'
2016-09-08 benjhayden Move unit_scale.html from value to base

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2321103003
Cr-Commit-Position: refs/heads/master@{#417356}

|dns_resolution_end_time_| is still used in other histograms
(e.g. Net.QuicServerInfo.DiskCacheWaitForDataReadyTime and
Net.QuicSession.HostResolution.HandshakeConfirmedTime).

The initialization is removed in crrev.com/2256803002. This CL adds it back
to maintain correctness of the remaining histograms which are still using this
field.

R=zhongyi@chromium.org

BUG=629384, 637051

Review-Url: https://codereview.chromium.org/2314403006
Cr-Commit-Position: refs/heads/master@{#417355}

As the ability for the user to avoid the displaying of mixed content
was recently removed the respective Blink setting didn't need to exist
anymore. This change removes it and also updates tests and other
dependencies.

BUG=631525

Review-Url: https://codereview.chromium.org/2278303002
Cr-Commit-Position: refs/heads/master@{#417354}

BUG=644894
TBR=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2321073003
Cr-Commit-Position: refs/heads/master@{#417353}

BUG=643549

Review-Url: https://codereview.chromium.org/2321853002
Cr-Commit-Position: refs/heads/master@{#417352}

This patch adds necessary offset when accessing this array.
`constraint_flags` is an array of 6 elements, however in
`for` loop it can be accessed with indices from 4 to 9
instead of indices from 0 to 5.

Review-Url: https://codereview.chromium.org/2320063002
Cr-Commit-Position: refs/heads/master@{#417351}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/395b994270c26b85198b4ab921880d21b6fc4d9d Fix "chromium.infra" LogDog canarying. (dnj@chromium.org)
  https://crrev.com/156cd97e26e5aaca148b26fcf70371e30eac4ebf DevTools: Add devtools for tryserver.chromium.linux (chenwilliam@chromium.org)
  https://crrev.com/44ac4f64965b436b43201bfe7e359f73ec073b82 Updating the low end bots to a vm that triggers the job. (eyaich@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:643243,642046,chromium:633253

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2322773003
Cr-Commit-Position: refs/heads/master@{#417350}

After three years, the obsolete tables are probably gone for good.

Review-Url: https://codereview.chromium.org/2318833003
Cr-Commit-Position: refs/heads/master@{#417349}

TBR=phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2326623002
Cr-Commit-Position: refs/heads/master@{#417348}

BUG=645099
TBR=dgozman

Review-Url: https://codereview.chromium.org/2324873002
Cr-Commit-Position: refs/heads/master@{#417347}

https://pdfium.googlesource.com/pdfium.git/+log/8c2a8cda1bdb..d827111fb10c

$ git log 8c2a8cda1..d827111fb --date=short --no-merges --format='%ad %ae %s'
2016-09-08 dsinclair Switch to ValueOrDie
2016-09-08 weili Fix leaks in class CFGAS_FontMgrImp

BUG=637984

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2324833003
Cr-Commit-Position: refs/heads/master@{#417346}

BUG=644050

Review-Url: https://codereview.chromium.org/2323753002
Cr-Commit-Position: refs/heads/master@{#417345}

It turns out creating a Channel paused is not good enough; we actually
need to be able to send some messages, then pause, send more messages,
unpause, send even more messages, and then flush.

This is because of subtleties in how RPHI handles queuing. It queues
messages before the Channel is created, then there is a brief period
between Channel creation and process launch where messages aren't
queued but are sent immediately (but previously queued messages remain
in queue), and then new messages are queued again during process
launch, and finally queueing is turned off after process launch.

This changes Channel to have an explicit Pause() API and gets rid
of the recently added ConnectPaused().

BUG=612500

Review-Url: https://codereview.chromium.org/2316963005
Cr-Commit-Position: refs/heads/master@{#417344}

Native heap profiler traces on Linux are sometimes incomplete because unwinder
hits a function from a system library (i.e. no frame pointers), finds bad stack
frame and stops.

This CL implements stack scanning, so instead of stopping unwinder scans stack
for a valid frame pointer and resumes unwinding.

BUG=624362

Review-Url: https://codereview.chromium.org/2276813002
Cr-Commit-Position: refs/heads/master@{#417343}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/fb935b70f5e0d69ce628d6df2aa4045efc3d60b7 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/aa76eb0516a28e78126869200f820fd3548b8f22 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/73baf8534877e82eb7c4e96aba0f122e39f6e2ee Update gclient test to assert both dir and url (agable@chromium.org)
  https://crrev.com/dce6ddcd21d71688aed5fd10b7cb1216275639ef Propagate use_relative_paths into recursedeps (agable@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2327563002
Cr-Commit-Position: refs/heads/master@{#417342}

BUG=610521

Review-Url: https://codereview.chromium.org/2316493006
Cr-Commit-Position: refs/heads/master@{#417341}

https://chromium.googlesource.com/skia.git/+log/2b3c2a3ff916..4cea3b9e9d98

$ git log 2b3c2a3ff..4cea3b9e9 --date=short --no-merges --format='%ad %ae %s'
2016-09-08 brianosman Push usage of GrColor4f into OverrideInput
2016-09-08 mtklein most is fine for *SAN bots now
2016-09-08 ethannicholas removed const from ASTVarDeclaration::fName to avoid a Chromium build failure GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2325673002
2016-09-08 mtklein Clean up target_os=llvm now that it does nothing.
2016-09-08 robertphillips Add GM/slide to simulate Android-style reveal clip
2016-09-08 halcanary Tests: DiscardableMemory test no longer relies on global state
2016-09-08 mtklein SkLiteDL: drawAsLayer()

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2324843002
Cr-Commit-Position: refs/heads/master@{#417340}

This change:
1) Reflects the window controls horizontally for RTL
2) Reflects the profile switcher horizontally for RTL
3) Adjusts the left and right indents for the tabstrip itself to account for
   those reflections

BUG=642732

Review-Url: https://codereview.chromium.org/2313723004
Cr-Commit-Position: refs/heads/master@{#417339}

Revert of [Fetch API] Start reading blob only when the reader wants to read contents. (patchset #3 id:40001 of https://codereview.chromium.org/2303753003/ )

Reason for revert:
Speculative revert: this patch is a suspect to cause Linux MSAN failures:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12091

The other suspected patch, the only one related to canvas, was reverted and didn't help.

Original issue's description:
> [Fetch API] Start reading blob only when the reader wants to read contents.
>
> BUG=643174
>
> Committed: https://crrev.com/f1ca96c413912ff1768e4274b8b7ac78eb41de64
> Cr-Commit-Position: refs/heads/master@{#416923}

TBR=hiroshige@chromium.org,jkarlin@chromium.org,yhirano@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=643174

Review-Url: https://codereview.chromium.org/2319093004
Cr-Commit-Position: refs/heads/master@{#417338}