- 14 Nov, 2018 40 commits
-
-
Shu Chen authored
Bug: 859432 Change-Id: I320f388acd90ed40d7343d9954ab067cadde15b6 Reviewed-on: https://chromium-review.googlesource.com/c/1335051Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607951}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Change-Id: I57c17eaa6add94d6defe8fea4e24c70bcb20af0b Reviewed-on: https://chromium-review.googlesource.com/c/1329165 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#607950}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87927acfcf75..cbbca2b41db2 Created with: gclient setdep -r src-internal@cbbca2b41db2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia95c5529310d51beffe037e8fce42f118947f9f8 Reviewed-on: https://chromium-review.googlesource.com/c/1335100Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607949}
-
Arthur Sonzogni authored
Disabled tests: NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_RespondWithFetch NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_PassThrough NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_NoFetchHandler TBR=shimazu@chromium.org Bug: 889855 Change-Id: Ibbeb9faaf6d5d1657d893bf4d4c825045b1f0cbf Reviewed-on: https://chromium-review.googlesource.com/c/1335587Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607948}
-
Rune Lillesveen authored
Better overflow handling for CSSPrimitiveValue::Create. Bug: 904872 Change-Id: Ieafc28406497b4a676994efdc6515959549a7ba1 Reviewed-on: https://chromium-review.googlesource.com/c/1335527Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#607947}
-
Clemens Arbesser authored
[Autofill Assistant] Changed autofill assistant payment request section order to: contact details -> shipping -> payment. Also removed the first section separator according to our mocks. The chrome feature WEB_PAYMENTS_METHOD_SECTION_ORDER_V2 is now disabled for autofill assistant payment PR. Bug: 806868 Change-Id: I52ed027192b145e50fb22c65fd50cfb5272d0fd2 Reviewed-on: https://chromium-review.googlesource.com/c/1333776 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607946}
-
Clemens Arbesser authored
before: https://screenshot.googleplex.com/je17gMxXPRX.png after: https://screenshot.googleplex.com/AQnyPSA2bs1.png Bug: 806868 Change-Id: Ia8b79c667d6b50a9f689d68831c1e6e29b3324c6 Reviewed-on: https://chromium-review.googlesource.com/c/1333777 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Matthew Cary authored
Obsolete and flaky tests for the disabled classical prerender are removed. This test also adds an ignored ExpectedContents to prevent a race condition in the test when a PrerenderContents final status may be checked before or after the test tears itself down. Bug: 903695 Change-Id: Ia77b3beb79bf579ca1904c54e469f0de4b648f94 Reviewed-on: https://chromium-review.googlesource.com/c/1333779 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607944}
-
Heng-Ruey Hsu authored
SetUpStreamsAndBuffers may be called twice when enabling blob stream. For the second call, kPreview stream already exists. Also reset repeating_request_settings_ in StopPreview. BUG=chromium:900900 TEST=./capture_unittest --gtest_filter="*VideoCaptureDeviceTests/*" Pass TakePhoto cases with DCHECK enabled. Change-Id: Iac89964b95e7d14f592c779f11a92ef46dba930e Reviewed-on: https://chromium-review.googlesource.com/c/1332974Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607943}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2dcaf264b69f..87927acfcf75 Created with: gclient setdep -r src-internal@87927acfcf75 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2470afa4e57c756d014b208044eb8e3720d2a128 Reviewed-on: https://chromium-review.googlesource.com/c/1335099Reviewed-by:
-
Stuart Langley authored
Analytics was disabled some time ago, and we want to remove this from the files app. Start with media upload flow. - Mark as obsolete UMA's that we no longer record (they stopped being recorded some time ago). - Add UMAs to replace the metrics that were being recorded using analytics. - Fix some of the noise in the unit tests. - Remove some of the analytics events dead code. Bug: 847729 Change-Id: Ic501553e6967aa401d9b3fcc5cd2c56024756d10 Reviewed-on: https://chromium-review.googlesource.com/c/1328062 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#607941}
-
Matthew Cary authored
Remove droger@ who is no longer on the team, and add lizeb@ to keep a minimum of three people involved. Change-Id: Ic6f28a106a679058dc74d65afc07475edbe251c8 TBR: pasko@chromium.org,lizeb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1335467Reviewed-by:
Matthew Cary <mattcary@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#607940}
-
Hiroshige Hayashizaki authored
This CL - Introduces CreateOutsideSettingsFetcher() that will be used in https://chromium-review.googlesource.com/1328164 - Extends pause/unpause mechanism that has been implemented for existing (insideSettings) ResourceFetcher to cover ResourceFetchers created by CreateOutsideSettingsFetcher(). This CL shouldn't change the behavior. Bug: 880027 Change-Id: Ifa21b4d31f6d01fa7a9021410d5aa95a7bbf0a78 Reviewed-on: https://chromium-review.googlesource.com/c/1328043 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#607939}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b6a0ca7f448..2dcaf264b69f Created with: gclient setdep -r src-internal@2dcaf264b69f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I93d0b3bb197105ee52fdd13c6cb45d2437e752e1 Reviewed-on: https://chromium-review.googlesource.com/c/1335098Reviewed-by:
-
Hajime Hoshi authored
google::Symbolize is not thread-safe since it manipulats a proc file without locks. This CL makes ProcessBacktrace thread-safe by base::Lock. Bug: 904743 Change-Id: I12eb0f27158f39baa9683d74c98f4defdf0449f1 Reviewed-on: https://chromium-review.googlesource.com/c/1329814Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607937}
-
Alexander Timin authored
MessageLoop is going away and this diagnosis metric will need to be re-evaluated. For the record, this metric's latest values were: Median 99th'ile Note Windows Stable : 37 448 >50% of users hit 500+ >=1 times a day Windows Canary: 37 258 >50% of users hit 250+ >=1 times a day Android Stable: 28 113 >50% of users hit 65+ >= 1 times a day Android Dev: 28 149 >50% of users hit 86+ >=1 times a day R=gab@chromium.org BUG=860801,891670 Change-Id: Ib45c47286a2a9153827bc4f6e71c7d056e90a5f0 Reviewed-on: https://chromium-review.googlesource.com/c/1333752Reviewed-by: -
Luciano Pacheco authored
Files app dialogs (file picker / save as) aren't opened by background page, thus they didn't get the IN_TEST state forwarded to them. This CL changes Files app background to attach IN_TEST to the dialog during dialog registration. This happens before the UI initialization. This fixes the issue where test functions can't use test-only attributes to select elements in the page, for example when trying to use |navigateWithDirectoryTree| which relies on |full-path-for-testing| attribute. Bug: 903669 Change-Id: I8ad19965cddbc6bd6779c9c6f2710872b830754c Reviewed-on: https://chromium-review.googlesource.com/c/1334992Reviewed-by:
-
John Z Wu authored
Change-Id: Ia0537fad5c80cb07382234853951305b3c340a2d Reviewed-on: https://chromium-review.googlesource.com/c/1333116Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#607934}
-
Christopher Lam authored
As a temporary measure, make System PWAs update on every Chrome launch. This allows developers to see changes when they update manifests. This will be replaced with a lighter, more robust system before consumer launch. Bug: 836128 Change-Id: I82febcd9b0f7ae5f8be401bdedbe4846008562f4 Reviewed-on: https://chromium-review.googlesource.com/c/1325595Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#607933}
-
Yuki Shiino authored
This reverts commit 305d9733. Reason for revert: This patch seems like causing failure at: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6429 webkit_layout_tests on (none) GPU on Mac Run on OS: 'Mac-10.13' Max shard duration: 0:23:45.917961 (shard #11) Min shard duration: 0:18:50.330065 (shard #6) Total tests: 88255 * Passed: 74827 (74757 expected, 70 unexpected) * Skipped: 10735 (10735 expected, 0 unexpected) * Failed: 2536 (2533 expected, >>>3 unexpected<<<) * Flaky: 157 (157 expected, 0 unexpected) Unexpected Failures: * media/controls/volume-slider.html * virtual/new-remote-playback-pipeline/media/controls/volume-slider.html * virtual/video-surface-layer/media/controls/volume-slider.html See also: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75687 Original change's description: > [Media Controls] Show volume slider only if user hover mute button for a while (200ms) > > Bug: 904554 > Change-Id: I3026b7c47df4f3950450b5fd721ae84bab00e382 > Reviewed-on: https://chromium-review.googlesource.com/c/1332718 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Jazz Xu <jazzhsu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607790} TBR=steimel@chromium.org,jazzhsu@chromium.org Change-Id: I56471b2879938b9a5d6f142d6a812e0d175bf6a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904554 Reviewed-on: https://chromium-review.googlesource.com/c/1334993 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#607932}
-
Marina Ciocea authored
On some pulse audio configs, creating a new pulse audio context requires creating /run/user/$UID/pulse directory and subsequent files in this path. Bug: 903929,903788 Change-Id: I7cf018a30428e024480c0215f4a17a85dfa826c2 Reviewed-on: https://chromium-review.googlesource.com/c/1331467Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#607931}
-
Noel Gordon authored
CL:841962 added the paste-into-current-folder gear-menu command, but no keyboard shortcut was provided (M65). Add a Ctrl+V shortcut to the #paste-into-current-folder <command> so it is displayed in the gear-menu. The #paste <command> has the same shortcut. So if a user clicks Ctrl+V, would both commands execute? Manual testing showed that Ctrl+V executes the #paste command only. Automatic tests cover keyboard (copy) Ctrl+C then (paste) Ctrl+V case: KeyboardOperations/FilesApp*keyboardCopyDownloads KeyboardOperations/FilesApp*keyboardCopyDrive Automatic tests cover gear-menu #paste-into-current-folder use: GearMenu/FilesApp*showPasteIntoCurrentFolder Bug: 875109 Change-Id: Iec2a98ae0b31ccbe1d2518c6d4c4e8edd7e02a2d Reviewed-on: https://chromium-review.googlesource.com/c/1331352Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
-
Khushal authored
We currently make an implict assumption that the caller will restore the underlying context state in GetContextState, which seems like a brittle assumption. Make sure we only do it in RestoreState. R=piman@chromium.org Change-Id: If436feb21d80ece2181e1af291e078ef59e30736 Reviewed-on: https://chromium-review.googlesource.com/c/1327219 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#607929}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a0014775d3f..0b6a0ca7f448 Created with: gclient setdep -r src-internal@0b6a0ca7f448 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6a716035df5a16c69599a12c76a7e040a49a5fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1335097Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ccc31e9e3220..b45b53f01cf3 git log ccc31e9e3220..b45b53f01cf3 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-11-14 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@b45b53f01cf3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Idb7e8482c2bda4ab19435f8d165f65315511ca6c Reviewed-on: https://chromium-review.googlesource.com/c/1335096Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607927}
-
Tarun Bansal authored
Add understats metrics for first contentful paint (FCP) broken down by page scheme. This CL adds metrics that record if FCP value was less than certain threshold or not. For background infomation on understats see slide 20 of http://shortn/_d9oDk4unEX. Bug: 883445 Change-Id: I7a657960755c055ab1f2bcdbcf6f9754e78ea8a8 Reviewed-on: https://chromium-review.googlesource.com/c/1328230 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#607926}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bfc52536. With Chromium commits locally applied on WPT: 39c398ad "Worklet: Modernize service worker interception tests for worklets using async/await" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: emircan@chromium.org: external/wpt/screen-capture NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I41121b13929bea66d8f522748ab98552eb6c1f7a Reviewed-on: https://chromium-review.googlesource.com/c/1335275 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607925}
-
Kelvin Jiang authored
Show recent extension activities by making a call to chrome.activityLogPrivate.getExtensionActivities whenever the user navigates to the activity log page. Currently, the activity type, api call, event count and page url (if there is one) are shown in descending order of event count. Note: the activity log database can sometimes store more than one entry that has the same api call/event type. This CL currently does not group any duplicate activity entries. Bug: 832354 Change-Id: I0191d77cd7961bdc5d95ec8daea98d39b1a7c638 Reviewed-on: https://chromium-review.googlesource.com/c/1321166 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607924}
-
Gyuyoung Kim authored
Call LowerASCII() instead of DeprecatedLower().Ascii() because we've been using after converting to ASCII(). Bug: 627682 Change-Id: I93315ec3ff51da0ae62dcdd13beddffed4b369fc Reviewed-on: https://chromium-review.googlesource.com/c/1335050Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#607923}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd90e943..666bded3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iefc8c7374eac244676964468e01a9e42e3ebbe05 Reviewed-on: https://chromium-review.googlesource.com/c/1335031Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607922}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I512bde6955d2d2d35e2d856207ecd2806d6e6fab Reviewed-on: https://chromium-review.googlesource.com/c/1334674 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#607921}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/890400d12a0a..2a0014775d3f Created with: gclient setdep -r src-internal@2a0014775d3f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic32483982664f6a6304bad8e84c16d4c024c0588 Reviewed-on: https://chromium-review.googlesource.com/c/1335095Reviewed-by:
-
Findit authored
This reverts commit 9f695d72. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 607896 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOWY2OTVkNzI0OWM5MjZkZGRlODUxNWNlNWU3YmY4NTA1YWRkZWNjMww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/54191 Sample Failed Step: browser_tests Sample Flaky Test: PrintPreviewDestinationSettingsTest.ChangeButtonState Original change's description: > Print Preview Refresh: Enable change button while destination loads > > In some cases (e.g. kiosk apps with no default printer configured), the > print destination may never load. Enable the "Change" button while > destination capabilities are loading so that the user can switch > destinations in this case. > > Bug: 901115 > Change-Id: I53eec9332e0d7f075e461226290d408ae6d6ef49 > Reviewed-on: https://chromium-review.googlesource.com/c/1332703 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607896} Change-Id: I67b37b31938b6af5c19edc09a1e66b9019d0e198 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901115, 905205 Reviewed-on: https://chromium-review.googlesource.com/c/1335278 Cr-Commit-Position: refs/heads/master@{#607919}
-
Joel Hockey authored
Bug: 878324 Change-Id: I7f14a0734ea2371215d41a2df7e4b3d0255afde6 Reviewed-on: https://chromium-review.googlesource.com/c/1334670 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#607918}
-
Findit authored
This reverts commit 656c20b3. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 607881 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjU2YzIwYjNhYWE0OGRiOTM4ZDYxNmMxZjQ2YjQ1ZGQ1NGMyMDZjMAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/15973 Sample Failed Step: single_process_mash_browser_tests Sample Flaky Test: LocalCardMigrationBrowserTest.ClickingSaveClosesDialog Original change's description: > [Autofill] Added browser tests for local card migration dialog. > > Relanding browser tests for local migration flow. Commented out flaky tests that were causing issues earlier. > > Bug: 897998 > Change-Id: I7dd0fdb5f71587bddc236732c6d3725dc6411818 > Reviewed-on: https://chromium-review.googlesource.com/c/1332704 > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Manas Verma <manasverma@google.com> > Cr-Commit-Position: refs/heads/master@{#607881} Change-Id: I128c446c52bd22b7c1957b69307d4768b5b39166 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897998 Reviewed-on: https://chromium-review.googlesource.com/c/1335277 Cr-Commit-Position: refs/heads/master@{#607917}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1e00aebd9a45..ccc31e9e3220 git log 1e00aebd9a45..ccc31e9e3220 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2778029563f2..d1a55e393e65 (2 commits) Created with: gclient setdep -r src/third_party/skia@ccc31e9e3220 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I5f15840c8434fffc207fe7cef48148e6a97e3968 Reviewed-on: https://chromium-review.googlesource.com/c/1335094Reviewed-by:
-
Sadrul Habib Chowdhury authored
After the fix in crrev.com/c/1322364, a bunch of tests that use the testRunner.capturePixelsAsyncThen() API can be turned back on. BUG=891427 Change-Id: Ice7d7b5f4dd0e0096363820cd4433ce0404ec83e Reviewed-on: https://chromium-review.googlesource.com/c/1330993 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#607915}
-
Sheng-hao Tsao authored
This reverts commit 1de878d8. Reason for revert: Causes many crashes like https://bugs.chromium.org/p/chromium/issues/detail?id=903443 https://buganizer.corp.google.com/issues/119116273 Original change's description: > Show consolidated camera icon on shelf > > This CL fixes 2 bugs: > > 1. Users might pin the internal app to the shelf. Clicking on it would > launch a real camera app, causing 2 camera icons shown on the shelf. > 2. Users might pin the currently running camera app on the shelf. If the > users click on it afterward, it will bypass the internal app deciding > logic and always launch that specific app. > > pinned the internal camera app icon, and launching camera app from it > does not show 2 camera icons on shelf. > > Bug: b:117909556 > Test: Tested on eve that pinning camera app on launcher or on shelf both > Change-Id: I0300456595e6c4c00c1a47f7a3bc7309d1230553 > Reviewed-on: https://chromium-review.googlesource.com/c/1303327 > Commit-Queue: Sheng-hao Tsao <shenghao@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603793} TBR=stevenjb@chromium.org,shenghao@google.com,wutao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:117909556 Change-Id: I20f4ea5762b29dbdbba0ad08592ff3755f06c023 Reviewed-on: https://chromium-review.googlesource.com/c/1328632Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d20b521f5864..a89ef2b38df0 git log d20b521f5864..a89ef2b38df0 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 thestig@chromium.org Revert "Remove some checks that are never true in patterns code." Created with: gclient setdep -r src/third_party/pdfium@a89ef2b38df0 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:904726 TBR=dsinclair@chromium.org Change-Id: I39606d138b366282511ab755607a1a9e9c127a18 Reviewed-on: https://chromium-review.googlesource.com/c/1335093Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6ce627d2b73d..b0c06d4b490c git log 6ce627d2b73d..b0c06d4b490c --date=short --no-merges --format='%ad %ae %s' 2018-11-13 sadrul@chromium.org rendering: Fix tasks_per_frame_ unit. 2018-11-13 benjhayden@chromium.org Add Range as es6 module for v2spa. 2018-11-13 benjhayden@chromium.org Add triage-new for v2spa 2018-11-13 chiniforooshan@chromium.org Telemetry: Fix a bug in sorting latency events 2018-11-13 benjhayden@chromium.org Add MemoryComponents for v2spa Created with: gclient setdep -r src/third_party/catapult@b0c06d4b490c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:760553,chromium:903312 TBR=sullivan@chromium.org Change-Id: Ic3288203c26cd02bea6122a76a63f3db22647362 Reviewed-on: https://chromium-review.googlesource.com/c/1335089Reviewed-by:
-
