- 02 Mar, 2012 40 commits
-
-
fischman@chromium.org authored
Before this CL the contract of SetMaxTime was unsatisfiable; a clock client could check that the max_time it was about to set wasn't greater than Elapsed() before calling SetMaxTime(), but between the time that check was done and the DCHECK inside SetMaxTime, time could move forward! After this CL, SetMaxTime() is allowed to move the media_time_ backward and set the underflow_ bit if the pipeline is slow enough. BUG=113037,chromium-os:26939 TEST=A Debug binary on an underpowered ARM crosbook with no audio device plays back correctly. Review URL: http://codereview.chromium.org/9582017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124739 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
Also make it possible to run the test against other hosts by specifying the environment variables COOKIES_TEST_HOST BUG=none TEST=pyauto Review URL: http://codereview.chromium.org/9584012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124738 0039d316-1c4b-4281-b951-d872f2087c98
-
xji@chromium.org authored
If script text is in right-to-left directionality, it got truncated because the width calculated in SizeStringInt() and DrawStringInt() are different since they are passed in different flags. DrawStringInt() was passed in an extra flag DT_RTLREADING through FORCE_RTL_DIRECTIONALITY. Fix by passing in the same flag for size calculation and drawing. BUG=104117 TEST=manual. JS alert a text begins with Hebrew letter followed by a punctuation, such as "A?". It should not be truncated. Review URL: http://codereview.chromium.org/9569025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124736 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=none TEST=password saving should continue to work Review URL: http://codereview.chromium.org/9564001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124735 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
TBR=jochen BUG=116515 TEST= Review URL: http://codereview.chromium.org/9582016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124734 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=nsylvain@chromium.org BUG=109517 TEST=sync_integration_tests is properly run. NOTRY=true Review URL: http://codereview.chromium.org/9513008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124732 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
BUG=114914 TEST=load a page that triggers the compositor and uses rAF but doesn't cause damage. the callback rate should still be ~60fps Review URL: http://codereview.chromium.org/9567038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124731 0039d316-1c4b-4281-b951-d872f2087c98
-
simonmorris@chromium.org authored
not in the headers. BUG=116574 Review URL: https://chromiumcodereview.appspot.com/9584020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124730 0039d316-1c4b-4281-b951-d872f2087c98
-
creis@chromium.org authored
BUG=93427 TEST=See bug, comment 112 Review URL: http://codereview.chromium.org/9565045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124729 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=62854 TEST=See bug. Review URL: http://codereview.chromium.org/9568046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124727 0039d316-1c4b-4281-b951-d872f2087c98
-
backer@chromium.org authored
Change-Id: I518e0c91a5f48ae1f5909d1e86a8fabfb97d1ec4 BUG=none TEST=record chrome events using about:tracing simultaneous with kernel events; check the resulting kernel event log for a trace_event_clock_sync record Review URL: http://codereview.chromium.org/9474023 TBR=sleffler@chromium.org Review URL: https://chromiumcodereview.appspot.com/9581019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124726 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=chromium-os:26646 TEST=none Review URL: https://chromiumcodereview.appspot.com/9582019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124725 0039d316-1c4b-4281-b951-d872f2087c98
-
mihaip@chromium.org authored
R=erg@chromium.org Review URL: http://codereview.chromium.org/9570059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124724 0039d316-1c4b-4281-b951-d872f2087c98
-
jamiewalch@google.com authored
BUG=115350 TEST=Everything looks the same. Review URL: https://chromiumcodereview.appspot.com/9586016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124723 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
BUG=116318,115952 TEST=Verify above issues. Review URL: https://chromiumcodereview.appspot.com/9567027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124722 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124721 0039d316-1c4b-4281-b951-d872f2087c98
-
adamk@chromium.org authored
TBR=haraken@chromium.org Review URL: https://chromiumcodereview.appspot.com/9582018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124720 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
Don't align window to grid when restoring window. BUG=none TEST=none Review URL: http://codereview.chromium.org/9513004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124718 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124717 0039d316-1c4b-4281-b951-d872f2087c98
-
arthurhsu@chromium.org authored
BUG=113514 TEST=existing Review URL: http://codereview.chromium.org/9512004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124716 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
BUG=114261 TEST=none Review URL: https://chromiumcodereview.appspot.com/9514020 TBR=rvargas@google.com Review URL: https://chromiumcodereview.appspot.com/9582024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124715 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
TBR=mpcomplete@chromium.org Review URL: https://chromiumcodereview.appspot.com/9583023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124714 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
BUG=none TEST=Verify 'show/hide' advanced settings responds to click. Review URL: https://chromiumcodereview.appspot.com/9570053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124713 0039d316-1c4b-4281-b951-d872f2087c98
-
gspencer@google.com authored
Added thumbnail URL, edit URL, and cache attributes. BUG=chromium-os:27030 TEST=none Review URL: https://chromiumcodereview.appspot.com/9570031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124712 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
By the standard, static constants should also have a definition counterpart to allocate storage space. It's not strictly necessary for ints (but it puts usage restrictions on them), and for some reason we are having linking failure on Chrome on Android when building with clang compiler, maybe that's because of using templates or perhaps it's a clang issue. Anyway, converting this constant into an enum solves the problem. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9585014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124711 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=98716 R=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/9566035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124710 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
BUG=none Review URL: https://chromiumcodereview.appspot.com/9569041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124709 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
BUG=none TEST=Verify that the 'add device' button in the bluetooth section works. Review URL: https://chromiumcodereview.appspot.com/9567031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124708 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
i.e., two declared attributes are bound to the same location, then we fail the link. Many drivers already do this, but not all of them. For example, mesa does not, and it caused memory corruption actually. So we do this in chrome command buffer. BUG=112569 TEST=test case in 112569 R=gman Review URL: https://chromiumcodereview.appspot.com/9570023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124707 0039d316-1c4b-4281-b951-d872f2087c98
-
jbates@chromium.org authored
BUG=113159,116438 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124346 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124562 Review URL: https://chromiumcodereview.appspot.com/9509001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124706 0039d316-1c4b-4281-b951-d872f2087c98
-
saintlou@chromium.org authored
TBR=sky@chromium.org BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9566044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124705 0039d316-1c4b-4281-b951-d872f2087c98
-
noelallen@google.com authored
TBR= elijahtaylor@chromium.org Review URL: https://chromiumcodereview.appspot.com/9580017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124704 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Adds suppression for JsonSchemaCompilerAdditionalPropertiesTest BUG=116580 TEST=Valgrind turns green R=calamity@chromium.org Review URL: https://chromiumcodereview.appspot.com/9572020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124703 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
BUG=114261 TEST=none Review URL: https://chromiumcodereview.appspot.com/9514020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124702 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Get rid of chrome dependencies from tab_contents_drag_win.cc. After this I'll move it to content\browser\tab_contents. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9581003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124701 0039d316-1c4b-4281-b951-d872f2087c98
-
kgr@chromium.org authored
Added guard to not set scrollTop if it hasn't changed. Surprisingly, this speeds up the list.redraw() method by 19X. BUG=62854 TEST=manually Review URL: http://codereview.chromium.org/9568039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124700 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
TBR=akalin@chromium.org BUG=111399 Review URL: https://chromiumcodereview.appspot.com/9585017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124699 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124698 0039d316-1c4b-4281-b951-d872f2087c98
-
adamk@chromium.org authored
TBR=haraken@chromium.org Review URL: https://chromiumcodereview.appspot.com/9584018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124697 0039d316-1c4b-4281-b951-d872f2087c98
-
yfriedman@chromium.org authored
The NTP is completely different on Android and doesn't display user name or offer other sync functionality. BUG=113487 TEST= Review URL: http://codereview.chromium.org/9564022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124696 0039d316-1c4b-4281-b951-d872f2087c98
-